Happy-melon [Sat, 10 Apr 2010 21:14:35 +0000 (21:14 +0000)]
Overhaul Special:EmailUser, use HTMLForm, a SpecialPage-derived class, and general tidy up. Message change got muddled into r64901.
Happy-melon [Sat, 10 Apr 2010 21:10:22 +0000 (21:10 +0000)]
Follow-up to r64866 - add message, and apply the same validation to TextareaField as well.
Siebrand Mazeland [Sat, 10 Apr 2010 18:58:35 +0000 (18:58 +0000)]
Tweak 'fileduplicatesearch-summary'. Spotted by Lloffiwr.
Raimond Spekking [Sat, 10 Apr 2010 18:57:02 +0000 (18:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-10 18:25:00 UTC)
Platonides [Sat, 10 Apr 2010 18:29:24 +0000 (18:29 +0000)]
Follow up r64876 setHTMLTitle with boolean parameter left.
Happy-melon [Sat, 10 Apr 2010 16:44:10 +0000 (16:44 +0000)]
Follow-up to r64407 - a perfect example of why we encourage using braces for one-line conditionals in the first place.
Tobias [Sat, 10 Apr 2010 14:11:40 +0000 (14:11 +0000)]
fixing bug 23139 (introduced in r59655) which broke edit conflict resolution
Platonides [Sat, 10 Apr 2010 14:06:16 +0000 (14:06 +0000)]
Follow up r62006 readding return $ok; to what is now runTests()
This fixes parserTests.php not returning 0 on success.
Tim Starling [Sat, 10 Apr 2010 13:38:50 +0000 (13:38 +0000)]
Proposed cleanup of recent LanguageConverter-related commits:
* Moved the responsibility for calling $wgOut->setPageTitle() from OutputPage::addParserOutputNoText() to the OutputPage/Parser caller. Previously, every call to $wgOut->addWikiText() (or any other message parsing function) was resulting in the title being reset to a converted version of $wgTitle, producing bug 23124. Moving responsibility to the caller seems to work fairly well, since there are apparently only two callers that really want {{DISPLAYTITLE}} etc. to work (EditPage and Article::view).
* Reverted data flow obfuscation in OutputPage::setHTMLTitle() from r64851, replaced by the above. The caller decides what overrides what.
* Reverted inappropriate, cache-polluting references to $wgUser and $wgRequest in Parser::parse(), introduced in r64819.
* Reverted incomprehensible boolean parameter to Language::convert() from r64851, reintroduced Language::convertTitle() instead. Gave it a simpler implementation than before.
* Fixed broken {{DISPLAYTITLE}} feature, was being unconditionally overwritten by the ParserOutput::setTitleText() call in Parser::parse(). Give {{DISPLAYTITLE}} precedence over autoconverted title, like we do for -{T|...}-.
* Tested extensively (perhaps not exhaustively)
Sam Reed [Sat, 10 Apr 2010 13:33:24 +0000 (13:33 +0000)]
Refactor getTokenSalt to use caching getUser/getTitle in ApiRollback and ApiUserrights
Tim Starling [Sat, 10 Apr 2010 13:16:49 +0000 (13:16 +0000)]
Fix total breakage of search engine in zh wikis due to incorrect variable name
Sam Reed [Sat, 10 Apr 2010 12:29:44 +0000 (12:29 +0000)]
Revert r64825
Roan Kattouw [Sat, 10 Apr 2010 12:14:47 +0000 (12:14 +0000)]
Followup to r64850: replace $username with the right var
Happy-melon [Sat, 10 Apr 2010 12:03:30 +0000 (12:03 +0000)]
Improvements and fixes to HTMLForm:
* allow css classes to be specified in form descriptors
* Don't overwrite $field['name'] if it's set
* Allow IDs on hidden fields
* Enforce 'required' validation on Text fields
* Fix type validation on Int fields to correctly handle numbers larger than PHP_MAX_INT or with leading zeroes (eg phone numbers on 32 bit systems)
* Fix weak-typing error in MultiSelect field
* Formatting and doc fixes
Roan Kattouw [Sat, 10 Apr 2010 11:10:53 +0000 (11:10 +0000)]
Fix epic fail in r64860
Roan Kattouw [Sat, 10 Apr 2010 10:08:29 +0000 (10:08 +0000)]
Fix yet another instance of comparing the result of User::newFromName to null
Philip Tzou [Sat, 10 Apr 2010 07:07:49 +0000 (07:07 +0000)]
Follow up r64851. Remove $wgOut.
Victor Vasiliev [Sat, 10 Apr 2010 06:21:13 +0000 (06:21 +0000)]
Add $wgLogAutocreatedAccounts to enable/disable account autocreation logging.
Mark A. Hershberger [Sat, 10 Apr 2010 06:11:02 +0000 (06:11 +0000)]
* Clean up some duplicated code in r64291
Would've like to refactor the $wgUser->*Watch — but I'm not sure if the hooks that come along with $articleObj->*Watch are ok.
Philip Tzou [Sat, 10 Apr 2010 05:46:01 +0000 (05:46 +0000)]
Fix bug 23115 again. Follow up r64821, r64823 and r64827. Rewrite the converted title to HTML title if the HTML title haven't set by other messages.
Mark A. Hershberger [Sat, 10 Apr 2010 04:31:43 +0000 (04:31 +0000)]
fix a bug where an undefined var was used, api actually works now?
Tim Starling [Sat, 10 Apr 2010 03:43:20 +0000 (03:43 +0000)]
Revert r64844 pending further discussion
Tim Starling [Sat, 10 Apr 2010 03:25:33 +0000 (03:25 +0000)]
(bug 23127) Fix for r57868, pass destination file name as $1 to uploadtext message
Tim Starling [Sat, 10 Apr 2010 02:41:46 +0000 (02:41 +0000)]
Swapped the order of the "diff" and "hist" links on Special:Contributions to match the 1.15 behaviour.
Roan Kattouw [Fri, 9 Apr 2010 22:12:38 +0000 (22:12 +0000)]
Fix another instance of the result of User::newFromName() being compared with null, fixes fatal errors
Conrad Irwin [Fri, 9 Apr 2010 22:09:07 +0000 (22:09 +0000)]
Revert r64834, hasty and unnecessary
Conrad Irwin [Fri, 9 Apr 2010 21:31:16 +0000 (21:31 +0000)]
Bug 23120. Make sure that all wikis sharing the same database use initialCapital
Alexandre Emsenhuber [Fri, 9 Apr 2010 21:27:23 +0000 (21:27 +0000)]
Fixed some doxygen warnings
Raimond Spekking [Fri, 9 Apr 2010 20:55:11 +0000 (20:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-09 20:45:00 UTC)
Platonides [Fri, 9 Apr 2010 20:47:05 +0000 (20:47 +0000)]
Follow up r64828. It was a typo, there's no variable called $wgDisableContentConversion
Philip Tzou [Fri, 9 Apr 2010 20:39:56 +0000 (20:39 +0000)]
Sorry it's $wgDisableLangConversion.
Raimond Spekking [Fri, 9 Apr 2010 20:34:53 +0000 (20:34 +0000)]
Follow-up r64819: PHP Notice: Undefined variable: wgDisableContentConversion in /www/w/includes/parser/Parser.php on line 379
Platonides [Fri, 9 Apr 2010 20:27:57 +0000 (20:27 +0000)]
Convert the previous title instead of getting it again, so the Main Page keeps pagetitle-view-mainpage as its title.
Sam Reed [Fri, 9 Apr 2010 20:05:33 +0000 (20:05 +0000)]
Refactor code in ApiRollback to fix bug 23117
Rollback uses salted token, but as this is dealt with in the Article object, it was missed by myself when refactoring API code
Refactor code to generate salt, and save variables as needed (so not needlessly regenerated)
Hence fix for r62482 and r62557
Sam Reed [Fri, 9 Apr 2010 20:02:29 +0000 (20:02 +0000)]
Reuse created instance of UserrightsPage
Platonides [Fri, 9 Apr 2010 19:46:26 +0000 (19:46 +0000)]
Recover namespace names.
Platonides [Fri, 9 Apr 2010 19:35:14 +0000 (19:35 +0000)]
Follow up r64819. Cosmetical fixes.
Philip Tzou [Fri, 9 Apr 2010 19:02:04 +0000 (19:02 +0000)]
Bug 23115: Follow up on r64811. Fix another bug which cause talk page can't converted. And fix the title convert problem.
Sam Reed [Fri, 9 Apr 2010 18:24:32 +0000 (18:24 +0000)]
Add link to Api Announcements mailing list
Alexandre Emsenhuber [Fri, 9 Apr 2010 18:21:50 +0000 (18:21 +0000)]
Fixes for r64708:
* removed the other disallowUserJs() call, for consistency with Special:Preferences
* removed RELEASE-NOTES entry
Also changed "SpecialPage::getTitleFor( 'Restpass' )" to $this->getTitle().
Platonides [Fri, 9 Apr 2010 18:08:38 +0000 (18:08 +0000)]
Follow up r64813 and r64814 by also applying r64814 to the branches.
Platonides [Fri, 9 Apr 2010 17:56:42 +0000 (17:56 +0000)]
Follow-up r64811 on fixing bug 23115.
This restores convert rules to the same ones as before r61101.
Philip Tzou [Fri, 9 Apr 2010 17:42:38 +0000 (17:42 +0000)]
Bug 23115: Language Converter should apply on talk page.
Alexandre Emsenhuber [Fri, 9 Apr 2010 17:21:52 +0000 (17:21 +0000)]
Update --help screen for better readability
Conrad Irwin [Fri, 9 Apr 2010 16:58:42 +0000 (16:58 +0000)]
Fix OggHandler/Mp3Handler etc. after r61912 r61918
Tobias [Fri, 9 Apr 2010 14:38:35 +0000 (14:38 +0000)]
fixing bug 23113 (introduced in r60945) which breaks show/hide links in diffs
Roan Kattouw [Fri, 9 Apr 2010 14:19:03 +0000 (14:19 +0000)]
Partial revert of r59157: change primary name of NS_USER in Portugese back to Usário after complaints on ptwiki village pump. Leaving Utilizador as an alias
Tim Starling [Fri, 9 Apr 2010 12:57:34 +0000 (12:57 +0000)]
revert r64792
Tim Starling [Fri, 9 Apr 2010 12:41:25 +0000 (12:41 +0000)]
Don't use $wgVariantArticlePath when the main language code is specified as a parameter to Title::getLocalURL(). Breakage observed on sr.wikipedia.org.
Roan Kattouw [Fri, 9 Apr 2010 12:33:04 +0000 (12:33 +0000)]
Restore special page aliases in Portugese to their 1.16wmf3 state following complains about mass-breakage due to aliases being removed. This is quick&dirty fix, the differences between these versions (not all are aliases removals) should be reconciled on TranslateWiki, keeping breakage due to alias removal in mind.
Roan Kattouw [Fri, 9 Apr 2010 12:31:27 +0000 (12:31 +0000)]
Fix division by zero in Profiler
Roan Kattouw [Fri, 9 Apr 2010 12:07:14 +0000 (12:07 +0000)]
Fix r64784: spelling the alias right helps
Roan Kattouw [Fri, 9 Apr 2010 11:51:42 +0000 (11:51 +0000)]
(bug 22940) Namespace aliases to the main namespace don't work. Patch by quietust
Alexandre Emsenhuber [Fri, 9 Apr 2010 07:16:12 +0000 (07:16 +0000)]
Fix for r61055: single-quoted strings doesn't replace \n with newlines :)
Mark A. Hershberger [Fri, 9 Apr 2010 05:25:40 +0000 (05:25 +0000)]
* Fix a bug to keep consecutive HTTP requests from sharing results
* Update Login API
Alexandre Emsenhuber [Thu, 8 Apr 2010 21:31:55 +0000 (21:31 +0000)]
* Fixed some doxygen warnings
* Documented a bit
* Removed trailing spaces
Jack Phoenix [Thu, 8 Apr 2010 20:19:03 +0000 (20:19 +0000)]
coding style tweaks (spacing, braces, etc.) to Language.php
Raimond Spekking [Thu, 8 Apr 2010 19:08:33 +0000 (19:08 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-08 18:55:00 UTC)
Max Semenik [Thu, 8 Apr 2010 15:55:59 +0000 (15:55 +0000)]
checkSyntax: fixed check for exclusions on Windows
Mark A. Hershberger [Thu, 8 Apr 2010 13:48:09 +0000 (13:48 +0000)]
re r62006 change private function to public
Meno25 [Thu, 8 Apr 2010 11:53:22 +0000 (11:53 +0000)]
update
Rotem Liss [Thu, 8 Apr 2010 11:30:44 +0000 (11:30 +0000)]
Localization update for he.
Alexandre Emsenhuber [Thu, 8 Apr 2010 10:15:04 +0000 (10:15 +0000)]
* (bug 16817) Group names in user rights log are now singular and in lowercase
Meno25 [Thu, 8 Apr 2010 07:22:01 +0000 (07:22 +0000)]
update
Conrad Irwin [Thu, 8 Apr 2010 00:29:58 +0000 (00:29 +0000)]
Bug 22474, urlencode now takes a parameter to change escaping style
Alexandre Emsenhuber [Wed, 7 Apr 2010 20:10:10 +0000 (20:10 +0000)]
changes group-*-member messages to lowercase, for consistency with about all extensions
Siebrand Mazeland [Wed, 7 Apr 2010 19:33:26 +0000 (19:33 +0000)]
Localisation updates for magic words from translatewiki.net
Siebrand Mazeland [Wed, 7 Apr 2010 19:28:14 +0000 (19:28 +0000)]
Localisation updates for special page aliases from translatewiki.net
Siebrand Mazeland [Wed, 7 Apr 2010 19:19:51 +0000 (19:19 +0000)]
Fix syntax error from r64719
Siebrand Mazeland [Wed, 7 Apr 2010 19:18:31 +0000 (19:18 +0000)]
Localisation updates for namespace aliases from translatewiki.net per catrope's request.
Raimond Spekking [Wed, 7 Apr 2010 18:54:28 +0000 (18:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-07 18:10:00 UTC)
Alexandre Emsenhuber [Wed, 7 Apr 2010 15:47:21 +0000 (15:47 +0000)]
* Special:ChangePassword no longer loads user javascript
Alexandre Emsenhuber [Wed, 7 Apr 2010 12:16:56 +0000 (12:16 +0000)]
* (bug 23078) "All public logs" option on Special:Log is now always the first item
Sam Reed [Wed, 7 Apr 2010 08:56:43 +0000 (08:56 +0000)]
Fixup to r64197 per mediawiki.org/wiki/Special:Code/MediaWiki/64197#c6451
Pass $fromTitle rather than $titleObj (which is undefined)
Roan Kattouw [Wed, 7 Apr 2010 08:50:34 +0000 (08:50 +0000)]
Fix for r64677: as reported on mediawiki-api, I forgot about clients that build their own cookies. Support this do-it-yourself method for the NeedToken error as well.
Ilmari Karonen [Wed, 7 Apr 2010 05:41:44 +0000 (05:41 +0000)]
(bug 23063) Reverse handling of $wgMaxImageArea and $wgMaxAnimatedGifArea: the former is now compared to the size of the first frame and the latter to the total size of all frames. Also increase default value of $wgMaxAnimatedGifArea to match $wgMaxImageArea. This change should not affect the thumbnailing of non-animated images in any way.
The way the logic and the defaults were before, it was basically impossible for animations with more than 12 frames to reach the "only thumbnail first frame" codepath; this surely cannot have been intended.
Also mention r64691 in release notes.
Ilmari Karonen [Wed, 7 Apr 2010 05:17:19 +0000 (05:17 +0000)]
allow display of unscaled image even if it exceeds $wgMaxImageArea (this can happen with animated GIFs, see bug 23063)
Shinjiman [Wed, 7 Apr 2010 00:40:17 +0000 (00:40 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Tim Starling [Wed, 7 Apr 2010 00:05:33 +0000 (00:05 +0000)]
* (bug 23076) Fixed login CSRF vulnerability. Logins now require a token to be submitted along with the user name and password. Patch by Roan Kattouw.
Alexandre Emsenhuber [Tue, 6 Apr 2010 20:00:26 +0000 (20:00 +0000)]
* (bug 23017) Special:Disambiguations now list pages in content namespaces rather than only main namespace
Raimond Spekking [Tue, 6 Apr 2010 19:36:58 +0000 (19:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-06 19:10:00 UTC)
Platonides [Tue, 6 Apr 2010 15:22:39 +0000 (15:22 +0000)]
Follow up r64324. Remove unneeded $wgUser->isAnon() check per Bryan.
Alexandre Emsenhuber [Tue, 6 Apr 2010 09:16:26 +0000 (09:16 +0000)]
Fix RELEASE-NOTES entry from r64653
Alexandre Emsenhuber [Tue, 6 Apr 2010 09:08:22 +0000 (09:08 +0000)]
* (bug 20049) Fixed in PHP notice in search highlighter that occurs in some cases
Please correct this if this is not the correct way to do it :)
Alexandre Emsenhuber [Mon, 5 Apr 2010 19:30:38 +0000 (19:30 +0000)]
Let at least be consistent between the two header() calls (the other one is four lines below)
Raimond Spekking [Mon, 5 Apr 2010 19:00:17 +0000 (19:00 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-07 17:40:00 UTC)
Chad Horohoe [Mon, 5 Apr 2010 18:18:47 +0000 (18:18 +0000)]
Stop caring about ss_admins, we don't use it for anything anyway. Could probably be dropped from schema too.
Alexandre Emsenhuber [Mon, 5 Apr 2010 16:14:58 +0000 (16:14 +0000)]
* (bug 21916) Last-Modified header is now correct when outputting cached feed
Rotem Liss [Mon, 5 Apr 2010 12:34:47 +0000 (12:34 +0000)]
Localization update for he.
Siebrand Mazeland [Mon, 5 Apr 2010 10:31:30 +0000 (10:31 +0000)]
Change button text on Special:Filepath from "Path" to "Go" (message key 'filepath-submit').
Siebrand Mazeland [Mon, 5 Apr 2010 10:26:17 +0000 (10:26 +0000)]
Fix typo in $fallback
Alexandre Emsenhuber [Mon, 5 Apr 2010 09:48:12 +0000 (09:48 +0000)]
And while I'm a it, fix for r55903: canonical name is "Ipblocklist", not "BlockList"
Alexandre Emsenhuber [Mon, 5 Apr 2010 09:20:07 +0000 (09:20 +0000)]
* (bug 22925) "sp-contributions-blocked-notice-anon" message now displayed when viewing contributions of a blocked IP address
Raimond Spekking [Sun, 4 Apr 2010 18:48:04 +0000 (18:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-04 18:30:00 UTC)
Alexandre Emsenhuber [Sun, 4 Apr 2010 18:33:57 +0000 (18:33 +0000)]
$fname -> __METHOD__/__FUNCTION__
Alexandre Emsenhuber [Sun, 4 Apr 2010 13:38:12 +0000 (13:38 +0000)]
* (bug 22918) Feed cache keys now use $wgRenderHashAppend (so that it doesn't mix between secure.wikimedia.org and normal sites)
* Modified the timestamp key to use all parameters, otherwise various entries are sharing the same timestamp key and thus some of them can be served even though they are out of date. Consider the following case:
** Two requests for feeds sharing the same timestamp key are done
** Someone edits a page (or whatever else that change the recentchanges table)
** A user request one of the two feed above, the feed is correctly re-generated and the timestamp key changed
** A request for the other feed is done, this time the timestamp is the one of the request just above and the cached version will be served (even though it should not)
Based on a patch by Bawolff.
Alexandre Emsenhuber [Sun, 4 Apr 2010 12:01:42 +0000 (12:01 +0000)]
Avoid PHP notice about undefined variable $diffText if $wgFeedDiffCutoff is 0
Alexandre Emsenhuber [Sun, 4 Apr 2010 08:55:01 +0000 (08:55 +0000)]
* (bug 22496) Viewing diff of a redirect page without specifying "oldid" parameter no longer makes the page displayed as being the redirect target
Siebrand Mazeland [Sat, 3 Apr 2010 22:01:24 +0000 (22:01 +0000)]
RELEASE-NOTES for r64560
Siebrand Mazeland [Sat, 3 Apr 2010 21:58:08 +0000 (21:58 +0000)]
Line breaks at 80 or before, trailing whitespace removed.