Brion Vibber [Thu, 29 Jan 2009 18:00:55 +0000 (18:00 +0000)]
Partial revert of r45778 and friends "(bug 15936) New page's patrol button should always be visible"
The permission & patrolled checks on every view seem to be a performance problem. Have backed this out live; backing it out in SVN until resolved.
Aaron Schulz [Thu, 29 Jan 2009 16:26:35 +0000 (16:26 +0000)]
Short-circuit block check
Aaron Schulz [Thu, 29 Jan 2009 16:03:13 +0000 (16:03 +0000)]
Use quickUserCan rather than strange boolean param :)
Rotem Liss [Thu, 29 Jan 2009 15:49:48 +0000 (15:49 +0000)]
* Localization update for he.
* Removing duplicate messages in en in AbuseFilter.
Domas Mituzas [Thu, 29 Jan 2009 15:41:00 +0000 (15:41 +0000)]
stray comma, did anyone test this?
Shinjiman [Thu, 29 Jan 2009 14:49:26 +0000 (14:49 +0000)]
Localisation updates Chinese
Cleanup: removing obsolete/outdated messages for zh-tw which are same as zh-hant
Philip Tzou [Thu, 29 Jan 2009 10:09:19 +0000 (10:09 +0000)]
mTables' element must not be left blank, to ensure the translate() function could always return a string.
Siebrand Mazeland [Thu, 29 Jan 2009 08:59:53 +0000 (08:59 +0000)]
Revert r46523, r46525. Spewing errors. See below. Behaviour observed on translatewiki.net.
PHP Notice: Undefined property: FakeConverter::$mMainLanguageCode in /var/www/w/languages/Language.php on line 2230
PHP Notice: Undefined property: FakeConverter::$mVariants in /var/www/w/languages/Language.php on line 2233
PHP Warning: in_array() [<a href='function.in-array'>function.in-array</a>]: Wrong datatype for second argument in /var/www/w/languages/Language.php on line 2233
PHP Notice: Undefined property: FakeConverter::$mMainLanguageCode in /var/www/w/languages/Language.php on line 2234
Philip Tzou [Thu, 29 Jan 2009 07:43:03 +0000 (07:43 +0000)]
mTables' element must not be left blank, to ensure the translate() function could always return a string.
Raimond Spekking [Thu, 29 Jan 2009 07:01:51 +0000 (07:01 +0000)]
Add a newline in front of the message to avoid wrong parsing when the message text starts with line-start-markup such as a table or list.
The missing newline was the real culprit of the breakage seen in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45651#c1531
Philip Tzou [Thu, 29 Jan 2009 06:51:20 +0000 (06:51 +0000)]
Move method 'getPreferredVariant' to Language class, patched by Fdcn.
Aaron Schulz [Thu, 29 Jan 2009 04:15:47 +0000 (04:15 +0000)]
If an item isn't going into RC, don't send to UDP unless explicitly told to do so
X! [Thu, 29 Jan 2009 04:13:50 +0000 (04:13 +0000)]
Forgot to remove that
X! [Thu, 29 Jan 2009 03:23:25 +0000 (03:23 +0000)]
Per 46512#c1554, moving check to before required params, returns a result rather than an error, and it must be posted.
Brion Vibber [Thu, 29 Jan 2009 01:29:43 +0000 (01:29 +0000)]
Revert r46447 in Collection -- fixed bug in Categoryfinder class it was trying to work around.
Categoryfinder::seed() was passing category names through Title::newFromText($ct,NS_CATEGORY), which meant that if the name started with what looks like a namespace, that would override the NS_CATEGORY default.
Thus you got 'Wikipedia:Books' -> text portion 'Books' when you wanted 'Category:Wikipedia:Books' -> text portion 'Wikipedia:Books'.
Using Title::makeTitleSafe(NS_CATEGORY,$ct) instead forces it to always use the category namespace.
Additionally, I've added a check for invalid input -- previously a bad input leading to an invalid title would just kill it dead with a fatal error. Invalid input in the category list is now skipped.
X! [Thu, 29 Jan 2009 01:25:17 +0000 (01:25 +0000)]
Add "check" parameter to action=email
Aryeh Gregor [Thu, 29 Jan 2009 01:22:43 +0000 (01:22 +0000)]
Reduce queries on RecentChanges via more LinkBatch
Andrew Garrett [Thu, 29 Jan 2009 01:04:00 +0000 (01:04 +0000)]
Fix broken calls to ArticleDelete hook.
Ryan Schmidt [Thu, 29 Jan 2009 00:29:52 +0000 (00:29 +0000)]
* (bug 11644) update recursive redirect checking code per CodeReview discussion on r45973
Aaron Schulz [Wed, 28 Jan 2009 23:55:17 +0000 (23:55 +0000)]
Use quickUserCan() at some possible performance hotspots (rollback links). Unlikely for anyone to notice anything except maybe getting a permission error once every blue moon.
Andrew Garrett [Wed, 28 Jan 2009 23:55:00 +0000 (23:55 +0000)]
Tweak variable name to avoid confusion.
Andrew Garrett [Wed, 28 Jan 2009 23:54:41 +0000 (23:54 +0000)]
Add Special:AbuseFilter/test, which allows (trusted for now, due to DoS potential) users to enter a filter, and have it checked against the last 100 RecentChanges items while-u-wait.
Some related cleanup to change tagging in ChangesList.
Andrew Garrett [Wed, 28 Jan 2009 23:37:42 +0000 (23:37 +0000)]
Fix patrolling checks, which are using the expensive version of userCan, and therefore causing queries to be made cross-cluster on every single pageview.
Brion Vibber [Wed, 28 Jan 2009 21:32:19 +0000 (21:32 +0000)]
* (bug 17207) Fix regression breaking category page display on PHP 5.1
r46020 added a call to $wgContLang->convert() for category article listings, but mistakenly passed the title *object* instead of the text.
In PHP 5.2, this was silently converted to a string, but in older versions this would interpolate as something useless like "Object id #110".
Danny B [Wed, 28 Jan 2009 21:06:16 +0000 (21:06 +0000)]
* tweak and fix r46474
Aaron Schulz [Wed, 28 Jan 2009 20:54:29 +0000 (20:54 +0000)]
Add an ID to wpForReUpload
Siebrand Mazeland [Wed, 28 Jan 2009 20:51:24 +0000 (20:51 +0000)]
Localisation updates for core messages from Betawiki (2009-01-28 20:32 UTC)
Aaron Schulz [Wed, 28 Jan 2009 20:17:11 +0000 (20:17 +0000)]
Split off 'wpReUpload' into the old check 'wpReUpload' and the bool 'wpForReUpload' to avoid breakage.
Andrew Garrett [Wed, 28 Jan 2009 20:10:29 +0000 (20:10 +0000)]
PLURAL for tags-hitcount
Andrew Garrett [Wed, 28 Jan 2009 20:08:46 +0000 (20:08 +0000)]
Allow individual TablePager rows to be styled with the internal method getRowClass, called in formatRow.
Aaron Schulz [Wed, 28 Jan 2009 20:03:15 +0000 (20:03 +0000)]
(bug 17193) Carry $this->mReUpload over with hidden field for better consistency after upload errors
Niklas Laxström [Wed, 28 Jan 2009 19:58:41 +0000 (19:58 +0000)]
* Fix visible regression and let the plural finally work properly
* Reported by saper at mediawiki-i18n
Brion Vibber [Wed, 28 Jan 2009 19:58:08 +0000 (19:58 +0000)]
bump style version for r46474
Aaron Schulz [Wed, 28 Jan 2009 19:58:04 +0000 (19:58 +0000)]
(bug 17200) "Reuploading a file saves to source file name (regression)" - Use 'readonly' instead of 'disabled'
Brion Vibber [Wed, 28 Jan 2009 19:57:20 +0000 (19:57 +0000)]
Tweak for bug 3043 -- disable feed link icons in RTL since they display incorrectly in IE and some other browsers (same as external link icons).
I thought this had been done previously, since they didn't show up when I did a quick test in RTL, but I guess I was wrong. :P
Andrew Garrett [Wed, 28 Jan 2009 19:44:58 +0000 (19:44 +0000)]
Move misplaced updates. I'd just put them at the bottom without paying attention to the fact that it was actually in the sqlite section :)
Alexandre Emsenhuber [Wed, 28 Jan 2009 19:36:20 +0000 (19:36 +0000)]
Fix syntax error :)
Aaron Schulz [Wed, 28 Jan 2009 19:29:04 +0000 (19:29 +0000)]
(bug 15811) Also remove license template cruft on re-upload
Alexandre Emsenhuber [Wed, 28 Jan 2009 19:24:39 +0000 (19:24 +0000)]
E_STRICT
Andrew Garrett [Wed, 28 Jan 2009 19:24:18 +0000 (19:24 +0000)]
Update RELEASE-NOTES for change tagging functionality.
Raimond Spekking [Wed, 28 Jan 2009 19:19:05 +0000 (19:19 +0000)]
Follow up r46460: Add new messages to messages.inc
Add new special page to MessagesEn.php
Andrew Garrett [Wed, 28 Jan 2009 19:08:18 +0000 (19:08 +0000)]
Branch merge of change-tagging branch with trunk
-- Introduce tagging of individual changes (revisions, logs, and on recentchanges). The tags are customisable, and currently settable by the Abuse Filter and by the TorBlock extension. The tags can be styled on the various pages on which they appear.
-- Introduces a schema change, three new tables (valid_tag, change_tag, and tag_summary).
Rotem Liss [Wed, 28 Jan 2009 18:21:27 +0000 (18:21 +0000)]
Localization update for he.
Aaron Schulz [Wed, 28 Jan 2009 17:45:51 +0000 (17:45 +0000)]
'known' still needed for title attrib
Aaron Schulz [Wed, 28 Jan 2009 17:34:44 +0000 (17:34 +0000)]
(bug 17198) Remove css from next/prev, 20/50/100 links and such
Aryeh Gregor [Wed, 28 Jan 2009 16:46:26 +0000 (16:46 +0000)]
Don't query unneeded rows on watchlist
This probably doesn't need to use a LinkBatch at all -- it could just
retrieve some extra info in the watchlist query. But we need a
LinkBatch anyway for the user pages, so why not.
By request of Domas.
Aryeh Gregor [Wed, 28 Jan 2009 16:46:13 +0000 (16:46 +0000)]
Remove unused variables
This code seriously needs cleaning up.
Shinjiman [Wed, 28 Jan 2009 16:09:30 +0000 (16:09 +0000)]
Localisation updates Chinese
Cleanup: removing obsolete/outdated messages for zh-tw which are same as zh-hant
Aryeh Gregor [Wed, 28 Jan 2009 15:14:38 +0000 (15:14 +0000)]
Remove useless left join in watchlist
By request of Domas. Extensions that were relying on the left join to
page being present must add it if it's not; LQT was the only one I found
in trunk, and I updated it so it should still work.
Shinjiman [Wed, 28 Jan 2009 14:32:24 +0000 (14:32 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Chad Horohoe [Wed, 28 Jan 2009 13:47:21 +0000 (13:47 +0000)]
Re-commit r46417 (Skip dupe warnings when it's a titles are the same and it's a reupload), this time without an E_NOTICE.
Alexandre Emsenhuber [Wed, 28 Jan 2009 10:48:13 +0000 (10:48 +0000)]
Parser tests no longer fail when $wgAlwaysUseTidy is set in LocalSettings.php
Philip Tzou [Wed, 28 Jan 2009 07:02:42 +0000 (07:02 +0000)]
Enable language conversion in "alt" and "title" attributes with preg_replace_callback. (fixed: rev 46068)
Aaron Schulz [Wed, 28 Jan 2009 06:20:07 +0000 (06:20 +0000)]
(bug 17186) Fixed incorrect stub link classing at user contribs
Aaron Schulz [Wed, 28 Jan 2009 06:08:00 +0000 (06:08 +0000)]
Fix group by for date sorting
Aaron Schulz [Wed, 28 Jan 2009 05:09:39 +0000 (05:09 +0000)]
Kill filesort
Brion Vibber [Wed, 28 Jan 2009 04:28:18 +0000 (04:28 +0000)]
Revert r46417 "Skip dupe warnings when it's a titles are the same and it's a reupload."
Notice: Undefined property: UploadForm::$mIsReUpload in /Library/WebServer/Documents/trunk/includes/specials/SpecialUpload.php on line 771
Brion Vibber [Wed, 28 Jan 2009 04:16:51 +0000 (04:16 +0000)]
Fix regression from r45502 -- extra "search" got displayed on old search UI due to extra old parameter getting passed through to what's now a parameter for extra HTML header info.
Brion Vibber [Wed, 28 Jan 2009 04:12:30 +0000 (04:12 +0000)]
Revert r45651 "Wrap 'searchresulttext' into a div with class"
This causes breakage when the message text starts with line-start-markup such as a table or list.
Chad Horohoe [Wed, 28 Jan 2009 02:40:14 +0000 (02:40 +0000)]
Skip dupe warnings when it's a titles are the same and it's a reupload.
Brion Vibber [Wed, 28 Jan 2009 01:29:25 +0000 (01:29 +0000)]
Release notes lines for:
r46134 - (bug 16483) Kill filesort in ApiQueryBacklinks caused by missing parentheses. Building query properly now using makeList()
r46170 - (bug 17151) Add magic word alias for #redirect for Vietnamese
Alex Z [Tue, 27 Jan 2009 23:15:16 +0000 (23:15 +0000)]
RELEASE-NOTES for r46270.
Brion Vibber [Tue, 27 Jan 2009 23:12:42 +0000 (23:12 +0000)]
Revert r46068 " Enable language conversion in "alt" and "title" attributes."
Use of eval is strongly discouraged, on penalty of death. :) Needs to be redone using preg_replace_callback
Brion Vibber [Tue, 27 Jan 2009 23:10:28 +0000 (23:10 +0000)]
revert r46067 also "* Follow up r46059: Add new message"
Aryeh Gregor [Tue, 27 Jan 2009 23:09:07 +0000 (23:09 +0000)]
(bug 17184) Duplicate "z" accesskey in MonoBook
Also (necessarily) changed accesskey-p-logo and tooltip-p-logo so that
they actually work -- previously they were just silently ignored in
favor of duplicating {accesskey,tooltip}-n-mainpage.
Brion Vibber [Tue, 27 Jan 2009 23:08:02 +0000 (23:08 +0000)]
Roll back r46059, r46062 "(bug 1433) Add meta-information to pages with language links." for now.
Localization issues with the description text should be ironed out first... also test use of rel="alternate" on the main links if that works, could save the extra metadata.
Brion Vibber [Tue, 27 Jan 2009 22:54:01 +0000 (22:54 +0000)]
Roll back r46196, 46202 for now "__IGNOREUNUSED__ excludes cats from UnusedCategories (bug 17145)"
The name is very unclear; would prefer to nail that down before rolling it out.
Brion Vibber [Tue, 27 Jan 2009 22:41:08 +0000 (22:41 +0000)]
Revert r45498 "Special:Upload can now have a custom upload message instead of uploadtext by passing "uploadmsg" parameter in the url. ... This should fix the Commons "uselang" hack on for Special:Upload."
As noted on bug, this is insufficient to cover the requirements.
Aaron Schulz [Tue, 27 Jan 2009 21:59:23 +0000 (21:59 +0000)]
* (bug 16604) Show title/rev in IRC for patrol log
Aaron Schulz [Tue, 27 Jan 2009 21:41:42 +0000 (21:41 +0000)]
* (bug 15391) catch DBQueryErrors on external storage insertion. This avoids error
messages on save were the edit in fact is saved.
Aaron Schulz [Tue, 27 Jan 2009 21:19:20 +0000 (21:19 +0000)]
* (bug 16604) Mark non-patrolled edits in feeds with "!"
Raimond Spekking [Tue, 27 Jan 2009 20:53:14 +0000 (20:53 +0000)]
Add Austrian German (de-at) and Swiss Standard German (de-ch) with fallback to 'de'
Brion Vibber [Tue, 27 Jan 2009 20:39:24 +0000 (20:39 +0000)]
Pulling back r46341 and r46342 for now "API: (bug 17142) Add redirects parameter to action=opensearch to control redirect resolution. Changes to OpenSearchXML extension in next commit"
Mysteriously there's no way to get a boolean parameter to default to true, which leads to an incompatibility in the sensible behavior of the more detailed responses in the XML output -- eg you get a whole buttload of "#REDIRECT Blabla" in your results, which is absolutely hideous. This is very much not desireable. :)
If we could change the default, and allow it to be set on or off for specific requests if some person for some reason is doing highly customized suggestion searches and wants it configured differently (no idea why), that might be doable. But as written this doesn't make any sense.
Chad Horohoe [Tue, 27 Jan 2009 20:35:44 +0000 (20:35 +0000)]
$wgLang -> $wgContLang. Thanks siebrand.
Alexandre Emsenhuber [Tue, 27 Jan 2009 20:29:20 +0000 (20:29 +0000)]
Don't use AutoLoader in class_exists() and interface_exists() in AutoLoader::loadAllExtensions() since we'll require() it if it doesn't exist
Aaron Schulz [Tue, 27 Jan 2009 19:58:26 +0000 (19:58 +0000)]
(bug 17180) Disable $wgShowIPinHeader if static caching is enabled
Chad Horohoe [Tue, 27 Jan 2009 19:53:20 +0000 (19:53 +0000)]
(bug 17180) Go ahead and disable $wgShowIPinHeader if we're using $wgUseFileCache.
Siebrand Mazeland [Tue, 27 Jan 2009 19:50:56 +0000 (19:50 +0000)]
Localisation updates for core messages from Betawiki (2009-01-27 19:46 UTC)
Chad Horohoe [Tue, 27 Jan 2009 19:34:21 +0000 (19:34 +0000)]
Remote file descriptions are now fetched using the uselang= parameter with $wgContLang.
Brion Vibber [Tue, 27 Jan 2009 18:33:17 +0000 (18:33 +0000)]
* Parser tests no longer fail when $wgExternalLinkTarget is set in LocalSettings
Siebrand Mazeland [Tue, 27 Jan 2009 15:20:31 +0000 (15:20 +0000)]
Re-revert r46344 because of crossing commits (r46346)
Siebrand Mazeland [Tue, 27 Jan 2009 15:17:45 +0000 (15:17 +0000)]
Revert r46344. PHP Fatal error: Class 'MWTidy' not found in /var/www/w/includes/parser/Parser.php on line 378
Alexandre Emsenhuber [Tue, 27 Jan 2009 15:16:43 +0000 (15:16 +0000)]
STAB STAB STAB
forgot to commit this file
Alexandre Emsenhuber [Tue, 27 Jan 2009 15:09:19 +0000 (15:09 +0000)]
Per Brion's comment on mediawiki.org/wiki/Special:Code/MediaWiki/46145#c1445 :
* Refactored Tidy function in a new class, MWTidy
* Only added Parser::tidy() for b/c, Parser::internalTidy() and Parser::externalTidy() were marked as private and are unused in core and extensions
* Added RELEASE-NOTES entry
Roan Kattouw [Tue, 27 Jan 2009 14:43:06 +0000 (14:43 +0000)]
API: (bug 17142) Add redirects parameter to action=opensearch to control redirect resolution. Changes to OpenSearchXML extension in next commit
Roan Kattouw [Tue, 27 Jan 2009 13:10:16 +0000 (13:10 +0000)]
Revert r46138 (Get $wgLegalTitleChars through API) per comments on CodeReview and Bugzilla (bug 17024)
Tim Starling [Tue, 27 Jan 2009 07:24:46 +0000 (07:24 +0000)]
Fixed a bug where the last batch of orphans would be skipped.
Aaron Schulz [Tue, 27 Jan 2009 03:32:22 +0000 (03:32 +0000)]
More updates
Aaron Schulz [Tue, 27 Jan 2009 03:28:37 +0000 (03:28 +0000)]
Added r46171, r46175
Aaron Schulz [Tue, 27 Jan 2009 03:25:05 +0000 (03:25 +0000)]
* Moved block log item under "fixes"
* Added r46158
Aaron Schulz [Tue, 27 Jan 2009 03:21:26 +0000 (03:21 +0000)]
Add r46119
Aaron Schulz [Tue, 27 Jan 2009 03:13:57 +0000 (03:13 +0000)]
Tweak r46117 to check $wgAllowUserCss, $wgAllowUserJs
Ryan Schmidt [Tue, 27 Jan 2009 01:51:13 +0000 (01:51 +0000)]
* fix method call
Siebrand Mazeland [Mon, 26 Jan 2009 23:32:52 +0000 (23:32 +0000)]
Localisation updates for core messages from Betawiki (2009-01-26 23:29 UTC)
Siebrand Mazeland [Mon, 26 Jan 2009 23:23:47 +0000 (23:23 +0000)]
Follow up to r46153 per mediawiki.org/wiki/Special:Code/MediaWiki/46153#code-comments: Note change in RELEASE-NOTES.
Brion Vibber [Mon, 26 Jan 2009 21:53:19 +0000 (21:53 +0000)]
Revert r45343 "(bug 16659) Prettify permalinks. Just use ?oldid=x" for now.
This hasn't been very popular so far; pulling it back pending further discussion (as on bug)
Niklas Laxström [Mon, 26 Jan 2009 21:00:21 +0000 (21:00 +0000)]
* Escape backslashes before normal escaping, to not counteract the effect
Aaron Schulz [Mon, 26 Jan 2009 19:11:34 +0000 (19:11 +0000)]
Break line
Alex Z [Mon, 26 Jan 2009 18:02:13 +0000 (18:02 +0000)]
add mIsPreview and mIsSectionPreview to parserOptions, set in EditPage. patch by Brad Jorsch on bug 16854 (changes to Cite in next commit)
Siebrand Mazeland [Mon, 26 Jan 2009 16:28:15 +0000 (16:28 +0000)]
Localisation updates for core messages from Betawiki (2009-01-26 16:18 UTC)