From: Ed Sanders <esanders@wikimedia.org>
Date: Mon, 28 Sep 2015 15:28:09 +0000 (+0100)
Subject: mediawiki.widgets: Add temporary workaround for upstream oojs-ui bug
X-Git-Tag: 1.31.0-rc.0~9406^2~1
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/fiche.php?a=commitdiff_plain;h=ca751872aac2be673d88fe9067472808c6500bb5;p=lhc%2Fweb%2Fwiklou.git

mediawiki.widgets: Add temporary workaround for upstream oojs-ui bug

'choose' sometimes emits with null. Fixed upstream in I03f0b6d88f.

Change-Id: I4f5ab119555f9e3c439e3d91054b8b99d0dd89a5
---

diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
index 0e2546f8b7..c37c723b4d 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
@@ -63,7 +63,11 @@
 	 * @param {OO.ui.OptionWidget} item Chosen item
 	 */
 	mw.widgets.TitleSearchWidget.prototype.onTitleSearchResultsChoose = function ( item ) {
-		this.getQuery().setValue( item.getData() );
+		// TOOD: Pressing enter can incorrectly trigger 'choose' with null.
+		// Remove this check when oojs-ui 0.12.10 lands.
+		if ( item ) {
+			this.getQuery().setValue( item.getData() );
+		}
 	};
 
 	/**