public function addBadLinkObj( $title ) {
$dbkey = $title->getPrefixedDbKey();
- if ( ! $this->isBadLink( $dbkey ) ) {
+ if ( !$this->isBadLink( $dbkey ) ) {
$this->mBadLinks[$dbkey] = 1;
}
}
*/
public function addLinkObj( &$nt, $len = -1, $redirect = NULL ) {
global $wgAntiLockFlags, $wgProfiler;
+ wfProfileIn( __METHOD__ );
- $title = $nt->getPrefixedDBkey();
- if ( $this->isBadLink( $title ) ) { return 0; }
- $id = $this->getGoodLinkID( $title );
- if ( 0 != $id ) { return $id; }
-
- $fname = 'LinkCache::addLinkObj';
- if ( isset( $wgProfiler ) ) {
- $fname .= ' (' . $wgProfiler->getCurrentSection() . ')';
+ $key = $nt->getPrefixedDBkey();
+ if ( $this->isBadLink( $key ) ) {
+ wfProfileOut( __METHOD__ );
+ return 0;
+ }
+ $id = $this->getGoodLinkID( $key );
+ if ( $id != 0 ) {
+ wfProfileOut( __METHOD__ );
+ return $id;
}
- wfProfileIn( $fname );
-
- $ns = $nt->getNamespace();
- $t = $nt->getDBkey();
-
- if ( '' == $title ) {
- wfProfileOut( $fname );
+ if ( $key === '' ) {
+ wfProfileOut( __METHOD__ );
return 0;
}
-
+
# Some fields heavily used for linking...
if ( $this->mForUpdate ) {
$db = wfGetDB( DB_MASTER );
$s = $db->selectRow( 'page',
array( 'page_id', 'page_len', 'page_is_redirect' ),
- array( 'page_namespace' => $ns, 'page_title' => $t ),
- $fname, $options );
+ array( 'page_namespace' => $nt->getNamespace(), 'page_title' => $nt->getDBkey() ),
+ __METHOD__, $options );
# Set fields...
- $id = $s ? $s->page_id : 0;
- $len = $s ? $s->page_len : -1;
- $redirect = $s ? $s->page_is_redirect : 0;
+ if ( $s !== false ) {
+ $id = $s->page_id;
+ $len = $s->page_len;
+ $redirect = $s->page_is_redirect;
+ } else {
+ $len = -1;
+ $redirect = 0;
+ }
- if( 0 == $id ) {
+ if ( $id == 0 ) {
$this->addBadLinkObj( $nt );
} else {
$this->addGoodLinkObj( $id, $nt, $len, $redirect );
}
- wfProfileOut( $fname );
+ wfProfileOut( __METHOD__ );
return $id;
}