From a46391b7174f4f34abb894624d413b97faacfced Mon Sep 17 00:00:00 2001 From: jrobson Date: Tue, 8 Apr 2014 08:59:32 -0700 Subject: [PATCH] =?utf8?q?Follow-up:=20If985b16c=20=E2=80=93=20Vector=20ex?= =?utf8?q?ternal=20link=20change=20release=20notes?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Also strengthen the CSS selector and remove a FIXME that it fixed. Bug: 54604 Change-Id: I84765c536ade4087d8d3d9753966a443e49b2c38 --- RELEASE-NOTES-1.23 | 3 +++ skins/vector/components/externalLinks.less | 13 +++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23 index 44469cba77..244cce7b4d 100644 --- a/RELEASE-NOTES-1.23 +++ b/RELEASE-NOTES-1.23 @@ -138,6 +138,9 @@ production. installer has been updated to use it. * Changes to content typography (fonts, line-height, etc.). See https://www.mediawiki.org/wiki/Typography_refresh for further information. +* The Vector skin's visual treatment of external links has been simplified to a + single icon (from nine). This should not affect local rules unless they were + re-using these icons, which have now been deleted. * ResourceLoader: mw.loader.using() now implements a Promise interface. * Add new hook ChangesListInitRows accessed via ChangesList::initChangesListRows. If called by the ChangesList consumer this gives extensions a chance to batch diff --git a/skins/vector/components/externalLinks.less b/skins/vector/components/externalLinks.less index 60792d580e..91388c6363 100644 --- a/skins/vector/components/externalLinks.less +++ b/skins/vector/components/externalLinks.less @@ -1,9 +1,10 @@ -// FIXME: This size of this CSS is ridiculous. Please refactor (see bug 54604) @import "mediawiki.mixins.less"; // External links -.external { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png' ); - padding-right: 13px; +#content { + .external { + background-position: center right; + background-repeat: no-repeat; + .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png'); + padding-right: 13px; + } } -- 2.20.1