From 4bfbaaf68245a4ade0466bab1a8051c02af46a44 Mon Sep 17 00:00:00 2001 From: aude Date: Tue, 22 Sep 2015 16:57:55 +0200 Subject: [PATCH] Set visibility of monolog tests setUp method to protected In phpunit and MediaWikiTestCase, the setUp method is protected, and it's nice if the subclasses are consistent. Change-Id: I4b8ac612951168913bb2dc9cf16d3dc18762a211 --- .../phpunit/includes/debug/logger/monolog/AvroFormatterTest.php | 2 +- .../phpunit/includes/debug/logger/monolog/KafkaHandlerTest.php | 2 +- .../phpunit/includes/debug/logger/monolog/LineFormatterTest.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/includes/debug/logger/monolog/AvroFormatterTest.php b/tests/phpunit/includes/debug/logger/monolog/AvroFormatterTest.php index 5cbb247730..44242ed279 100644 --- a/tests/phpunit/includes/debug/logger/monolog/AvroFormatterTest.php +++ b/tests/phpunit/includes/debug/logger/monolog/AvroFormatterTest.php @@ -25,7 +25,7 @@ use PHPUnit_Framework_Error_Notice; class AvroFormatterTest extends MediaWikiTestCase { - public function setUp() { + protected function setUp() { if ( !class_exists( 'AvroStringIO' ) ) { $this->markTestSkipped( 'Avro is required for the AvroFormatterTest' ); } diff --git a/tests/phpunit/includes/debug/logger/monolog/KafkaHandlerTest.php b/tests/phpunit/includes/debug/logger/monolog/KafkaHandlerTest.php index b6f33d81d9..090f439ec6 100644 --- a/tests/phpunit/includes/debug/logger/monolog/KafkaHandlerTest.php +++ b/tests/phpunit/includes/debug/logger/monolog/KafkaHandlerTest.php @@ -28,7 +28,7 @@ require_once __DIR__ . '/../../../ConsecutiveParametersMatcher.php'; class KafkaHandlerTest extends MediaWikiTestCase { - public function setUp() { + protected function setUp() { if ( !class_exists( 'Monolog\Handler\AbstractProcessingHandler' ) || !class_exists( 'Kafka\Produce' ) ) { diff --git a/tests/phpunit/includes/debug/logger/monolog/LineFormatterTest.php b/tests/phpunit/includes/debug/logger/monolog/LineFormatterTest.php index 6ee54d3380..be23c4a210 100644 --- a/tests/phpunit/includes/debug/logger/monolog/LineFormatterTest.php +++ b/tests/phpunit/includes/debug/logger/monolog/LineFormatterTest.php @@ -28,7 +28,7 @@ use TestingAccessWrapper; class LineFormatterTest extends MediaWikiTestCase { - public function setUp() { + protected function setUp() { if ( !class_exists( 'Monolog\Formatter\LineFormatter' ) ) { $this->markTestSkipped( 'This test requires monolog to be installed' ); } -- 2.20.1