jenkins-bot [Wed, 21 Feb 2018 17:37:47 +0000 (17:37 +0000)]
Merge "Update README file for Selenium tests"
jenkins-bot [Wed, 21 Feb 2018 12:52:22 +0000 (12:52 +0000)]
Merge "Truncate tag filter descriptions"
jenkins-bot [Wed, 21 Feb 2018 11:42:23 +0000 (11:42 +0000)]
Merge "Fix English name for lb"
Željko Filipin [Wed, 21 Feb 2018 11:28:49 +0000 (12:28 +0100)]
Update README file for Selenium tests
Bug: T187862
Change-Id: Iadd41307a48a1b50f64a495e7efcee3b88d0ff68
Niklas Laxström [Wed, 21 Feb 2018 11:12:20 +0000 (12:12 +0100)]
Fix English name for lb
This version has been in MediaWiki longer than my email history,
since 2005 at least. This spelling is not present in
https://en.wikipedia.org/wiki/Luxembourgish
Change-Id: Ibda7e6428a2c79b9f7d88892ef1c16e9921ae934
jenkins-bot [Wed, 21 Feb 2018 10:31:32 +0000 (10:31 +0000)]
Merge "Factor OldRevisionImporter & ImportableOldRevision out of WikiRevision"
jenkins-bot [Wed, 21 Feb 2018 09:53:30 +0000 (09:53 +0000)]
Merge "Factor UploadRevisionImporter & ImportableUploadRevision out of WikiRevision"
Aaron Schulz [Wed, 21 Feb 2018 03:16:51 +0000 (19:16 -0800)]
rdbms: make sure non-native replace() uses one transaction
This is similar to what upsert() already does
Change-Id: Ide83eefe0d937fb2cdc20aa3c7dc9654c4d34beb
jenkins-bot [Tue, 20 Feb 2018 22:15:50 +0000 (22:15 +0000)]
Merge "mw.Title: Use $.trimByteLength from jquery.byteLimit module"
jenkins-bot [Tue, 20 Feb 2018 22:15:47 +0000 (22:15 +0000)]
Merge "tests: Remove dead code in jquery.byteLimit tests"
jenkins-bot [Tue, 20 Feb 2018 22:09:50 +0000 (22:09 +0000)]
Merge "Switch the sidebar cache to using checkKeys"
Bartosz Dziewoński [Mon, 19 Feb 2018 19:53:11 +0000 (20:53 +0100)]
mw.Title: Use $.trimByteLength from jquery.byteLimit module
Change-Id: I39ebd559a72ce72743cbe3bb86abe679d108d94a
Bartosz Dziewoński [Mon, 19 Feb 2018 20:56:08 +0000 (21:56 +0100)]
tests: Remove dead code in jquery.byteLimit tests
These options do nothing.
Change-Id: I15cc91b9208e8cfd3f3f42bb0a9c91514d6532e3
jenkins-bot [Tue, 20 Feb 2018 21:16:34 +0000 (21:16 +0000)]
Merge "parser: Deprecate string type for $lang arg in DateFormatter::getInstance"
jenkins-bot [Tue, 20 Feb 2018 21:14:51 +0000 (21:14 +0000)]
Merge "jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming"
Fomafix [Wed, 13 Sep 2017 12:57:44 +0000 (14:57 +0200)]
parser: Deprecate string type for $lang arg in DateFormatter::getInstance
The parameter $lang is not used with type string in the Git repository:
https://codesearch.wmflabs.org/search/?q=DateFormatter%3A%3AgetInstance
This function is only used with type Language and without parameter.
The support for the language as string will be removed with Change-ID
I677ab561d67b63f0c86f65fadf9319e41444a22a.
The removal of the support for the type string simplifies the code.
Change-Id: I0c0ab46ffc0fab6b68672940e979ad7e5754a7d1
L10n-bot [Tue, 20 Feb 2018 21:02:55 +0000 (21:02 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Tue, 20 Feb 2018 21:02:45 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Iea6405478e926c0bce200213a211bb66da7efbf3
jenkins-bot [Tue, 20 Feb 2018 20:59:55 +0000 (20:59 +0000)]
Merge "mediawiki.cldr: Use require() for pluralruleparser"
MarcoAurelio [Tue, 20 Feb 2018 19:19:28 +0000 (19:19 +0000)]
Fix for Ia97b750b
Change-Id: I2eb5ba754334864f65dede92b138f9a81a210e70
jenkins-bot [Tue, 20 Feb 2018 19:05:24 +0000 (19:05 +0000)]
Merge "Add support for 'es-formal'"
jenkins-bot [Tue, 20 Feb 2018 17:07:51 +0000 (17:07 +0000)]
Merge "mw.loader: Document mw.loader.require() as private"
addshore [Tue, 4 Jul 2017 21:46:46 +0000 (22:46 +0100)]
Factor OldRevisionImporter & ImportableOldRevision out of WikiRevision
This is to be used within the FileImporter extension to allow
adding custom loggers to this import process.
Change-Id: Ib094d4829764ccc8e5bd2619fb827d701ae06d43
addshore [Tue, 4 Jul 2017 21:07:04 +0000 (22:07 +0100)]
Factor UploadRevisionImporter & ImportableUploadRevision out of WikiRevision
This is to be used within the FileImporter extension to allow
adding custom loggers to this import process.
Change-Id: I4a6c573fc0a69b06d696cd2afca9226fb492a9bc
Fomafix [Fri, 16 Feb 2018 15:18:10 +0000 (16:18 +0100)]
mediawiki.cldr: Use require() for pluralruleparser
Use require( 'mediawiki.libs.pluralruleparser' ) instead of
mw.libs.pluralRuleParser. (Added in 1.27, with
bc4e07b6f63b0)
Change-Id: I7388cf631068458596250b8da82edec3f7cbd98b
Timo Tijhof [Tue, 20 Feb 2018 04:47:39 +0000 (20:47 -0800)]
mw.loader: Document mw.loader.require() as private
Only public for debugging purposes.
Change-Id: Icc44e11ec6874d7f74ed527e87a80dd06b4edb3a
jenkins-bot [Tue, 20 Feb 2018 04:33:22 +0000 (04:33 +0000)]
Merge "Cleanup IDEA warnings in MessageCache"
Dan Mattern [Mon, 19 Feb 2018 22:59:17 +0000 (17:59 -0500)]
GD zero filesize error
Checking if the filesize is zero before passing to GD. This can result
in a fatal error.
Bug: T182387
Change-Id: I26a24286f3035f233de682caed21a8e8c2d5aaad
jenkins-bot [Mon, 19 Feb 2018 22:55:53 +0000 (22:55 +0000)]
Merge "Pass change tags to NewRevisionFromEditComplete hook"
jenkins-bot [Mon, 19 Feb 2018 22:55:51 +0000 (22:55 +0000)]
Merge "rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()"
jenkins-bot [Mon, 19 Feb 2018 22:27:45 +0000 (22:27 +0000)]
Merge "tests: Remove verbose logging settings from DevelopmentSettings.php"
Timo Tijhof [Mon, 19 Feb 2018 22:17:11 +0000 (14:17 -0800)]
tests: Remove verbose logging settings from DevelopmentSettings.php
Follows-up
fdb7d36903. It seems these make unit tests on Travis CI
fail, per T187581. And when we briefly enabled DevelopmentSettings.php
in our Jenkins setup, the PHPUnit tests also failed.
Remove these from DevelopmentSettings.php to confirm that the
tests pass that way. Then, once our own Jenkins setup has switched
back to using DevelopmentSettings.php, we can re-consider adding
these in a way that is verified by Gerrit/Jenkins before merging.
Bug: T187581
Change-Id: Ib81c5909849598bdad02955f6414d68c038742c5
Bartosz Dziewoński [Mon, 5 Feb 2018 18:38:10 +0000 (19:38 +0100)]
jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming
Bug: T186364
Change-Id: I6282d97bcd637ae8e86d70996adb468582c8f02f
MarcoAurelio [Mon, 19 Feb 2018 21:19:13 +0000 (22:19 +0100)]
Add support for 'es-formal'
Spanish formal address. First exported on Id132ebc6.
Bug: T187750
Change-Id: Ia97b750bde01ceee7db0ea826e4f87bb9a2f0a93
Translation updater bot [Mon, 19 Feb 2018 20:56:27 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I11bbae1702de3352fd8b59efa3abe3ad47b49acc
jenkins-bot [Mon, 19 Feb 2018 19:08:10 +0000 (19:08 +0000)]
Merge "Update links in comments to developer.mozilla.org"
jenkins-bot [Mon, 19 Feb 2018 19:07:12 +0000 (19:07 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 16.0.0"
Aaron Schulz [Mon, 19 Feb 2018 11:50:29 +0000 (03:50 -0800)]
Switch the sidebar cache to using checkKeys
The avoids the long delete() loop in MessageCache::replace()
and has better separation of concern.
Change-Id: I0acb0119058fa92fcafb52a5850f5dad4aaa94d2
Aaron Schulz [Mon, 19 Feb 2018 11:21:24 +0000 (03:21 -0800)]
Cleanup IDEA warnings in MessageCache
Change-Id: I0ced7c7289918f78bb6f3682ae974fe0c04a1e04
Fomafix [Mon, 19 Feb 2018 08:54:25 +0000 (09:54 +0100)]
Update links in comments to developer.mozilla.org
Change-Id: I2310cf73ab494375655067833cea11b18483a396
Translation updater bot [Sun, 18 Feb 2018 20:57:57 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I613493a91cd01032529bd161947b9231819b99cb
Aaron Schulz [Fri, 16 Feb 2018 21:50:08 +0000 (13:50 -0800)]
rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()
Also mark the methods as "final" due to their delegation
Change-Id: Ie32f53445f749d9a00e77fce43d75830e260c039
Translation updater bot [Sat, 17 Feb 2018 20:59:21 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Idc8c6ef5a94c61cac176895e089f9624428dc2af
Umherirrender [Sat, 17 Feb 2018 12:29:13 +0000 (13:29 +0100)]
build: Updating mediawiki/mediawiki-codesniffer to 16.0.0
Change-Id: I59b59f79bbf3ce4feff3b3a20c1c31bc16370531
jenkins-bot [Sat, 17 Feb 2018 04:11:53 +0000 (04:11 +0000)]
Merge "rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs"
Aaron Schulz [Fri, 16 Feb 2018 19:16:10 +0000 (11:16 -0800)]
rdbms: remove "m" member prefix from various classes
Change-Id: Iade8e8f70bb1307b96683d979d7e3650f4107515
jenkins-bot [Fri, 16 Feb 2018 23:37:08 +0000 (23:37 +0000)]
Merge "rdbms: remove "m" member prefix from DatabaseMssql"
jenkins-bot [Fri, 16 Feb 2018 23:37:05 +0000 (23:37 +0000)]
Merge "objectcache: add IExpiringStore::TTL_SECOND constant"
jenkins-bot [Fri, 16 Feb 2018 23:15:37 +0000 (23:15 +0000)]
Merge "Soft deprecate DeferredStringifier class"
星耀晨曦 [Wed, 14 Feb 2018 10:27:44 +0000 (10:27 +0000)]
Soft deprecate DeferredStringifier class
As of
3041b5c, the DeferredStringifier class is no longer used in MediaWiki core or any Gerrit-hosted extensions.
Bug: T187290
Change-Id: Ic363daf0847c0371a6b4c4041f9ea394377185f3
jenkins-bot [Fri, 16 Feb 2018 22:39:55 +0000 (22:39 +0000)]
Merge "RCLFilters: make sticky filters default and current value equal"
Aaron Schulz [Fri, 16 Feb 2018 22:23:49 +0000 (14:23 -0800)]
objectcache: add IExpiringStore::TTL_SECOND constant
Change-Id: Iec59ce72f3dbb0de68c8f6704d86f1522f86827e
jenkins-bot [Fri, 16 Feb 2018 21:36:35 +0000 (21:36 +0000)]
Merge "site_stats: Unbreak counting newly created pages"
Eddie Greiner-Petter [Fri, 16 Feb 2018 21:18:48 +0000 (22:18 +0100)]
site_stats: Unbreak counting newly created pages
Fixes a bug introduced on
331c9f9e2e that stopped newly created pages
from incrementing the counter of ss_total_pages in site_stats. The array
accepted by SiteStatsUpdate::factory is not meant to take a value with
the key 'total'. What's meant here is 'pages'. Let's change the variable
name as well to avoid confusion in the future.
Change-Id: I9c82d926206d9b46f333c6f6cb9d3c7d41db3a53
Translation updater bot [Fri, 16 Feb 2018 21:03:24 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib373192166d7f9d43bbd15df341f8ad770353685
Aaron Schulz [Fri, 9 Feb 2018 23:01:40 +0000 (15:01 -0800)]
rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs
Change-Id: I543deef24f6cbf99094a4f3bee7cabe768fa221a
Aaron Schulz [Fri, 16 Feb 2018 19:23:30 +0000 (11:23 -0800)]
rdbms: remove "m" member prefix from DatabaseMssql
Change-Id: I270cd4f4048e0ae751ea1c078d31d45c9db59690
jenkins-bot [Fri, 16 Feb 2018 12:26:17 +0000 (12:26 +0000)]
Merge "Follow-up I0bb4ed7f7: Use correct 'this'"
Ed Sanders [Fri, 16 Feb 2018 11:55:00 +0000 (11:55 +0000)]
Follow-up I0bb4ed7f7: Use correct 'this'
Bug: T187523
Change-Id: I7ced05b239d3ce0da1bcd6acdb3a30f65872645c
Brad Jorsch [Wed, 14 Feb 2018 18:01:19 +0000 (13:01 -0500)]
Don't write exceptions to STDERR from BadTitleErrorTest or ThrottledErrorTest
It's annoying and pointless. Instead, have MWException write them to
standard output where we can catch them with ob_start().
Bug: T170028
Bug: T170029
Change-Id: Icd99c1c39d4a30d78c511d33948ef639e1b92455
jenkins-bot [Fri, 16 Feb 2018 00:50:54 +0000 (00:50 +0000)]
Merge "rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()"
Reedy [Sun, 11 Feb 2018 15:39:45 +0000 (15:39 +0000)]
Update wikimedia/php-session-serializer from 1.0.4 to 1.0.5
https://github.com/wikimedia/php-session-serializer/releases/tag/v1.0.5
https://github.com/wikimedia/php-session-serializer/compare/v1.0.4...v1.0.5
Change-Id: Ib9f301f8f86031faed698beca65a56407859a1aa
Depends-On: I0f85f206fdd5566641784037132d2a6046de2c2d
Aaron Schulz [Wed, 14 Feb 2018 08:27:14 +0000 (00:27 -0800)]
rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()
Named locks are session-level constructs and this transaction agnostic.
Also make lockIsFree() a bit more consistent when the thread has the
lock itself.
Change-Id: Ief51196161bbc50c798740f3c738fd0e39880508
jenkins-bot [Fri, 16 Feb 2018 00:15:04 +0000 (00:15 +0000)]
Merge "rdbms: remove "m" prefix from Database fields"
jenkins-bot [Fri, 16 Feb 2018 00:11:48 +0000 (00:11 +0000)]
Merge "rdbms: make MySQLMasterPos handle inactive GTIDs"
jenkins-bot [Thu, 15 Feb 2018 23:52:26 +0000 (23:52 +0000)]
Merge "tests: Commit initial version of DevelopmentSettings.php"
Aaron Schulz [Tue, 13 Feb 2018 06:58:57 +0000 (22:58 -0800)]
rdbms: remove "m" prefix from Database fields
Done using the PhpStorm refactor->rename tool.
Also move "defaultBigSelects" declaration to DatabaseMysqlBase
as no other classes uses that.
Change-Id: I424a2d9815de3a5d4cca2522f3db23a5efe6b592
jenkins-bot [Thu, 15 Feb 2018 23:07:08 +0000 (23:07 +0000)]
Merge "rdbms: improve ILoadBalancer comments about reuseConnection()"
jenkins-bot [Thu, 15 Feb 2018 23:05:07 +0000 (23:05 +0000)]
Merge "rdbms: remove leading table name space hack in Database"
jenkins-bot [Thu, 15 Feb 2018 23:02:11 +0000 (23:02 +0000)]
Merge "Salvage site_stats row with negative values in miser mode"
jenkins-bot [Thu, 15 Feb 2018 23:02:08 +0000 (23:02 +0000)]
Merge "rdbms: remove "m" prefix from LoadBalancer fields"
Aaron Schulz [Fri, 9 Feb 2018 22:12:44 +0000 (14:12 -0800)]
rdbms: make MySQLMasterPos handle inactive GTIDs
Change-Id: I328142a9fe10bccb2717a0a392e0c50d0c070390
Aaron Schulz [Thu, 15 Feb 2018 10:30:12 +0000 (02:30 -0800)]
rdbms: remove leading table name space hack in Database
This was added in r19879 (
3de6fd8c8) with no provided use case.
There also appears to be nothing exploiting this.
Change-Id: I1641d4ed16d612ab6f08ee1eeca1580af73888bf
Aaron Schulz [Wed, 14 Feb 2018 10:03:45 +0000 (02:03 -0800)]
rdbms: remove "m" prefix from LoadBalancer fields
Change-Id: I68fc74859bd58ef0c7591beef1c21411198d45e9
Timo Tijhof [Thu, 15 Feb 2018 22:30:26 +0000 (14:30 -0800)]
Use `lock(,,0)` instead of `lockIsFree && lock(,,1)` for non-blocking locks
This pattern is already used elsewhere and seems like a more efficient
way to acquire locks in a non-blocking way.
Change-Id: Idb369e7cb03b793d5f8295e956fecd8d1f849e17
Aaron Schulz [Thu, 15 Feb 2018 21:28:58 +0000 (13:28 -0800)]
rdbms: improve ILoadBalancer comments about reuseConnection()
Change-Id: I94f8e95f5ed9c3357d118e9bc66c55b389061e7f
jenkins-bot [Thu, 15 Feb 2018 21:12:23 +0000 (21:12 +0000)]
Merge "Drop the 'CategorizedRecentChanges' feature"
Translation updater bot [Thu, 15 Feb 2018 21:05:09 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I820327da7a4aa07879b4fa23f8187783bf35befa
jenkins-bot [Thu, 15 Feb 2018 20:51:06 +0000 (20:51 +0000)]
Merge "objectcache: improve WANObjectCache reap method comments"
Aaron Schulz [Thu, 15 Feb 2018 19:48:48 +0000 (11:48 -0800)]
objectcache: improve WANObjectCache reap method comments
Change-Id: Icec0846b0e66229af39bb819d75144734fd111bf
jenkins-bot [Thu, 15 Feb 2018 19:47:47 +0000 (19:47 +0000)]
Merge "Be more db-friendly when purging expired userrights"
jenkins-bot [Thu, 15 Feb 2018 18:46:32 +0000 (18:46 +0000)]
Merge "build: Add grunt target for 'karma:firefox'"
James D. Forrester [Sat, 18 Mar 2017 01:17:17 +0000 (18:17 -0700)]
Drop the 'CategorizedRecentChanges' feature
It is off by default, it's very rarely used (GitHub finds four config
users setting it true), it has over time had fatals going unnoticed or
fixed for years. Let's just kill it.
Change-Id: Idac2341ed7ecf053ee84069df657e424e50b896c
addshore [Thu, 15 Feb 2018 14:15:45 +0000 (14:15 +0000)]
RevisionStore logging use wfBacktrace instead of wfDebugBacktrace
wfDebugBacktrace doesn't work very will with logstash.
The whole message ends up being too long and the log ends
up in the 'jsonTruncated' channel.
Instead use wfBacktrace which will be smaller as it just gives
us a string.
Change-Id: I5309ac2ad4592fb6dbb1474526d382893fb7e6c1
jenkins-bot [Thu, 15 Feb 2018 11:03:16 +0000 (11:03 +0000)]
Merge "EditPage::getBaseRevision can return null. (fix phpdoc)"
addshore [Thu, 15 Feb 2018 10:08:20 +0000 (10:08 +0000)]
EditPage::getBaseRevision can return null. (fix phpdoc)
If !$this->mBaseRevision then the code to populte $this->mBaseRevision
is run.
This code either calls Revision::newFromId or Revision::loadFromTimestamp
both of which are documented as being able to return null.
As a result EditPage::getBaseRevision can alos return null.
Bug: T187378
Change-Id: I60ad9ddcfbe6e1060cab1ad6aa2194c1a3406cbf
jenkins-bot [Thu, 15 Feb 2018 02:14:07 +0000 (02:14 +0000)]
Merge "Hard-deprecate ParserOutput stateful transform methods"
jenkins-bot [Thu, 15 Feb 2018 00:37:22 +0000 (00:37 +0000)]
Merge "resourceloader: Fix comment on Mobile Safari requirement"
Ed Sanders [Tue, 13 Feb 2018 11:03:07 +0000 (11:03 +0000)]
resourceloader: Fix comment on Mobile Safari requirement
Mobile Safari 5.1 doesn't support Function#bind.
Change-Id: Ifdbd593352ab6d682a37010b17a13370f3c96176
Umherirrender [Mon, 12 Feb 2018 21:06:05 +0000 (22:06 +0100)]
resourceloader: Remove ResourceLoaderModule::getPosition
@deprecated since 1.29
Bug: T184257
Change-Id: I1a59a1f0a5fbedfea9f0b28bee8c298710557a8d
jenkins-bot [Wed, 14 Feb 2018 23:43:50 +0000 (23:43 +0000)]
Merge "RCFilters: Add missing jQueryMsg dependency"
Aaron Schulz [Wed, 14 Feb 2018 23:23:42 +0000 (15:23 -0800)]
Salvage site_stats row with negative values in miser mode
* Instead of returning all zeroes, just use zero for the
negative values in the row.
* Allow large numbers since the fields are BIGINT.
* Clean up the return types to truly be integers.
* Respect the $groups argument in SiteStatsInit::getDB().
Bug: T186947
Change-Id: I51fdc45124c12aba114540fc0ec66a3e63d61e09
jenkins-bot [Wed, 14 Feb 2018 23:37:34 +0000 (23:37 +0000)]
Merge "rdbms: avoid "SHOW MASTER/SLAVE STATUS" queries in the GTID case"
Matthew Flaschen [Sat, 6 Jan 2018 01:11:08 +0000 (20:11 -0500)]
RCFilters: Add missing jQueryMsg dependency
Some of these messages use jQueryMsg-only features, like PLURAL.
Bug: T184320
Change-Id: I7f5a4979bb5ed5779e9d24d18189f89a9453c54e
Translation updater bot [Wed, 14 Feb 2018 21:08:32 +0000 (22:08 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If74c8c7ca0ff8aa93e63505c9ce0009d891423fb
jenkins-bot [Wed, 14 Feb 2018 18:59:32 +0000 (18:59 +0000)]
Merge "Update $wgGitRepositoryViewers to use Gerrit/Gitiles instead of Phabricator"
Jayprakash12345 [Tue, 13 Feb 2018 05:43:55 +0000 (05:43 +0000)]
Update $wgGitRepositoryViewers to use Gerrit/Gitiles instead of Phabricator
Bug: T187152
Change-Id: I957274e670eb6d1b7971d8dbad7765af568cc96a
jenkins-bot [Wed, 14 Feb 2018 18:30:48 +0000 (18:30 +0000)]
Merge "Log the reason why revision->getContent() returns null"
jenkins-bot [Wed, 14 Feb 2018 18:05:38 +0000 (18:05 +0000)]
Merge "globals.txt: Remove trailing whitespace"
Chad Horohoe [Wed, 14 Feb 2018 17:57:48 +0000 (09:57 -0800)]
globals.txt: Remove trailing whitespace
Change-Id: I4e495754f810069247af60d72731a2f382eed8a6