Antoine Musso [Mon, 24 Oct 2011 13:58:03 +0000 (13:58 +0000)]
makes HTML5 five only attributes a global property
This patch move an array hidden in Html::expandAttributes() to the top of
the class definition as self::$HTMLFiveOnlyAttribs.
That also make the Html::expandAttributes() method a bit more concise.
Antoine Musso [Mon, 24 Oct 2011 10:51:46 +0000 (10:51 +0000)]
test that preloaded text is unstripped
bug 27467 reported our preloaded system did not unstrip <nowiki>
or <pre> enclosed text. The fix was applied by r82473.
Antoine Musso [Mon, 24 Oct 2011 09:32:33 +0000 (09:32 +0000)]
test {{SERVERNAME}} with relative URLS
bug 31176 mentionned an issue with {{SERVERNAME}} returning the full
URL instead of servername when using relative URLs (//localhost).
The fix was made by r98193.
This patch test three different URL protocols (http, https & relative)
and check we return the expected 'localhost'.
Antoine Musso [Mon, 24 Oct 2011 09:08:13 +0000 (09:08 +0000)]
using real identity for hashar
Converting my pseudonym to use my real identity instead:
Ashar Voultoiz -> Antoine Musso
Antoine Musso [Mon, 24 Oct 2011 08:39:58 +0000 (08:39 +0000)]
Test handling of escaped CSS comments
r85856 fixed a CSS injection issue but lacked testing. This
test verify we properly strip out CSS comments even when the
token delimiter '/*' is backslash-escaped : \2f\2a
Tim Starling [Mon, 24 Oct 2011 04:45:26 +0000 (04:45 +0000)]
Updated documentation of $wgMaxImageArea for r99911 etc.
Aaron Schulz [Mon, 24 Oct 2011 03:08:45 +0000 (03:08 +0000)]
FU r100535:
* Changed custom functions to work via a $thgThumbCallbacks variable
* Added 'checkCache' and 'fillCache' hooks to $thgThumbCallbacks
* Minor regex cleanup to wfExtractThumbParams()
* Re-organized a bit of the wfStreamThumbViaCurl() code
Brian Wolff [Mon, 24 Oct 2011 02:47:22 +0000 (02:47 +0000)]
(follow-up r100575 / r99477) unit-tests for jpegMetadataExtractor dealing with padding bytes.
Brian Wolff [Mon, 24 Oct 2011 02:41:34 +0000 (02:41 +0000)]
(follow up r99477) not sure what I was doing on r99477, but its not right (doesn't work for odd number padding bytes)
Will commit unittests in follow up.
Brian Wolff [Mon, 24 Oct 2011 02:19:11 +0000 (02:19 +0000)]
(bug 31740) JpegMetadataExtractor and friends weren't checking for unexpected end of input properly
I created a new wrapper around unpack - wfUnpack which throws an exception if it runs out of input
(but i didn't use that on GIFMetadataExtractor/PNGMetadataExtractor because those files have a header saying that they weren't external dependencies minimized for potential re-users. I don't think anyone actually re-uses those files, but I didn't want to add a dependency on wfUnpack just in case).
I also changed fopen( blah, "r" ) -> fopen( blah, "rb" ) since these are binary formats, so we don't want newlines converted on windows.
Brandon Harris [Sun, 23 Oct 2011 22:49:03 +0000 (22:49 +0000)]
Update green buttons to a color that doesn't clash with Vector.
Raimond Spekking [Sun, 23 Oct 2011 19:48:36 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Sun, 23 Oct 2011 18:38:22 +0000 (18:38 +0000)]
Adding functions to HTMLForm for explicitly setting the content of the header and footer.
Also adds a function for setting the intro, as a counterpart to addPreText
John Du Hart [Sun, 23 Oct 2011 18:09:44 +0000 (18:09 +0000)]
HTMLForm is now a context source.
Replace wfMessage() calls with $this->msg()
John Du Hart [Sun, 23 Oct 2011 16:57:53 +0000 (16:57 +0000)]
Adding flatlists to HTMLRadioField, sort of like HTMLMultiSelect
John Du Hart [Sun, 23 Oct 2011 16:45:08 +0000 (16:45 +0000)]
Add check to see if the user has permission to view the log. Right now the page title and description are still set.
Aaron Schulz [Sun, 23 Oct 2011 10:15:51 +0000 (10:15 +0000)]
Removed wrong comment in doBatchLookups()
Aaron Schulz [Sun, 23 Oct 2011 09:51:13 +0000 (09:51 +0000)]
Reverted r99195 quick-fix per r99897
Aaron Schulz [Sun, 23 Oct 2011 09:38:52 +0000 (09:38 +0000)]
Use getId() accessors for Revision object (fixes fatal)
Aaron Schulz [Sun, 23 Oct 2011 09:36:35 +0000 (09:36 +0000)]
Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled by default.
* The thumb.php parameter extraction can also be overridden by the config to handle more complex setups and things like OggHandler and PagedTiffHandler.
* A simple 404 error page is also included. It can be overridden by the config.
* Additional HTTP headers can be passed through cURL via the config.
Alexandre Emsenhuber [Sun, 23 Oct 2011 09:21:02 +0000 (09:21 +0000)]
* Changed action=history to use an Action subclass
* Use local context instead of global variables
* Removed obsolete aliases PageHistory and PageHistoryPager; no longer used
* Made Action::getContext() and related methods public for the call in HistoryPager's constructor and also for consistency with other classes
Alexandre Emsenhuber [Sun, 23 Oct 2011 08:54:48 +0000 (08:54 +0000)]
Group shell-related functions
Derk-Jan Hartman [Sun, 23 Oct 2011 08:17:19 +0000 (08:17 +0000)]
Use attr() instead of this.href, to make sure that we don't absolutify the URI.
Fixes bug 31899
Alexandre Emsenhuber [Sun, 23 Oct 2011 08:13:52 +0000 (08:13 +0000)]
* Use local context to get messages
* Simply use getLang() instead of getContext()->getLang() now that this method exists
* Also changed addWikiMsgArray() to use a Message object with addWikiText() for the parse operation; removed its $options parameter, no caller was using it
Alexandre Emsenhuber [Sun, 23 Oct 2011 07:55:45 +0000 (07:55 +0000)]
Check first that $wgDisableLangConversion is false and we are not in a special page before doing the language variant check
John Du Hart [Sun, 23 Oct 2011 01:10:23 +0000 (01:10 +0000)]
Follow up r100512, adding @since tags and using wfMessage
Robin Pepermans [Sat, 22 Oct 2011 20:48:59 +0000 (20:48 +0000)]
Allowing moving -> allow moving; use past tense
Raimond Spekking [Sat, 22 Oct 2011 20:29:38 +0000 (20:29 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Sat, 22 Oct 2011 20:10:41 +0000 (20:10 +0000)]
Removing extra stuff that was committed in r100512
John Du Hart [Sat, 22 Oct 2011 20:03:40 +0000 (20:03 +0000)]
Adding functions to HTMLForm for setting the submitText and WrapperLegend to messages instead of having to use wfMsg every single time
Derk-Jan Hartman [Sat, 22 Oct 2011 19:50:43 +0000 (19:50 +0000)]
Follow up to r79085. Fixes bug 31408.
There was a typo, causing the minoredit tag not to show up in the enhanced recentchanges.
Rotem Liss [Sat, 22 Oct 2011 17:35:20 +0000 (17:35 +0000)]
Typo.
Alexandre Emsenhuber [Sat, 22 Oct 2011 05:06:54 +0000 (05:06 +0000)]
* Call Linker methods statically
* Use local context to get messages
Aaron Schulz [Fri, 21 Oct 2011 23:20:52 +0000 (23:20 +0000)]
Revision objects now always use the current name of users, loading it on demand if necessary (e.g. when given a $row with no user_name but rev_user is not 0)
Platonides [Fri, 21 Oct 2011 22:18:02 +0000 (22:18 +0000)]
Fix fatal: Fatal error: func_get_args(): Can't be used as a function parameter in includes/context/ContextSource.php on line 121
Raimond Spekking [Fri, 21 Oct 2011 20:30:08 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Fri, 21 Oct 2011 20:24:03 +0000 (20:24 +0000)]
Followup r100396, use is_string instead of !is_array
Alexandre Emsenhuber [Fri, 21 Oct 2011 20:09:27 +0000 (20:09 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Fri, 21 Oct 2011 16:54:25 +0000 (16:54 +0000)]
* Call Linker methods statically
* Removed now-useless parameter RevisionDeleter::getLogLinks(), updated the only caller
Brion Vibber [Fri, 21 Oct 2011 00:15:45 +0000 (00:15 +0000)]
* (bug 31847) Fix positioning of WikiEditor 'header' insertions when selection is empty in IE 7/8
Follows up to the test cases added in r100391. jquery.textSelection's getCaretPosition() for IE needs to focus the textarea first in order to get consistent results when there's an empty selection -- getSelection() which returns the text already does this.
Because focus had previously been stolen by the drop-down menus in WikiEditor's toolbar, the saveCursorAndScrollTop() was getting a bogus result from getCaretPosition, saving that, then restoring the bad selection (wiping out the original caret position) right before going ahead with the encapsulateText call.
Now seems to get the correct caret position, and also doesn't appear to interfere with selections.
John Du Hart [Fri, 21 Oct 2011 00:09:56 +0000 (00:09 +0000)]
Bugfix to r96441, class_exists throws warnings when arrays are passed to it
Brion Vibber [Thu, 20 Oct 2011 22:50:04 +0000 (22:50 +0000)]
QUnit test cases for bug 31847: will trigger a fail on IE 6/7/8
jquery.textSelection's getCaretPosition() gives bogus results on IE 6/7/8 when there's not a selection set in the textarea; it seems to give us some value somewhere in the middle of the textarea, rather than what we expected.
If we actually set an empty selection, then it gets it back just fine!
But if the cursor is in initial state, or has been moved by the user, we get back garbage. This is causing WikiEditor to sometimes insert things in the wrong place, as it tries to pull the caret position and manipulate the selection to do insertions; we then end up using the bogus selection when it gets saved in via selection restoration.
Krinkle [Thu, 20 Oct 2011 22:35:27 +0000 (22:35 +0000)]
Updating jquery.qunit from upstream
* Source: https://github.com/jquery/qunit/tree/
ee156923cdb01820e35e6bb579d5cf6bf55736d4
-- Several bug fixes
-- New hooks system
-- Version numbers, finally (this is 1.2.0pre)
-- (BREAKING CHANGE) start/stop now takes count instead of timeout as first argument (read more at https://github.com/jquery/qunit/pull/125 and http://docs.jquery.com/QUnit/stop)
Krinkle [Thu, 20 Oct 2011 22:34:05 +0000 (22:34 +0000)]
[JSTesting] Fix dependencies. Of course jquery.qunit.completenessTest needs jquery.qunit
Krinkle [Thu, 20 Oct 2011 22:33:05 +0000 (22:33 +0000)]
[JSTesting] Don't rely on the timeout argument of start/stop. This behavior is removed in the latest QUnit version.
-- Actually, in the latest QUnit version start/stop take 'count' as first argument. It would internally set the number of wait levels to 5000 xD
Sam Reed [Thu, 20 Oct 2011 21:22:59 +0000 (21:22 +0000)]
After r100379, move release notes for bug 29392
Raimond Spekking [Thu, 20 Oct 2011 19:16:53 +0000 (19:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 20 Oct 2011 19:05:48 +0000 (19:05 +0000)]
More whitespace tweaks...and fixed doc typo
Aaron Schulz [Thu, 20 Oct 2011 17:13:53 +0000 (17:13 +0000)]
Removed deprecated getFullPath(); no callers
Mark A. Hershberger [Thu, 20 Oct 2011 15:12:13 +0000 (15:12 +0000)]
eol w/s
Mark A. Hershberger [Thu, 20 Oct 2011 14:46:29 +0000 (14:46 +0000)]
Revert r79363, r79364, and r79369 to disable datalists support entirely based
on Bug 31602, Bug 31697, Bug 31654, Bug 31658, and even Aryeh Gregor's
comments in
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029593.html
Antoine Musso [Thu, 20 Oct 2011 14:28:41 +0000 (14:28 +0000)]
(bug 31345) document API Revisions parameters as enum
Patch by Brad Jorsch.
Alexandre Emsenhuber [Thu, 20 Oct 2011 10:29:51 +0000 (10:29 +0000)]
Fix for r100333: forgot to override requiresWrite() and requiresUnblock()
Alexandre Emsenhuber [Thu, 20 Oct 2011 08:10:25 +0000 (08:10 +0000)]
* Changed action=raw to use an Action subclass
* Left RawPage with back compat code for extensions that use it
* Removed calls to Skin for gen=(css|js). Calling action=raw&gen=(css|js) will now unconditionally return empty content
* Removed Skin::generateUserJs() and Skin::generateUserStylesheet() since they were only used in RawPage
Raimond Spekking [Thu, 20 Oct 2011 07:36:22 +0000 (07:36 +0000)]
* (bug 25306) Add link of old page title to MediaWiki:Delete_and_move_reason
Aaron Schulz [Thu, 20 Oct 2011 03:03:45 +0000 (03:03 +0000)]
* Simplified r100286 by just using the field 'user_name' and removed the COALESCE
* Simplified contribs pager with Revision::selectFields()
Aaron Schulz [Thu, 20 Oct 2011 02:26:59 +0000 (02:26 +0000)]
Moved contribs rev parent ID batch query into doBatchLookups()
Aaron Schulz [Thu, 20 Oct 2011 01:15:28 +0000 (01:15 +0000)]
* Made ?contribs=user actually show the results for the *user* if 'newbies' was given as the user.
* Added a link batch query to newbie contribs paging
Aaron Schulz [Thu, 20 Oct 2011 00:43:43 +0000 (00:43 +0000)]
* Added a proper Pager::doBatchLookups() function
* Made HistoryPager use a link batch via Pager::doBatchLookups()
Aaron Schulz [Thu, 20 Oct 2011 00:41:48 +0000 (00:41 +0000)]
FU r100300, r100286:
* Updated link batch code in MergeHistory
* Marked some Revision functions explicitly public
Aaron Schulz [Thu, 20 Oct 2011 00:04:14 +0000 (00:04 +0000)]
JOIN to get user_name in Contributions, HistoryPage, RevisionList, RevisionDelete, and MergeHistory
Aaron Schulz [Wed, 19 Oct 2011 23:56:48 +0000 (23:56 +0000)]
FU r100286: Added sanity check to fetchFromConds() join conds
Aaron Schulz [Wed, 19 Oct 2011 22:25:26 +0000 (22:25 +0000)]
* Tweaked Revision class to handle loading the current user name instead of rev_user_text. It still falls back to rev_user_text when building objects from DB rows for b/c.
* Moved JOIN conds to fetchFromConds() as that's where the tables are specified. This lets us avoid the same page_id=rev_page join conds plastered all over the code. Also, we can't mix WHERE and JOIN style join conds.
* Removed duplication in fetchFromConds() by using selectPageFields().
* Removed duplicate rev_parent_id field from contribs SELECT.
Yo make use of these changes, Pagers and lists still need to be updated to use Revision::selectUserFields() and join on the user table.
Aaron Schulz [Wed, 19 Oct 2011 21:21:20 +0000 (21:21 +0000)]
Code cleanups & fixed strange comma
Raimond Spekking [Wed, 19 Oct 2011 20:15:34 +0000 (20:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Wed, 19 Oct 2011 20:08:15 +0000 (20:08 +0000)]
Add some braces
Unindent most of the code
Mark A. Hershberger [Wed, 19 Oct 2011 20:01:50 +0000 (20:01 +0000)]
Revert r100262 — wasn't the right place for it and other problems,
like broken parser tests.
Please read [[Manual:Pre-commit checklist]] before committing.
Jeroen De Dauw [Wed, 19 Oct 2011 19:38:17 +0000 (19:38 +0000)]
we want to get the edit token, not edit the token...
Mark A. Hershberger [Wed, 19 Oct 2011 19:34:56 +0000 (19:34 +0000)]
Give a clear error message instead of un-intelligible UNIQ.*QINU
markers.
Not sure the preg_match() is actually needed. Or it may be
appropriate to use MARKER_SUFFIX for the match.
The error message may also need to be rewritten to be more
user-friendly, but I'm pretty sure *an* error message is friendlier
than UNIQ garbage. And making them visible error messages makes them
easier to be found.
Aaron Schulz [Wed, 19 Oct 2011 18:50:34 +0000 (18:50 +0000)]
Join ipb_by to user table to get the user name. If we can't find a user, fallback to ipb_by_text. This lets centralauth blocks have the blocking user be displayable again.
Aaron Schulz [Wed, 19 Oct 2011 17:30:55 +0000 (17:30 +0000)]
* Fixed undefined var $g error
* Style cleanups
Raimond Spekking [Wed, 19 Oct 2011 17:15:05 +0000 (17:15 +0000)]
Change the hook case per CR r95152
Happy-melon [Wed, 19 Oct 2011 17:09:04 +0000 (17:09 +0000)]
Follow-up r82285: we should not apply case conversion to these names, because it's unintuitive and potentially risky when they could theoretically contain weird characters. It was necessary before r86508, but not now there is a prefix meaning the group name is not at the start of the title. Plus the default messages are already at the lowercase titles.
Alexandre Emsenhuber [Wed, 19 Oct 2011 15:30:02 +0000 (15:30 +0000)]
Follow-up r100227:
* Missed one call to ParserOptions::getUserLang() in Parser
* Also convert RefreshLinksJob and RefreshLinksJob2 to use ParserOptions::newFromUserAndLang() and pass $wgContLang instead of whatever $wgLang could be
Platonides [Wed, 19 Oct 2011 15:15:08 +0000 (15:15 +0000)]
It is valid (albeit silly) to specify lang;q=1.000 No more than three decimals are allowed.
(rfc2616 section 3.9: Quality Values)
The language-range may contain more than one - (section 14.4) such as x-pig-latin
(section 3.10: Language Tags)
Alexandre Emsenhuber [Wed, 19 Oct 2011 14:52:26 +0000 (14:52 +0000)]
Don't reinvent the wheel in LegacyTemplate::pageStats(), just use them items from SkinTemplate
Alexandre Emsenhuber [Wed, 19 Oct 2011 14:16:01 +0000 (14:16 +0000)]
* Changed ParserOptions to store a Language object instead of only a string, avoids object -> string -> object conversion
* ParserOptions::getUserLang() will still return a string for compatibility, added ParserOptions::getUserLangObj() to get the object
* Added ParserOptions::newFromUserAndLang() and ParserOptions::newFromContext() to easily get a ParserOptions object when a context is available or when someone wants to force the language
* Updated OutputPage and Preferences to use newFromContext() and WikiPage to use newFromUserAndLang()
* ParserOptions::setUserLang() still accepts either a string or a Language object, but changed the calls to pass an object instead of a string
* Changed Parser::getFunctionLang() to return the Language object from ParserOptions when parsing interface messages rather than $wgLang directly and updated the documentation to say that $wgLang should not be used directly (as $wgUser, $wgTitle and $wgRequest)
Philip Tzou [Wed, 19 Oct 2011 14:13:41 +0000 (14:13 +0000)]
Revert unihan.zip's version to 5.2.0.
Philip Tzou [Wed, 19 Oct 2011 13:51:33 +0000 (13:51 +0000)]
Fix some incorrect rules. Fxxk unihan.zip!
Philip Tzou [Wed, 19 Oct 2011 13:10:16 +0000 (13:10 +0000)]
Fix a bug existed in Makefile.py which allows single character appearring in words list.
Philip Tzou [Wed, 19 Oct 2011 12:19:00 +0000 (12:19 +0000)]
Update Chinese conversion table: follow r90409, fix an incorrect rule.
Raimond Spekking [Wed, 19 Oct 2011 09:35:33 +0000 (09:35 +0000)]
Fix r100138 per Nikas CR: "always use explicit conversion to string with wfMessage"
Aaron Schulz [Wed, 19 Oct 2011 04:06:16 +0000 (04:06 +0000)]
* Removed newFileFromKey() which had a misleading description and a bug where giving a sha1,time could fail if two current version files existed with the same sha1 but different timestamps. Merged the code into findFileFromKey().
* Fixed bug in findFileFromKey() were it would bail out if it couldn't find a matching current file without even check for matching old files.
* Fixed timestamp format of oi_timestamp condition in newFromKey().
* Some code style cleanups.
Ryan Kaldari [Wed, 19 Oct 2011 00:53:39 +0000 (00:53 +0000)]
more accurate documentation for addValue() method
Aaron Schulz [Wed, 19 Oct 2011 00:14:13 +0000 (00:14 +0000)]
Minor code style cleanups and tweaks
Siebrand Mazeland [Tue, 18 Oct 2011 22:51:48 +0000 (22:51 +0000)]
Clarify proxyblockreason per suggestion of Amir.
Siebrand Mazeland [Tue, 18 Oct 2011 22:24:51 +0000 (22:24 +0000)]
Use spaces around "×" for consistency.
Sam Reed [Tue, 18 Oct 2011 21:47:51 +0000 (21:47 +0000)]
Remove some more code after r98467
Mark A. Hershberger [Tue, 18 Oct 2011 21:09:52 +0000 (21:09 +0000)]
revert r99562 and set standard_conforming_strings “on” by default
Krinkle [Tue, 18 Oct 2011 20:00:17 +0000 (20:00 +0000)]
Add bug id, follows-up r99934didn't know there was a bug about that
Raimond Spekking [Tue, 18 Oct 2011 19:31:51 +0000 (19:31 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Tue, 18 Oct 2011 18:07:56 +0000 (18:07 +0000)]
Fix for r100114: make API and tests work again
Raimond Spekking [Tue, 18 Oct 2011 17:57:32 +0000 (17:57 +0000)]
* (bug 18823) "move succeeded" text displays bluelinks even when redirect was suppressed
Ping r100017 for the subpage part.
Sam Reed [Tue, 18 Oct 2011 17:50:59 +0000 (17:50 +0000)]
Kill unused maintenance script (probably rotten and seriously out of date also)
Sam Reed [Tue, 18 Oct 2011 17:32:20 +0000 (17:32 +0000)]
Remove some unused getting of non existent arguments
Documentation
Sam Reed [Tue, 18 Oct 2011 17:31:54 +0000 (17:31 +0000)]
Remove some unused getting of non existent arguments
Documentation
Sam Reed [Tue, 18 Oct 2011 17:30:36 +0000 (17:30 +0000)]
Cleanup whitespace
Couple of bits of documentation
Sam Reed [Tue, 18 Oct 2011 17:29:06 +0000 (17:29 +0000)]
Kill dead/rotting importUseModWiki(pedia)? maintenance scripts
Sam Reed [Tue, 18 Oct 2011 17:27:52 +0000 (17:27 +0000)]
Documentation
Explicit member variable definitions
Simplify some code
Sam Reed [Tue, 18 Oct 2011 17:26:09 +0000 (17:26 +0000)]
Add documentation
Fix some unused variables, commented some others out