Derk-Jan Hartman [Fri, 9 Dec 2011 22:39:04 +0000 (22:39 +0000)]
Fix issue with sortable headers when nesting a table INSIDE a table header cell ?
Who comes up with these usecases ? :D
Fixes bug 32888
Raimond Spekking [Fri, 9 Dec 2011 20:31:37 +0000 (20:31 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Fri, 9 Dec 2011 20:13:31 +0000 (20:13 +0000)]
Added LoggableUserIPData hook to hooks.txt and made CheckUser handle it. This is needed for bug 32925.
Sam Reed [Fri, 9 Dec 2011 14:48:34 +0000 (14:48 +0000)]
Followup r105575, r105619, r105671 Add RELEASE-NOTES-1.19
Sam Reed [Fri, 9 Dec 2011 14:46:28 +0000 (14:46 +0000)]
1.8.17 also
Tim Starling [Fri, 9 Dec 2011 10:32:55 +0000 (10:32 +0000)]
* Revert r103476, r105161 and implement the fix for bug 32858 (a.k.a. bug 32450) in WikiPage instead. See comment 14 for further rationale.
* Clarified release notes. Please write what the new code does, not the bug description.
Tim Starling [Fri, 9 Dec 2011 09:32:15 +0000 (09:32 +0000)]
Fix for r102295 per CR r105654: don't double-escape the URL
Tim Starling [Fri, 9 Dec 2011 06:03:27 +0000 (06:03 +0000)]
Revert r102504 (allow ESC in debug output): the justification in the comment above seems very reasonable to me, and is in fact an argument for stripping only ESC, since that's the only character that can change terminal modes. You could always make a highlighter pipe script for your wfDebugGreen(), instead of tailing the log directly.
Tim Starling [Fri, 9 Dec 2011 05:54:26 +0000 (05:54 +0000)]
Fixes for r102295:
* Rename getDiffText to getDiffLink since that's what it actually gets. Fix associated variable names.
* Use Html::element() not Html::rawElement() when escaping is desired.
Tim Starling [Fri, 9 Dec 2011 05:37:57 +0000 (05:37 +0000)]
Fix comment from r102287
Tim Starling [Fri, 9 Dec 2011 05:22:39 +0000 (05:22 +0000)]
Fix message documentation from r102284
Neil Kandalgaonkar [Fri, 9 Dec 2011 04:48:39 +0000 (04:48 +0000)]
add JS api, feedback libs from UW into core.
Tim Starling [Fri, 9 Dec 2011 04:31:10 +0000 (04:31 +0000)]
Add a configuration variable to work around the issue that has been reported at least twice on IRC: pages from MW with a 404 status code have the last block of their body replaced, and their headers appended to, resulting in totally broken output for page views of non-existent pages. BizLand or some reseller is probably at fault.
Neil Kandalgaonkar [Fri, 9 Dec 2011 00:29:52 +0000 (00:29 +0000)]
add guaranteed-to-be-undefined undefined to mw object
Daniel Friesen [Fri, 9 Dec 2011 00:28:34 +0000 (00:28 +0000)]
Followup r104676, r104688:
- Update our woefully out of date doc comment for WebRequest::getPathInfo (we haven't simply been extracting a PATH_INFO for ages)
- Make PathRouter::makeWeight protected
- Add more comments to the PathRouter code
- Add two more edge case tests to the PathRouter tests.
Brion Vibber [Thu, 8 Dec 2011 23:57:24 +0000 (23:57 +0000)]
remove stray alert() from r105560 which popped up during test runs (bug 32884)
Sam Reed [Thu, 8 Dec 2011 23:54:06 +0000 (23:54 +0000)]
Update jquery.effects
Sam Reed [Thu, 8 Dec 2011 23:42:08 +0000 (23:42 +0000)]
* (bug 32879) Upgrade jQuery to 1.7.1
Tests in qunit still pass fine
Sam Reed [Thu, 8 Dec 2011 19:25:08 +0000 (19:25 +0000)]
Delete images not in 1.8.17 download of jQuery-ui
Sam Reed [Thu, 8 Dec 2011 19:17:59 +0000 (19:17 +0000)]
Update jQuery.ui from 1.8.16 to 1.8.17
Aaron Schulz [Thu, 8 Dec 2011 19:02:36 +0000 (19:02 +0000)]
Removed swift subclass comments from r99546 (that is an extension and it will be done differently as well)
Sam Reed [Thu, 8 Dec 2011 18:07:26 +0000 (18:07 +0000)]
Fix version check version from r105559
Antoine Musso [Thu, 8 Dec 2011 16:27:19 +0000 (16:27 +0000)]
basic tests for bug 8115
Sam Reed [Thu, 8 Dec 2011 16:18:18 +0000 (16:18 +0000)]
Bug 32874 - Bitmap.php uses -define in ImageMagick configuration line which requires ImageMagick 6.5.6-2 but doesn't do a version check
"Patch"/Idea provided by Christian Neubauer
Antoine Musso [Thu, 8 Dec 2011 15:24:12 +0000 (15:24 +0000)]
clean whitespaces in jquery.tablesorter.test.js
Antoine Musso [Thu, 8 Dec 2011 14:03:04 +0000 (14:03 +0000)]
clean some files when testing upload
This catch temporary uploaded files which are six characters long.
Follow-up r102458
Antoine Musso [Thu, 8 Dec 2011 13:02:34 +0000 (13:02 +0000)]
clean up whitespace / reindent
Antoine Musso [Thu, 8 Dec 2011 12:51:53 +0000 (12:51 +0000)]
purgeThumbList debug message is now a oneliner
Antoine Musso [Thu, 8 Dec 2011 10:04:59 +0000 (10:04 +0000)]
(bug 32508) clean up update.php messages
The user_options migration messages were not prefixed with '...' and
were split on several lines. This patch make the output messages more
inline with the existant ones.
Follow-up r103917
. <-- that is a patch of ink sorry. ><OO>
Niklas Laxström [Thu, 8 Dec 2011 09:48:04 +0000 (09:48 +0000)]
Followup r104300
Niklas Laxström [Thu, 8 Dec 2011 09:07:10 +0000 (09:07 +0000)]
Revert r97468 and implemented it in another way suggested by Tim
Niklas Laxström [Thu, 8 Dec 2011 08:51:21 +0000 (08:51 +0000)]
Gender is already needed in addResultToCache
Santhosh Thottingal [Thu, 8 Dec 2011 08:29:33 +0000 (08:29 +0000)]
Follow up r105517. Corrected the CSS.
Santhosh Thottingal [Thu, 8 Dec 2011 06:19:15 +0000 (06:19 +0000)]
Fix the line heights for Indic languages. Refer Bug 32826.
Grouped the elements based on language.
Aaron Schulz [Thu, 8 Dec 2011 04:58:26 +0000 (04:58 +0000)]
FU r105512: just always use thumb.php style errors
Aaron Schulz [Thu, 8 Dec 2011 03:43:07 +0000 (03:43 +0000)]
FU r101117: removed cURL thumb handler code and made thumb_handler.php a thin wrapper around thumb.php
* Moved original URL fetching code and parameter extraction code to thumb.php
* Made use of local repo URL and hash settings to avoid extra config code
* This makes it easy to add hooks for extensions/config to alter behavoir (ExtractThumbParameters hook added)
* Added FileRepo::getHashLevels()
Aaron Schulz [Thu, 8 Dec 2011 02:02:21 +0000 (02:02 +0000)]
FU r104688:
* Removed a bit of cruft in from a comment (c&p error)
* Clarified 'value' params comment (AFAIK)
* Broke some long lines and made some other w/s cleanups
Jeroen De Dauw [Wed, 7 Dec 2011 23:54:51 +0000 (23:54 +0000)]
add since tag; please do this if you add new public methods, it avoids bugs and hassle for other people
Antoine Musso [Wed, 7 Dec 2011 14:25:26 +0000 (14:25 +0000)]
(bug 32473) [[Special:PasswordReset]] can not be used on private wiki
This patch is a quick fix for REL1_18 branch.
For later:
We should not have hack in Title.php to allow some specific special pages
this should be made possible using SpecialPage. Would make code cleaner.
Antoine Musso [Wed, 7 Dec 2011 11:04:11 +0000 (11:04 +0000)]
(bug 32853) DBA cache broken in MW 1.18
DBABagOStuff was not refactored by r83140 which pass BagOStuff constructors
an array. This patch honor the 'dir' parameter to let you override the global
$wgTmpDirectory.
Need backport in REL1_18
Tim Starling [Tue, 6 Dec 2011 23:50:22 +0000 (23:50 +0000)]
It looks documented to me
Brion Vibber [Tue, 6 Dec 2011 23:40:44 +0000 (23:40 +0000)]
* (bug 32617) Fix for edit summary on section 0 containing a bogus section heading
Based on patch posted by Dan Collins: https://bugzilla.wikimedia.org/attachment.cgi?id=9552
with a tweak to avoid breaking a similar case in other sections. Follows up on function extraction & test cases added in r105379.
Brion Vibber [Tue, 6 Dec 2011 23:35:42 +0000 (23:35 +0000)]
For bug 32617: lift some code out to a function - EditPage::extractSectionTitle - so it can be tested and fixed.
Added test cases, including one that fails thus demonstrating bug 32617.
Chad Horohoe [Tue, 6 Dec 2011 23:07:13 +0000 (23:07 +0000)]
Minor tweaks to cleanSig(inSig)
* Make cleanSig public, since it's a declared entry point per class docs
* Make cleanSigInSig public static, added 2 more test cases for it
Chad Horohoe [Tue, 6 Dec 2011 23:06:50 +0000 (23:06 +0000)]
Indentation fix
Brion Vibber [Tue, 6 Dec 2011 22:37:38 +0000 (22:37 +0000)]
* (bug 32786) Fix backwards compatibility for extensions using 1.17's Database::newFromType()
Patch based on https://bugzilla.wikimedia.org/attachment.cgi?id=9604 by Solitarius -- thanks!
Added a conversion for a changed tablePrefix / tableprefix bit.
Raimond Spekking [Tue, 6 Dec 2011 21:36:57 +0000 (21:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Platonides [Tue, 6 Dec 2011 21:27:55 +0000 (21:27 +0000)]
Follow up r104314 as noted in bug 21261 comment 9
Brion Vibber [Tue, 6 Dec 2011 19:45:56 +0000 (19:45 +0000)]
Followup r104350, r104318: only allow custom limits through if they're valid positive ints.
Brion Vibber [Tue, 6 Dec 2011 19:32:29 +0000 (19:32 +0000)]
Revert r104353, r104354, r104356, r104358, r104383: changes to pagers breaking existing links as noted in CR.
Aaron Schulz [Tue, 6 Dec 2011 18:48:48 +0000 (18:48 +0000)]
Reverted r105208 per CR
Brion Vibber [Tue, 6 Dec 2011 18:15:28 +0000 (18:15 +0000)]
Followup r92081: SQL fix for cleanupUploadStash.php on PostgreSQL (bug 32822)
Chad Horohoe [Tue, 6 Dec 2011 17:40:12 +0000 (17:40 +0000)]
Reduce some duplication in Action::getRestriction(), all but 2 (plus one extension) return null anyway
Gabriel Wicke [Tue, 6 Dec 2011 16:04:43 +0000 (16:04 +0000)]
Add comment on legality of plain % in html5 spec for later consideration.
Gabriel Wicke [Tue, 6 Dec 2011 15:43:40 +0000 (15:43 +0000)]
Fix misleading parser test title, likely a copyo from the one just before it.
This test is about %25 in an URL, not %26.
Sam Reed [Tue, 6 Dec 2011 15:38:51 +0000 (15:38 +0000)]
Fix whitespace
Sam Reed [Tue, 6 Dec 2011 15:23:21 +0000 (15:23 +0000)]
Add a getExpiry method to Block (rather than direct member variable access. Yuck)
Antoine Musso [Tue, 6 Dec 2011 12:49:59 +0000 (12:49 +0000)]
revert r104468 per CR: not needed :-)
Antoine Musso [Tue, 6 Dec 2011 10:50:47 +0000 (10:50 +0000)]
allow bold in TOC lines
just like r102179 allowed italics in TOC lines for bug 26375, this
patch allow bold text as well.
Antoine Musso [Tue, 6 Dec 2011 09:41:52 +0000 (09:41 +0000)]
Diff colors now use the french Wikipedia scheme
The french community has been using a specific set of colors for diff, it is
believed to be easier to read for people perceiving colors differently.
Source is from:
http://fr.wikipedia.org/w/index.php?oldid=
72567845&uselang=en
This commit override r94429 / r94461.
See also docs/uidesign/mediawiki.action.history.diff.html
Antoine Musso [Tue, 6 Dec 2011 09:35:24 +0000 (09:35 +0000)]
uidesign: fix diffchange, show basic diff just like on wiki
Antoine Musso [Tue, 6 Dec 2011 09:15:41 +0000 (09:15 +0000)]
basic design file for our diffs
Might help folks on r94461 . Loading this file will let you easily
look at the diff file. Might need to be improved to show a real diff
instead.
Antoine Musso [Tue, 6 Dec 2011 09:14:27 +0000 (09:14 +0000)]
move docs/design.html to a new 'uidesign' directory
Tim Starling [Tue, 6 Dec 2011 01:21:08 +0000 (01:21 +0000)]
Fix for r103471: WikiPage::doSubmit() is not the only implementation of doSubmit() that needs to be patched to return true. Without this, action=purge on an image page just shows a blank body.
Krinkle [Mon, 5 Dec 2011 22:29:40 +0000 (22:29 +0000)]
mediawiki.user.js comment fix
Raimond Spekking [Mon, 5 Dec 2011 21:02:57 +0000 (21:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Mon, 5 Dec 2011 19:17:44 +0000 (19:17 +0000)]
FU r104216: keep the r103738 regex check for thumbnails but use the parent directory as the source file name. This avoids the assumption that the thumb URL starts with /thumb.
Daniel Friesen [Mon, 5 Dec 2011 18:56:09 +0000 (18:56 +0000)]
Add missing @since tags for getLanguage and deal with this sanitizeLangCode fatal that no-one bothered to fix.
Sam Reed [Mon, 5 Dec 2011 16:50:58 +0000 (16:50 +0000)]
More documentation of parameters following up r104591
Sam Reed [Mon, 5 Dec 2011 16:33:54 +0000 (16:33 +0000)]
Fix hook name in RELEASE-NOTES-1.19 per Niklas on r104441
Antoine Musso [Mon, 5 Dec 2011 16:15:05 +0000 (16:15 +0000)]
Fix PageHistoryBeforeList hook
Following r100534 refactoring, it was using an incorrect variable.
Raimond Spekking [Mon, 5 Dec 2011 12:47:52 +0000 (12:47 +0000)]
Revert r105162 for now per CR.
Antoine Musso [Mon, 5 Dec 2011 10:56:56 +0000 (10:56 +0000)]
Fix PageHistoryBeforeList hook
Following r100534 refactoring, it was using an incorrect variable.
Use the new accessor instead.
Antoine Musso [Mon, 5 Dec 2011 10:14:40 +0000 (10:14 +0000)]
Skip replaceInternalLinks2 for js/css pages
Just skip the whole replaceInternalLinks2 parser function whenever we hit
js/css pages. Previous patch r103476 only handled Category links which was
not enough.
Aaron Schulz [Mon, 5 Dec 2011 07:22:27 +0000 (07:22 +0000)]
* Made resetDB() actually clear out the tables rather than leave the contents
* Removed destroyDB(); unused and broken (does not use prefix)
Roan Kattouw [Mon, 5 Dec 2011 07:03:21 +0000 (07:03 +0000)]
Revert r105140 temporarily. The exception is thrown while running the parser tests (at least from Jenkins, haven't tried locally), which completely breaks the test suite and renders Jenkins useless. Feel free to reapply once the cause of the oi_archive_name bug is fixed and committing this won't cause exceptions to be thrown in Jenkins's face.
John Du Hart [Mon, 5 Dec 2011 02:29:08 +0000 (02:29 +0000)]
Type hinting please
Amir E. Aharoni [Mon, 5 Dec 2011 00:13:06 +0000 (00:13 +0000)]
Showing an error message always left-to-right.
Aaron Schulz [Sun, 4 Dec 2011 23:34:24 +0000 (23:34 +0000)]
Added file old version name sanity check to recordUpload2()
John Du Hart [Sun, 4 Dec 2011 18:35:40 +0000 (18:35 +0000)]
svn:eol-style native on all phase3 stuff, since I messed that up in r105122
Also adding the MWDebug class I missed there as well
John Du Hart [Sun, 4 Dec 2011 18:29:57 +0000 (18:29 +0000)]
Adding new debugging toolbar
Needs a UI cleanup still, but for the most part is working.
Derk-Jan Hartman [Sun, 4 Dec 2011 16:38:43 +0000 (16:38 +0000)]
Remove documentByLine, as documentDescription unused since introduced in r2881
Derk-Jan Hartman [Sun, 4 Dec 2011 16:31:17 +0000 (16:31 +0000)]
Remove documentDescription class, which seems to have been introduced with the original monobook commit, but was never actually used.
Derk-Jan Hartman [Sun, 4 Dec 2011 16:19:14 +0000 (16:19 +0000)]
Remove totally pointless and somewhat annoying !important from commonPrint.
This fixes bug 32795
Derk-Jan Hartman [Sun, 4 Dec 2011 16:06:56 +0000 (16:06 +0000)]
Follow up to r105114
one more tocindent
Derk-Jan Hartman [Sun, 4 Dec 2011 15:59:38 +0000 (15:59 +0000)]
Remove tocindent and tocinline from print stylesheet. These seem to have been unused since r7073
Daniel Friesen [Sat, 3 Dec 2011 23:19:34 +0000 (23:19 +0000)]
Followup r103678; Add a comment.
Raimond Spekking [Sat, 3 Dec 2011 14:56:00 +0000 (14:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Fri, 2 Dec 2011 21:50:42 +0000 (21:50 +0000)]
Per Timo, the second line would wipe out the first
Brion Vibber [Fri, 2 Dec 2011 21:47:46 +0000 (21:47 +0000)]
Followup r104671: fix regression in jquery.delayedBind() due to change in param processing for jquery's bind()
Problem was per CR comment https://www.mediawiki.org/wiki/Special:Code/MediaWiki/104671#c26836 -- parameter count check changed in upstream jquery.bind(), causing the way we passed params to break if the optional 'data' parameter was left out.
Added QUnit test cases for jquery.delayedBind() with and without the optional 'data' parameter.
Undoes r104671 since the issue it was working around is fixed.
Aaron Schulz [Fri, 2 Dec 2011 07:45:20 +0000 (07:45 +0000)]
Fixed comment typo
Tim Starling [Fri, 2 Dec 2011 02:59:11 +0000 (02:59 +0000)]
purgeParserCache.php improvements:
* Do queries in batches of 100 rows instead of all at once. Note that if there are a lot of objects with the exact same expiry time, it might take multiple runs of the script to delete them all.
* Progress meter.
Sam Reed [Fri, 2 Dec 2011 00:29:46 +0000 (00:29 +0000)]
Reverting r103706
Only seemingly supported by MySQL, and likely a seldom used function
Not worth trying to support it, as other non mysql db's would need workarounds, and that's just not happening
gicode [Thu, 1 Dec 2011 19:11:54 +0000 (19:11 +0000)]
Attempt to fix External Edit for files.
I would feel better if I knew how to test this all the way through...
Follow-up r102521.
Raimond Spekking [Thu, 1 Dec 2011 15:19:26 +0000 (15:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Chad Horohoe [Thu, 1 Dec 2011 14:41:07 +0000 (14:41 +0000)]
Fix double period from r104043
Sam Reed [Thu, 1 Dec 2011 14:40:11 +0000 (14:40 +0000)]
Don't comment tests out, use $this->markTestIncomplete()
Followup r104812
Sam Reed [Thu, 1 Dec 2011 00:40:56 +0000 (00:40 +0000)]
Comment out brokwn Xml::dateMenu() tests
Failing because it's december (ie the test is wrong)
Sam Reed [Thu, 1 Dec 2011 00:24:22 +0000 (00:24 +0000)]
Another artefact of the disable account merge
Remove disableaccount userright from core
Brion Vibber [Wed, 30 Nov 2011 23:17:19 +0000 (23:17 +0000)]
* (bug 4901) lang, hreflang attributes added to sidebar interlanguage links
The lang attribute assists screen readers in reading out the language name correctly; see sample recordings from iOS's VoiceOver reader mode attached on <https://bugzilla.wikimedia.org/show_bug.cgi?id=4901>
hreflang attribute is less clearly useful, but may assist some tools in indicating the language of the destination site.
Inline interwiki links have not been changed.
Release notes will be added on 1.18 channel, this is an old bug fix and easy to backport.