Krinkle [Tue, 22 Mar 2011 21:44:18 +0000 (21:44 +0000)]
Follow-up r84565: Whitespace
Krinkle [Tue, 22 Mar 2011 21:42:16 +0000 (21:42 +0000)]
Fixing bug 27764. Adding an extra if-check to make sure ['text'] is defined. In To avoid wrapping multiple 'if shorthands', converted it to an actual if-statement at the same time
Jack Phoenix [Tue, 22 Mar 2011 20:44:26 +0000 (20:44 +0000)]
findhooks.php: also check for Hooks::run, not just wfRunHooks. Hooks class has existed since r80435 but IIRC nothing in core calls it (yet). Also added some braces and tweaked docs.
Aaron Schulz [Tue, 22 Mar 2011 20:34:50 +0000 (20:34 +0000)]
Made FileRepo::newFileFromKey actually work
Raimond Spekking [Tue, 22 Mar 2011 20:33:52 +0000 (20:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-22 19:57:00 UTC)
Jack Phoenix [Tue, 22 Mar 2011 20:23:52 +0000 (20:23 +0000)]
coding style tweaks, doc updates, marked some public functions as such
Raimond Spekking [Tue, 22 Mar 2011 19:02:48 +0000 (19:02 +0000)]
Bug 28184 - Namespaces for the Latgalian Wikipedia
Pls sync with 1.17wmf1. Thanks.
Happy-melon [Tue, 22 Mar 2011 17:26:32 +0000 (17:26 +0000)]
Fix "$1 is already blocked" parameter-not-passed-to-message error
Happy-melon [Tue, 22 Mar 2011 17:18:15 +0000 (17:18 +0000)]
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables.
Chad Horohoe [Tue, 22 Mar 2011 15:59:50 +0000 (15:59 +0000)]
Cleanup r80892, r84485: Check user also in sqlite for consistency.
Chad Horohoe [Tue, 22 Mar 2011 13:59:00 +0000 (13:59 +0000)]
Followup r84527, forgot to press save on R-N changes
Chad Horohoe [Tue, 22 Mar 2011 13:57:11 +0000 (13:57 +0000)]
(bug 26866) remove trackback user right from DefaultSettings.php
Aaron Schulz [Tue, 22 Mar 2011 13:11:28 +0000 (13:11 +0000)]
* Avoid adding DISTINCT if possible
* Added comments
Aaron Schulz [Tue, 22 Mar 2011 11:51:09 +0000 (11:51 +0000)]
Fixed daft error in r84523 so "angry" autoblocks work again
Happy-melon [Tue, 22 Mar 2011 11:45:18 +0000 (11:45 +0000)]
Don't try and load a block with no target; we're not going to find it :D
Aaron Schulz [Tue, 22 Mar 2011 11:22:15 +0000 (11:22 +0000)]
Relate block log entries to block table rows (useful for bug 25763)
Happy-melon [Tue, 22 Mar 2011 11:14:11 +0000 (11:14 +0000)]
Follow-up r84475: fix notices.
Sam Reed [Tue, 22 Mar 2011 00:24:17 +0000 (00:24 +0000)]
Followup r84470, fill "MW 1.15 compat"
Sam Reed [Tue, 22 Mar 2011 00:08:45 +0000 (00:08 +0000)]
* (bug 27586) Remove duplication of props in ApiQueryStashImageInfo by using ApiQueryImageInfo
Programatically do properties and descriptions. Reduces text duplication, and hence normalises descriptions! :)
Follows up r84502, r84433
Sam Reed [Mon, 21 Mar 2011 23:51:26 +0000 (23:51 +0000)]
* (bug 27589) list=allimages&aiprop=archivename is useless
Followup r84433
Add way to filter returned properties/descriptions
Happy-melon [Mon, 21 Mar 2011 23:27:08 +0000 (23:27 +0000)]
Follow-up r84475: what ever posessed me to get rid of this?
Happy-melon [Mon, 21 Mar 2011 23:03:11 +0000 (23:03 +0000)]
Follow-up r84475: fixing the warning is easy enough... :D Also some random tweaks to Database.php documentation.
Greg Sabino Mullane [Mon, 21 Mar 2011 22:09:49 +0000 (22:09 +0000)]
When switching from admin to non-admin account, make sure to set $this->db to null, otherwise MW will happily return the old handle, which means we end up in the old admin database, and thus create our 'mediawiki' schema in the postgres or template1 database (whoops!). There may be other similar cases in the code in which we are not clearing this->db before toggling the useAdmin attribute. Fixes bug 28171.
Greg Sabino Mullane [Mon, 21 Mar 2011 21:59:04 +0000 (21:59 +0000)]
template1 is a poor choice: use the standard 'postgres' database instead.
Especially as the installer currently is modifying this database! (a separate bug...)
Greg Sabino Mullane [Mon, 21 Mar 2011 21:36:21 +0000 (21:36 +0000)]
$safedb needs to be set *outside* the if/else block, not just inside the if
Fixes bug 28170
Sam Reed [Mon, 21 Mar 2011 21:26:16 +0000 (21:26 +0000)]
Fix variable typo introduced in r83282
Greg Sabino Mullane [Mon, 21 Mar 2011 21:20:11 +0000 (21:20 +0000)]
Do not depend on the lack of a server for connecting: Postgres has a valid and common use case where the server name (aka host) is empty, as the connection is via a Unix socket. Instead, check if a $user has been sent to the function, as all databases can agree that we need at least that much before doing an open. Fixes bug 28167.
Raimond Spekking [Mon, 21 Mar 2011 20:38:19 +0000 (20:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-21 19:57:00 UTC)
Happy-melon [Mon, 21 Mar 2011 19:12:41 +0000 (19:12 +0000)]
Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D
* Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId().
* This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions.
* Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter)
* Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S
* Remove transitionary getTargetAndType() and newFromTargetAndType() methods
* Some optimisation in parseTarget()
* Fix the broken phpunit test mentioned in r84251
Max Semenik [Mon, 21 Mar 2011 18:41:46 +0000 (18:41 +0000)]
Removed Article::insertNewArticle() and Article::updateArticle() - deprecated in 1.7(!), unused
Russ Nelson [Mon, 21 Mar 2011 18:38:45 +0000 (18:38 +0000)]
Some docs, a spelin eror and fixing a mw1.15 compatibility bug.
Raimond Spekking [Mon, 21 Mar 2011 17:23:14 +0000 (17:23 +0000)]
Bug 28159 - Change interwiki name of language kbd to Къэбэрдеибзэ / Qabardjajəbza
Platonides [Mon, 21 Mar 2011 16:46:17 +0000 (16:46 +0000)]
(Bug 26223) Concurrently moving an article to different titles leaks a redirect revision with no page.
Just the GAID_FOR_UPDATE fixes the issue in my tests, but without the transaction there's still potential for inconsistencies.
Aaron Schulz [Mon, 21 Mar 2011 16:15:56 +0000 (16:15 +0000)]
Broke some of the more annoying lines
Sam Reed [Mon, 21 Mar 2011 15:18:11 +0000 (15:18 +0000)]
Reinstate some lines added during r84357
I guess they're used on some code paths... As it's not an unconditional return...
Greg Sabino Mullane [Mon, 21 Mar 2011 14:59:14 +0000 (14:59 +0000)]
Change the default user from 'root' to 'postgres' if using a PostgreSQL backend.
There may be a better way to do this, so comments welcome.
Roan Kattouw [Mon, 21 Mar 2011 14:56:30 +0000 (14:56 +0000)]
Add warnings about how the math options must all be different; two of these being translated the same in Gujarati caused bug 28152
Greg Sabino Mullane [Mon, 21 Mar 2011 03:01:36 +0000 (03:01 +0000)]
Don't need an Oracle flag here...
Sam Reed [Sun, 20 Mar 2011 23:50:59 +0000 (23:50 +0000)]
Start of bug 27586/bug 27589
Turn properties into a filterable key/value pair, but leave exisiting wrapper methods in place for the moment
Will finish it off later
Sam Reed [Sun, 20 Mar 2011 22:46:09 +0000 (22:46 +0000)]
As I've removed most of Roans reason to use php magic variables, completely remove them this time.
Followup r84430
Sam Reed [Sun, 20 Mar 2011 22:35:41 +0000 (22:35 +0000)]
Followup r84392
Be a bit more explicit about the code, add a bit of readability into foreach too
Aaron Schulz [Sun, 20 Mar 2011 21:55:54 +0000 (21:55 +0000)]
Ugly bug 24375 hack
Aaron Schulz [Sun, 20 Mar 2011 21:30:24 +0000 (21:30 +0000)]
Reverted r84386; breakage too severe
Aaron Schulz [Sun, 20 Mar 2011 20:50:05 +0000 (20:50 +0000)]
More comments on hash inputs
Aaron Schulz [Sun, 20 Mar 2011 20:34:03 +0000 (20:34 +0000)]
* Added findFileFromKey() function
* Added doc comments to findBySha1()
Roan Kattouw [Sun, 20 Mar 2011 19:53:46 +0000 (19:53 +0000)]
Per CR, remove round() call I accidentally reintroduced in r84401
Krinkle [Sun, 20 Mar 2011 19:09:41 +0000 (19:09 +0000)]
Typo from r54350: Overide > Override
Max Semenik [Sun, 20 Mar 2011 18:47:16 +0000 (18:47 +0000)]
Installer: require_once extensions, simple require can cause problems with extensions implicitly depending on other extensions (e.g. Maps already requires Validator, if user checks Validator, xe gets a fatal).
Max Semenik [Sun, 20 Mar 2011 17:54:43 +0000 (17:54 +0000)]
Fixed <doclink> broken by r83023
Happy-melon [Sun, 20 Mar 2011 17:43:17 +0000 (17:43 +0000)]
Follow-up r84358 CR: rename 'editusertalk' to 'editownusertalk', private --> protected, and run stylize.php over Block.php
Max Semenik [Sun, 20 Mar 2011 17:36:18 +0000 (17:36 +0000)]
(bug 26939) Installer does not set $wgMetaNamespace
Roan Kattouw [Sun, 20 Mar 2011 17:18:39 +0000 (17:18 +0000)]
Add Michael Dale to the list of patch contributors
Roan Kattouw [Sun, 20 Mar 2011 17:15:51 +0000 (17:15 +0000)]
(bug 26805) Introduce ResourceLoaderGetStartupModules hook to allow extensions to add modules to the startup set (normally this is jQuery and mediawiki). Applied patch by Michael Dale, with minor style tweaks
Roan Kattouw [Sun, 20 Mar 2011 17:10:48 +0000 (17:10 +0000)]
Followup r84399: remove another round() call
Roan Kattouw [Sun, 20 Mar 2011 17:08:38 +0000 (17:08 +0000)]
Remove stray round() call, rounding of timestamps was removed some time ago. Thanks to Michael for pointing this one out
Roan Kattouw [Sun, 20 Mar 2011 16:52:57 +0000 (16:52 +0000)]
(bug 27336) Add $wgJobTypesExcludedFromDefaultQueue for job types that aren't supposed to be run by 'normal' job runners. Modified patch by Michael Dale
Roan Kattouw [Sun, 20 Mar 2011 16:38:08 +0000 (16:38 +0000)]
(bug 27641) purgeThumbnails should support exclusion of expensive files. Add $wgExcludeFromThumbnailPurge and don't purge thumbnails whose extension is in that array when the files they belong to are purged with action=purge. Committing patch by Michael Dale with small coding style tweaks
Roan Kattouw [Sun, 20 Mar 2011 16:30:59 +0000 (16:30 +0000)]
Revert r83812 (schema change for cl_type enum), no longer needed after r84392. Also reverts r83821 (followup to r83812, add /*_*/ )
Platonides [Sun, 20 Mar 2011 16:29:31 +0000 (16:29 +0000)]
Follow up r84175
Roan Kattouw [Sun, 20 Mar 2011 16:25:01 +0000 (16:25 +0000)]
Per r83812 CR, solve the categorymembers paging problem by doing separate queries for each value of cl_type, with some trickery to make paging work. This makes the enum->varchar schema change for cl_type unnecessary, so I'll revert that.
Code was largely copied from Tim's CR comment on r83812 but adapted to deal with the fact that we have to apply the cmcontinue-induced WHERE on cl_sortkey and cl_from only for the first query. Because ApiQueryBase doesn't let us unset or overwrite conditions like these in a nice way, I added an $extraQuery parameter to ApiQueryBase::select() that excepts additional query parameters that are only applied to that query but not stored in the object.
Antoine Musso [Sun, 20 Mar 2011 14:57:49 +0000 (14:57 +0000)]
Makes wikilinks nicer when possible
This patch mostly impact Title:getLocalUrl() with two changes:
1) Abstraction:
$wgActionPath related code is now in Title::resolveActionPath(). It now
interprets query parameters using an array which is easier to read than
playing with a regexp and the evil $matches[].
2) Tweaking:
Change the 7 years old (r2621) URL forge:
"{$wgScript}?title={$dbkey}&{$query}"
=> /w/index.php?title=FOO&q=2
To a nicer
"str_replace( '$1', $dbkey, $wgArticlePath )"
=> /wiki/FOO?q=2
Additional changes:
* Parser tests were modified to reflect the changes.
* PHPUnit TitleTest amended to test getLocalUrl() (add more!!)
* When using wgActionPaths, makes sure the 'view' action is a sane default
Roan Kattouw [Sun, 20 Mar 2011 14:48:20 +0000 (14:48 +0000)]
In $.textSelection, treat <input> elements differently from other elements (such as textareas and iframes) in IE, seems to be needed for some reason (oh IE, how I hate you). This fixes a bug causing Narayam's keyboard mappings to not work in <input> elements in IE.
Sam Reed [Sun, 20 Mar 2011 13:41:41 +0000 (13:41 +0000)]
* (bug 16288) API: consider making closure status of wikis more clear with meta=siteinfo
Added bug to RELEASE-NOTES, this adds the hook and usage into SiteMatrix
Have I got my & all right? I can never remember
Sam Reed [Sun, 20 Mar 2011 13:31:22 +0000 (13:31 +0000)]
Addition of 'APIQuerySiteInfoGeneralInfo' hook for usage in bug 16288 "API: consider making closure status of wikis more clear with meta=siteinfo"
Antoine Musso [Sun, 20 Mar 2011 11:39:44 +0000 (11:39 +0000)]
correct wfDebug() calls added in r79272 & r79368
Sam Reed [Sun, 20 Mar 2011 00:32:28 +0000 (00:32 +0000)]
Followup r84361, numerical keys ftw
Sam Reed [Sun, 20 Mar 2011 00:23:41 +0000 (00:23 +0000)]
Actually list implicit groups in allusers.
Looks like I might've regressed this in the course of fixing other bugs. Oh well, fixed now
Sam Reed [Sun, 20 Mar 2011 00:19:29 +0000 (00:19 +0000)]
* (bug 27469) label implicit groups in list=allusers&auprop=groups/list=users&usprop=groups
Happy-melon [Sat, 19 Mar 2011 23:47:08 +0000 (23:47 +0000)]
* Implement an extensible Block::prevents( <action> ) function to replace the plethora of direct member variable accesses This pushes the historic *disable*-createaccount-vs-*allow* usertalk-edit wierdness down to the database layer
* Implement accessors for isHardblock() and getRangeStart()/getRangeEnd() in the same fashion.
* Make the corresponding variables private, removing external accessors. This required updating AbuseFilter with non-B/C code, so I also implemented the rest of the changes I've made to the blocking backend in that extension.
* Move the "get an IP range which encompasses the given IP/range" logic to Block.php; will be needed later... :D
Sam Reed [Sat, 19 Mar 2011 23:23:32 +0000 (23:23 +0000)]
* (Bug 14005) editing section 0 of an existing but empty page gives no such section error
Tested, with minor tweak. Also removed now un-needed code
Patch by Harry Burt
Sam Reed [Sat, 19 Mar 2011 22:54:43 +0000 (22:54 +0000)]
* (bug 27343) Add parseddescription to list=filearchive
Niklas Laxström [Sat, 19 Mar 2011 21:46:45 +0000 (21:46 +0000)]
This feature never made it into 1.16
Happy-melon [Sat, 19 Mar 2011 21:19:50 +0000 (21:19 +0000)]
Follow-up r81524: fix fatal when modules are deregistered
Max Semenik [Sat, 19 Mar 2011 19:48:29 +0000 (19:48 +0000)]
update.php: restore compatibility with PHP4 to die gracefully
Happy-melon [Sat, 19 Mar 2011 17:44:01 +0000 (17:44 +0000)]
Mark various internal methods as protected, which have no external calls in core or extensions.
Happy-melon [Sat, 19 Mar 2011 17:36:10 +0000 (17:36 +0000)]
Follow-up r84336: break some long lines
Happy-melon [Sat, 19 Mar 2011 17:32:59 +0000 (17:32 +0000)]
Block::forUpdate() is never called, and doesn't really make much sense in this context anyway; remove it and simplify.
Happy-melon [Sat, 19 Mar 2011 16:50:21 +0000 (16:50 +0000)]
Clarify the behaviour of Block::parseTarget(), and that TYPE_AUTO and TYPE_ID are broadly the same.
Happy-melon [Sat, 19 Mar 2011 16:41:14 +0000 (16:41 +0000)]
Remove some insanely ancient (~r4797) unused globals and variables, and make private variables actually private (no external calls to worry about)
Max Semenik [Sat, 19 Mar 2011 15:27:24 +0000 (15:27 +0000)]
Fixed message borkage from r78593
Raimond Spekking [Sat, 19 Mar 2011 14:46:48 +0000 (14:46 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-19 14:31:00 UTC)
Alexandre Emsenhuber [Sat, 19 Mar 2011 13:00:11 +0000 (13:00 +0000)]
Fix fatal from r83823
Tim Starling [Sat, 19 Mar 2011 12:55:48 +0000 (12:55 +0000)]
Don't refuse to do work just because the pool counter server is down. This seemed like a good idea at the time, but in practice is rather fragile.
Alexandre Emsenhuber [Sat, 19 Mar 2011 12:53:56 +0000 (12:53 +0000)]
Per Hashar, fix for r83673: only accept StubContLang and StubUserLang for stub objects
Tim Starling [Sat, 19 Mar 2011 12:06:04 +0000 (12:06 +0000)]
Log pool counter errors
Max Semenik [Sat, 19 Mar 2011 11:54:27 +0000 (11:54 +0000)]
Fixed typo in r84314
Antoine Musso [Sat, 19 Mar 2011 11:00:27 +0000 (11:00 +0000)]
consitent PHP version in RELEASE-NOTES (PHP 5.2.3)
Follow up r83879
Mark A. Hershberger [Sat, 19 Mar 2011 04:24:15 +0000 (04:24 +0000)]
Fix for Bug# 17463: New pages log doesn't remove/update item after suppression redirect
Except for some whitespace changes, this is Baowolff's patch from http://bug-attachment.wikimedia.org/attachment.cgi?id=8312 which I am applying in the spirit of “apologize later”.
Baowolff writes:
Don't show new page entries in Special:newpage for supressed redirects.
Patch to remove the new page entry from Special:RecentChange and
special:newpages, if the new page gets moved with redirect supressed.
I'm not a 100% sure this is a good idea. This will only suppress the initial
new page line in the RC (And newpages), and won't supress any other edits to
the page. Does this behaviour really make sense? (Thats not rhetorical). It
seems somewhat different from deleting a page, where none of the content is
relevent, but when you move a page, the edits don't go away, they're just in a
new title.
I suppose we could just change the new page entry in the RC to point to the
other page, but that seems rather wrong too.
So anyhow, not sure what the right approach is.
Happy-melon [Fri, 18 Mar 2011 23:29:17 +0000 (23:29 +0000)]
Missed one instance of Block::infinity() from r84279.
Happy-melon [Fri, 18 Mar 2011 23:28:23 +0000 (23:28 +0000)]
Move Block::normaliseRange() to IP.php, then reduce it to 4 lines by using the existing functionality in that class.
Bryan Tong Minh [Fri, 18 Mar 2011 23:03:58 +0000 (23:03 +0000)]
Extract bit depth and color type for PNG images
Happy-melon [Fri, 18 Mar 2011 22:28:39 +0000 (22:28 +0000)]
Follow-ups to r84258
Bryan Tong Minh [Fri, 18 Mar 2011 22:28:19 +0000 (22:28 +0000)]
Added hook BitmapHandlerTransform to allow extension to transform a file without overriding the entire handler.
Krinkle [Fri, 18 Mar 2011 22:22:04 +0000 (22:22 +0000)]
Follow-up r83658 CR: Undoing addition of second argument, prefix is for identifying the source window, not the context within
Krinkle [Fri, 18 Mar 2011 22:18:06 +0000 (22:18 +0000)]
per r83658 CR: mw.log.prefix is for identifying windows, not context. Using string concat instead
Krinkle [Fri, 18 Mar 2011 22:16:12 +0000 (22:16 +0000)]
per r83658 CR: mw.log.prefix is for identifying windows, not context. Using string concat instead
Happy-melon [Fri, 18 Mar 2011 22:03:31 +0000 (22:03 +0000)]
Follow-ups to r84258.
Sam Reed [Fri, 18 Mar 2011 22:01:42 +0000 (22:01 +0000)]
Fix fatal Invalid argument supplied for foreach
Antoine Musso [Fri, 18 Mar 2011 21:45:32 +0000 (21:45 +0000)]
debugging statement when starting a phpunit parser test
Happy-melon [Fri, 18 Mar 2011 21:42:39 +0000 (21:42 +0000)]
Follow-up r83909, r83825: update special page aliases for all languages.