jenkins-bot [Thu, 28 Sep 2017 17:12:51 +0000 (17:12 +0000)]
Merge "LogFormatter: Don't return a non-array from formatParameterValueForApi"
Huji Lee [Thu, 28 Sep 2017 15:20:45 +0000 (11:20 -0400)]
Unregister hooks that interfere with unit testing
Id7403f57cc9d751ada85b611193c1d8f3503e713 did not properly
reference the hook
Bug: T176102
Change-Id: Ibff72c0efe82ba6fd4458e3c8a96179f50ca21b0
Brad Jorsch [Thu, 28 Sep 2017 14:06:53 +0000 (10:06 -0400)]
LogFormatter: Don't return a non-array from formatParameterValueForApi
If the title for a 'title' or 'title-link' type is invalid, the code
still must not return a non-array from the method.
I'm not sure this is what was behind T176938, but it's the only thing I
can find that might cause the errors I saw logged at about the same
time.
Change-Id: Iae77eb6ad9a64d8b67074164ff0c0fea36826f3c
jenkins-bot [Thu, 28 Sep 2017 10:47:52 +0000 (10:47 +0000)]
Merge "Migrate and convert WL settings to the new UX"
jenkins-bot [Thu, 28 Sep 2017 10:33:21 +0000 (10:33 +0000)]
Merge "Fix insertSelect() with IGNORE in PostgreSQL"
jenkins-bot [Thu, 28 Sep 2017 10:29:19 +0000 (10:29 +0000)]
Merge "Reopen db connection after doing SpecialPageCacheUpdates"
jenkins-bot [Wed, 27 Sep 2017 23:09:23 +0000 (23:09 +0000)]
Merge "Revert Message dependency from DB exception classes"
jenkins-bot [Wed, 27 Sep 2017 23:02:57 +0000 (23:02 +0000)]
Merge "user: Unregister hooks that interfere with unit testing"
Huji Lee [Mon, 18 Sep 2017 01:10:27 +0000 (21:10 -0400)]
user: Unregister hooks that interfere with unit testing
testExecute_email() should unregister the hooks
mailPasswordInternal and SpecialPasswordResetOnSubmit
for proper unit testing.
Bug: T176102
Change-Id: Id7403f57cc9d751ada85b611193c1d8f3503e713
Brian Wolff [Tue, 26 Sep 2017 21:51:31 +0000 (21:51 +0000)]
Reopen db connection after doing SpecialPageCacheUpdates
Special page updates on commons have been broken recently due
to Mysql "going away" after doing the ActiveUsers special page
cache update. Presumably this is because we were only repinging
the server after QueryPage updates, and not the callback updates
(Combined with a spike in wikidata recentchanges entries making
the ActiveUsers callback now take about an hour to complete)
Bug: T176055
Change-Id: Ic344940460c353544d7c08bbe2d8c900f6cc73da
Translation updater bot [Wed, 27 Sep 2017 19:55:40 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7ea7ab422e07d18a233e2c9e8df9e8d0c3d158c0
petarpetkovic [Wed, 27 Sep 2017 14:00:18 +0000 (16:00 +0200)]
Migrate and convert WL settings to the new UX
Convert Watchlist settings to new UX, with following rules:
- If "Hide edits by anonymous users from the watchlist" is checked,
add "Registered" filter to defaults.
- If "Hide edits by logged in users from the watchlist" is checked,
add "Unregistered" filter to defaults.
- Change test for Special:Watchlist page, so new structured filters
are supported.
Bug: T172757
Change-Id: I27bdaa1401323fa3143f79a57dc5b9773e48fd1d
Brad Jorsch [Wed, 27 Sep 2017 12:01:58 +0000 (08:01 -0400)]
Fix watchlist "in the last X hours" display
If6280ad6 changed the interpretation of the URL parameter "days=0" (or
any negative value) from meaning "maximum number of days" to actually
meaning "0 days". That's a somewhat annoying breaking change, but easily
worked around by updating bookmarks.
But it didn't update the display on the page, so despite querying 0 days
it would still incorrectly say something like "in the last 720 hours"
rather than "in the last 0 hours".
Bug: T176857
Change-Id: I90c79ef9c4819a34060515b863277fd185828ed9
Aaron Schulz [Fri, 24 Feb 2017 16:20:07 +0000 (08:20 -0800)]
Revert Message dependency from DB exception classes
This was added in
a90bbf1a.
These classes are in /libs and should not depend on all of MediaWiki.
Change-Id: I67bc818b0c674f1aa3e0dde27a38a9f385fcab75
jenkins-bot [Wed, 27 Sep 2017 02:32:38 +0000 (02:32 +0000)]
Merge "objectcache: Improve WANObjectCache test coverage"
jenkins-bot [Tue, 26 Sep 2017 23:20:31 +0000 (23:20 +0000)]
Merge "Update jQuery Migrate to v3.0.1"
Jforrester [Tue, 26 Sep 2017 21:57:26 +0000 (21:57 +0000)]
Merge "Update OOjs UI to v0.23.2"
Timo Tijhof [Tue, 26 Sep 2017 21:16:27 +0000 (22:16 +0100)]
Update jQuery Migrate to v3.0.1
* Fixes IE9 issues with console.log.
* Add warning for $.fn.hover().
* Add warning for $.holdReady().
* Improve handling of jQuery.easing methods.
Change-Id: I38084ac6367b6d2ba47d6ecc6c9934a8bb7d8ae0
James D. Forrester [Tue, 26 Sep 2017 20:28:20 +0000 (16:28 -0400)]
Update OOjs UI to v0.23.2
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.2
Depends-On: I9d1264ebf456cadc7e350c2558a9997a2a0633c4
Change-Id: I9bbd4b8ff6333816e7ba73b3c033623753bb6df5
eranroz [Tue, 26 Sep 2017 20:10:06 +0000 (23:10 +0300)]
Correcting check icon placement in RTL
Bug: T176796
Change-Id: Ib0c6faa77f393a9f0f78b9d9d492c4c25fb0d3b5
Translation updater bot [Tue, 26 Sep 2017 19:57:23 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idf6479521c3219958d6e50941b5876e735e9cf9b
jenkins-bot [Tue, 26 Sep 2017 17:53:37 +0000 (17:53 +0000)]
Merge "Make mw.widget.TitleWidget more flexible"
jenkins-bot [Tue, 26 Sep 2017 17:25:47 +0000 (17:25 +0000)]
Merge "RCFilters: Log performance data"
Ed Sanders [Tue, 26 Sep 2017 16:31:38 +0000 (17:31 +0100)]
Make mw.widget.TitleWidget more flexible
* Factor out #createOptionWidget so different option
widget subclasses can be constructed
* Factor out #getApiParams so extra data can be fetched
from the API
* Pass through raw API data to pageData, so extra API
data can be used in option widgets
Change-Id: I150c513e4144ad5b57643e98dd48866ce2d37850
jenkins-bot [Tue, 26 Sep 2017 13:39:12 +0000 (13:39 +0000)]
Merge "RCFilters: Also set toplinks-collapsed class if no cookie"
jenkins-bot [Tue, 26 Sep 2017 01:50:10 +0000 (01:50 +0000)]
Merge "RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()"
Brad Jorsch [Wed, 20 Sep 2017 16:55:55 +0000 (12:55 -0400)]
Fix insertSelect() with IGNORE in PostgreSQL
I0e6a9e6d overlooked the special handling PG needs (prior to 9.5 anyway)
to properly emulate MySQL's IGNORE option when delegating to the parent
implementation.
For now, then, don't use the native implementation in PG when IGNORE is
specified. Instead, fall back to the non-native implementation that does
a select() then an insert() where PG can handle the IGNORE properly.
In the future we might use the ON CONFLICT DO NOTHING clause added in PG
9.5 to be able to do native insertSelect() with IGNORE (and to better
handle multi-row insert() with IGNORE, and we could use the related ON
CONFLICT DO UPDATE to implement upsert()). All that is left for a future
patch.
Change-Id: I7987d59580543de03d5c6a5ed7fa3ce551ac12f3
jenkins-bot [Mon, 25 Sep 2017 23:39:19 +0000 (23:39 +0000)]
Merge "SpecialPages: Reduce selector specificity"
Timo Tijhof [Mon, 25 Sep 2017 23:21:40 +0000 (00:21 +0100)]
objectcache: Improve WANObjectCache test coverage
class WANObjectCache (methods: 30% -> 40%, lines: 62% -> 65%)
* doGetWithSetCallback: 98% -> 100%
- Add case: Throw for invalid callback.
* getWithSetCallback: 86% -> 100%
- Cover case: Else branch for `$cur[self::VFLD_VERSION] === $version`.
* getMulti: 91% -> 98%
- Cover case: If branch for `$this->warmupCache`.
* set: 93% -> 100%
- Cover case: If branch for `lockTSE >= 0`.
* reap: 84% -> 100%
- Add case: Error when changeTTL() fails.
Change-Id: I4844ab0ebdd4d3ec9acc9cd4500721b04cfda317
jenkins-bot [Mon, 25 Sep 2017 22:41:19 +0000 (22:41 +0000)]
Merge "Allow two-queue style insertion in MapCacheLRU"
Roan Kattouw [Mon, 25 Sep 2017 22:28:47 +0000 (15:28 -0700)]
RCFilters: Log performance data
Just UI ready time and wgBackendResponseTime for now.
Sanitizing responseStart and especially firstPaint cross-browser
is too messy. NavigationTiming has code for it but that would
need to be exposed somewhere.
Bug: T176652
Change-Id: I6caf52fe8bc77fac0426d73549553301c5951c32
Roan Kattouw [Mon, 25 Sep 2017 21:50:04 +0000 (14:50 -0700)]
RCFilters: Also set toplinks-collapsed class if no cookie
If the cookie was not set, the PHP code treated that as
"expanded", but the JS code treated it as "collapsed".
Fix the PHP code.
Bug: T176380
Change-Id: Iff9b865bd20a571ade2ae619cbb5b3a70629003c
Gilles Dubuc [Wed, 6 Sep 2017 13:05:16 +0000 (15:05 +0200)]
Give thumbor swift user r/w access to containers
readUsers and writeUsers are new optional values
of the swift backend configuration. They allow
giving read and/or write rights to additional
users than the default swift user.
Bug: T144479
Change-Id: I0f81a013ec994eee3f156a89f29f4fcfc37c42b7
Aaron Schulz [Fri, 22 Sep 2017 16:26:50 +0000 (18:26 +0200)]
Allow two-queue style insertion in MapCacheLRU
Change-Id: I1cd98ea8965b51e43371efd990fb9302bb507928
jenkins-bot [Mon, 25 Sep 2017 21:06:45 +0000 (21:06 +0000)]
Merge "WLFilters: Live update and View newest"
jenkins-bot [Mon, 25 Sep 2017 20:18:04 +0000 (20:18 +0000)]
Merge "HTMLSelectAndOtherField/HTMLSelectOrOtherField: Change how ID is handled in OOUI mode"
Translation updater bot [Mon, 25 Sep 2017 19:54:30 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic032757aa36350153e2df304b7636a4b66916f64
jenkins-bot [Mon, 25 Sep 2017 19:49:56 +0000 (19:49 +0000)]
Merge "Add print styles for gallery mode packed-hover"
Roan Kattouw [Mon, 25 Sep 2017 19:39:12 +0000 (12:39 -0700)]
RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()
Calling Message::parse() on 2 messages per tag (for 80+ tags)
is fairly expensive. It takes about 400ms in production, but
adding that to requests that normally take 150-400ms is a pretty
big hit.
Bug: T176652
Change-Id: I9114f69de8b18007735de3438809f5695e380738
jenkins-bot [Mon, 25 Sep 2017 19:22:53 +0000 (19:22 +0000)]
Merge "Block same-file reuploads"
jenkins-bot [Mon, 25 Sep 2017 19:14:46 +0000 (19:14 +0000)]
Merge "mw.special.preferences.timezone: Remove some very old unnecessary code"
Bartosz Dziewoński [Mon, 25 Sep 2017 18:49:51 +0000 (20:49 +0200)]
HTMLSelectAndOtherField/HTMLSelectOrOtherField: Change how ID is handled in OOUI mode
Set the ID on the main widget (mw.widgets.SelectWithInputWidget), so
that it can be infused by ID.
The dropdown/textbox by themselves can't be infused individually,
therefore IDs on them are pretty useless; remove those where they're
not necessary.
Follow-up to
8bd6605736c47259bd5f901284cbd2e639cef30c.
Change-Id: If54dd48f1000e3e0f5a978428a5b622797b4f765
jenkins-bot [Mon, 25 Sep 2017 18:39:12 +0000 (18:39 +0000)]
Merge "resourceloader: Remove deprecated MessageBlobStore::insertMessageBlob"
Bartosz Dziewoński [Mon, 25 Sep 2017 18:34:30 +0000 (20:34 +0200)]
mw.special.preferences.timezone: Remove some very old unnecessary code
The first two removed blocks date to the pre-HTMLForm versions of the
preferences form (rSVN44915 /
c672ce603272d5206f0967f70f2474b4c09ce43a),
where the dual dropdown/textbox field was implemented specially for
this form. Its behavior currently is handled by HTMLSelectOrOtherField
and selectorother.js, and this code is entirely unnecessary.
The third removed block was added as a workaround for an issue caused
by the second block, in
e8d94f433c43982003fb0d008e1fc8ee04ed7744.
Looks like we didn't realize at the time that we can just delete the
buggy line.
This fixes a minor issue where no warning would be displayed when
exiting the preferences page without saving the changes after the user
changed the "Time zone" field from "Other" to "Fill in from the
browser" and the guessed value was different from the saved one.
Change-Id: I9b5317111aaf7f6039d476b263ee9e54c4b4cf52
jenkins-bot [Mon, 25 Sep 2017 17:45:00 +0000 (17:45 +0000)]
Merge "Unify monospace font family stack"
jenkins-bot [Mon, 25 Sep 2017 17:44:27 +0000 (17:44 +0000)]
Merge "Update documentation for IApiMessage interface"
Timo Tijhof [Mon, 25 Sep 2017 17:37:35 +0000 (18:37 +0100)]
resourceloader: Remove deprecated MessageBlobStore::insertMessageBlob
Deprecated since MediaWiki 1.27. No uses in Wikimedia Git.
Follows-up
5d5b269e0e63. (T113092)
Change-Id: I98c4db4fb0a3909d25d0fcd587e0f34391612423
Cormac Parle [Mon, 25 Sep 2017 13:44:26 +0000 (14:44 +0100)]
Add print styles for gallery mode packed-hover
Bug: T140346
Change-Id: Ifd94706c427c6bb7577040bbfecfdc6a303e0d8b
jenkins-bot [Mon, 25 Sep 2017 16:30:57 +0000 (16:30 +0000)]
Merge "getConfiguration: Don't bail when a valid variable is set null"
Brad Jorsch [Mon, 25 Sep 2017 16:14:55 +0000 (12:14 -0400)]
Update documentation for IApiMessage interface
It was created for a specific purpose, and apparently this is confusing
some people who're inexplicably trying to implement it outside of that
purpose. So, this patch more clearly documents that purpose.
Change-Id: I638482327370522bedea1ec514ecbb9d98207382
jenkins-bot [Mon, 25 Sep 2017 16:11:01 +0000 (16:11 +0000)]
Merge "Make `ApiUploadTest` up to date so it passes"
jenkins-bot [Mon, 25 Sep 2017 15:43:07 +0000 (15:43 +0000)]
Merge "resourceloader: Implement isKnownEmpty for user.options module"
jenkins-bot [Mon, 25 Sep 2017 15:42:33 +0000 (15:42 +0000)]
Merge "resourceloader: Support isKnownEmpty for general modules"
jenkins-bot [Mon, 25 Sep 2017 15:22:39 +0000 (15:22 +0000)]
Merge "registration: Fix caching of load_composer_autoloader"
jenkins-bot [Mon, 25 Sep 2017 15:07:40 +0000 (15:07 +0000)]
Merge "EditPage: Disable preview on open if $wgRawHtml is enabled"
Volker E [Mon, 25 Sep 2017 15:07:09 +0000 (16:07 +0100)]
Unify monospace font family stack
Bug: T176636
Change-Id: I4bab7f13b5bd641df9a2a9638e60e14951313d52
jenkins-bot [Mon, 25 Sep 2017 14:51:39 +0000 (14:51 +0000)]
Merge "WikiPage: Hard deprecate second arg of prepareContentForEdit() as an int"
Stephane Bisson [Thu, 21 Sep 2017 19:44:02 +0000 (15:44 -0400)]
WLFilters: Live update and View newest
Moved handling for 'from', 'days' and 'limit'
to base class (ChangesListSpecialPage)
I moved 'days' because its implementation
is related to 'from'.
I moved 'limit' because it was getting lonely
and it's identical in all cases.
Bug: T176348
Change-Id: If6280ad6fbad65909e1d0b2a48344e24d485aca2
jenkins-bot [Sun, 24 Sep 2017 20:43:41 +0000 (20:43 +0000)]
Merge "EditPage: Hard-deprecate isOouiEnabled(), getCheckboxes(), getCheckboxesOOUI()"
Translation updater bot [Sun, 24 Sep 2017 19:56:32 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I690f31abfbbfaff56761bde38a0813d12c949f39
jenkins-bot [Sun, 24 Sep 2017 14:57:00 +0000 (14:57 +0000)]
Merge "RCFilters: Don't load all of OOUI"
Kunal Mehta [Sat, 23 Sep 2017 21:07:15 +0000 (14:07 -0700)]
EditPage: Disable preview on open if $wgRawHtml is enabled
Otherwise the user will see a session failure message since their
request wasn't posted with a token, which doesn't make sense since they
just clicked on an edit link.
Bug: T172251
Change-Id: Id4a20818c737886f5a7ec72dba52c531f1ba78a0
Translation updater bot [Sat, 23 Sep 2017 19:58:19 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I41d3d09b418676e2b1171c02ac72182455ba5e16
Volker E [Sat, 23 Sep 2017 15:54:03 +0000 (08:54 -0700)]
SpecialPages: Reduce selector specificity
Reducing unneeded selector specificity.
Change-Id: I96b46b4e8b267c239c9a2cb73f65848c9fff9be1
Volker E [Sat, 23 Sep 2017 15:28:00 +0000 (08:28 -0700)]
SpecialPages: Align subtle and disabled text color to WikimediaUI palette
Aligning ProtectedPages unknown and disabled user rights text colors
to WikimediaUI color palette and make them conforming to WCAG level AA.
Bug: T152025
Change-Id: Id10477f92dd8b43caa26659cb63352637b436bda
jenkins-bot [Sat, 23 Sep 2017 12:13:36 +0000 (12:13 +0000)]
Merge "HTMLForm: Do not generate wrappers for empty sections"
Kunal Mehta [Sat, 23 Sep 2017 05:20:16 +0000 (22:20 -0700)]
registration: Fix caching of load_composer_autoloader
Move the file_exists() check out of the extension processor and into the
extension registry so that it is evaluated at run time instead of during
caching. The prior way is problematic since we don't invalidate the
cache if the existence of the file were to change.
Bug: T176534
Change-Id: I98e4ffdfac9f98397a103966824519afe1375356
jenkins-bot [Sat, 23 Sep 2017 00:03:02 +0000 (00:03 +0000)]
Merge "Use native ES5 Array prototype methods instead of jQuery"
Roan Kattouw [Fri, 22 Sep 2017 23:33:31 +0000 (16:33 -0700)]
RCFilters: Don't load all of OOUI
Just the widgets module is enough, we don't need
the windows or toolbars modules.
Change-Id: Ie8ce45f0d46fbc759d4579d619ab8c99c13cb0d5
jenkins-bot [Fri, 22 Sep 2017 21:59:38 +0000 (21:59 +0000)]
Merge "Improve "selfmove" message's wording"
Egbe Eugene [Thu, 13 Jul 2017 20:40:15 +0000 (21:40 +0100)]
Improve "selfmove" message's wording
The error shown when a page is to be moved (renamed) with the same
title is not immediately obvious to the user, so use simpler
and clearer language.
Bug: T164987
Change-Id: I639c4ae27866234fed9bcc5f2afc4684155418f8
Fomafix [Fri, 22 Sep 2017 04:46:40 +0000 (06:46 +0200)]
Use native ES5 Array prototype methods instead of jQuery
Replace
* $.each( array, function ( index, value ) { ... } ) by
array.forEach( function ( value ) { ... } )
* $.grep( array, function ( value ) { ... } ) by
array.filter( function ( value ) { ... } )
* $.map( array, function ( value ) { ... } ) by
array.map( function ( value ) { ... } )
Change-Id: I985ddf710e13c9ae788245349e2791571aeec97e
Volker E [Fri, 22 Sep 2017 20:30:19 +0000 (13:30 -0700)]
SpecialSearch: Fix unintended `margin` when zoom level is above 100%
With zoom level > 100% on Firefox, `#mw-searchoptions` which is a
`fieldset` element adds unintended `margin` with negative `margin-top`
applied. This is a workaround for wrong browser behaviour and
regression of I4bda42c03a5.
Bug: T176499
Change-Id: I329f83e6063460dc11ff45583e335280c9257ef7
jenkins-bot [Fri, 22 Sep 2017 20:10:10 +0000 (20:10 +0000)]
Merge "Remove duplicate release note for $wgOOUIEditPage removal"
jenkins-bot [Fri, 22 Sep 2017 20:06:48 +0000 (20:06 +0000)]
Merge "EditPage: Mark getSubmitButtonLabel() as @since 1.30"
Translation updater bot [Fri, 22 Sep 2017 19:56:06 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If2bdcb141ae02cc0c5324a9a1b10440edf1f6235
Kunal Mehta [Fri, 22 Sep 2017 19:52:35 +0000 (12:52 -0700)]
Remove duplicate release note for $wgOOUIEditPage removal
And capitalize Unicode properly.
Follows-up
b2441fc57d6e.
Change-Id: I2d68ff1abb0497eae046bd984d2a182066956325
Kunal Mehta [Fri, 22 Sep 2017 19:51:20 +0000 (12:51 -0700)]
EditPage: Mark getSubmitButtonLabel() as @since 1.30
Change-Id: I801e98b9f42636a46cdfa5cf7de4de2b59f9e46d
Aleksey Bekh-Ivanov (WMDE) [Fri, 22 Sep 2017 18:49:03 +0000 (20:49 +0200)]
Make `ApiUploadTest` up to date so it passes
Although the test is still might fail from time to time
and needs refactoring.
Bug: T28169
Change-Id: Ib27a36e0d76495a133eb8941300e4940e5eb670e
jenkins-bot [Fri, 22 Sep 2017 18:27:23 +0000 (18:27 +0000)]
Merge "Remove use of MWException in MapCacheLRU"
jenkins-bot [Fri, 22 Sep 2017 17:52:13 +0000 (17:52 +0000)]
Merge "RCFilters: Make 'lastRevision' filter include non-rev types"
jenkins-bot [Fri, 22 Sep 2017 17:38:59 +0000 (17:38 +0000)]
Merge "RCFilters: Make live update polling configurable"
jenkins-bot [Fri, 22 Sep 2017 17:35:07 +0000 (17:35 +0000)]
Merge "RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews"
Stephane Bisson [Thu, 21 Sep 2017 20:43:23 +0000 (16:43 -0400)]
RCFilters: Make live update polling configurable
Introducing $wgStructuredChangeFiltersLiveUpdatePollingRate
to configure the polling rate for live update.
Allows disabling polling completely by setting it to 0.
Change-Id: I13d3a4bb642c55a16e442f8f8d650c637f13f72c
jenkins-bot [Fri, 22 Sep 2017 17:17:53 +0000 (17:17 +0000)]
Merge "RCFilters: restore watch/unwatch link"
jenkins-bot [Fri, 22 Sep 2017 16:21:26 +0000 (16:21 +0000)]
Merge "EditPage: Avoid unnecessary calls to Article::getContext()"
Aaron Schulz [Fri, 22 Sep 2017 15:38:46 +0000 (17:38 +0200)]
Remove use of MWException in MapCacheLRU
Change-Id: I830555ffcb1b50bdc54e552daa469e2c5e00611d
jenkins-bot [Fri, 22 Sep 2017 10:55:34 +0000 (10:55 +0000)]
Merge "RCFilters: Start the toplinks collapsed/expanded by cookie value"
Stephane Bisson [Fri, 22 Sep 2017 10:35:58 +0000 (06:35 -0400)]
RCFilters: restore watch/unwatch link
Use jQuery event delegation to handle all
present and future watch/unwatch links.
Bug: T176264
Change-Id: If372c480e3e3809485027744b99caa6d4c94f86a
Kunal Mehta [Fri, 22 Sep 2017 09:05:15 +0000 (02:05 -0700)]
EditPage: Avoid unnecessary calls to Article::getContext()
Change-Id: I18a7f3b3eb1a9b18ea6ca20ad43878f4740f4e47
Kunal Mehta [Fri, 22 Sep 2017 09:20:19 +0000 (02:20 -0700)]
Add release notes for EditPage changes in 1.30
Change-Id: I42368cd97a2b25fb5d31c551442a527465157ce8
Moriel Schottlender [Thu, 21 Sep 2017 23:15:47 +0000 (16:15 -0700)]
RCFilters: Start the toplinks collapsed/expanded by cookie value
Prevent "jumping" of the content by initializing the top links already
collapsed or expanded depending on the cookie value.
Bug: T176380
Change-Id: I6c494b42ec6f029b60182607faa37feba062b597
jenkins-bot [Fri, 22 Sep 2017 00:16:32 +0000 (00:16 +0000)]
Merge "mw.loader: Simplify getVersion and getState"
Timo Tijhof [Thu, 21 Sep 2017 23:10:45 +0000 (00:10 +0100)]
mw.loader: Simplify getVersion and getState
This undefined check no longer makes sense since there are now
defaults for these in register(). There is no supported scenario
in which a module would have a key in the registry but not
have these properties defined, or have them defined with
the undefined value.
Change-Id: I945871861ccf3659c2d7dd021aa87dfd747f22b9
Timo Tijhof [Thu, 21 Sep 2017 22:31:48 +0000 (23:31 +0100)]
resourceloader: Use ES5 Array#filter instead of jQuery.grep
Same or better performance in Chrome Canary and latest WebKit.
Further reduces reliance on jQuery in base module.
Change-Id: I691b73b837178b76cff665cbd52f5e5067672a6e
Stephane Bisson [Thu, 21 Sep 2017 20:24:38 +0000 (16:24 -0400)]
RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews
Not used anymore.
Change-Id: I1afe736db76eef6ddae5c602d8e24fddfd807a3a
Stephane Bisson [Thu, 21 Sep 2017 20:17:22 +0000 (16:17 -0400)]
RCFilters: Make 'lastRevision' filter include non-rev types
Make 'lastRevision' filter behave like its predecessor (expanded)
by including the non-rev types (RC_LOG and others added via hook).
Bug: T176328
Change-Id: I2312fd536716f0b07637ed4caf225650a4ffe70c
Translation updater bot [Thu, 21 Sep 2017 20:05:48 +0000 (22:05 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4587d08701d8d44621e69077ef4a1b1fcce09025
Erik Bernhardson [Thu, 21 Sep 2017 19:18:57 +0000 (12:18 -0700)]
getConfiguration: Don't bail when a valid variable is set null
isset() will return false with a value is null. Null is an acceptable
result for a configuration variable, so switch to array_key_exists.
Change-Id: I11a3feb07d2bdc7ee30975014db29365086f89bc
jenkins-bot [Thu, 21 Sep 2017 18:21:19 +0000 (18:21 +0000)]
Merge "RCFilters: Use findRelativeSelectableItem instead of getRelativeSelectableitem"