jenkins-bot [Thu, 21 Feb 2019 10:37:50 +0000 (10:37 +0000)]
Merge "build: Update eslint-config-wikimedia to 0.11.0"
jenkins-bot [Thu, 21 Feb 2019 07:24:52 +0000 (07:24 +0000)]
Merge "Add support for Argon2 password hashing"
jenkins-bot [Thu, 21 Feb 2019 06:54:45 +0000 (06:54 +0000)]
Merge "Set $wgMediaInTargetLanguage to true by default"
jenkins-bot [Thu, 21 Feb 2019 04:30:09 +0000 (04:30 +0000)]
Merge "Set BlockDisablesLogin false for Blocking group tests that assume this"
Max Semenik [Thu, 21 Feb 2019 04:26:46 +0000 (20:26 -0800)]
Set $wgMediaInTargetLanguage to true by default
This feature flag is still unreleased, flipping it on by default
in preparation for removal.
Change-Id: Ice3c3d7e35023d93afb85d43f838c18dae9a9c3a
Ed Sanders [Wed, 20 Feb 2019 22:53:09 +0000 (22:53 +0000)]
build: Update eslint-config-wikimedia to 0.11.0
Change-Id: Iee025a518962e68c5ec2c07d952f402cd2a7f69b
jenkins-bot [Wed, 20 Feb 2019 22:14:37 +0000 (22:14 +0000)]
Merge "Database: Have buildStringCast() actually cast for MySQL, MSSQL"
jenkins-bot [Wed, 20 Feb 2019 20:48:33 +0000 (20:48 +0000)]
Merge "Fix password policy handling in temporary password provider"
jenkins-bot [Wed, 20 Feb 2019 20:25:59 +0000 (20:25 +0000)]
Merge "Make uca-tr use I as uppercase of dotless ı instead of reverse"
Gergő Tisza [Tue, 19 Feb 2019 04:19:13 +0000 (20:19 -0800)]
Fix password policy handling in temporary password provider
Fix breakage caused by
f15ecc60cd94. Also use correct check name.
Bug: T216196
Change-Id: Id2567adf8334742ef18a59a6c7e74b2b780ab43a
jenkins-bot [Wed, 20 Feb 2019 20:15:38 +0000 (20:15 +0000)]
Merge "Add missing use for IMaintainableDatabase"
jenkins-bot [Wed, 20 Feb 2019 20:01:20 +0000 (20:01 +0000)]
Merge "DifferenceEngine: Allow cache hits for empty diffs"
Umherirrender [Wed, 20 Feb 2019 19:57:18 +0000 (20:57 +0100)]
Add missing use for IMaintainableDatabase
Change-Id: I00b30466fa6044988768493586993c3db253c975
Brad Jorsch [Wed, 20 Feb 2019 19:41:55 +0000 (14:41 -0500)]
Database: Have buildStringCast() actually cast for MySQL, MSSQL
While these databases allow implicit casts (at least from int to
string), in MySQL at least the implicit cast can prevent appropriate
index usage (see T216183). So let's have buildStringCast() actually do
the cast.
This also changes the base implementation in Wikimedia\Rdmbs\Database to
explicitly cast. Any other subclasses should check whether this new
version works for them.
Bug: T216247
Change-Id: I98c67c857b35de3191d47ab28810d8eb21ddbbc8
jenkins-bot [Wed, 20 Feb 2019 19:31:44 +0000 (19:31 +0000)]
Merge "API: Spread autoblocks from action=edit and action=move"
jenkins-bot [Wed, 20 Feb 2019 19:24:49 +0000 (19:24 +0000)]
Merge "API: Add block info to more block errors"
Brian Wolff [Wed, 20 Feb 2019 16:55:44 +0000 (16:55 +0000)]
Make uca-tr use I as uppercase of dotless ı instead of reverse
The primary collision resolution makes wrong choice
Bug: T203158
Change-Id: Id677476937cc6575950496767b50c1e8c21f2fbc
jenkins-bot [Wed, 20 Feb 2019 16:18:02 +0000 (16:18 +0000)]
Merge "resourceloader: Tolerate string as deps for test suites"
James D. Forrester [Wed, 20 Feb 2019 12:55:51 +0000 (12:55 +0000)]
resourceloader: Tolerate string as deps for test suites
Change-Id: I53a5fd0f3716e50abd10e4cae1de6329e7b0f6e8
jenkins-bot [Wed, 20 Feb 2019 15:37:21 +0000 (15:37 +0000)]
Merge "objectcache: avoid duplicate cache sets for missing keys with lockTSE"
jenkins-bot [Wed, 20 Feb 2019 03:07:24 +0000 (03:07 +0000)]
Merge "Various fixes for phan-taint-check"
Aaron Schulz [Thu, 14 Feb 2019 03:56:05 +0000 (19:56 -0800)]
objectcache: avoid duplicate cache sets for missing keys with lockTSE
Follow-up to
70bf85d4626 which only affected the case of tombstoned keys.
Improve documentation about getWithSetCallback() options.
Bug: T203786
Change-Id: I683a38f65a79cb98a4ae71cbc5dd88aefe48d022
jenkins-bot [Wed, 20 Feb 2019 00:32:14 +0000 (00:32 +0000)]
Merge "eslint: Enable caching"
jenkins-bot [Wed, 20 Feb 2019 00:32:07 +0000 (00:32 +0000)]
Merge "TOC: Add z-index: -1 to hidden checkbox"
Brad Jorsch [Mon, 18 Feb 2019 19:46:05 +0000 (14:46 -0500)]
API: Spread autoblocks from action=edit and action=move
The code in EditPage and SpecialMovepage does this primarily in web UI
code paths that aren't called by the API. EditPage also has a check in
the internal code path used by the API, but ApiEditPage runs its own
permissions check first and won't reach that code path.
Bug: T216245
Change-Id: I6263c8b60a24f3195dba583463f1ce4b004f82f5
Brad Jorsch [Mon, 18 Feb 2019 20:30:41 +0000 (15:30 -0500)]
API: Add block info to more block errors
When using ApiBase::errorArrayToStatus(), block info was added to
'blocked' errors. But when using dieStatus() with a Status object
returned by core MediaWiki code, block info was not being added.
Change-Id: I14887b6dd76d665055283945b956b2e26c521ed5
Depends-On: Ie3addf53ab5fabf1c24e1033b58e63927f4e21bf
jenkins-bot [Tue, 19 Feb 2019 21:49:35 +0000 (21:49 +0000)]
Merge "MultiHttpClient: Don't relay the end-of-headers line"
jenkins-bot [Tue, 19 Feb 2019 21:47:54 +0000 (21:47 +0000)]
Merge "RCFilters: Don't show tags with 0 hits in tag menu"
jenkins-bot [Tue, 19 Feb 2019 21:34:50 +0000 (21:34 +0000)]
Merge "pagers: Remove unused "form" properties from two pagers"
Brad Jorsch [Tue, 19 Feb 2019 18:54:03 +0000 (13:54 -0500)]
MultiHttpClient: Don't relay the end-of-headers line
The callback registered by CURLOPT_HEADERFUNCTION is called for the
empty line that separates the headers from the body, as well as all the
actual headers. In this case, the $header string will be "\r\n".
It turns out that HHVM ignores a call to header() when passed a string
that's empty after trimming whitespace, while Zend PHP only ignores the
call when the string is empty before trimming whitespace. This later
causes problems when headers_list() is used expecting all strings
returned to contain a colon.
Bug: T216086
Change-Id: I07937b17beb06788166266fbb1ea1bbf456761e3
Translation updater bot [Tue, 19 Feb 2019 21:01:52 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1959bd49bd394c4a206843a2967111df1de9081d
Brad Jorsch [Tue, 19 Feb 2019 20:54:33 +0000 (15:54 -0500)]
DifferenceEngine: Allow cache hits for empty diffs
PHP considers the empty string as falsey, so check for a string
result instead.
Bug: T216554
Change-Id: I3b7d1199acbfede8a95761c5cb1c797b9a3d64cb
Roan Kattouw [Tue, 19 Feb 2019 20:53:53 +0000 (12:53 -0800)]
RCFilters: Don't show tags with 0 hits in tag menu
Bug: T182219
Change-Id: Id6b4c6fe652c15388f0d6b37912cb582ea205a47
Thiemo Kreuz [Tue, 19 Feb 2019 14:31:45 +0000 (15:31 +0100)]
pagers: Remove unused "form" properties from two pagers
I used
https://codesearch.wmflabs.org/search/?q=BlockListPager
https://codesearch.wmflabs.org/search/?q=ProtectedPagesPager
to make sure no subclass of these two classes exist, as well as no
other code that uses them in the first place.
I would like to argue that this does not need a deprecation phase.
Change-Id: If66f2378bc88adb5e8a6df5e637714be135dfafd
Fomafix [Tue, 19 Feb 2019 20:13:41 +0000 (21:13 +0100)]
TOC: Add z-index: -1 to hidden checkbox
The hidden checkbox is not visible but still clickable and changes the
cursor. The z-index: -1 prevent this.
Also add comments to explain the reason for each declaration.
This change is a follow-up to
68527cf47935a0350d3f0a153bd06cbb98062ec8.
Change-Id: Ia66f4fb250d1685fe5bb0089b789b36d9916a5d5
Thalia [Tue, 19 Feb 2019 20:16:21 +0000 (20:16 +0000)]
Set BlockDisablesLogin false for Blocking group tests that assume this
The global config $wgBlockDisablesLogin can override certain block flags
if true, causing some tests to fail. Set it to false for these tests.
Change-Id: I497ef07bd34a1e458fd9692ef4874474e61151c8
Ed Sanders [Tue, 19 Feb 2019 19:57:08 +0000 (19:57 +0000)]
eslint: Enable caching
Makes re-running eslint faster on dev environments.
Change-Id: I3bd7932b49de35022898cdc8add1934633e6dacb
Thiemo Kreuz [Tue, 19 Feb 2019 14:27:25 +0000 (15:27 +0100)]
pagers: Fix and add missing @param documentation
Sometimes the code expects a specific subclass as it calls a specific
method that only exists in this subclass. If this is not the case, all
the code needs to know is that it got some special page.
Some of these constructors should be changed to expect a IContextSource
instead of a special page. But this is for another patch. Here in this
patch I intentionally touch documentation only.
Change-Id: I33bae9641a8871f359edccacf88f09cfe8e83139
jenkins-bot [Tue, 19 Feb 2019 17:49:17 +0000 (17:49 +0000)]
Merge "resourceloader: Make $rl parameter mandatory for MessageBlobStore"
Timo Tijhof [Sat, 16 Feb 2019 23:46:30 +0000 (23:46 +0000)]
resourceloader: Make $rl parameter mandatory for MessageBlobStore
Change-Id: I851b2417b7e495a1d0c7ee1aa8be2b2e970840bb
Timo Tijhof [Tue, 5 Feb 2019 20:57:11 +0000 (20:57 +0000)]
build: Add initial version of Fresnel config
Copied from fresnel.git (removed there with I742c56122).
Bug: T133646
Change-Id: I23e7e9bc6343cf9e14dbfe275c1cdbb4cc5bd76d
mainframe98 [Tue, 19 Feb 2019 15:01:59 +0000 (16:01 +0100)]
Follow-up
262fd58: Correctly apply the ORDER BY in ActiveUsersPager
In
262fd58, an ORDER BY clause was added, but the direction it
is supposed to use was not loaded correctly from the $data array.
It is available under the key 'order', not 'dir'.
Bug: T216200
Change-Id: I5e675c98820813cd9107865e11e82ae57828a974
jenkins-bot [Tue, 19 Feb 2019 12:49:46 +0000 (12:49 +0000)]
Merge "Remove deprecated method insertArticleLink() from class ChangeList"
jenkins-bot [Tue, 19 Feb 2019 12:48:13 +0000 (12:48 +0000)]
Merge "Follow-up
77276ce: Clarify i18n message key/values and div class"
Derick Alangi [Sun, 10 Feb 2019 23:49:13 +0000 (00:49 +0100)]
Remove deprecated method insertArticleLink() from class ChangeList
This method was deprecated in MediaWiki 1.27 and in MW 1.26, an alternative
method was introduced (getArticleLink). Per the code search tool here:
https://codesearch.wmflabs.org/search/?q=insertArticleLink%5C(&i=nope&files=&repos=,
only SimpleChanges and RecentActivityFeed extensions still use this method and
patches have been made to stop the use of these deprecated methods, see;
~ Ia80496c02ee5d0cb7bf9bdb1b336ea2699325d4c (RecentActivityFeed extension)
~ I5a9359f107da6a92b5f52e58879b540480ed2443 (SimpleChanges extension)
Once the above patches are merged, this patch can be reviewed and merged
as there will no longer be any usage of the deprecated method per code search
tool.
Change-Id: I166a7e5af7d8d3df60208583b6ce002bf65305a6
jenkins-bot [Tue, 19 Feb 2019 11:21:52 +0000 (11:21 +0000)]
Merge "Changed the name of the (gcr) language from "Kreyol Gwiyanè" to "Kriyòl Gwiyannen""
Derick Alangi [Tue, 19 Feb 2019 08:59:20 +0000 (09:59 +0100)]
Follow-up
77276ce: Clarify i18n message key/values and div class
Bug: T150324
Change-Id: I5bbaf2030e07f27d64bf18109f198ff4cc04a7ff
jenkins-bot [Tue, 19 Feb 2019 00:44:21 +0000 (00:44 +0000)]
Merge "specials: Fix fatal MWNamespace exception on Special:Contributions"
Derick Alangi [Sun, 17 Feb 2019 11:38:12 +0000 (12:38 +0100)]
specials: Fix fatal MWNamespace exception on Special:Contributions
Namespaces with negative values (valid like -1 and -2 or invalid like
less than -2), should not be processed as they do not have associated
namespaces. Rather than throwing an exception, nicely tell the user
the namespace is a negative value and doesn't have an associated
namespace to it.
Also, don't show any results, just load the form again so user can do
another request but show reason for this behavior atop of form.
Bug: T150324
Change-Id: I525d305a4dabb040110894d3230eeb5e04ff8336
jenkins-bot [Mon, 18 Feb 2019 21:41:52 +0000 (21:41 +0000)]
Merge "Cache redirects from Special:Redirect"
jenkins-bot [Mon, 18 Feb 2019 21:19:51 +0000 (21:19 +0000)]
Merge "MigrateActors: Don't delete log_search rows when migrating"
Translation updater bot [Mon, 18 Feb 2019 21:04:55 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibb9f46d77e8fc63163bd1f7792beb7a7bde12be7
jenkins-bot [Mon, 18 Feb 2019 19:53:40 +0000 (19:53 +0000)]
Merge "mediawiki.api: Prevent misusing #saveOptions"
Timo Tijhof [Sat, 16 Feb 2019 23:30:46 +0000 (23:30 +0000)]
resourceloader: Require $context parameter for FileModule::readStyleFiles()
Deprecated since MW 1.27.
Also update ResourcesTest to use TestingAccessWrapper instead of long-form
object reflection, and also apply it to its call for this method given
its meant to be private.
Change-Id: I9cc1af93730f632e4f8bf3a16d514a51ee73cb03
jenkins-bot [Mon, 18 Feb 2019 18:44:44 +0000 (18:44 +0000)]
Merge "resourceloader: Instantiate main class via ServiceWiring"
Timo Tijhof [Sat, 16 Feb 2019 23:16:09 +0000 (23:16 +0000)]
resourceloader: Instantiate main class via ServiceWiring
It also removes some code duplication which is nice.
This unlocks various future changes, including:
* Making the `$config` parameter mandatory for the ResourceLoader class
constructor, which currently falls back to global state.
This should be deprecated and removed.
* Making it possible to instantiate the ResourceLoader class
without all the default MW modules being registered from
global state. E.g. move MW module registration from main class
constructor to ServiceWiring, and remove the 'EmptyResourceLoader'
class hack from unit tests, and use regular 'new ResourceLoader'
instead.
* Making ResourceLoader a standalone library (some day),
e.g. allowing it to be instantiated from a basic PHP script,
in a way that is still useful and perhaps able to serve
(most) RL modules without MW itself.
Bug: T32956
Change-Id: I4939f296c705b268e9cf8de635e923a739410470
Bartosz Dziewoński [Fri, 1 Feb 2019 22:23:30 +0000 (14:23 -0800)]
mediawiki.api: Prevent misusing #saveOptions
Task T214963 is about how we misused #saveOptions in VisualEditor and
made MediaWiki sad. I'm not sure whether we should fix the issues
there or here, but it seems like the mistakes would be easy to make in
other software, so let's try here first and see what folks think about
it.
* Do not send action=options API requests for IP users
* Wait for the previous request to finish before sending another
Bug: T214963
Change-Id: I85cfc6b5829bcd96e6245431cd979c24630a8fd8
jenkins-bot [Mon, 18 Feb 2019 17:35:57 +0000 (17:35 +0000)]
Merge "mediawiki.Title: Avoid 'this' in static method"
jenkins-bot [Mon, 18 Feb 2019 17:07:20 +0000 (17:07 +0000)]
Merge "objectcache: remove dangling WAN cache EventRelayer references"
jenkins-bot [Mon, 18 Feb 2019 11:39:30 +0000 (11:39 +0000)]
Merge "Do not use raw html for Special:ProtectedPages drop-down messages"
Brian Wolff [Sun, 17 Feb 2019 11:14:18 +0000 (11:14 +0000)]
Do not use raw html for Special:ProtectedPages drop-down messages
The following messages are affected: protectedpages-indef,
protectedpages-cascade, protectedpages-noredirect.
This appear to be accidental. AFAIK nobody is using these messages
in a raw html fashion.
This change is to make phan-taint-check happier.
Bug: T216348
Change-Id: I0e038c2e01e2252be288b86950208510741efc67
jenkins-bot [Mon, 18 Feb 2019 07:48:00 +0000 (07:48 +0000)]
Merge "import: Remove deprecated WikiRevision::$importer property"
zoranzoki21 [Sun, 17 Feb 2019 22:45:10 +0000 (23:45 +0100)]
Fix 'expliciit' typo at resources/Resources.php
Bug: T201491
Change-Id: Ic6c60aad037df3599572f7248093d7dc1509819d
Translation updater bot [Sun, 17 Feb 2019 20:55:23 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2316460e88bc758daa875638518105524f97ea1d
jenkins-bot [Sun, 17 Feb 2019 14:58:29 +0000 (14:58 +0000)]
Merge "Escape messages ipb-sitewide and ipb-partial."
Brian Wolff [Sun, 17 Feb 2019 12:49:03 +0000 (12:49 +0000)]
Escape messages ipb-sitewide and ipb-partial.
Radio button htmlform treats options as being raw html
Change-Id: Ia25ed5b88e937414ea7993a1cf29fe44ed8e22d4
Brian Wolff [Sun, 17 Feb 2019 11:41:11 +0000 (11:41 +0000)]
Various fixes for phan-taint-check
Bug: T216348
Change-Id: I0adafdc680dae0e930f38f08fe926645c57be06c
Brian Wolff [Fri, 1 Feb 2019 01:54:08 +0000 (01:54 +0000)]
Cache redirects from Special:Redirect
People sometimes link these from high traffic places, so it is
important to cache in varnish.
File's with height can change so only cache that for 10 seconds.
Also change from 302 to 301.
Change-Id: I87a60c812cd1aa78a36359090c0cb8390be7183f
Brian Wolff [Wed, 26 Sep 2018 01:00:25 +0000 (01:00 +0000)]
Avoid rawParams() in Special:Emailuser
Bug: T216348
Change-Id: I6b543c508260f5889f1236dd43022a6a0fe963a9
Aaron Schulz [Sun, 17 Feb 2019 03:44:36 +0000 (19:44 -0800)]
objectcache: remove dangling WAN cache EventRelayer references
* Remove 'channels' field references from config/setup
* Remove 'relayer'/'channels' field reference in unit tests
* Remove unused DEFAULT_PURGE_CHANNEL class constant
* Also remove long-since bogus 'pool' field references
Follow-up to
4753b0a4ed4b6b8abb
Change-Id: If6670ff4e1dccc8ae253a08b46d205601da10024
Timo Tijhof [Sun, 17 Feb 2019 00:48:41 +0000 (00:48 +0000)]
mediawiki.Title: Avoid 'this' in static method
Follows-up
144103b0293.
Also remove use of private mw.config.values, and remove redundant
manual restoration.
Change-Id: I3570dbfa2d2f524ade6b467821e493e950f2a605
Fomafix [Fri, 7 Dec 2018 09:55:03 +0000 (10:55 +0100)]
resources: Document why mw.user has two seemingly unused deps
The code in the module 'mediawiki.user' does not depend on the modules
'user.options' and 'user.tokens' so the ResourceLoader dependency is
not necessary.
Change-Id: I22b9175f7623dbdf1c08826904b76dee5d56ea40
jenkins-bot [Sun, 17 Feb 2019 00:35:34 +0000 (00:35 +0000)]
Merge "widgets: Remove redundant equality check in SelectWithInputWidget"
jenkins-bot [Sat, 16 Feb 2019 19:49:22 +0000 (19:49 +0000)]
Merge "objectcache: remove EventRelayer dependency from WANObjectCache"
jenkins-bot [Sat, 16 Feb 2019 10:59:48 +0000 (10:59 +0000)]
Merge "Fix documentation for Revision::getComment and WikiPage::getComment"
Aaron Schulz [Sat, 16 Feb 2019 07:17:23 +0000 (23:17 -0800)]
objectcache: remove EventRelayer dependency from WANObjectCache
The use of that class for WAN cache by third parties is extremely unlikely
and the approach was abandoned at WMF in favor of mcrouter (dynomite was
also considered preferable).
Change-Id: I328eb74f21c23db80acc5178bc3c9cf9f823da13
Roan Kattouw [Sat, 16 Feb 2019 01:00:49 +0000 (17:00 -0800)]
ChangeTags: Deprecate ChangeTags::purgeTagUsageCache()
The cache key that it purges is no longer used anywhere.
Change-Id: I2c255936451cde09579594cc4524c8fe38cf3e7c
jenkins-bot [Fri, 15 Feb 2019 22:23:54 +0000 (22:23 +0000)]
Merge "Improve documentation for different block types"
jenkins-bot [Fri, 15 Feb 2019 20:15:47 +0000 (20:15 +0000)]
Merge "Remove double check of $oldRevision"
Brad Jorsch [Thu, 7 Feb 2019 15:27:06 +0000 (10:27 -0500)]
MigrateActors: Don't delete log_search rows when migrating
When I4764c1c78 switched from being run during read-both/write-new to
write-both/read-old, we should have also removed the code that
blanked/deleted the old rows. That was done for the main migration, but
was overlooked for log_search.
Bug: T215464
Change-Id: Icbba54dbd57fe0fa07ea0f6dcdde30089f067ace
Thalia [Fri, 15 Feb 2019 19:24:58 +0000 (19:24 +0000)]
Improve documentation for different block types
Clarify the purposes of Block::type and Block::getType
Change-Id: I64a2695f430c7718c504edb1fa6531a529c115cf
Matěj Suchánek [Thu, 14 Feb 2019 09:47:54 +0000 (10:47 +0100)]
Prevent PHP notice on SpecialDeletedContributions
Bug: T208544
Change-Id: Ie8d5c3d7257134857713853eec8e0eb42890366a
Bill Pirkle [Thu, 7 Feb 2019 00:14:23 +0000 (18:14 -0600)]
Refactor calls to deprecated function Content::getNativeData()
Function Content::getNativeData() was deprecated. Replace with
calls to new function TextContent::getText() in most places.
Bug: T155582
Change-Id: I2bd508c72aac4faf474ba45ab1f92e2e8d2eb9be
Derick Alangi [Thu, 14 Feb 2019 12:30:49 +0000 (13:30 +0100)]
import: Remove deprecated WikiRevision::$importer property
This property was introduced since 1.17 and was unused, then following
the deprecation policy, it was deprecated in 1.29. Removing this now
as it's been long enough and has been for several MW versions. Also,
updated release notes to mention this removal.
Change-Id: Ib6353dd37079bcfe7cd15600e8af1f67b245f4a3
Translation updater bot [Thu, 14 Feb 2019 21:05:27 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic40eaf0cedbbf6a81585f4f0d686f4aa3ae7d160
jenkins-bot [Thu, 14 Feb 2019 20:58:56 +0000 (20:58 +0000)]
Merge "objectcache: refactor and simplify some WANObjectCache code"
jenkins-bot [Thu, 14 Feb 2019 20:40:35 +0000 (20:40 +0000)]
Merge "Update required PHP version to 7.0.13"
jenkins-bot [Thu, 14 Feb 2019 19:31:57 +0000 (19:31 +0000)]
Merge "Use "try-catch" block instead of "if" block to prevent interruption of new installation"
James D. Forrester [Thu, 14 Feb 2019 19:29:48 +0000 (11:29 -0800)]
Update required PHP version to 7.0.13
Bug: T209423
Change-Id: I66e563adb062bc132a1092d78bfd06e2210f382e
jenkins-bot [Thu, 14 Feb 2019 13:26:12 +0000 (13:26 +0000)]
Merge "jquery.makeCollapsible.styles: Avoid FOUC for collapse button"
jenkins-bot [Thu, 14 Feb 2019 13:24:55 +0000 (13:24 +0000)]
Merge "EnhancedChangesList: Load style module via addModuleStyles()"
jenkins-bot [Thu, 14 Feb 2019 13:17:55 +0000 (13:17 +0000)]
Merge "Add missing dependency on module 'mediawiki.notify'"
jenkins-bot [Thu, 14 Feb 2019 13:09:13 +0000 (13:09 +0000)]
Merge "mediawiki.special.changeslist.enhanced: Convert CSS to LESS"
Fomafix [Thu, 14 Feb 2019 08:59:23 +0000 (09:59 +0100)]
Add missing dependency on module 'mediawiki.notify'
watchlist.js uses mw.notify.
Change-Id: Iff59e01d96f3d8ffddd9ddaf9d3b4463c8cac8d1
jenkins-bot [Thu, 14 Feb 2019 06:38:04 +0000 (06:38 +0000)]
Merge "registration: Allow @-prefixed keys in manifest_version 2"
jenkins-bot [Thu, 14 Feb 2019 06:18:57 +0000 (06:18 +0000)]
Merge "Update AtEase calls to use Wikimedia namespace"
Aaron Schulz [Wed, 13 Feb 2019 20:24:27 +0000 (12:24 -0800)]
objectcache: refactor and simplify some WANObjectCache code
* Move $value === false checks to isValid()
* Rename $isTombstone variable to avoid confusion with the new value
* Reorganize conditionals around set() calls in doGetWithSetCallback()
* Skip getInterimValue() check when there is no reason to assume anything
might even be there (e.g. the key is not tombstoned)
* Fold the tombstone case for $useMutex into the ternary
Change-Id: I257110097cffe7fe87c6a9896e875f09d5c936d9
jenkins-bot [Thu, 14 Feb 2019 01:25:11 +0000 (01:25 +0000)]
Merge "objectcache: cleanup tombstone/mutex logic in doGetWithSetCallback()"
jenkins-bot [Thu, 14 Feb 2019 00:49:21 +0000 (00:49 +0000)]
Merge "resourceloader: Restore the comment about <script> vs XHR loading"
Bartosz Dziewoński [Wed, 13 Feb 2019 13:21:04 +0000 (14:21 +0100)]
resourceloader: Restore the comment about <script> vs XHR loading
Removed in
42956b99b558294e5aa8c6c0e2a8f18513478022.
I think it's useful to know this rationale (even more so because
the arguments about caching seem no longer correct these days).
Also, add the line about loading progress not being known when
using this method.
(Slightly related to T216034)
Change-Id: I81fa90483c0c85fecc5cb620196521ce8bdd33a7