Aaron Schulz [Tue, 7 Feb 2012 00:20:27 +0000 (00:20 +0000)]
r80240: throw an exception if an empty message key array is given
Chad Horohoe [Mon, 6 Feb 2012 22:44:30 +0000 (22:44 +0000)]
Revert r103467, r106446 (bug 24464: calling LoginAuthenticateAudit hook more often)
Pretty narrow use case isn't very well defined, and this has *felt wrong* to me since
it was committed in November. Easier to pull for now rather than blocking release.
Alexandre Emsenhuber [Mon, 6 Feb 2012 21:52:48 +0000 (21:52 +0000)]
Follow-up r110761: removed duplicate check of $wgShowIPinHeader and fix some whitespaces
Raimond Spekking [Mon, 6 Feb 2012 21:41:15 +0000 (21:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Antoine Musso [Mon, 6 Feb 2012 21:39:56 +0000 (21:39 +0000)]
disable ApiUploadTest
ApiUploadTest gives inconsistent results which trigger false alamrs to all
the ops team. We are disabling those tests for now.
See https://bugzilla.wikimedia.org/26169
Antoine Musso [Mon, 6 Feb 2012 21:38:14 +0000 (21:38 +0000)]
comment about wgDebugToolbar disabling file cache
Sam Reed [Mon, 6 Feb 2012 20:20:43 +0000 (20:20 +0000)]
Add @since to getIP/getRawIP
Came in r94932, soemwhere after 1.18 was branched, so is in 1.19
Alexandre Emsenhuber [Mon, 6 Feb 2012 17:34:33 +0000 (17:34 +0000)]
Recommit r110758 (again) now that the problem has been fixed in r110761
Antoine Musso [Mon, 6 Feb 2012 17:17:51 +0000 (17:17 +0000)]
disable wgDebugToolbar when rebuilding file cache
credits to iAlex :)
Sam Reed [Mon, 6 Feb 2012 17:06:10 +0000 (17:06 +0000)]
Ping r110759, remove erroneous extra subdir
Sam Reed [Mon, 6 Feb 2012 16:58:10 +0000 (16:58 +0000)]
Move mediawiki.api to own folder
Antoine Musso [Mon, 6 Feb 2012 16:42:58 +0000 (16:42 +0000)]
reverts r110488
Breaks maintenance/rebuildFileCache.php with stack trace saying that
FauxRequest::getRequestURL() not implemented
Backtrace:
#0 includes/WebRequest.php(1261): FauxRequest->notImplemented('FauxRequest::ge...')
#1 includes/debug/Debug.php(266): FauxRequest->getRequestURL()
#2 includes/Skin.php(561): MWDebug::getDebugHTML(Object(RequestContext))
#3 includes/SkinTemplate.php(461): Skin->generateDebugHTML()
#4 includes/OutputPage.php(1982): SkinTemplate->outputPage()
#5 maintenance/rebuildFileCache.php(119): OutputPage->output()
#6 maintenance/doMaintenance.php(105): RebuildFileCache->execute()
#7 maintenance/rebuildFileCache.php(146): require_once('/srv/trunk/main...')
#8 {main}
Sam Reed [Mon, 6 Feb 2012 16:16:01 +0000 (16:16 +0000)]
And fix fail rom r110752
Sam Reed [Mon, 6 Feb 2012 16:07:52 +0000 (16:07 +0000)]
Not much point making user_groups.ug_group 32 chars if we leave user_former_groups.ufg_group at 16
Also fix modify field to use correct table/column
Robin Pepermans [Mon, 6 Feb 2012 15:21:49 +0000 (15:21 +0000)]
Add fallback to Russian (per meta.wikimedia.org/wiki/Requests_for_new_languages/Wikipedia_Lezgi )
Max Semenik [Mon, 6 Feb 2012 15:21:10 +0000 (15:21 +0000)]
Fixed r63018: made it possible to delte half-baked images w/o descriptions, clearer error message
Alexandre Emsenhuber [Mon, 6 Feb 2012 11:35:24 +0000 (11:35 +0000)]
Removed false comment, we no longer use file cache for action=raw calls.
Alexandre Emsenhuber [Mon, 6 Feb 2012 11:19:14 +0000 (11:19 +0000)]
Use WikiPage instead of Article to call doEdit() and getId()
Aaron Schulz [Mon, 6 Feb 2012 05:26:36 +0000 (05:26 +0000)]
Added missing tests from r110731
Aaron Schulz [Mon, 6 Feb 2012 05:25:26 +0000 (05:25 +0000)]
In FileBackend:
* Added simple getReadOnly()/getReadOnlyReason() functions.
* Allow directly passing a LockManager object into __construct(), useful for testing.
* Fixed bug in FSFileBackend were creating empty files would result in a failing status.
* Added more file stat unit tests.
Alexandre Emsenhuber [Sun, 5 Feb 2012 20:29:53 +0000 (20:29 +0000)]
Fixed string -> __METHOD__ in calling method parameter
Raimond Spekking [Sun, 5 Feb 2012 20:20:23 +0000 (20:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sun, 5 Feb 2012 18:45:07 +0000 (18:45 +0000)]
* Use $this->getRevision() to get the latest revision instead of loading it each time from the database
* Moved wfGetDB( DB_MASTER ) a bit after so that it is only called when needed
Alexandre Emsenhuber [Sun, 5 Feb 2012 16:45:41 +0000 (16:45 +0000)]
* Use WikiPage instead of Article for ParserCache stuff
* Use ParserOptions::newFromUserAndLang() instead of 'new ParserOptions' to not rely on global variables
Alexandre Emsenhuber [Sun, 5 Feb 2012 15:26:41 +0000 (15:26 +0000)]
Fix call to deprecated to fix test since it was throwing errors
Krinkle [Sun, 5 Feb 2012 13:30:24 +0000 (13:30 +0000)]
[Actions] Update usage of wgDisabledActions to check wgActions instead
* Setup.php adds any values in the deprecated wgDisabledActions to wgActions in the new format. So checking wgDisabledActions is actually insufficient, not just deprecated.
* Poke r86041
Krinkle [Sun, 5 Feb 2012 12:29:49 +0000 (12:29 +0000)]
[tests] update QUnitTestResources.php to include jquery.delayedBind
Krinkle [Sun, 5 Feb 2012 12:27:20 +0000 (12:27 +0000)]
[tests] use core qunit-fixture properly
QUnit provides a <div id="qunit-fixture"> by default that is cleared out after each test.
* Switch tests to append to the provided #qunit-fixture instead of appending to the body.
* Remove redundant .remove() calls, which now happens automatically
* Fix jquery.textSelection.test to not cause dozens of elements to be appended to the body with duplicate IDs, which was causing WebFonts test suite to fail (since the DOM can't select multiple elements with the same DOM). (Fixes r92923, r100391)
Thomas Gries [Sun, 5 Feb 2012 11:00:07 +0000 (11:00 +0000)]
Please review carefully, I cannot see negative side effects from this patch. It gives extensions which use the (depreacted) UnknownAction hook a chance to see the original action= value. This fixes bug 34203 and bug 34161 UnknownAction hook problem: the hook must pass the unknown action to the callee and not the value "nosuchaction"
Aaron Schulz [Sun, 5 Feb 2012 03:52:40 +0000 (03:52 +0000)]
Removed some useless code and a confusing comment in FSLockManager::doLock(). This was from before referencing counting was used.
Raimond Spekking [Sat, 4 Feb 2012 22:42:59 +0000 (22:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sat, 4 Feb 2012 19:07:37 +0000 (19:07 +0000)]
Removed declaration of ProfilerSimpleTrace::$mMinimumTime; already defined in parent class
Alexandre Emsenhuber [Sat, 4 Feb 2012 14:51:01 +0000 (14:51 +0000)]
Added overrides of logData() and getCurrentSection() in ProfilerStub; just in case.
Aaron Schulz [Fri, 3 Feb 2012 23:37:30 +0000 (23:37 +0000)]
Reverted r106025 and friends (r106370, r106373, r108060, r108337, r106419). This can go in 1.20 if a Postgres person has time to look at it.
Raimond Spekking [Fri, 3 Feb 2012 23:30:18 +0000 (23:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Fri, 3 Feb 2012 21:42:31 +0000 (21:42 +0000)]
(bug 33846) Fixed backwards error msg/param passing.
Ryan Kaldari [Fri, 3 Feb 2012 21:34:59 +0000 (21:34 +0000)]
adding note about local modifications
Aaron Schulz [Fri, 3 Feb 2012 18:05:33 +0000 (18:05 +0000)]
Per r108369 CR comment, use StringUtils::escapeRegexReplacement() since backend name can have $1 or such. Also added comments to discourage such characters in backend names.
Aaron Schulz [Fri, 3 Feb 2012 17:30:54 +0000 (17:30 +0000)]
Cleaned up a few file backend related messages
Alexandre Emsenhuber [Fri, 3 Feb 2012 11:19:35 +0000 (11:19 +0000)]
Use local context to get message instead of relying on global variables
Alexandre Emsenhuber [Fri, 3 Feb 2012 09:54:40 +0000 (09:54 +0000)]
Moved wfDeprecated() and wfWarn() near other debug-related functions
Alexandre Emsenhuber [Fri, 3 Feb 2012 08:32:34 +0000 (08:32 +0000)]
wfTime() -> microtime( true ), no need to use the former which is just a wrapper to the latter
Aaron Schulz [Fri, 3 Feb 2012 06:16:37 +0000 (06:16 +0000)]
Reverted r96516, manually, per CR. Moved maybeDoTransform() code back into transform().
Robin Pepermans [Fri, 3 Feb 2012 02:18:49 +0000 (02:18 +0000)]
Add @noflip to arrow directions like "southwest", as that is the same location regardless of language directionality. The arrow was displayed at the wrong side. Also removing text-align:left; for the tooltip as the text direction should be set in html if needed, and shouldn't be overridden by (flipped) css.
Alexandre Emsenhuber [Thu, 2 Feb 2012 23:01:36 +0000 (23:01 +0000)]
Follow-up r110591: remove unused global declaration
Sam Reed [Thu, 2 Feb 2012 22:57:39 +0000 (22:57 +0000)]
Revert r110276
Make changes like this after 1.19 has been branched. kthx
Aaron Schulz [Thu, 2 Feb 2012 22:05:21 +0000 (22:05 +0000)]
Reverted r110608 - no known need for this
Aaron Schulz [Thu, 2 Feb 2012 21:46:30 +0000 (21:46 +0000)]
Release notes for r100315
Roan Kattouw [Thu, 2 Feb 2012 21:41:18 +0000 (21:41 +0000)]
Followup r110542: unbreak the QUnit tests; the change wasn't broken but the test runner was. Reflect the dependency change (mw.page.startup now depends on mw.util) by moving up mw.util . It's kind of annoying that the test suite doesn't use the dependency map from Resources.php
Raimond Spekking [Thu, 2 Feb 2012 20:47:04 +0000 (20:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Thu, 2 Feb 2012 20:46:01 +0000 (20:46 +0000)]
[Special:MovePage] fix Title method usage. Need potential subpages included as well.
* Follows-up r110209 CR
Sam Reed [Thu, 2 Feb 2012 20:19:20 +0000 (20:19 +0000)]
Improve documentation
Simplify if
Fix whitespace
Sam Reed [Thu, 2 Feb 2012 20:16:28 +0000 (20:16 +0000)]
Bring the epocs into this decade
Aaron Schulz [Thu, 2 Feb 2012 19:33:36 +0000 (19:33 +0000)]
Ported changes from r110601
Aaron Schulz [Thu, 2 Feb 2012 18:42:02 +0000 (18:42 +0000)]
Fixed windows-related test failures (that string format doesn't work with \r\n line endings as the \r chars are left in the PHP string).
Roan Kattouw [Thu, 2 Feb 2012 16:38:28 +0000 (16:38 +0000)]
Followup r108184: per CR, blocking loads in debug mode were broken because debug mode uses chained loading, and the second part of the chain would run after the blocking flag had been set back to false. So get rid of the blocking flag as a global state flag, and instead pass it around all over the place so nestedAddScript() can use it.
Alexandre Emsenhuber [Thu, 2 Feb 2012 16:35:02 +0000 (16:35 +0000)]
* Always add the hostname in wfDebugLog(), whatever $wgShowHostnames is, since that setting is for user display, not internal stuff
* Use wfHostname() and wfWikiId() instead of executing "hostname" command and $wgDBname respectively for consistency
Roan Kattouw [Thu, 2 Feb 2012 16:31:42 +0000 (16:31 +0000)]
Fix bug in CSSJanus where background-position and background-position-x weren't flipped if negative values were given. Trevor found this by running the original CSSJanus test suite against his NodeJS port; I should port the test suite to PHPUnit some time
Sam Reed [Thu, 2 Feb 2012 15:12:28 +0000 (15:12 +0000)]
Strict Standards: Declaration of DatabaseOracle::sourceStream() should be compatible with that of DatabaseBase::sourceStream()
Followup r108768, and also use $inputCallback
Amir E. Aharoni [Thu, 2 Feb 2012 14:42:48 +0000 (14:42 +0000)]
== comparison for all languages, instead of ===, according to Niklas' suggestion. Follow up to r110485, r110492, r110461.
Niklas Laxström [Thu, 2 Feb 2012 11:14:26 +0000 (11:14 +0000)]
Whitespace cleanup
Alexandre Emsenhuber [Thu, 2 Feb 2012 10:33:42 +0000 (10:33 +0000)]
Use $wgRequestTime in wfDebugTimer() to get the time since the start of the request instead the difference with the first call so that the time before that call is not ignored and for consistency with other time displays.
Roan Kattouw [Thu, 2 Feb 2012 10:30:57 +0000 (10:30 +0000)]
(bug 34114) CSSMin::remap() doesn't respect its $embed parameter. Patch by Gilles van den Hoven
Alexandre Emsenhuber [Thu, 2 Feb 2012 09:55:04 +0000 (09:55 +0000)]
Use WikiPage instead of Title to get its id, whether it exists and its latest revision's id
Krinkle [Thu, 2 Feb 2012 00:47:53 +0000 (00:47 +0000)]
Enqueue mw.util.init in document-ready even handler earlier
* Previously $(document).ready(mw.util.init) was in module 'mediawiki.page.ready' (position: bottom). I've now moved this to 'mediawiki.page.startup' so that it'll be enqueued sooner.
* This making it more likely that if someone also enqueues in document-ready that mw.util.init ran before than and thus mw.util.$content populated
* Fixes bug 33711
* All this is still depends on the order in which the event handler queue is executed, which is risky. Bug 30713 will bring the solid "watertight" solution
Aaron Schulz [Wed, 1 Feb 2012 23:47:08 +0000 (23:47 +0000)]
r110253: reworded "expensive" cache fields and function per CR
Antoine Musso [Wed, 1 Feb 2012 21:40:49 +0000 (21:40 +0000)]
doxygen landing page
Raimond Spekking [Wed, 1 Feb 2012 20:58:11 +0000 (20:58 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Antoine Musso [Wed, 1 Feb 2012 20:53:38 +0000 (20:53 +0000)]
Fix doxygen docs before REL1_19 branching
Antoine Musso [Wed, 1 Feb 2012 17:05:15 +0000 (17:05 +0000)]
fix @example in ResourceLoaderFileModule
Doxygen @example is meant to include another file content. To render
an example you need to use a named paragraph and then a block of code.
Amir E. Aharoni [Wed, 1 Feb 2012 15:59:26 +0000 (15:59 +0000)]
Added tests for plural, same as Russian.
Amir E. Aharoni [Wed, 1 Feb 2012 15:53:59 +0000 (15:53 +0000)]
Fixes r110484.
Alexandre Emsenhuber [Wed, 1 Feb 2012 15:53:57 +0000 (15:53 +0000)]
* Use WikiPage instead of Article
* Use a local User object passed to WikiPage::doEdit() instead of overriding $wgUser
Alexandre Emsenhuber [Wed, 1 Feb 2012 15:48:12 +0000 (15:48 +0000)]
Recommit r109062 (Only run some MWDebug code when really needed) but leaving the addition of ResourceLoader module inside the MWDebug class this time
Max Semenik [Wed, 1 Feb 2012 15:44:32 +0000 (15:44 +0000)]
HTML 2???
Amir E. Aharoni [Wed, 1 Feb 2012 15:37:40 +0000 (15:37 +0000)]
Fixed plural rules for Romanian / Moldovan according to CLDR. Added tests for Romanian and fixed tests for Moldovan.
Amir E. Aharoni [Wed, 1 Feb 2012 15:36:00 +0000 (15:36 +0000)]
Integer comparison in Hebrew plural forms.
Aaron Schulz [Wed, 1 Feb 2012 04:58:19 +0000 (04:58 +0000)]
Quick fix to getContainerHashLevels() comparison from r110435.
Amir E. Aharoni [Wed, 1 Feb 2012 04:53:55 +0000 (04:53 +0000)]
Adding plural tests for more languages.
Aaron Schulz [Wed, 1 Feb 2012 04:44:08 +0000 (04:44 +0000)]
Deferred File::getLocalRef() in BitmapHandler and altered MediaTransformOutput to compensate. They were getting called on every getTransform() call, which are triggered by just looking at pages with files (like Special:ListFiles). This made page loads very slow for non-FS backends.
Tim Starling [Wed, 1 Feb 2012 03:39:38 +0000 (03:39 +0000)]
* Documentation fix
* Binary mode on php://output, for consistency.
Aaron Schulz [Tue, 31 Jan 2012 22:03:36 +0000 (22:03 +0000)]
Added PurgeDeletedFiles script to purge recently deleted files. To be used before initial Swift thumbnail deploy.
Aaron Schulz [Tue, 31 Jan 2012 21:52:58 +0000 (21:52 +0000)]
Expanded 'shardViaHashLevels' config var in FileBackendStore to be able to recognize FileRepo-style deleted zone hash paths (which are different than for the other zones).
Raimond Spekking [Tue, 31 Jan 2012 20:31:52 +0000 (20:31 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Tue, 31 Jan 2012 15:56:17 +0000 (15:56 +0000)]
Followup r110001
Add BadTitleError to AutoLoader.php
Amir E. Aharoni [Tue, 31 Jan 2012 14:47:12 +0000 (14:47 +0000)]
"isset( $forms[2] )" is not needed - plural is filled in preConvertPlural if dual is not provided.
Amir E. Aharoni [Tue, 31 Jan 2012 14:42:38 +0000 (14:42 +0000)]
Testing the case when dual is not provided.
Amir E. Aharoni [Tue, 31 Jan 2012 13:49:36 +0000 (13:49 +0000)]
Adding tests for plural in Hebrew.
Alexandre Emsenhuber [Tue, 31 Jan 2012 10:26:22 +0000 (10:26 +0000)]
Added 'page_id' to the fields returned by Revision::selectPageFields() so that the Title object created in Revision::__construct() already knows its id and it doesn't have to issue another DB query to load it (happens e.g. in api.php?action=parse&oldid=... calls)
Alexandre Emsenhuber [Tue, 31 Jan 2012 10:22:17 +0000 (10:22 +0000)]
Added missing __METHOD__ parameter to DatabaseBase::selectField() calls in ExternalStoreDB
Mark A. Hershberger [Tue, 31 Jan 2012 01:02:01 +0000 (01:02 +0000)]
revert r110340 after talking with krinle
Aaron Schulz [Mon, 30 Jan 2012 23:44:34 +0000 (23:44 +0000)]
(bug 33992) - "Allow anon a formless purge with POST". Changed HTMLForm::tryAuthorizedSubmit() to (a) require post for forms that are supposed to be posted and (b) bypass the token check for anons as it doesn't really do much except be slightly annoying. The tokens are just User::EDIT_TOKEN_SUFFIX in that case.
Mark A. Hershberger [Mon, 30 Jan 2012 23:07:08 +0000 (23:07 +0000)]
Fixes bug 34036 - [regression] mw.loader.load doesn't works as importScriptURI for some kinds of URLs
Patch from Helder.wiki
Alexandre Emsenhuber [Mon, 30 Jan 2012 21:09:48 +0000 (21:09 +0000)]
Use local context to get messages instead of relying on global variables
Alexandre Emsenhuber [Mon, 30 Jan 2012 20:23:01 +0000 (20:23 +0000)]
Use Language::userTimeAndDate() instead of Language::timeanddate() to display timestamp with user preferences
Krinkle [Mon, 30 Jan 2012 19:45:38 +0000 (19:45 +0000)]
[Xml::encodeJsVar] Use FormatJson::encode / native json_encode instead
* Follows-up r110320
* XmlTest.php passes
Krinkle [Mon, 30 Jan 2012 19:40:20 +0000 (19:40 +0000)]
[Xml::encodeJsVar] Change to match FormatJson::encode output
- Pure whitespace change
- In preparation to deprecate it in favor of FormatJson / json_encode
Krinkle [Mon, 30 Jan 2012 19:34:43 +0000 (19:34 +0000)]
[jquery.qunit.completenessTest.js] typo
Krinkle [Mon, 30 Jan 2012 18:35:38 +0000 (18:35 +0000)]
[shared.css] Fix preferences CSS bug
* Apply r109054 fix from branches/RL2 to trunk
-- width: 0; doesn't work and still leaves the column open to free interpretation by the browsers. causing inconsistent widths for the "no label" columns when there are multiple of those tables on one page.
* Also dropping unneeded "!important".
Antoine Musso [Mon, 30 Jan 2012 17:36:43 +0000 (17:36 +0000)]
rv r87948 "fix backtrace on SQL error"
Looks unneeded nowaday. Backtrace is correctly appended to HTML output
or CLI output when $wgShowDBErrorBacktrace is true.
Not sure what it was supposed to fix.