Merge "installer: Do not wrongly hide namespace input field"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 23 May 2018 05:26:05 +0000 (05:26 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 23 May 2018 05:26:05 +0000 (05:26 +0000)
includes/installer/WebInstallerName.php
mw-config/config.js

index 81a107d..50c88ae 100644 (file)
@@ -76,7 +76,7 @@ class WebInstallerName extends WebInstallerPage {
                        $this->parent->getTextBox( [
                                'var' => 'wgMetaNamespace',
                                'label' => '', // @todo Needs a label?
-                               'attribs' => [ 'readonly' => 'readonly', 'class' => 'enabledByOther' ]
+                               'attribs' => [ 'class' => 'enabledByOther' ]
                        ] ) .
                        $this->getFieldsetStart( 'config-admin-box' ) .
                        $this->parent->getTextBox( [
index bb62067..99290f4 100644 (file)
@@ -73,7 +73,9 @@
 
                // Hide "other" textboxes by default
                // Should not be done in CSS for javascript disabled compatibility
-               $( '.enabledByOther' ).closest( '.config-block' ).hide();
+               if ( !$( '#config__NamespaceType_other' ).is( ':checked' ) ) {
+                       $( '.enabledByOther' ).closest( '.config-block' ).hide();
+               }
 
                // Enable/disable "other" textboxes
                $( '.enableForOther' ).click( function () {