From ddee066b412c6606b90617b0dc465cb419efcd29 Mon Sep 17 00:00:00 2001 From: Alex Monk Date: Wed, 13 Mar 2013 15:43:27 +0000 Subject: [PATCH] Fix Ifb93e49b This commit caused a PHP notice if you tried to use diff=prev with an oldid which was the first revision of the page. Change-Id: I4c4ccb9a0c8d82e104723a2e72f1c699e2fc249b --- includes/diff/DifferenceEngine.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index 421bee9767..0f3c77ffbf 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -267,6 +267,8 @@ class DifferenceEngine extends ContextSource { $deleted = $suppressed = false; $allowed = $this->mNewRev->userCan( Revision::DELETED_TEXT, $user ); + $revisionTools = array(); + # mOldRev is false if the difference engine is called with a "vague" query for # a diff between a version V and its previous version V' AND the version V # is the first version of that article. In that case, V' does not exist. @@ -292,7 +294,6 @@ class DifferenceEngine extends ContextSource { $samePage = false; } - $revisionTools = array(); if ( $samePage && $this->mNewPage->quickUserCan( 'edit', $user ) ) { if ( $this->mNewRev->isCurrent() && $this->mNewPage->userCan( 'rollback', $user ) ) { $rollbackLink = Linker::generateRollback( $this->mNewRev, $this->getContext() ); -- 2.20.1