From 0a4f6dd7ac5a7fd2ab891254723d6b2ad14d3f72 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Mon, 14 Nov 2011 09:23:58 +0000 Subject: [PATCH] Revert r102949. Broke tests (undefined variable $_SESSION because session_start() hadn't been called) and is unnecessary because we have DerivativeRequest now --- includes/WebRequest.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/includes/WebRequest.php b/includes/WebRequest.php index 570a53d3fe..d0430b926a 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -1179,7 +1179,7 @@ class FauxRequest extends WebRequest { * @param $data Array of *non*-urlencoded key => value pairs, the * fake GET/POST values * @param $wasPosted Bool: whether to treat the data as POST - * @param $session Mixed: session array or null. If null, $_SESSION will be used + * @param $session Mixed: session array or null */ public function __construct( $data, $wasPosted = false, $session = null ) { if( is_array( $data ) ) { @@ -1188,11 +1188,8 @@ class FauxRequest extends WebRequest { throw new MWException( "FauxRequest() got bogus data" ); } $this->wasPosted = $wasPosted; - if( $session ) { + if( $session ) $this->session = $session; - } else { - $this->session = $_SESSION; - } } /** -- 2.20.1