From: Kartik Mistry <kartik.mistry@gmail.com>
Date: Tue, 1 Apr 2014 12:17:22 +0000 (+0530)
Subject: shell script fix using shellcheck lint
X-Git-Tag: 1.31.0-rc.0~15358^2
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/cotisations/rappels.php?a=commitdiff_plain;h=e10082c62b73a2d2d11b152066fff53d5fa22360;p=lhc%2Fweb%2Fwiklou.git

shell script fix using shellcheck lint

* shellcheck script used: https://github.com/koalaman/shellcheck
* includes/php.sh: Use $(..) instead of deprecated `..`.

Change-Id: Ie1dfff97b548aca75d76c762b74f8fcab84d46fb
---

diff --git a/maintenance/dev/includes/php.sh b/maintenance/dev/includes/php.sh
index 7ce8794482..3c5bef0dd6 100644
--- a/maintenance/dev/includes/php.sh
+++ b/maintenance/dev/includes/php.sh
@@ -4,7 +4,7 @@
 # and previous home directory location
 # The binary path is returned in $PHP if any
 
-for binary in $PHP `which php || true` "$DEV/php/bin/php" "$HOME/.mediawiki/php/bin/php" "$HOME/.mwphp/bin/php" ]; do
+for binary in $PHP $(which php || true) "$DEV/php/bin/php" "$HOME/.mediawiki/php/bin/php" "$HOME/.mwphp/bin/php" ]; do
 	if [ -x "$binary" ]; then
 		if "$binary" -r 'exit((int)!version_compare(PHP_VERSION, "5.4", ">="));'; then
 			PHP="$binary"