From 9a66cb86419ba4aef267bb62015d989078303c8c Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Thu, 16 Feb 2017 16:24:06 -0800 Subject: [PATCH] RCFilters UI: Cancel 'editItem' on CapsuleMultiselectWidget This method assumes you want to edit the item manually, and so it calls this.$input.val() on a nonexisting input (because there is no input if a popup exists.) Bug: T158368 Change-Id: I7bbce89e5280f97d3e85619d9a8fe23fa5e5e47c --- .../ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js index 9bb1a98d79..7f8d79da92 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js @@ -247,4 +247,9 @@ } ); }; + /** + * Override 'editItem' since it tries to use $input which does + * not exist when a popup is available. + */ + mw.rcfilters.ui.FilterCapsuleMultiselectWidget.prototype.editItem = function () {}; }( mediaWiki, jQuery ) ); -- 2.20.1