Aaron Schulz [Tue, 5 Feb 2019 05:35:42 +0000 (21:35 -0800)]
objectcache: avoid occasional test flakiness due to microtime()
* Fix the timestamps to static hard-coded values
* Force the timestamps before various get/set tests so they do not
use the microtime() value either.
* Remove the direct and duplicated (causing further risk) microtime()
calls from testGetWithSeveralCheckKeys().
Bug: T207247
Change-Id: Id30a8127f11501dbe54e075b6e9d18490353f4a5
jenkins-bot [Mon, 4 Feb 2019 10:08:04 +0000 (10:08 +0000)]
Merge "watcheditem: Replace error message strings with constant string"
jenkins-bot [Mon, 4 Feb 2019 07:03:56 +0000 (07:03 +0000)]
Merge "Equialization of Serbian Latin translations with Serbian Cyrillic translations"
jenkins-bot [Sun, 3 Feb 2019 22:04:26 +0000 (22:04 +0000)]
Merge "objectcache: avoid duplicate set() calls with lockTSE when no value is in cache"
Translation updater bot [Sun, 3 Feb 2019 20:56:18 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic00ccbd3487d1861d3196670792ec529d1f81f73
jenkins-bot [Sun, 3 Feb 2019 20:28:49 +0000 (20:28 +0000)]
Merge "Add @coversNothing for left over tests and enable sniff"
jenkins-bot [Sun, 3 Feb 2019 20:28:43 +0000 (20:28 +0000)]
Merge "Add some missing @covers tags"
jenkins-bot [Sun, 3 Feb 2019 17:55:10 +0000 (17:55 +0000)]
Merge "Title: Add null to @return type for getSubpage"
Fomafix [Sun, 3 Feb 2019 17:08:40 +0000 (18:08 +0100)]
Title: Add null to @return type for getSubpage
Title::makeTitleSafe can return null on an invalid title. Therefor
Title::getSubpage can also return null on an error.
Change-Id: I8f7d5125bd8bd609b6120b0f7682c6e519063476
Fomafix [Wed, 30 Jan 2019 20:24:06 +0000 (21:24 +0100)]
Fix @param tags
* Use 'callable' instead of 'callback'.
* Remove '$' as part of a type name.
* Add missing type.
Change-Id: Ic1b39a7d8cbbee000d8fb2f3a1f71a621bd01993
Kunal Mehta [Sun, 3 Feb 2019 05:42:31 +0000 (21:42 -0800)]
Finish FormatJson::encode() test coverage
Change-Id: I3aced17da653216de2092e1d7986748c271c5b82
Umherirrender [Fri, 1 Feb 2019 19:46:59 +0000 (20:46 +0100)]
Add @coversNothing for left over tests and enable sniff
LessFileCompilationTest is checking less files for valid syntax
doc test is checking xml file for valid syntax
MediaWikiTest is testing a complex situation with many functions involved
SideBarTest is self checking, needs no coverage
structure tests not covers functions, there are covers global structures
Change-Id: I3ac65db561cae0be8418aa9c830e7a9f46ad11fe
Kunal Mehta [Wed, 30 Jan 2019 08:23:48 +0000 (00:23 -0800)]
Add some missing @covers tags
Change-Id: Idb9af9515702ee9748755d7799663713b2283647
Aaron Schulz [Sun, 3 Feb 2019 02:13:17 +0000 (18:13 -0800)]
objectcache: avoid duplicate set() calls with lockTSE when no value is in cache
Each thread will still run the callback, but only one will save the value back
Bug: T203786
Change-Id: Idc4738aa005cc44ec0f1adc6dcf2e3f87d0c9480
jenkins-bot [Sat, 2 Feb 2019 23:44:56 +0000 (23:44 +0000)]
Merge "Add missing @covers to media related tests"
jenkins-bot [Sat, 2 Feb 2019 23:39:36 +0000 (23:39 +0000)]
Merge "Add missing @covers to revision related tests"
jenkins-bot [Sat, 2 Feb 2019 23:39:32 +0000 (23:39 +0000)]
Merge "Add missing @covers to search related tests"
jenkins-bot [Sat, 2 Feb 2019 23:25:48 +0000 (23:25 +0000)]
Merge "Add missing @covers to action related tests"
jenkins-bot [Sat, 2 Feb 2019 23:25:42 +0000 (23:25 +0000)]
Merge "Add missing @covers to user related tests"
jenkins-bot [Sat, 2 Feb 2019 23:20:26 +0000 (23:20 +0000)]
Merge "Add missing @covers to backend related tests"
jenkins-bot [Sat, 2 Feb 2019 23:20:21 +0000 (23:20 +0000)]
Merge "Add missing @covers to parser related tests"
jenkins-bot [Sat, 2 Feb 2019 23:15:49 +0000 (23:15 +0000)]
Merge "Add missing @covers to database related tests"
jenkins-bot [Sat, 2 Feb 2019 21:44:50 +0000 (21:44 +0000)]
Merge "build: Update eslint-config-wikimedia to 0.10.1"
Thalia [Sat, 2 Feb 2019 04:47:58 +0000 (20:47 -0800)]
Prevent special block test failures with certain configs
The checkbox for preventing a user from editing their own talk
page is only present for partial blocks if wgBlockAllowsUTEdit
is true, so set it to true for any tests that check for its
presence.
Change-Id: I0228f5787ad17130cbe015641c1142a7e52cef38
Ed Sanders [Sat, 2 Feb 2019 19:05:04 +0000 (11:05 -0800)]
build: Update eslint-config-wikimedia to 0.10.1
Change-Id: Id98af16c1ec1c6c4a790948a35e96e2fe925ebb5
Zoranzoki21 [Sat, 2 Feb 2019 15:35:29 +0000 (16:35 +0100)]
Equialization of Serbian Latin translations with Serbian Cyrillic translations
This was done already before at I3c79ded77f16beee404ca3005ae7678838ab9d60
Change-Id: I09e704d3051a6177f5f41eff8c8085e85ef4e02a
jenkins-bot [Sat, 2 Feb 2019 04:14:07 +0000 (04:14 +0000)]
Merge "Preload styles for 'jquery.tablesorter'"
jenkins-bot [Fri, 1 Feb 2019 21:40:14 +0000 (21:40 +0000)]
Merge "Soft deprecate QuickTemplate::msgWiki()"
jenkins-bot [Fri, 1 Feb 2019 21:38:42 +0000 (21:38 +0000)]
Merge "Move interface ILocalizedException to own file"
jenkins-bot [Fri, 1 Feb 2019 21:35:43 +0000 (21:35 +0000)]
Merge "Check for intl extension in updateCredits.php"
Umherirrender [Fri, 1 Feb 2019 20:57:58 +0000 (21:57 +0100)]
Add missing @covers to search related tests
Change-Id: Iba122ad763a5728a7ddb487b3d01d679de6845e5
Thiemo Kreuz [Mon, 14 Jan 2019 13:43:29 +0000 (14:43 +0100)]
Soft deprecate QuickTemplate::msgWiki()
This method just should not exist. It does have a bad name that does not
say much about what it does and how it is supposed to be used. And it
does horrible things: it accesses the global $wgOut, which currently
results in test failures, see
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/15200/console
Note how it was marked as @private, which is honorable, but doesn't
work for multiple reasons. First, an overload exists in the BaseTemplate
subclass. Second, calls from external code exist. Third, if it would be
really private, it could as well be deleted, because there is no private
caller.
Luckily the number of callers is extremely close to zero, see
https://codesearch.wmflabs.org/search/?q=>msgWiki%5C(
A patch for the Collection extension already exists.
Change-Id: I8d2c14f10fbf314735d1aa82bdc8edfb4fa9a0dd
Umherirrender [Fri, 1 Feb 2019 19:44:21 +0000 (20:44 +0100)]
Add missing @covers to user related tests
Change-Id: Icebd692a37108e3c637648213896ededa588cecd
Umherirrender [Fri, 1 Feb 2019 20:34:31 +0000 (21:34 +0100)]
Add missing @covers to media related tests
Change-Id: Ideb4fcf4e0c55c3720557b3d93eec06f671b3fd9
Umherirrender [Fri, 1 Feb 2019 20:48:33 +0000 (21:48 +0100)]
Add missing @covers to parser related tests
Change-Id: I615ba41c9a6f235f65991549cb27003438115fe9
Umherirrender [Fri, 1 Feb 2019 19:53:33 +0000 (20:53 +0100)]
Add missing @covers to revision related tests
Change-Id: Id95369208e988c16d626ca6f986898e3e84e8565
Umherirrender [Fri, 1 Feb 2019 21:13:32 +0000 (22:13 +0100)]
Add missing @covers to action related tests
Change-Id: I7653b5fa6f6a3c247f735ac22fda12e7c9549786
Umherirrender [Fri, 1 Feb 2019 21:08:32 +0000 (22:08 +0100)]
Add missing @covers to backend related tests
Change-Id: I6ecbedf7d4f6c48b4f17331c31588f2c8b772054
Umherirrender [Fri, 1 Feb 2019 19:59:16 +0000 (20:59 +0100)]
Add missing @covers to database related tests
Change-Id: I370275bb6c5d456b73f6a5f782e231f16c2b0fbe
jenkins-bot [Fri, 1 Feb 2019 19:08:36 +0000 (19:08 +0000)]
Merge "Remove require_once from maintenance tests"
Umherirrender [Fri, 1 Feb 2019 19:05:30 +0000 (20:05 +0100)]
Move interface ILocalizedException to own file
Change-Id: I66429a89633a74a22999775214aa23ae189b837e
Umherirrender [Fri, 1 Feb 2019 18:57:56 +0000 (19:57 +0100)]
Check for intl extension in updateCredits.php
Change-Id: Ifa2892b2f38fa73362c3ac60e1d90614cdbc0a93
Umherirrender [Fri, 1 Feb 2019 18:45:12 +0000 (19:45 +0100)]
Remove require_once from maintenance tests
class FetchText and TextPassDumper part of autoloader
Change-Id: I307a9ac002d09e8fe05385e57d525055f5cb0b8a
Umherirrender [Fri, 1 Feb 2019 18:40:22 +0000 (19:40 +0100)]
Rename CategoryChangesRdfTest to match maintenance script
Change-Id: Ib0ab880653f90df608d89a5f85c9949b380abe33
Derick Alangi [Fri, 1 Feb 2019 15:55:29 +0000 (16:55 +0100)]
watcheditem: Replace error message strings with constant string
As the messages are the same and in addition using the same class
DBReadOnlyError, make the error message a constant and pass it as
self::DB_READONLY_ERROR argument to this class. Changing the error
will apply to the class as intended rather than change it in each
single place that this string appears.
Change-Id: I7f978cc334020746b4c4405fa2a0a73219bdacac
jenkins-bot [Thu, 31 Jan 2019 22:43:20 +0000 (22:43 +0000)]
Merge "Remove Revision::fetchRevision()"
Thiemo Kreuz [Wed, 2 Jan 2019 09:30:34 +0000 (10:30 +0100)]
Update type hints and documentation of RevisionDeleteUser
Technically unrelated, but motivated by Ib59cf77.
Change-Id: I54cb9c396552d6982f5ca8463e00a0769e60a291
Translation updater bot [Thu, 31 Jan 2019 20:53:43 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie2c639a0adbb91dc68109e58b6d74263e8ae0f0c
Thiemo Kreuz [Thu, 31 Jan 2019 11:26:13 +0000 (12:26 +0100)]
languages: Fix some soft type hints in the Language class
Change-Id: Ic9ffbc79c6932db97175d0a1da75df45ba3455e0
jenkins-bot [Thu, 31 Jan 2019 14:50:49 +0000 (14:50 +0000)]
Merge "Correct whitespace and parentheses typos in BlockLogFormatter"
jenkins-bot [Thu, 31 Jan 2019 11:59:42 +0000 (11:59 +0000)]
Merge "Fix documentation for RevisionRecord::$mPageId"
Thalia [Thu, 31 Jan 2019 06:17:18 +0000 (22:17 -0800)]
Correct whitespace and parentheses typos in BlockLogFormatter
Change-Id: I9e79e9d274e8ed1fa94966f5e1ac01f8fcd6d96b
jenkins-bot [Thu, 31 Jan 2019 01:38:43 +0000 (01:38 +0000)]
Merge "Avoid making master connection from Skin::getUndeleteLink"
jenkins-bot [Thu, 31 Jan 2019 01:32:51 +0000 (01:32 +0000)]
Merge "build: Don't install symfony/polyfill-* that we require"
jenkins-bot [Thu, 31 Jan 2019 00:01:57 +0000 (00:01 +0000)]
Merge "docs: Remove 'code-coverage' placeholder directory"
jenkins-bot [Thu, 31 Jan 2019 00:00:50 +0000 (00:00 +0000)]
Merge "Remove deprecated wgEnableParserCache"
Max Semenik [Wed, 30 Jan 2019 23:08:56 +0000 (15:08 -0800)]
Remove Revision::fetchRevision()
Deprecated in 1.28, hard deprecated since 1.31. No callers, never had
callers outside of core.
Change-Id: I39721d12ad0d221931d23f2807f0a87cf05f0e3a
jenkins-bot [Wed, 30 Jan 2019 23:39:34 +0000 (23:39 +0000)]
Merge "RemexCompatMunger: Don't split p-wrapping on style/link tags"
jenkins-bot [Wed, 30 Jan 2019 23:04:08 +0000 (23:04 +0000)]
Merge "Password: replace equals() with verify()"
Thalia [Wed, 30 Jan 2019 22:32:52 +0000 (14:32 -0800)]
Avoid making master connection from Skin::getUndeleteLink
Do this by calling Title:quickUserCan instead of Title::userCan
from Skin::getUndeleteLink.
Bug: T214735
Change-Id: I24dfd86275638e52012a5647ab3e5c848af840c2
jenkins-bot [Wed, 30 Jan 2019 20:54:55 +0000 (20:54 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 30 Jan 2019 20:53:36 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If0c6e253be60e3b6b0b36f1281936b4719cb1eeb
Thiemo Kreuz [Wed, 9 Jan 2019 16:15:21 +0000 (17:15 +0100)]
Remove a few obscure "done" and "empty" comments
These don't add any knowledge to what is already obvious from the
code, I find.
Change-Id: Ia613b6a059f78dbeefdfd020899bd1a6e239a731
Brad Jorsch [Sun, 27 Jan 2019 22:13:10 +0000 (14:13 -0800)]
RemexCompatMunger: Don't split p-wrapping on style/link tags
<style> and <link> tags are metadata tags, they shouldn't split the <p>
tag when p-wrapping content.
Bug: T208901
Change-Id: I2ef5da68c9ccde4477d8295dfe4abf8497c5d26e
Kunal Mehta [Wed, 30 Jan 2019 05:49:15 +0000 (21:49 -0800)]
Remove some exemptions that are no longer needed
Manually identified, it's possible that there are more.
Change-Id: Ifda5ecdb12915f4005161f1f98eae5f1162fbee1
Kunal Mehta [Wed, 30 Jan 2019 05:47:05 +0000 (21:47 -0800)]
Require ClassMatchesFilename sniff to pass for most of tests/
phpunit-patch-coverage assumes that the filename matches the classname
as a performance optimization. And for most test cases, this is true. We
should enforce this with PHPCS, mostly to help developers not make
mistakes.
Test cases that have mock classes will need to ensure that the test case
class that matches the filename comes first, since that's the only class
the sniff will look at.
Tests in GlobalFunctions/ and maintenance/ are still exempted for now,
since they don't match yet.
Change-Id: Iede341504290f5ba2da1c81908069ba9d465600f
Kunal Mehta [Wed, 30 Jan 2019 07:56:46 +0000 (23:56 -0800)]
Rename FirejailCommandIntegrationTest to match class name
Change-Id: I581c0d95c38e6d22ab19d68e58e2f48c98b2379b
Kunal Mehta [Wed, 30 Jan 2019 05:35:52 +0000 (21:35 -0800)]
Rename UncategorizedCategoriesPageTest to match class name
Change-Id: Iedf32a15e0a8cb79a2823ccffa3b486a38fb1dc6
Kunal Mehta [Wed, 30 Jan 2019 05:35:11 +0000 (21:35 -0800)]
Rename tests/phpunit/includes/media files to match class names
The classes were renamed in
9bf39163, this updates the test cases to
match. Also take care of XCF while we're at it too.
Change-Id: Iaaeee93e496af6cdd610df5bc75302ecfe273f64
Kunal Mehta [Wed, 30 Jan 2019 05:33:42 +0000 (21:33 -0800)]
Use TestingAccessWrapper in FormOptionsInitializationTest
Avoids the need for an extra wrapper class just to make a property
public.
Change-Id: I08ae2fb24604a2bde352525abdcadf6251045f5b
Brian Wolff [Sat, 7 Jul 2018 15:36:10 +0000 (15:36 +0000)]
installer: Suggest using 127.0.0.1 in the db not found error message
Its a really common error people have where they specify
localhost, not realizing that mysql does socket magic for that
value, and they need to specify 127.0.0.1 instead.
Also remove windows specific language in the help text.
Although more of an issue on windows, it is not unheard of
to happen on linux if the mysql socket is not configured.
Change-Id: Ie8199ab50d37dc2bc43dfafe2e5ef7812e9d832c
Translation updater bot [Mon, 28 Jan 2019 21:03:28 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I55f7b5a4c28e9756e5432573a67a179aed70fa4c
David Barratt [Fri, 23 Nov 2018 05:08:27 +0000 (00:08 -0500)]
Add Namespace Restrictions to Special:BlockList
The editing restrictions will be split by type and add a heading for each type.
The namespace will be linked to Special:AllPages with the namespace set so the
user can see what pages the user is blocked from.
Bug: T204990
Change-Id: Idb1de20c1a780562b072ea350e5ba7dd1518d177
jenkins-bot [Mon, 28 Jan 2019 16:39:17 +0000 (16:39 +0000)]
Merge "Fix typo in tests/phpunit/includes/Revision/MainSlotRoleHandlerTest.php"
zoranzoki21 [Sat, 26 Jan 2019 19:41:31 +0000 (20:41 +0100)]
Fix typo in tests/phpunit/includes/Revision/MainSlotRoleHandlerTest.php
Bug: T201491
Depends-On: I47530e01d8061d6826deaf0b9111d77a0b269d0a
Change-Id: Iaf1abd06cd35444cf4c6c4edef65f973089579c1
Translation updater bot [Sat, 26 Jan 2019 20:54:16 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia1d66a4d2b2aa5fb06b85b15c89cdc941dea363d
Fomafix [Sat, 26 Jan 2019 10:45:39 +0000 (11:45 +0100)]
Add missing dependency on 'mediawiki.storage'
mediawiki.special.preferences.ooui/tabs.js uses mw.storage from module
'mediawiki.storage'.
Change-Id: Ia0d02a9445449645ce1054b4eb9c935f51e374c0
Timo Tijhof [Sat, 26 Jan 2019 05:05:21 +0000 (21:05 -0800)]
Remove deprecated wgEnableParserCache
One less thing to do in Setup.php.
Bug: T189966
Change-Id: Ie9b631897fda51f6db9fc4d634bcbd6bf865dfc9
Timo Tijhof [Sat, 26 Jan 2019 02:33:15 +0000 (18:33 -0800)]
docs: Remove 'code-coverage' placeholder directory
In 8 years, this is the first time I see this directory exists
and that there is a Makefile that would write to it.
I don't know if anyone uses that, but PHPUnit auto-creates this
directory as needed. Hence, it need not exist ahead of time.
It seems most contributors generate code coverage by invoking
PHPUnit directory, which requires a path to be specified.
Per https://mediawiki.org/wiki/Manual:PHP_unit_testing/Code_coverage,
this tends to be docs/coverage, not docs/code-coverage.
Change the Makefile to write there as well, as better example,
and also add it to gitignore.
Change-Id: I0a4cf716ea9b7fae89c282945b160b0dc7b2d02f
jenkins-bot [Fri, 25 Jan 2019 21:33:16 +0000 (21:33 +0000)]
Merge "Add namespace restrictions to block's log messages"
Translation updater bot [Fri, 25 Jan 2019 21:08:04 +0000 (22:08 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I371f47ad51f9cce54686e9e7dad8e186274c8962
Dayllan Maza [Fri, 25 Jan 2019 04:45:11 +0000 (23:45 -0500)]
Add namespace restrictions to block's log messages
Currently, there are 3 block messages: sitewide, partial with restrictions, and
non-editing partial blocks. This will add namespace restrictions to the
partial editing blocks message type.
Bug: T204985
Change-Id: Ic17d5459e67c267fdee1fb2513d67428148ac85d
jenkins-bot [Fri, 25 Jan 2019 19:07:33 +0000 (19:07 +0000)]
Merge "wdio-mediawiki: Release 0.3.0"
addshore [Wed, 16 Jan 2019 09:06:54 +0000 (09:06 +0000)]
wdio-mediawiki: Release 0.3.0
Bug: T211038
Change-Id: I5036034be75a39d21234987e78edb927d6a9e7a4
jenkins-bot [Fri, 25 Jan 2019 09:58:45 +0000 (09:58 +0000)]
Merge "Add block and unblock commands to WDIO"
jenkins-bot [Fri, 25 Jan 2019 02:22:32 +0000 (02:22 +0000)]
Merge "Don't check anon permissions for maint scripts in autoCreateUser()"
James Montalvo [Wed, 23 Jan 2019 20:14:37 +0000 (14:14 -0600)]
Don't check anon permissions for maint scripts in autoCreateUser()
AuthManager::autoCreateUser() causes createAndPromote.php to give error
"Automatic account creation is not allowed." when
$wgGroupPermissions['*']['createaccount']=false is set. Anonymous user
checks should be skipped for maintenance scripts.
Change-Id: Ib61889a758e542abe991707d8b7853a25cfed8e9
Bill Pirkle [Wed, 2 Jan 2019 22:16:44 +0000 (16:16 -0600)]
http: Support callback functions in GuzzleHttpRequest
Provide backward compatibility for callback functions in
GuzzleHttpRequest, which was missing in T202110, and restore
GuzzleHttpRequest as the default provided by HttpRequestFactory.
Bug: T212175
Depends-On: I4b45e79d35252d13f714f3271b87301ca515121a
Change-Id: I60d1a034b44874f6d24a04058db264eeb565f5e1
Max Semenik [Thu, 24 Jan 2019 02:51:21 +0000 (18:51 -0800)]
Password: replace equals() with verify()
So far, our key derivation code assumed that it has control over
the salt used by the derivation routines, however I want to add Argon2
support and it doesn't work this way: password_hash() generates the
salt itself, and the only way to verify a password is by using
password_verify(). Current way the things are done doesn't support it
because it relies on the result of password hashing with parameters we
provide to be deterministic.
Therefore, I'm deprecating Password::equals(), as well as whole concept
of comparing Password objects - it's used only in tests anyway. It's
getting replaced with verify() that only accepts password strings.
Uses of old function are fixed with exception of a few calls in tests
that will be addressed in my Argon2 patch.
Change-Id: I2b2be9a422ee0f773490eac316ad81505c3f8571
Translation updater bot [Thu, 24 Jan 2019 21:16:57 +0000 (22:16 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia3e8a3a29198b7032e95618445aa53ab72f65cf0
jenkins-bot [Thu, 24 Jan 2019 20:40:31 +0000 (20:40 +0000)]
Merge "Add missing `@return` PHPDoc to __sleep() function"
jenkins-bot [Thu, 24 Jan 2019 20:24:01 +0000 (20:24 +0000)]
Merge "Clone the Title object to prevent mutations."
Derick Alangi [Thu, 24 Jan 2019 20:17:47 +0000 (21:17 +0100)]
Add missing `@return` PHPDoc to __sleep() function
Change-Id: I97547938041264440af621694f08a067f1d0791f
jenkins-bot [Thu, 24 Jan 2019 18:51:00 +0000 (18:51 +0000)]
Merge "HTMLForm OOUI: Reduce distance between flatlist label and widgets"
jenkins-bot [Thu, 24 Jan 2019 13:27:43 +0000 (13:27 +0000)]
Merge "Document Uri.js constructor and methods throwing Errors"
jenkins-bot [Thu, 24 Jan 2019 11:11:19 +0000 (11:11 +0000)]
Merge "MIME: Re-classify DjVu files as OFFICE, like PDFs, and not as BITMAP"
jenkins-bot [Thu, 24 Jan 2019 08:57:33 +0000 (08:57 +0000)]
Merge "Make sure database update succeeds from older database versions too."
Thiemo Kreuz [Wed, 23 Jan 2019 21:01:07 +0000 (22:01 +0100)]
Document Uri.js constructor and methods throwing Errors
I, personally, think the fact an empty `new Uri()` call can fail with
an Error being thrown is a bug. But it seems others think this is a
feature (see Ib4dc568). Can we at least document it then? And then
somehow (not sure how) tell everybody who ever used this class to fix
their code?
Change-Id: I86ef1ccf90f9be9c61bc6a8312369ae09d622b0c
Volker E [Tue, 8 Jan 2019 02:13:33 +0000 (18:13 -0800)]
Special:AllMessages: Visually hide repeating text
Leaving it in for better screen reader navigation though.
Also, in order for this to use 'mediawiki.mixins' renaming special
stylesheet from CSS to LESS.
Bug: T209253
Change-Id: I40ac43d0a4a379a71ce78f2bd1f62b828170f4d8
Volker E [Thu, 24 Jan 2019 02:12:08 +0000 (18:12 -0800)]
HTMLForm OOUI: Reduce distance between flatlist label and widgets
With `.oo-ui-fieldLayout-header` set to `padding-bottom: 0;` label
is visually appearing equally to other “normal” label and widget
combinations.
Change-Id: I1efa11301b631304ef1d9cc7613fc139e84fa9c0