Jforrester [Tue, 3 Sep 2019 16:35:48 +0000 (16:35 +0000)]
Revert "Modify -—with-extensions to throw extension dependency errors"
This reverts commit
d9eec3c9124d87fd44e6917d5b1512b78352afb3.
Reason for revert: Breaking most of CI
Bug: T231876
Change-Id: I9b64a2bb770ee2e7ee717669070843814f37e81e
Clara Andrew-Wani [Thu, 29 Aug 2019 14:56:27 +0000 (10:56 -0400)]
Modify -—with-extensions to throw extension dependency errors
Changes the behavior of -—with-extensions from silently skipping
extensions that lack another extension dependency to throwing an
install exception.
Bug: T225512
Change-Id: Ia5b41841aaf55fa5c4971ae67218f8231f8adcb8
jenkins-bot [Tue, 3 Sep 2019 11:22:00 +0000 (11:22 +0000)]
Merge "FileJournal tests"
Aryeh Gregor [Thu, 22 Aug 2019 06:47:54 +0000 (09:47 +0300)]
FileJournal tests
100% unit test coverage for FileJournal and NullFileJournal. 100%
integration test coverage for DBFileJournal. Unit tests for
DBFileJournal once it supports injection.
I removed FileJournal and NullFileJournal from the list of classes that
FileBackendTest tests. It doesn't actually test them, it just happens to
run code from them without checking its correctness at all.
Depends-On: Ic22075bb5e81b7c2c4c1b8647547aa55306a10a7
Change-Id: I46d10ab7b87c23937aa04d7ec1922abfcf3bd611
jenkins-bot [Mon, 2 Sep 2019 23:17:22 +0000 (23:17 +0000)]
Merge "Add $specialPageAliases and $magicWords for Tajik"
jenkins-bot [Mon, 2 Sep 2019 23:12:30 +0000 (23:12 +0000)]
Merge "Correct the wording of the backend-fail-hash message"
jenkins-bot [Mon, 2 Sep 2019 23:12:21 +0000 (23:12 +0000)]
Merge "Use IDatabase::buildStringCast in Special:MediaStatistics"
jenkins-bot [Mon, 2 Sep 2019 23:12:15 +0000 (23:12 +0000)]
Merge "Use Maintenance::getConfig in some maintenance scripts"
jenkins-bot [Mon, 2 Sep 2019 23:03:18 +0000 (23:03 +0000)]
Merge "Add Martin Urbanec to .mailmap"
jenkins-bot [Mon, 2 Sep 2019 20:52:18 +0000 (20:52 +0000)]
Merge "phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase"
Timo Tijhof [Wed, 7 Aug 2019 13:40:55 +0000 (14:40 +0100)]
phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase
This code didn't work because the $GLOBALS array is exposed by reference.
Once this reference was broken by unset(), the rest just manipulated a
local array that happens to be called "GLOBALS". It must not be unset or
re-assigned. It can only be changed in-place.
Before this, the execution of a MediaWikiUnitTestCase test stored a
copy of GLOBALS in unitGlobals, then lost the GLOBALS pointer and
created a new variable called "GLOBALS". As such, the tearDown() function
didn't do what it meant to do, either – which then results in odd
failures like T230023
Rewrite it as follows:
* In setup, store the current GLOBALS keys and values, then reduce
GLOBALS to only the whitelisted keys and values.
* In teardown, restore the original state.
* As optimisation, do this from setUpBeforeClass as well, so that
there are relatively few globals to reset between tests.
(Thanks @Simetrical!)
The following tests were previously passing by accident under
MediaWikiUnitTestCase but actually did depend on global config.
* MainSlotRoleHandlerTest (…, ContentHandler, $wgContentHandlers)
* SlotRecordTest (…, ContentHandler, $wgContentHandlers)
* WikiReferenceTest (wfParseUrl, $wgUrlProtocols)
* DifferenceEngineSlotDiffRendererTest (DifferenceEngine, wfDebug, …)
* SlotDiffRendererTest (…, ContentHandler, $wgContentHandlers)
* FileBackendDBRepoWrapperTest (wfWikiID, "Backend domain ID not provided")
* JpegMetadataExtractorTest (…, wfDebug, …, LoggerFactory, …)
* ParserFactoryTest (…, wfDebug, …, LoggerFactory, InvalidArgumentException)
* MediaWikiPageNameNormalizerTest (…, wfDebug, …, LoggerFactory, …)
* SiteExporterTest (SiteImporter, wfLogWarning, …)
* SiteImporterTest (Site::newForType, $wgSiteTypes)
* ZipDirectoryReaderTest (…, wfDebug, …, LoggerFactory, …)
Bug: T230023
Change-Id: Ic22075bb5e81b7c2c4c1b8647547aa55306a10a7
jenkins-bot [Mon, 2 Sep 2019 19:37:19 +0000 (19:37 +0000)]
Merge "Fix duplicate Jon Harald Søby in CREDITS"
Amir Aharoni [Mon, 2 Sep 2019 19:08:22 +0000 (22:08 +0300)]
Correct the wording of the backend-fail-hash message
Change-Id: I5dfc0fa4ecc04cd2e31a633b3a6473eca48ec6c4
jenkins-bot [Mon, 2 Sep 2019 17:08:22 +0000 (17:08 +0000)]
Merge "Permit case independent unit test directories"
jenkins-bot [Mon, 2 Sep 2019 17:00:21 +0000 (17:00 +0000)]
Merge "objectcache: Optimise array_map in MemcachedBagOStuff::makeKey()"
jenkins-bot [Mon, 2 Sep 2019 17:00:13 +0000 (17:00 +0000)]
Merge "ProxyLookup: Optimise in_array in isConfiguredProxy()"
jenkins-bot [Mon, 2 Sep 2019 16:54:56 +0000 (16:54 +0000)]
Merge "Rework ApiUploadTest"
jenkins-bot [Mon, 2 Sep 2019 16:54:48 +0000 (16:54 +0000)]
Merge "Correctly format null error reporting level"
jenkins-bot [Mon, 2 Sep 2019 13:11:13 +0000 (13:11 +0000)]
Merge "Use the existing link renderer in the special page pagers"
Brad Jorsch [Wed, 28 Aug 2019 20:34:30 +0000 (16:34 -0400)]
ApiQueryCategories: Supply limit for DB query
The limit is applied in PHP, but all matching rows are being fetched
from the database. We should only fetch the number of rows needed.
Bug: T231462
Change-Id: Ie64ea6f79a187942c476868c383a1349d110aa7c
jenkins-bot [Mon, 2 Sep 2019 11:28:10 +0000 (11:28 +0000)]
Merge "Revert "Reset $wgContLang consistently for tests""
jenkins-bot [Mon, 2 Sep 2019 11:11:57 +0000 (11:11 +0000)]
Merge "Permit destructors in MediaWikiTestCaseTrait::createNoOpMock"
Ladsgroup [Mon, 2 Sep 2019 11:03:18 +0000 (11:03 +0000)]
Revert "Reset $wgContLang consistently for tests"
This reverts commit
09407afd74104bb3a674e4f5c48d10b15914d0db.
Reason for revert: It broke Wikibase on master.
Bug: T231799
Change-Id: Ie347abb24183ce3000af4d653ce2343ec7a63290
Lucas Werkmeister [Mon, 2 Sep 2019 10:49:06 +0000 (12:49 +0200)]
Add Martin Urbanec to .mailmap
Commit
6ded91313c, presumably created on Gerrit, uses the author name
Urbanecm instead of Martin Urbanec; without this .mailmap entry to fix
it, maintenance/updateCredits.php would add another entry for that name
(he’s already credited under the proper name).
Change-Id: I14c6a58f969f8d10bdd0e3d17566af5ad53e5a8b
Lucas Werkmeister [Mon, 2 Sep 2019 10:40:09 +0000 (12:40 +0200)]
Fix duplicate Jon Harald Søby in CREDITS
There are some commits from “jhsoby <jhsoby@gmail.com>”. Update the
.mailmap to correct the name of those commits (the existing line would
only update <jhsoby@users.mediawiki.org> commits), and remove the jhsoby
line from the CREDITS.
Also remove jeblad from CREDITS – he already has a .mailmap entry
mapping <john.blad@wikimedia.de> to John Erling Blad, but
maintenance/updateCredits.php never removes CREDITS entries, so while it
adds a correct John Erling Blad entry it won’t remove jeblad by itself.
Change-Id: I987d1cb1e5190899d944c0880211296580abbcb6
jenkins-bot [Mon, 2 Sep 2019 08:55:51 +0000 (08:55 +0000)]
Merge "phpunit: Add more info to LocalSettings.php error in MediaWikiIntegrationTestCase"
Translation updater bot [Mon, 2 Sep 2019 07:19:57 +0000 (09:19 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I17cb40921799c2b97f8c8bfca201c6a77939ce48
jenkins-bot [Sun, 1 Sep 2019 23:58:11 +0000 (23:58 +0000)]
Merge "Remove Oracle reference from WikiMap"
Aaron Schulz [Thu, 15 Aug 2019 12:37:29 +0000 (08:37 -0400)]
Remove Oracle reference from WikiMap
Bug: T230418
Change-Id: I06536034a9d7f176e65b087cc2d3ad65d172961b
Aryeh Gregor [Sun, 1 Sep 2019 08:39:50 +0000 (11:39 +0300)]
Reset $wgContLang consistently for tests
We already reset $wgParser to a stub in a number of places where it
might have changed. Let's give $wgContLang the same treatment so we can
avoid special-case code.
This deprecates setContentLang(), which is no longer needed. The magic
of $wgContLang is now handled by setMwGlobals() and setService().
This is a follow-up to
e4f69ee, which fixed one case of this problem.
Change-Id: I90925ef8b2a7478cce90d474db1b8b4539e45c15
jenkins-bot [Sun, 1 Sep 2019 22:43:06 +0000 (22:43 +0000)]
Merge "Avoid multiply calls to MediaWikiServices::getInstance() in one function"
jenkins-bot [Sun, 1 Sep 2019 22:31:08 +0000 (22:31 +0000)]
Merge "rdbms: clean up use of ATTACH queries in DatabaseSqlite"
jenkins-bot [Sun, 1 Sep 2019 22:19:59 +0000 (22:19 +0000)]
Merge "objectcache: add "sessionConsistencyWindow" option to ReplicatedBagOStuff"
jenkins-bot [Sun, 1 Sep 2019 22:16:40 +0000 (22:16 +0000)]
Merge "filebackend: improve FileBackendMultiWrite consistencyCheck()/resyncFiles()"
Aaron Schulz [Mon, 26 Aug 2019 18:17:12 +0000 (11:17 -0700)]
rdbms: clean up use of ATTACH queries in DatabaseSqlite
Defer the queries until a connection exists. Only issue issue the
them for databases that are different than the currently opened file.
Also, make handleSessionLossPreconnect() aware of attached databases.
In LoadBalancer::reallyOpenConnection(), avoid having the "catch" block
appear like it returns a half-constructed Database.
Change-Id: I9f676bb72a1ab06f0eac5820dce28231741c283d
Aaron Schulz [Sat, 20 Jul 2019 21:59:45 +0000 (14:59 -0700)]
objectcache: add "sessionConsistencyWindow" option to ReplicatedBagOStuff
Change-Id: I25af780f063879eda2de1b9a1168e37115f823ed
jenkins-bot [Sun, 1 Sep 2019 21:30:26 +0000 (21:30 +0000)]
Merge "Allow CompositeBlock::appliesToRight to return null when unsure"
Timo Tijhof [Sun, 1 Sep 2019 20:34:35 +0000 (21:34 +0100)]
phpunit: Add more info to LocalSettings.php error in MediaWikiIntegrationTestCase
Change-Id: I3df68aab40f4b0bb1d5134330347d77ed3399f02
Thalia [Fri, 30 Aug 2019 18:37:15 +0000 (19:37 +0100)]
Allow CompositeBlock::appliesToRight to return null when unsure
CompositeBlock::appliesToRight checks $block->appliesToRight()
for each of the original blocks from which it is made.
AbstractBlock::appliesToRight returns:
* true if the block applies to the right
* false if the block does not apply to the right
* null if unsure
Before this, CompositeBlock::appliesToRight can only return true
or false. After this, it returns:
* false if false for all of the original blocks
* true if true for one or more original blocks
* null otherwise
Bug: T229417
Bug: T231145
Change-Id: Ie93b7691b57ac6a8f86b3641ad07a1d54babcd42
jenkins-bot [Sun, 1 Sep 2019 19:56:12 +0000 (19:56 +0000)]
Merge "Unit tests: Remove duplicated code in ExtensionRegistry"
Umherirrender [Mon, 19 Aug 2019 15:44:14 +0000 (17:44 +0200)]
Use Maintenance::getConfig in some maintenance scripts
This avoid global state
Change-Id: Id67d07597159a0bd2721a381775230c3cd1d5509
Umherirrender [Mon, 19 Aug 2019 20:45:43 +0000 (22:45 +0200)]
Avoid multiply calls to MediaWikiServices::getInstance() in one function
RepoGroup::singleton() results in
MediaWikiServices::getInstance()->getRepoGroup()
Also avoid getting the service in loops, doing it once before the loop
is cheaper
Change-Id: I29e0c7487e3e498559ff16a567e2fad0c0f8bb69
Umherirrender [Thu, 4 Jul 2019 20:33:35 +0000 (22:33 +0200)]
Add string cast when outputting exceptions in sql.php
Change-Id: Ibf21869a2525a8c55f53ec79727c818888344e99
Umherirrender [Mon, 19 Aug 2019 21:41:04 +0000 (23:41 +0200)]
Use the existing link renderer in the special page pagers
Use SpecialPage::getLinkRenderer and pass it to the pagers
Since I082152b64141f1a9a4085bba23fe81a99ec8d886 it is a property in the
IndexPager and can be used by getLinkRenderer
Change-Id: I2be8a8b9f2b0b8c04fe9e18aa1959987fc125f50
mainframe98 [Sun, 1 Sep 2019 15:44:14 +0000 (17:44 +0200)]
Permit case independent unit test directories
If unit tests are namespaced under Tests/Unit/, with tests/phpunit being
the PSR4 root Tests/, then the the unit test directory cannot be named unit/.
The autoloader will not be able to find the files in that namespace, as
it will be looking for the directory Unit/, not unit/.
Change-Id: I8cf6cd31f22decb061650def9e1e5d8893dfa73f
jenkins-bot [Sun, 1 Sep 2019 15:25:02 +0000 (15:25 +0000)]
Merge "Avoid usage of deprecated setTags() method, use addTags() instead"
Derick Alangi [Sun, 7 Jul 2019 22:07:56 +0000 (23:07 +0100)]
Avoid usage of deprecated setTags() method, use addTags() instead
$tags can be `null` as seen in most cases and this causes failures,
so, the safer path is to make sure if $tags is a null, do nothing.
Change-Id: I5b7e39adba5d08fdcd42c437a72a391be98c8695
Daimona Eaytoy [Fri, 30 Aug 2019 18:17:32 +0000 (20:17 +0200)]
Unsuppress phan issues part 6
Bug: T231636
Depends-On: I50377746f01749b058c39fd8229f9d566224cc43
Change-Id: I2cd24e73726394e3200a570c45d5e86b6849bfa9
Daimona Eaytoy [Fri, 30 Aug 2019 17:56:27 +0000 (19:56 +0200)]
Unsuppress more phan issues (part 5)
Bug: T231636
Depends-On: I6e5fba7bd273219b1206559420b5bdb78734aa84
Change-Id: I50377746f01749b058c39fd8229f9d566224cc43
jenkins-bot [Sun, 1 Sep 2019 09:07:02 +0000 (09:07 +0000)]
Merge "Unpack arrays on variadic arguments"
jenkins-bot [Sun, 1 Sep 2019 09:05:59 +0000 (09:05 +0000)]
Merge "Remove unneeded redeclaration of mPage in Article subclasses"
Umherirrender [Sat, 29 Jun 2019 15:17:33 +0000 (17:17 +0200)]
Unpack arrays on variadic arguments
This avoids extra handling in the function to unpack an array
Change-Id: I93277599bc8125e23fca53d43a728fb7e9e39aad
Umherirrender [Sat, 29 Jun 2019 14:11:57 +0000 (16:11 +0200)]
Remove unneeded redeclaration of mPage in Article subclasses
It is already set in the parent class
To make phan happy, set the new type with a @property annotation
Change-Id: I47a83e3c4848b0a75284dc08c72df60b3d5dd19b
Derick Alangi [Sat, 31 Aug 2019 20:59:45 +0000 (21:59 +0100)]
Fix method/function names case mismatch in core files
PHP doesn't care much but I think we humans do because we should
call methods by the name we give them. Method fixed are;
- isOk() -> isOK()
- setOk() -> setOK()
- teardown() -> tearDown()
Change-Id: I6b3f0cf3902887058efa426968da380803869e0b
Timo Tijhof [Sat, 31 Aug 2019 21:38:42 +0000 (22:38 +0100)]
objectcache: Optimise array_map in MemcachedBagOStuff::makeKey()
This can get called a lot on an average page load, optimise
a bit by using a referenced foreach iteration instead.
Using a simplified test case, I found this saves about 70% on PHP 7.2.
For 100 iterations, from ~1.5ms to ~0.4 ms.
```lang=php
$args = [ 'FooBar', 'thisthat', 4, 'foo', 12 ];
$left = 100;
foreach ($args as &$arg) {
$arg = strtr( $arg, ' ', '_' );
if ( strlen( $arg ) < $left || true ) {
$arg = '#' . $arg;
}
$left--;
}
```
Change-Id: Ie779c4661306a6d3dc08c08671f1a36682ca1afb
Timo Tijhof [Sat, 31 Aug 2019 21:16:08 +0000 (22:16 +0100)]
ProxyLookup: Optimise in_array in isConfiguredProxy()
This is called on all page loads by WebRequest::getIP(),
from Setup.php.
Strict in_array can easily make it 4 times faster (reduce by 75%).
For example, with an array containing 5 short strings and looking
up a 6th similar string that is not in the list, repeated 100x:
loose: 2.410 ms, 2.731 ms, 2.367 ms
strict: 0.649 ms, 0.668 ms, 0.653 ms
The larger the array to search through, the bigger the difference
becomes as it speeds up each internal comparison.
(PHP 7.2.20)
Bug: T189966
Change-Id: I6742dfa0a6d44b15294695b15ffe4885cb6a5310
jenkins-bot [Sat, 31 Aug 2019 21:09:07 +0000 (21:09 +0000)]
Merge "jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()`"
jenkins-bot [Sat, 31 Aug 2019 20:40:49 +0000 (20:40 +0000)]
Merge "phpunit: Don't bother resetting unused global in UploadFromUrlTestSuite"
jenkins-bot [Sat, 31 Aug 2019 20:39:05 +0000 (20:39 +0000)]
Merge "maintenance: Remove cross-wiki purging from rebuildmessages.php"
jenkins-bot [Sat, 31 Aug 2019 20:38:58 +0000 (20:38 +0000)]
Merge "Add ext-dom to composer.json"
jenkins-bot [Sat, 31 Aug 2019 20:17:53 +0000 (20:17 +0000)]
Merge "INSTALL/RELEASE-NOTES-1.34: Add required PHP extensions"
Amir Aharoni [Tue, 6 Aug 2019 13:44:26 +0000 (16:44 +0300)]
Add $specialPageAliases and $magicWords for Tajik
Contributed by translatewiki user ToJack.
Change-Id: Idada22a2e331c2b8519f961b6ca0e2f02a721681
Timo Tijhof [Sat, 31 Aug 2019 15:33:06 +0000 (16:33 +0100)]
Setup: Remove debug message for "caches"
This is currently forcing more object cache interfaces to be constructed
than might be needed in a given request. The configuration for these
interfaces is usually quite straight forward or can be trivially
verified from eval.php.
If we do want to log this, I would recommend doing it from the classes
constructor instead e.g. something like:
LoggerFactory::getInstance('MessageCache')->debug( get_class( $cache ) );
Bug: T189966
Change-Id: I06dc6dfbdf274bb57e9295b0c757b8d52c02acbe
jenkins-bot [Sat, 31 Aug 2019 18:00:57 +0000 (18:00 +0000)]
Merge "lockmanager: sort key by bucket in QuorumLockManager::doLockByType"
jenkins-bot [Sat, 31 Aug 2019 17:59:08 +0000 (17:59 +0000)]
Merge "Optimize HashRing to avoid hashing for the common single-location case"
jenkins-bot [Sat, 31 Aug 2019 17:50:09 +0000 (17:50 +0000)]
Merge "Unsuppress other phan issues (part 4)"
jenkins-bot [Sat, 31 Aug 2019 17:49:55 +0000 (17:49 +0000)]
Merge "Replace unecessary rollbackMasterChangesAndLog() call in doPostOutputShutdown()"
jenkins-bot [Sat, 31 Aug 2019 17:49:49 +0000 (17:49 +0000)]
Merge "Remove redundant ignore_user_abort() call in ApiStashEdit"
Daimona Eaytoy [Fri, 30 Aug 2019 16:01:28 +0000 (18:01 +0200)]
Unsuppress other phan issues (part 4)
Bug: T231636
Depends-On: I58e67c2b38389df874438deada4239510d21654f
Change-Id: I6e5fba7bd273219b1206559420b5bdb78734aa84
Daimona Eaytoy [Fri, 30 Aug 2019 13:09:51 +0000 (15:09 +0200)]
Unsuppress more phan issues (part 3)
Bug: T231636
Depends-On: I78354bf5f0c831108c8f606e50c87cf6bc00d8bd
Change-Id: I58e67c2b38389df874438deada4239510d21654f
Timo Tijhof [Sat, 31 Aug 2019 14:00:29 +0000 (15:00 +0100)]
phpunit: Don't bother resetting unused global in UploadFromUrlTestSuite
messageMemc is not used for anything important. Should be removed
soon, but at least don't reset it in tests. If something new depends
on it, it should fail.
Bug: T189966
Change-Id: Id707db028e6eba03242fc9e1541d785a607d9be9
Timo Tijhof [Sat, 31 Aug 2019 13:38:31 +0000 (14:38 +0100)]
maintenance: Remove cross-wiki purging from rebuildmessages.php
This script relied on numerous outdated or unofficial methods that
are no longer supported.
* Global variable $messageMemc holding a BagOStuff based on
MessageCacheType. This logic is now in ServiceWiring
for the MessageCache service.
* String "{$db}:messages", should have been using BagOStuff::makeKey()
and may've fallen out of sync.
* Deleting keys outright instead of touching check keys as
MessageCache does, since it's been using WANObjectCache for
several years.
All of this should be done via MessageCache::clear(), but that
can't be easily constructed across wikis on a wiki farm. That
requires instantiating the script for other wikis separately.
Remove support for that, recommending instead that site admins
run it in a loop for each wiki as needed.
Realistically though, that should never be needed. The script has
virtually no known use case, except (as documented in maintenance/README)
"after changing a wiki's content language" - which applies to one
wiki, not all a once.
Change-Id: I9f45d65f5cef93d6e332baf26d955d3f7a7c19d2
Translation updater bot [Sat, 31 Aug 2019 13:11:56 +0000 (15:11 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I130e7b793e6327e0d1f3b56d0b321f7bb3448c70
Mahuton [Wed, 28 Aug 2019 06:48:27 +0000 (08:48 +0200)]
Change the autonym of Banjar from "Bahasa Banjar" to "Banjar"
Change requested on the Sundanese Wikipedia village pump
Bug: T231283
Change-Id: Ib2f49f77634c497135c0b32256fca4e919866a38
Mahuton [Wed, 28 Aug 2019 07:22:16 +0000 (09:22 +0200)]
Change the autonym of Sunda from "Basa Sunda" to "Sunda"
Change requested on the Sundanese Wikipedia village pump
Bug: T228832
Change-Id: Id26493395a028b72f0254c7b866eb074eccbe1f9
jenkins-bot [Sat, 31 Aug 2019 03:34:01 +0000 (03:34 +0000)]
Merge "Use DatabaseBlock instead of deprecated Block in CompositeBlock tests"
jenkins-bot [Fri, 30 Aug 2019 22:50:27 +0000 (22:50 +0000)]
Merge "user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method"
jenkins-bot [Fri, 30 Aug 2019 22:37:41 +0000 (22:37 +0000)]
Merge "ContribsPage: Re-remove the getContribs() method"
jenkins-bot [Fri, 30 Aug 2019 22:27:11 +0000 (22:27 +0000)]
Merge "filebackend: fix PhpStorm warnings in FileBackend"
jenkins-bot [Fri, 30 Aug 2019 22:12:28 +0000 (22:12 +0000)]
Merge "MessageFormatterFactory"
Derick Alangi [Tue, 27 Aug 2019 21:43:33 +0000 (22:43 +0100)]
user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method
This method is no longer used in core or any extension per CS below;
https://codesearch.wmflabs.org/search/?q=addNewUserLogEntryAutoCreate&i=nope&files=&repos=
Change-Id: I906db9a123f6eb4210642b68525324071422eb61
Derick Alangi [Tue, 27 Aug 2019 22:52:38 +0000 (23:52 +0100)]
jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()`
Change-Id: I58c007436d38e4d0edd1ce14034b2f3bfb536df9
DannyS712 [Thu, 29 Aug 2019 20:22:15 +0000 (20:22 +0000)]
ContribsPage: Re-remove the getContribs() method
Dependencies remove the use from Flow and ArticleFeedback.
This reverts commit
e6a8e5268d8b70867e58b1c827d42fec56bb315f.
Depends-On: If77a646344b3ee89505bb17be7571f63cff16a5a
Depends-On: I3b2fa1c65cfc32e8ebc21166d32f174557694d88
Bug: T220447
Bug: T231540
Change-Id: I3f87c0310f2f2de674d8c2fa017642bcc69fd834
Petr Pchelko [Thu, 29 Aug 2019 23:11:04 +0000 (16:11 -0700)]
Rework ApiUploadTest
Bug: T28169
Change-Id: I923bf82d07db0efce1d0d14cf04e15bb58472f59
jenkins-bot [Fri, 30 Aug 2019 19:42:04 +0000 (19:42 +0000)]
Merge "rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls"
Thalia [Fri, 30 Aug 2019 18:54:34 +0000 (19:54 +0100)]
Use DatabaseBlock instead of deprecated Block in CompositeBlock tests
Change-Id: I377da7e070ccd4f1ebb4a3e9619833e912180491
Aaron Schulz [Thu, 29 Aug 2019 05:30:30 +0000 (22:30 -0700)]
filebackend: improve FileBackendMultiWrite consistencyCheck()/resyncFiles()
Report file stat errors and sha1/stat mismatches in consistencyCheck().
This will trigger resyncFiles() which will make second attempt to check
the consistency while also fixing any problems if possible. Make sure
that it also bails out if such errors occur again.
Improve consistencyCheck()/resyncFiles() variable naming and add more
comments to FileBackend::UNKNOWN.
Also replace wfDebugLog() calls with PSR logger calls and wfTimestamp()
calls with ConvertibleTimestamp::convert() calls.
Bug: T231086
Change-Id: I69bcee636c6d99970e9a6448bb8296c0790c7254
jenkins-bot [Fri, 30 Aug 2019 18:38:52 +0000 (18:38 +0000)]
Merge "Make Special:ChangeContentModel field labels consistently use colons"
D3r1ck01 [Fri, 30 Aug 2019 18:35:50 +0000 (18:35 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Fri, 30 Aug 2019 18:16:05 +0000 (18:16 +0000)]
Merge "Return null from EditPage::importContentFormData"
Aaron Schulz [Wed, 17 Jul 2019 11:55:19 +0000 (04:55 -0700)]
filebackend: fix PhpStorm warnings in FileBackend
Change-Id: Ia02bc8a94a28e7582c078bb89bd92d1ecf9e2841
jenkins-bot [Fri, 30 Aug 2019 17:00:46 +0000 (17:00 +0000)]
Merge "Actually assign suppression-related rights to 'suppress' group"
mainframe98 [Fri, 30 Aug 2019 15:24:41 +0000 (17:24 +0200)]
Permit destructors in MediaWikiTestCaseTrait::createNoOpMock
709773ab5747 introduced this method, but its implementation
does not permit calls to __destruct. PHP documentation on destructors
says that they'll be called unconditionally, which makes using the
mock created with this method unusable for classes that implement
__destruct.
Bug: T231656
Change-Id: Icb4f978c78e726401d75627128c9c76f6f9afc87
jenkins-bot [Fri, 30 Aug 2019 13:55:53 +0000 (13:55 +0000)]
Merge "Unsuppress other phan issues with low count"
jenkins-bot [Fri, 30 Aug 2019 13:55:33 +0000 (13:55 +0000)]
Merge "Globally unsuppress phan issues with low count"
Lucas Werkmeister [Fri, 30 Aug 2019 12:31:11 +0000 (14:31 +0200)]
Also set $wgContLang in MWITC::setContentLang()
This assignment got lost in change Ie7a89f6ed7 (commit
47464abb4f) – the
resetServices() now implicit in setMwGlobals() resets the
ContentLanguage service, but does not update the $wgContLang global.
setService( 'ContentLanguage' ) does update it, but that method is
deliberately not used in this branch of setContentLang(), for reasons
that I assume are still relevant even though the comment explaining them
was removed – see change I8c60e37c17 (commit
c70c2e4714).
Bug: T231630
Change-Id: I0170cc6bf40a5524523c45e8ffff8f72adc2fc47
jenkins-bot [Fri, 30 Aug 2019 11:42:55 +0000 (11:42 +0000)]
Merge "Add some LocalRepo integration tests"
Daimona Eaytoy [Thu, 29 Aug 2019 13:19:39 +0000 (15:19 +0200)]
Unsuppress other phan issues with low count
And also update approximated counts, which for the most part are lower
than reported (hooray!)
Bug: T231636
Depends-On: Ica50297ec7c71a81ba2204f9763499da925067bd
Change-Id: I78354bf5f0c831108c8f606e50c87cf6bc00d8bd
Petr Pchelko [Mon, 26 Aug 2019 20:18:50 +0000 (13:18 -0700)]
Introduce BlobStore::getBlobBatch method
Bug: T230834
Change-Id: I56306c50a6617dc91e4eb362ef010703ac25d951
Daimona Eaytoy [Thu, 29 Aug 2019 09:59:59 +0000 (11:59 +0200)]
Globally unsuppress phan issues with low count
All of these suppression prevent the detection of many common mistakes,
and could easily prevent things like T231488. Especially if there are
few issues of a given type, it's way better to suppress them inline,
instead of disabling them for the whole core.
This patch only touches the one with a lower count (although those
counts may be out of date).
Bug: T231636
Change-Id: Ica50297ec7c71a81ba2204f9763499da925067bd