Timo Tijhof [Wed, 23 Jan 2019 03:22:28 +0000 (19:22 -0800)]
build: Remove newer HHVM versions we'll never support
Been failing for months. The believe that, defacto, the only version
we support is HHVM 3.18. Interestingly, that build is failing too,
possibly due to configuration differences between WMF and Travis.
I'll keep it for now, in case wants to try and make it pass.
Change-Id: Id2fd32db14686cba1f65f9aa015e2b7f9275f00c
jenkins-bot [Wed, 23 Jan 2019 04:28:02 +0000 (04:28 +0000)]
Merge "Datatable: Unify `padding` with `.wikitable`"
jenkins-bot [Wed, 23 Jan 2019 04:18:29 +0000 (04:18 +0000)]
Merge "Datatable: Apply `padding` only on `th` & `td` elements"
Volker E [Sat, 19 Jan 2019 00:52:15 +0000 (16:52 -0800)]
Datatable: Unify `padding` with `.wikitable`
Unifying `padding` with `.wikitable`.
Bug: T214208
Change-Id: Ic04b647d2fa90ee0002a4d5b4597e271ea543194
Volker E [Fri, 18 Jan 2019 23:35:24 +0000 (15:35 -0800)]
Datatable: Apply `padding` only on `th` & `td` elements
Applying it on `table` as well results in issues when wanting
to override `border-radius` together with `border-collapse`.
It's not needed in a well-formed table as every child element would
need to reside within a `th` or `td` anyways.
Also the only other content carrying element `caption` doesn't receive
table's `padding` by default.
Change-Id: I5e8c9d47fab806b56e6d03f1611ddbf6d4ea8924
jenkins-bot [Wed, 23 Jan 2019 01:01:43 +0000 (01:01 +0000)]
Merge "Better detection for old MS Office files"
Tim Starling [Tue, 15 Jan 2019 03:15:18 +0000 (14:15 +1100)]
Better detection for old MS Office files
* Introduce MSCompoundFileReader, which reads the CFB directory and
detects the file type from well-known names in the root directory
* Do not detect a ZIP file if the EOCDR is not at the end. Other
containers, especially CFB files, may contain ZIP files embedded
within them in the last 64KB, but this is not a security concern
unless the EOCDR is exactly at the end of the file.
Bug: T40432
Change-Id: Id5b1a258ccf3c3c8951e32f6b7a5b1bafe941082
jenkins-bot [Tue, 22 Jan 2019 21:56:57 +0000 (21:56 +0000)]
Merge "Remove deprecated module alias "jquery.byteLimit""
jenkins-bot [Tue, 22 Jan 2019 21:56:51 +0000 (21:56 +0000)]
Merge "mediawiki.api: Remove deprecated module aliases"
jenkins-bot [Tue, 22 Jan 2019 20:54:56 +0000 (20:54 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Tue, 22 Jan 2019 20:53:23 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia9ecbc8465dd445aa109916f2e8dda5161ed2ebd
jenkins-bot [Tue, 22 Jan 2019 20:50:52 +0000 (20:50 +0000)]
Merge "Fix more jquery event shorthand usages"
jenkins-bot [Tue, 22 Jan 2019 19:52:58 +0000 (19:52 +0000)]
Merge "rdbms: Remove references to pg_attrdef.adsrc in Postgres code"
jenkins-bot [Tue, 22 Jan 2019 19:33:49 +0000 (19:33 +0000)]
Merge "Convert RandomImageGenerator to use the new execution framework"
Jeff Janes [Thu, 17 Jan 2019 23:41:51 +0000 (18:41 -0500)]
rdbms: Remove references to pg_attrdef.adsrc in Postgres code
PostgreSQL v12 will remove the long-deprecated column
pg_attrdef.adsrc. The supported way to introspect into column
default values is pg_get_expr(adbin, adrelid), which works
back through all versions of PostgreSQL supported by wikimedia.
Changing to the supported method will allow the upcoming v12 of the
database to be used while maintaining compatibility with older
versions, without needing to write version-specific code.
This patch has been tested with maintenance/update.php and
with phpunit in PostgreSQL versions 9.2, 11, and 12dev. It does
not harm the first two, and fixes errors that would otherwise
arise in the dev version. All unit tests which pass under version
11 now pass under 12dev as well.
Change-Id: I874d347fd286b26773113d4f0c6c30d9a4055ad3
jenkins-bot [Tue, 22 Jan 2019 18:27:42 +0000 (18:27 +0000)]
Merge "build: Remove unused 'deepmerge' package"
jenkins-bot [Tue, 22 Jan 2019 08:27:05 +0000 (08:27 +0000)]
Merge "tests: Remove use of $IP and MediaWikiTestCase in libs/composer tests"
Timo Tijhof [Tue, 22 Jan 2019 04:17:54 +0000 (20:17 -0800)]
tests: Remove use of $IP and MediaWikiTestCase in libs/composer tests
Reference the fixture files relatively instead of absolutely,
this is done for most other references to data files as well
I believe.
Use plain arrayEquals(), which seems to suffice here. In PHP 7 at
least, regular == doesn't require the declaration order of the
keys to be the same in order to evaluate to true.
Change-Id: Iddc874ec811f5c960e13d480d70bcb20334cfa1e
Max Semenik [Tue, 22 Jan 2019 07:04:01 +0000 (23:04 -0800)]
Hard-deprecate wfArrayFilter() and wfArrayFilterByKey()
Deprecated in 1.32, no callers.
Change-Id: Id6147cff1336cc39863c985023933ce9c6afca31
Max Semenik [Tue, 14 Nov 2017 04:11:53 +0000 (20:11 -0800)]
Convert RandomImageGenerator to use the new execution framework
Introduces a stringifier for Command, useful for debugging.
Change-Id: Ifcfccaef5a609e0cf30186e39a6bd0fa971c2dbd
jenkins-bot [Tue, 22 Jan 2019 05:12:14 +0000 (05:12 +0000)]
Merge "htmlform: Move HTMLSelectLanguageField into includes/htmlform/fields"
SamanthaNguyen [Tue, 22 Jan 2019 03:35:32 +0000 (21:35 -0600)]
htmlform: Move HTMLSelectLanguageField into includes/htmlform/fields
This was originally directly under includes/htmlform. This is
a specific type of field, so it should go here instead.
Follows-up
d0c31ac988888764.
Change-Id: Iac196068ce2cbca063948bc78d21913482717d9a
Bartosz Dziewoński [Tue, 22 Jan 2019 02:09:13 +0000 (03:09 +0100)]
registration: Fix typo in schemas
Change-Id: I8d39290904593c1ef962be2995a536028d0635bc
jenkins-bot [Tue, 22 Jan 2019 01:05:33 +0000 (01:05 +0000)]
Merge "Remove unnecessary placeholders from RELEASE-NOTES"
jenkins-bot [Tue, 22 Jan 2019 00:19:38 +0000 (00:19 +0000)]
Merge "Replace deprecated `setIconTitle` with `setTitle`"
jenkins-bot [Tue, 22 Jan 2019 00:19:33 +0000 (00:19 +0000)]
Merge "RELEASE-NOTES: Add note for jquery.async deprecation"
jenkins-bot [Tue, 22 Jan 2019 00:09:47 +0000 (00:09 +0000)]
Merge "Return to LESS multiple value escape mechanism to prevent invalid output"
Bartosz Dziewoński [Tue, 22 Jan 2019 00:03:18 +0000 (01:03 +0100)]
Remove unnecessary placeholders from RELEASE-NOTES
Change-Id: Ic30da7d03b0d34774e7d24d8b0616b6c6f66ae40
James D. Forrester [Tue, 15 Jan 2019 00:25:33 +0000 (16:25 -0800)]
RELEASE-NOTES: Add note for jquery.async deprecation
Change-Id: I245fd9141f1b3040bed031ede7cb4327d900f5af
Volker E [Thu, 17 Jan 2019 07:14:51 +0000 (23:14 -0800)]
Return to LESS multiple value escape mechanism to prevent invalid output
LESS doesn't accept JS evaluation in PHP via `'@{arguments}'.replace`,
therefore we need to go back to manual escaping multiple comma separated
values.
Change-Id: I4c46afc012d804350ccee2cd5b1eed4e6ea61d8a
Timo Tijhof [Mon, 21 Jan 2019 23:13:42 +0000 (15:13 -0800)]
build: Remove unused 'deepmerge' package
Was added for wdio-related code, but not used in the end.
The only reference to this module anywhere in Wikimedia Git is
mediawiki/extensions/CirrusSearch, which doesn't use it for
its regular or daily tests, but rather the integration test,
which already has its own copy of this module in package.json.
Change-Id: Ifdf4362077f4684a2866363e35d0aca2f89f48b5
jenkins-bot [Mon, 21 Jan 2019 22:45:19 +0000 (22:45 +0000)]
Merge "WebInstallerOutput: Add getLanguage()"
Lucas Werkmeister [Mon, 21 Jan 2019 11:46:36 +0000 (12:46 +0100)]
Document header case in MWHttpRequest
The lack of this documentation resulted in some confusion in T214032 and
related tasks.
Change-Id: I08fc201b625197614ef5e163ed3686638b630b13
Timo Tijhof [Sat, 19 Jan 2019 02:55:03 +0000 (18:55 -0800)]
Remove deprecated module alias "jquery.byteLimit"
Follows-up
777336288bc8 (MW 1.31).
Bug: T202154
Depends-On: I91b88601334f72e9d7e897853d0e075c86928c60
Change-Id: Ief22737b9f64cec4f0cc7b25e79e385f2e9eb2b1
Timo Tijhof [Fri, 18 Jan 2019 06:31:33 +0000 (22:31 -0800)]
mediawiki.api: Remove deprecated module aliases
Bug: T202154
Bug: T196802
Depends-On: If1bd7521563b8574d12d45988737e0e838337f8a
Change-Id: Ic7020e43747774bfdad2e63263ee8caadc5d2f45
Translation updater bot [Sun, 20 Jan 2019 21:04:06 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I74147fe057b8b4c35deba3146787d4e7082d3656
Translation updater bot [Sat, 19 Jan 2019 20:53:48 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I9718a0adfc58858c00092a962f7d592cdc6f55db
Fomafix [Tue, 23 Oct 2018 15:48:31 +0000 (17:48 +0200)]
WebInstallerOutput: Add getLanguage()
Combine the functions getLanguageCode() and getDir() to the single
function getLanguage().
Also mark the class WebInstallerOutput as @private.
Change-Id: Ic7deea5f3040fe8f1211b96622bdae222ca9e072
jenkins-bot [Sat, 19 Jan 2019 01:40:29 +0000 (01:40 +0000)]
Merge "TablePager: Unify `padding` with `.wikitable`"
jenkins-bot [Sat, 19 Jan 2019 01:13:07 +0000 (01:13 +0000)]
Merge "Reduce selector specificity of `.wikitable`"
Volker E [Sat, 19 Jan 2019 01:01:53 +0000 (17:01 -0800)]
TablePager: Unify `padding` with `.wikitable`
This should be at best temporarily until `.mw-datatable` gets same
`padding`.
Bug: T214208
Change-Id: Ib86808803fd6fa41704e7a69687a1ab41ef3c43d
jenkins-bot [Sat, 19 Jan 2019 00:47:00 +0000 (00:47 +0000)]
Merge "registration: Add @codeCoverageIgnore for statement that can't be covered"
Volker E [Sat, 19 Jan 2019 00:15:52 +0000 (16:15 -0800)]
Reduce selector specificity of `.wikitable`
Reducing selector specificity by removing `table` from `.wikitable`.
All use cases seem to be covered by direct child `>` selectors anyways.
Bug: T214218
Change-Id: Iae532d6389348972a85404926aaa0c45de7e02e1
jenkins-bot [Fri, 18 Jan 2019 21:59:32 +0000 (21:59 +0000)]
Merge "filerepo: avoid dynamic calls to FileRepo::isVirtualUrl"
Kunal Mehta [Fri, 18 Jan 2019 21:57:43 +0000 (13:57 -0800)]
registration: Add @codeCoverageIgnore for statement that can't be covered
MW_PHPUNIT_TEST will always be defined during tests, so we can't have a
test that requires it to be undefined.
Change-Id: I67b011af31026bc9c568725f8f294359b63f2fd5
Aaron Schulz [Fri, 18 Jan 2019 21:03:45 +0000 (13:03 -0800)]
filerepo: avoid dynamic calls to FileRepo::isVirtualUrl
Change-Id: Ie851ec33ba5d7965393e41595d0b4b9df070bd27
Translation updater bot [Fri, 18 Jan 2019 20:54:03 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1fc5d6f7500437df862f9f3f7b8e42af4702a9d8
jenkins-bot [Fri, 18 Jan 2019 17:52:14 +0000 (17:52 +0000)]
Merge "Make sure page restrictions are handled as a string"
jenkins-bot [Fri, 18 Jan 2019 17:47:05 +0000 (17:47 +0000)]
Merge "TablePager: Reduce pagination button in visual strength"
Ed Sanders [Fri, 18 Jan 2019 16:39:25 +0000 (16:39 +0000)]
Fix more jquery event shorthand usages
Not yet caught by the linter.
Change-Id: I9601bff47c099c4901487e7faaf871f23e2e2d1c
Thalia [Fri, 18 Jan 2019 16:22:09 +0000 (16:22 +0000)]
Make sure page restrictions are handled as a string
Bug: T214173
Change-Id: I3ec9b0a4f797b0e89fd30a9ceafcaaf8a6dce5d9
Volker E [Fri, 18 Jan 2019 00:04:30 +0000 (16:04 -0800)]
TablePager: Reduce pagination button in visual strength
Reducing buttons to `frameless` buttons and reposition icons of
next and last page button to be symmetrically harmonious.
Bug: T214128
Change-Id: I1c0a621d7699b5fadc2559abdf6003a0db0aabae
Gergő Tisza [Thu, 17 Jan 2019 23:55:35 +0000 (15:55 -0800)]
Fix exception language in MovePage
Follows up I8f6c9647ee.
Change-Id: Iff2941bfc9e14f52ddd33f0a3d522c5a0d594c3e
jenkins-bot [Thu, 17 Jan 2019 23:43:29 +0000 (23:43 +0000)]
Merge "dao: Add a type hint to getConnection() and some extra newlines"
jenkins-bot [Thu, 17 Jan 2019 23:28:23 +0000 (23:28 +0000)]
Merge "DateTimeInputWidget: Set `max-width` equivalent to calendar popup"
jenkins-bot [Thu, 17 Jan 2019 19:50:38 +0000 (19:50 +0000)]
Merge "WikiTextStructure: Add an exclusion from WikibaseMediaInfo"
jenkins-bot [Thu, 17 Jan 2019 19:50:33 +0000 (19:50 +0000)]
Merge "WikiTextStructure: Explain the source of two non-Core exclusions"
jenkins-bot [Thu, 17 Jan 2019 18:46:14 +0000 (18:46 +0000)]
Merge "Try to avoid master queries for GET requests"
James D. Forrester [Thu, 17 Jan 2019 18:31:52 +0000 (10:31 -0800)]
WikiTextStructure: Add an exclusion from WikibaseMediaInfo
This is not lovely, and probably should be a hook or similar.
Bug: T213638
Change-Id: I042ac81b630dede55887e644692ea1a3b1fd6fe1
James D. Forrester [Thu, 17 Jan 2019 18:31:28 +0000 (10:31 -0800)]
WikiTextStructure: Explain the source of two non-Core exclusions
Change-Id: I2673afb25c6f21789a4c89f390ca13dae2cc2fa9
jenkins-bot [Thu, 17 Jan 2019 18:19:25 +0000 (18:19 +0000)]
Merge "Linker: Simplify return paths"
jenkins-bot [Thu, 17 Jan 2019 18:04:46 +0000 (18:04 +0000)]
Merge "ApiSetNotificationTimestamp: Make entirewatchlist more efficient"
Aftab [Tue, 18 Dec 2018 21:10:34 +0000 (21:10 +0000)]
Adding $digitTransformTable for Santali (sat)
Bug: T212221
Change-Id: I30b9b55f16186e7fd404b6e3c9460a3fd81187d0
Fomafix [Thu, 3 Jan 2019 10:13:19 +0000 (11:13 +0100)]
Linker: Simplify return paths
* Avoid else after return.
* Use early-return pattern.
Change-Id: I059e233d019dbc2233756776dfa09f8f2fdb2df7
Translation updater bot [Thu, 17 Jan 2019 07:24:35 +0000 (08:24 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I86f2b814991862ac1d750445543e6d9a8117c23a
Volker E [Thu, 17 Jan 2019 07:04:25 +0000 (23:04 -0800)]
DateTimeInputWidget: Set `max-width` equivalent to calendar popup
Input fields should provide as much width as user input is needed or
in this case a little more to be aligned with inherently connected
calendar widget.
Bug: T213785
Change-Id: Id316af701cd054ed29603ffa38af9238a39cb50e
Volker E [Thu, 3 Jan 2019 20:43:50 +0000 (12:43 -0800)]
Replace deprecated `setIconTitle` with `setTitle`
Bug: T76638
Change-Id: Ia51cbfaff7325f5eef385cc00e801ede69e78954
jenkins-bot [Thu, 17 Jan 2019 05:02:23 +0000 (05:02 +0000)]
Merge "Fix error reporting in MovePage"
jenkins-bot [Thu, 17 Jan 2019 02:25:19 +0000 (02:25 +0000)]
Merge "Separate content parts of mw-usertoollinks from presentation"
Gergő Tisza [Thu, 17 Jan 2019 02:14:52 +0000 (18:14 -0800)]
Fix error reporting in MovePage
Bug: T210739
Change-Id: I8f6c9647ee949b33fd4daeae6aed6b94bb1988aa
Daimona Eaytoy [Wed, 16 Jan 2019 22:25:46 +0000 (23:25 +0100)]
Try to avoid master queries for GET requests
Skin::getUndeleteLink performs several checks, including a
Title::userCan, which in turn checks the blocked status from master in
order to decide whether to show the link. This happens during GET
requests, and a basic calculation shows that it is responsible for
roughly 15% of the DBPerformance alerts.
This patch rearranges the IF conditions so that the permission check is
performed last, and thus will be avoided if the previous condition is
false.
Change-Id: I45a18a244a26df09beb12e198e0e91a465bd1907
Roan Kattouw [Thu, 3 Jan 2019 01:41:04 +0000 (17:41 -0800)]
ApiSetNotificationTimestamp: Make entirewatchlist more efficient
Use WatchedItemStore's built-in feature for clearing the entire
watchlist when no timestamp is specified. When a timestamp is specified,
this will still use the inefficient page-by-page method, which I'll
improve in a follow-up commit.
Bug: T207941
Change-Id: I2008ff89c95fe6f66a3fd789d2cef0e8fe52bd93
jenkins-bot [Wed, 16 Jan 2019 20:19:01 +0000 (20:19 +0000)]
Merge "AllMessagesTablePager: Simplify language handling"
jenkins-bot [Wed, 16 Jan 2019 20:17:22 +0000 (20:17 +0000)]
Merge "Deprecate Content::getNativeData, add TextContent::getText"
jenkins-bot [Wed, 16 Jan 2019 20:17:16 +0000 (20:17 +0000)]
Merge "Simplify boolean logic for Special:Block widgets"
daniel [Thu, 8 Nov 2018 15:19:23 +0000 (16:19 +0100)]
Deprecate Content::getNativeData, add TextContent::getText
getNativeData() is under-specified - callers can do nothing with the
value returned by getNativeData without knowing the concrete Content
class. And if they know the concrete class, they can and should use
a specialized getter instead, anyway.
Basically, getNativeData is overly generic, an example of polymorphism
done poorly. Let's fix it now.
Bug: T155582
Change-Id: Id2c61dcd38ab30416a25746e3680edb8791ae8e8
jenkins-bot [Wed, 16 Jan 2019 19:23:00 +0000 (19:23 +0000)]
Merge "Fix BlockList params for non-editing partial blocks"
jenkins-bot [Wed, 16 Jan 2019 18:39:46 +0000 (18:39 +0000)]
Merge "Correct namespace 'Template' for gom-deva"
Dayllan Maza [Wed, 16 Jan 2019 18:20:51 +0000 (13:20 -0500)]
Fix BlockList params for non-editing partial blocks
When multiple blocks are listed, if there is a partial block
with restrictions, any other partial block in the list will be
shown as an editing block even if it isn't.
Bug: T213952
Change-Id: Ieafb5f71c484d9f0551fa293f7c43e1a3a2e1f2a
The Discoverer [Mon, 14 Jan 2019 19:55:43 +0000 (19:55 +0000)]
Correct namespace 'Template' for gom-deva
The existing name for the 'Template' namespace was incorrect. Hence,
replaced it with the correct word for 'Template' and 'Template_talk',
and added the existing ones as aliases.
Noticed that the existing file was missing a comma at the end of the
last item in the alias list.
Bug: T213717
Change-Id: Ibb8385cae3368e2c36006cf9993dec4ebbbc4491
Lucas Werkmeister [Mon, 10 Dec 2018 17:33:38 +0000 (18:33 +0100)]
Fully extract services framework as a library
This code doesn’t use any MediaWiki-specific code, so rename
MediaWiki\Services to Wikimedia\Services and move it below libs/. (Of
course, this does not apply to the MediaWikiServices subclass.)
Class aliases are added to retain backwards compatibity for now.
Bug: T211608
Change-Id: Ic14ea28ef21c359695b309d4293dbaaf5deedc09
Thalia [Mon, 14 Jan 2019 20:51:20 +0000 (20:51 +0000)]
Simplify boolean logic for Special:Block widgets
The boolean logic controlling the showing/hiding of widgets on
Special:Block could be expressed more simply. The logic is
becoming more complex due to partial blocks, so now is a good
time to rephrase it.
This removes safeguards against passing undefined to toggle,
so make sure none of the checks ever return undefined.
Change-Id: I1e0eb288db708be951fe5cf11f658725a38a7c4d
Brad Jorsch [Sat, 12 Jan 2019 19:16:52 +0000 (14:16 -0500)]
Avoid session double-start in Setup.php
In PHP before 7.3, the double start doesn't really matter: session_id()
changes the ID even if it was already started, and the warning from
session_start() can just be ignored. Which is what we did.
In PHP 7.3, now session_id() also warns and no longer changes the ID. To
preserve the previous behavior, we'll need to explicitly close the old
session and open the new one.
Bug: T213489
Change-Id: I02a5be1c3adb326927c156fdd00663bccee37477
Derick Alangi [Wed, 16 Jan 2019 13:29:53 +0000 (14:29 +0100)]
dao: Add a type hint to getConnection() and some extra newlines
Change-Id: I57a060394403a6b7335fda68edaeabc02888e14d
jenkins-bot [Wed, 16 Jan 2019 08:34:42 +0000 (08:34 +0000)]
Merge "Chinese Conversion Table Update 2018-4"
Krinkle [Wed, 16 Jan 2019 07:49:54 +0000 (07:49 +0000)]
Merge "resourceloader: Avoid unnecessary xmlns attributes in ResourceLoaderImage"
jenkins-bot [Wed, 16 Jan 2019 07:04:36 +0000 (07:04 +0000)]
Merge "Setup: Avoid using count() function in any kind of loop(s)"
jenkins-bot [Wed, 16 Jan 2019 07:03:47 +0000 (07:03 +0000)]
Merge "Safe replacement of a lot of `!count()` with `=== []`"
Bartosz Dziewoński [Tue, 15 Jan 2019 19:43:35 +0000 (20:43 +0100)]
resourceloader: Avoid unnecessary xmlns attributes in ResourceLoaderImage
We were creating the `<g>` element without specifying a namespace,
which caused the library to add `xmlns` attributes with the document's
default SVG namespace to elements that we appended underneath it.
(At least, that's what I think was happening.)
Specify the SVG namespace when creating it to avoid the mess and
reduce resulting file size.
Change-Id: Ida27494aeae9dece16f878c16cf9aa582e6deac3
jenkins-bot [Wed, 16 Jan 2019 00:39:29 +0000 (00:39 +0000)]
Merge "resourceloader: Avoid toplevel `<title>` under `<g>` in ResourceLoaderImage"
Bartosz Dziewoński [Tue, 15 Jan 2019 19:28:30 +0000 (20:28 +0100)]
resourceloader: Avoid toplevel `<title>` under `<g>` in ResourceLoaderImage
While it shouldn't be causing any rendering problems,
doing so is semantically incorrect.
Bug: T213507
Change-Id: Ic86cd2bf3028eb24ad60db7ffa9498dd86edd4a5
Thiemo Kreuz [Tue, 15 Jan 2019 11:36:04 +0000 (12:36 +0100)]
Add missing "@return StatusValue" to all abstract do… methods
All implementations do this, and all callers expect this. I wonder how
the documentation for this detail got lost?
Change-Id: If4977c9f4032ca5d93ea91f49cdc70f7ef1175ba
Fomafix [Tue, 15 Jan 2019 19:30:48 +0000 (20:30 +0100)]
AllMessagesTablePager: Simplify language handling
wfGetLangObj always returns a Language object and never returns null.
The ?? operator never reached the fallback $contLang.
Message::inLanguage supports language code strings and Language objects.
Language code strings get converted to a Language object. So directly
pass the available Language object.
Change-Id: I5e13d6350df8b9b0261c853939d3485c4ed835cd
Thiemo Kreuz [Tue, 15 Jan 2019 15:04:58 +0000 (16:04 +0100)]
Add missing empty lines between methods
This might hint at an edge-case in the PHP CodeSniffer sniff that should
detect if methods are separated by a single empty line. Feel free to
investigate. I, personally, can't invest more time in this than
suggesting this quick fix.
Change-Id: Ib3c60eac76f255b4fe929f7933de256222716576
Thiemo Kreuz [Wed, 9 Jan 2019 16:24:36 +0000 (17:24 +0100)]
Safe replacement of a lot of `!count()` with `=== []`
This was originally a global search and replace. I manually checked all
replacements and reverted them if (due to the lack of type hints) either
null (that would be 0 when counted) or a Countable object can end in the
variable or property in question.
Now this patch only touches places where I'm sure nothing can break.
For the sanity of the honorable reviewers this patch is exclusively touching
negated counts. You should not find a single `!== []` in this patch, that
would be a mistake.
Change-Id: I5eafd4d8fccdb53a668be8e6f25a566f9c3a0a95
jenkins-bot [Tue, 15 Jan 2019 15:40:49 +0000 (15:40 +0000)]
Merge "Fix non-editing partial block creation on Special:Block"
Derick Alangi [Sat, 12 Jan 2019 19:39:51 +0000 (20:39 +0100)]
Setup: Avoid using count() function in any kind of loop(s)
Using count() function in loops makes things very slow because
of function overheads and this function gets called everytime the
loop runs meaning the bigger the value of the variable in count(),
the slower the loop as its value always gets computed as the loop
runs.
In this case, the use of foreach(...){} is possible in order to
perform the computation making it pretty fast hence improving the
performance.
Change-Id: Ie21fbf8f6acf72373d1da75023725b4592c80386
Thalia [Mon, 14 Jan 2019 14:58:42 +0000 (14:58 +0000)]
Fix non-editing partial block creation on Special:Block
Bug: T213707
Change-Id: Iaf8b3a6a0b2715808c9e6f8de94d315404368b12
jenkins-bot [Mon, 14 Jan 2019 22:12:23 +0000 (22:12 +0000)]
Merge "registration: Allow overriding attributes in tests"
jenkins-bot [Mon, 14 Jan 2019 20:54:47 +0000 (20:54 +0000)]
Merge "OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76"