OverlordQ [Fri, 3 Sep 2010 21:17:33 +0000 (21:17 +0000)]
Fix sequence renaming to be backwards-compat with older versions of PG. Needs merged with 1.16
Chad Horohoe [Fri, 3 Sep 2010 21:14:52 +0000 (21:14 +0000)]
Comment fix
Greg Sabino Mullane [Fri, 3 Sep 2010 21:08:16 +0000 (21:08 +0000)]
Bump cl_collation from smallint to a text
Aryeh Gregor [Fri, 3 Sep 2010 20:52:08 +0000 (20:52 +0000)]
Further categorylinks schema changes
Per review by Tim, I made two changes:
1) Fix cl_sortkey to be varbinary(255).
2) Expand cl_collation to varbinary(32), and change $wgCollationVersion
to $wgCategoryCollation, to account for the variety of collations we
might have. tinyint is too small. I could have gone with int, but
that's annoyingly inscrutable in practice, as we all know from namespace
fields.
To make the upgrade easier for non-trunk users, I updated the old patch
file to incorporate the new changes, using the updatelog table so that
people upgrading from 1.16 won't have to do two alters on categorylinks.
I didn't test the upgrade-from-1.16 code path yet, so if anyone tests
that and it seems not to break, commenting to that effect would be
appreciated.
Also removed wfDeprecated() from archive(). Do *not* add this to
functions that are still actively used in core. If you think this
function is so terrible that it really mustn't be used, remove callers
yourself, don't pester every single developer with messages in the hope
that someone else will do it for you.
Chad Horohoe [Fri, 3 Sep 2010 19:40:01 +0000 (19:40 +0000)]
Address comment on r63710, rm unused paramters
Alexandre Emsenhuber [Fri, 3 Sep 2010 18:53:19 +0000 (18:53 +0000)]
Moved OracleUpdater to its own file so that I can stop asking me why this file is missing
Alexandre Emsenhuber [Fri, 3 Sep 2010 18:24:42 +0000 (18:24 +0000)]
added file description header
Sam Reed [Fri, 3 Sep 2010 16:00:58 +0000 (16:00 +0000)]
Followup r72238, remove &
Sam Reed [Fri, 3 Sep 2010 15:53:08 +0000 (15:53 +0000)]
Followup r72234, pass $this->mConn instead of null
Chad Horohoe [Fri, 3 Sep 2010 14:24:40 +0000 (14:24 +0000)]
Followup r72108, put the history file in $IP/maintenance rather than the cwd. Also add it to svnignore.
Platonides [Fri, 3 Sep 2010 14:04:50 +0000 (14:04 +0000)]
Follow up r72164. The list was still there.
Platonides [Fri, 3 Sep 2010 14:00:01 +0000 (14:00 +0000)]
Follow up r72202 rename of Message::key() to wfMessage()
Sam Reed [Fri, 3 Sep 2010 01:06:06 +0000 (01:06 +0000)]
Widen header documentation
Priyanka Dhanda [Fri, 3 Sep 2010 00:57:56 +0000 (00:57 +0000)]
Fixing bad cpmmand to make phpunit work r72250
Trevor Parscal [Fri, 3 Sep 2010 00:48:22 +0000 (00:48 +0000)]
Actually does what r72249 claimed to do.
Trevor Parscal [Fri, 3 Sep 2010 00:41:52 +0000 (00:41 +0000)]
Fixed PHPUnit < 3.5 compatibiliy breaking change r72248, now we automatically use the new/old way by checking for 'PHPUnit/Autoload.php'.
Trevor Parscal [Fri, 3 Sep 2010 00:31:52 +0000 (00:31 +0000)]
Using PHPUnit/Autoload.php instead of trying to include everything by hand all the time.
Sam Reed [Thu, 2 Sep 2010 23:43:14 +0000 (23:43 +0000)]
Partial revert of r72240
Sam Reed [Thu, 2 Sep 2010 23:37:15 +0000 (23:37 +0000)]
Align URL's
Sam Reed [Thu, 2 Sep 2010 23:12:47 +0000 (23:12 +0000)]
Remove unused global
Simplify some logic
Sam Reed [Thu, 2 Sep 2010 22:20:00 +0000 (22:20 +0000)]
Comment out some unused array declarations
Move some comments
Sam Reed [Thu, 2 Sep 2010 22:15:20 +0000 (22:15 +0000)]
Add some $retval = '' before some wfShellExec
Sam Reed [Thu, 2 Sep 2010 22:11:32 +0000 (22:11 +0000)]
$file->group to $this->group
Sam Reed [Thu, 2 Sep 2010 22:08:09 +0000 (22:08 +0000)]
$result = '' in Title->checkPermissionHooks
Fixup $session in ApiWatchTest
Jack Phoenix [Thu, 2 Sep 2010 21:56:14 +0000 (21:56 +0000)]
coding style tweaks
Sam Reed [Thu, 2 Sep 2010 21:54:53 +0000 (21:54 +0000)]
Fixup some method calls with missing parameters
Jack Phoenix [Thu, 2 Sep 2010 21:43:04 +0000 (21:43 +0000)]
trim trailing whitespace
Sam Reed [Thu, 2 Sep 2010 21:38:45 +0000 (21:38 +0000)]
Followup r72207, uc isn't static
Sam Reed [Thu, 2 Sep 2010 20:52:01 +0000 (20:52 +0000)]
Per r72181, refactor isInCategory into ArticleAssessmentPilot
Sam Reed [Thu, 2 Sep 2010 20:48:02 +0000 (20:48 +0000)]
Simplify some returns, remove some whitespace
Indent on a switch
Sam Reed [Thu, 2 Sep 2010 20:11:01 +0000 (20:11 +0000)]
Followup r72200, cast return to bool
Alexandre Emsenhuber [Thu, 2 Sep 2010 19:35:38 +0000 (19:35 +0000)]
Removed leading whitespace
Raimond Spekking [Thu, 2 Sep 2010 19:30:22 +0000 (19:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-02 19:00:00 UTC)
Leons Petrazickis [Thu, 2 Sep 2010 19:10:54 +0000 (19:10 +0000)]
Based on r72134 feedback, applied spacing conventions from MediaWiki style guide, eliminated one-line ifs, wrapped all lines at less than 80 chars, and improved comments a bit.
Ryan Kaldari [Thu, 2 Sep 2010 18:05:58 +0000 (18:05 +0000)]
Adding helpful comments
Niklas Laxström [Thu, 2 Sep 2010 17:12:56 +0000 (17:12 +0000)]
One step forward with the Message class.
wfMessage can be used now. Later the old wfMsg* function will be changed to just wrappers over the new class.
Sam Reed [Thu, 2 Sep 2010 16:03:59 +0000 (16:03 +0000)]
Followup r72181, condense code, use selectRow()
Sam Reed [Wed, 1 Sep 2010 23:58:26 +0000 (23:58 +0000)]
Add a "isInCategory" function to check if a specific title is in a certain category
Leons Petrazickis [Wed, 1 Sep 2010 22:37:19 +0000 (22:37 +0000)]
Reverting some of r72166 and fixing the $wgDBport collision between Postgres and DB2 in a different way.
Leons Petrazickis [Wed, 1 Sep 2010 21:06:42 +0000 (21:06 +0000)]
Completed removal of $wgDBport_db2 in favour of regular $wgDBport begun by platonides in r69918.
Removed $wgDBcataloged based on discussion with platonides for r45755. All DB2 connections are now uncataloged. There is no performance difference.
Now using DB2 persistent connections.
Removed uniqueness constraint on user_groups table index in DB2 schema.
Raimond Spekking [Wed, 1 Sep 2010 21:05:53 +0000 (21:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-01 20:55:00 UTC)
Chad Horohoe [Wed, 1 Sep 2010 21:01:46 +0000 (21:01 +0000)]
Fix author list duplication.
Alexandre Emsenhuber [Wed, 1 Sep 2010 19:36:18 +0000 (19:36 +0000)]
Standardised file description headers:
* added @file where needed
* replaced @copyright and @license with GPL header and copyright notice
Alexandre Emsenhuber [Wed, 1 Sep 2010 19:30:41 +0000 (19:30 +0000)]
invert without namespace doesn't do anything, so ignore it
Alexandre Emsenhuber [Wed, 1 Sep 2010 19:24:08 +0000 (19:24 +0000)]
Don't show the namespace list (and members) since we don't use it
Chad Horohoe [Wed, 1 Sep 2010 19:09:27 +0000 (19:09 +0000)]
Add getConnection() for Oracle
Chad Horohoe [Wed, 1 Sep 2010 19:05:52 +0000 (19:05 +0000)]
Stray semicolon, followup r72150
Chad Horohoe [Wed, 1 Sep 2010 19:03:56 +0000 (19:03 +0000)]
Move createTables() up a level, this code was practically identical
Chad Horohoe [Wed, 1 Sep 2010 18:52:06 +0000 (18:52 +0000)]
Deprecate archive() in favor of DatabaseBase::patchPath()
Max Semenik [Wed, 1 Sep 2010 18:24:56 +0000 (18:24 +0000)]
svn:eol-style=native
Chad Horohoe [Wed, 1 Sep 2010 18:16:05 +0000 (18:16 +0000)]
More duplication reduction
Leons Petrazickis [Wed, 1 Sep 2010 18:14:15 +0000 (18:14 +0000)]
DB2: Implemented prepared statements for INSERT and UPDATE to allow more than 32k of text data
DB2: New LIST_SET_PREPARED mode for DatabaseIbm_db2::makeList() that handles ? tokens in prepared UPDATE statement
DB2: General fixes for DB2 database schema
DB2: Factored out foreign key definitions into foreignkeys.sql so that more can be added down the line without messing with the main schema
DB2: Better limit and offset support
Chad Horohoe [Wed, 1 Sep 2010 18:10:02 +0000 (18:10 +0000)]
Reduce some duplication, just implement stub in parent
Chad Horohoe [Wed, 1 Sep 2010 17:46:07 +0000 (17:46 +0000)]
Skip install entirely if we did an upgrade
Chad Horohoe [Wed, 1 Sep 2010 17:15:25 +0000 (17:15 +0000)]
Call time pass-by-ref
Mark A. Hershberger [Wed, 1 Sep 2010 16:58:44 +0000 (16:58 +0000)]
fill out appendQuery() for FauxRequest — probably should be refactored
into the parent class, but the parent uses $_GET where we have $this->data
Sam Reed [Wed, 1 Sep 2010 16:47:21 +0000 (16:47 +0000)]
* (bug 24166) API error when using rvprop=tags
Move addition of revision table to after other joins
Raimond Spekking [Wed, 1 Sep 2010 16:16:30 +0000 (16:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-01 15:44:00 UTC)
Chad Horohoe [Wed, 1 Sep 2010 14:30:47 +0000 (14:30 +0000)]
$_ENV['HOME'] might not exist for everyone, doesn't on OSX
Chad Horohoe [Wed, 1 Sep 2010 14:16:23 +0000 (14:16 +0000)]
Don't show "older edit" when no older edit available. Based on patch by Umherirrender
Niklas Laxström [Wed, 1 Sep 2010 11:25:04 +0000 (11:25 +0000)]
Update Doxyfile
Niklas Laxström [Wed, 1 Sep 2010 08:25:55 +0000 (08:25 +0000)]
file_exists can emit warnings under safe mode... silence those for diff and diff3
Adam Miller [Tue, 31 Aug 2010 22:41:22 +0000 (22:41 +0000)]
follow up to r72055 - fixing the discussion tab
Adam Miller [Tue, 31 Aug 2010 21:52:51 +0000 (21:52 +0000)]
Fix for bug 24906
Sam Reed [Tue, 31 Aug 2010 21:06:01 +0000 (21:06 +0000)]
ApiBase.php:
"Don't show No more than 500 ( for bots) allowed" when MAX2 isn't set
Trim trailing whitespace from Database.php
Raimond Spekking [Tue, 31 Aug 2010 18:37:00 +0000 (18:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-31 18:22:00 UTC)
Aryeh Gregor [Tue, 31 Aug 2010 17:58:50 +0000 (17:58 +0000)]
Fix three test failures if project contains space
It was expecting "Test_Wiki" instead of "Test Wiki". These Language
methods are very poorly named, they should use Text vs. Dbkey (like
Title) instead of FormattedText vs. Text.
Greg Sabino Mullane [Tue, 31 Aug 2010 14:35:56 +0000 (14:35 +0000)]
Add in new categorylinks columns.
Daniel Kinzler [Tue, 31 Aug 2010 14:08:45 +0000 (14:08 +0000)]
introducing Generic::verifyFileHook() to let media handlers do the verification on upload. triggered from UploadBase:verifyFile, like the UploadVerifyFile hook.
Daniel Kinzler [Tue, 31 Aug 2010 13:47:24 +0000 (13:47 +0000)]
Follow-up to r71944: Interoducing MimeMagic::improveTypeFromExtension() for two reasons:
a) avoid redundant inspection of file contents when validating uploads, caused by multiple calls to guessMimeType
b) deprecated obscure use of the file extension when guessing mime types, using an explicit call to improveTypeFromExtension() instead
Note that File::getPropsFromPath() will now return an additional field: $props['file-mime'] contains the mime type as determined solely from the file's content, $props['mime'] contains the type that was derived considering the file extension too.
Platonides [Tue, 31 Aug 2010 13:16:42 +0000 (13:16 +0000)]
Move FileUpload hook out of the transaction.
FileSearch relied on the article not existing to detect if it's a but it was broken: always detected it as a reupload.
Add a new parameter to the hook to detect reuploads.
Fixed other issues on FileSearch extension.
Platonides [Tue, 31 Aug 2010 11:12:33 +0000 (11:12 +0000)]
(Bug 20744) - Wiki forgets about an uploaded file
(Bug 24978) - "A file disappeared" thread on Commons:VP
Only save the LocalFile to memcache after the db entry has been commited.
Otherwise, when the transaction fails, the file apparently succeeded, but
after a week (memcached expiry) it disappears.
Fixes bug 20744 and bug 24978. Found by the Great Domas.
The correlation with db problems is probably just that in such case there are more transactions get rollbacked.
Derk-Jan Hartman [Tue, 31 Aug 2010 11:01:00 +0000 (11:01 +0000)]
Followup r71942. Documentation fix, the mime passed is a string, not an object.
Daniel Kinzler [Tue, 31 Aug 2010 09:38:11 +0000 (09:38 +0000)]
reverting r71944 as per TheDJ's comment. Will investigate a better way to avoid redundant mime guesses
Siebrand Mazeland [Tue, 31 Aug 2010 06:32:18 +0000 (06:32 +0000)]
Localisation updates for core messages from translatewiki.net
* Fix translator messup for French.
Ryan Kaldari [Tue, 31 Aug 2010 00:33:14 +0000 (00:33 +0000)]
Fixing comment so that method documentation isn't broken
Siebrand Mazeland [Mon, 30 Aug 2010 21:00:57 +0000 (21:00 +0000)]
Localisation updates for core messages from translatewiki.net
* Minangkabau (min) (new)
Sam Reed [Mon, 30 Aug 2010 20:28:32 +0000 (20:28 +0000)]
Spaces and braces
Raimond Spekking [Mon, 30 Aug 2010 19:13:28 +0000 (19:13 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-30 18:48:00 UTC)
Chad Horohoe [Mon, 30 Aug 2010 19:07:09 +0000 (19:07 +0000)]
Tweak SpecialRecentChangesQuery hook. Need to be able to modify selected fields on RCL (part 1 for bug 23916)
Niklas Laxström [Mon, 30 Aug 2010 18:16:43 +0000 (18:16 +0000)]
Avoid stupid queries in LinkHolderArray
Title::isAlwaysKnown will return true for all existing special pages, so the rest don't exists
Chad Horohoe [Mon, 30 Aug 2010 16:52:51 +0000 (16:52 +0000)]
Get rid of PHP4-style constructors
Chad Horohoe [Mon, 30 Aug 2010 14:23:52 +0000 (14:23 +0000)]
Mark wfSeedRandom() for removal in next version. Not used anywhere
Daniel Kinzler [Mon, 30 Aug 2010 12:51:44 +0000 (12:51 +0000)]
as per r71789: don't guess mime type again, that's expensive. Re-use the value from FileProps.
Daniel Kinzler [Mon, 30 Aug 2010 12:10:02 +0000 (12:10 +0000)]
interoduced new hoop in Uploadbase::verifyFile, as per comments to r71789
Aryeh Gregor [Sun, 29 Aug 2010 21:46:29 +0000 (21:46 +0000)]
RELEASE-NOTES for r71903
Aryeh Gregor [Sun, 29 Aug 2010 21:40:27 +0000 (21:40 +0000)]
Make SpecialUpload members public again
These were made protected in r57868 with no explanation, and it broke
extensions. See bug 24981, which points out that there's no longer any
way for extensions to edit things like $mComment from the
UploadForm:BeforeProcessing hook.
Will backport to 1.16, as a regression from 1.15.
Aryeh Gregor [Sun, 29 Aug 2010 21:21:57 +0000 (21:21 +0000)]
Fix category count when category table out of sync
This should fix a regression from my category sort work, caused by not
accounting for the the fact that $this->from and $this->until were
changed to arrays. Wrong counts for the number of pages in the category
might have been displayed in some cases.
Platonides [Sun, 29 Aug 2010 19:11:23 +0000 (19:11 +0000)]
Follow up r32776.
$log->addEntry got added an extra indentation, which was wrong.
Functionality was right. It goes *outside* the if
Aryeh Gregor [Sun, 29 Aug 2010 19:07:06 +0000 (19:07 +0000)]
Use <<<HTML for vim docstring syntax highlighting
This way vim highlights the docstring as HTML instead of plaintext,
which is nice.
Raimond Spekking [Sun, 29 Aug 2010 19:04:07 +0000 (19:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-29 18:53:00 UTC)
Chad Horohoe [Sun, 29 Aug 2010 13:06:22 +0000 (13:06 +0000)]
Partial revert r71363. I lied, these are used. They're just not documented for crap
Siebrand Mazeland [Sun, 29 Aug 2010 11:40:28 +0000 (11:40 +0000)]
(bug 24794) Update Tatar link trail.
Andrew Garrett [Sun, 29 Aug 2010 03:08:15 +0000 (03:08 +0000)]
Unmerging r71867. Merge-conflicts with some things Nikerabbit was doing. He broke it, leaving him to fix it for now :-)
Andrew Garrett [Sun, 29 Aug 2010 03:03:28 +0000 (03:03 +0000)]
Fix bug introduced in untested r71576. getNamespaces() did not use getCanonicalNamespaces for backwards-compatibility with 1.16wmf4 :-)
Siebrand Mazeland [Sat, 28 Aug 2010 23:52:46 +0000 (23:52 +0000)]
Localisation updates for core messages from translatewiki.net
Raimond Spekking [Sat, 28 Aug 2010 19:25:37 +0000 (19:25 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-08-28 19:12:00 UTC)
Alexandre Emsenhuber [Sat, 28 Aug 2010 12:27:29 +0000 (12:27 +0000)]
Reuse code from updateRestrictions.php in do_restrictions_update() instead of having its own code
Sam Reed [Sat, 28 Aug 2010 01:18:18 +0000 (01:18 +0000)]
Describe user property in ApiQueryAllimages
Add userid to ApiQueryProtectedTitles
bug 19195
Sam Reed [Sat, 28 Aug 2010 01:09:21 +0000 (01:09 +0000)]
Bug 19195 - Make user IDs more readily available with the API
Rest of user props done