2e6bf37db80f552a72f5898cecb8f8fbfd2f4c72
[lhc/web/wiklou.git] / tests / phpunit / structure / ResourcesTest.php
1 <?php
2 /**
3 * Sanity checks for making sure registered resources are sane.
4 *
5 * @file
6 * @author Antoine Musso
7 * @author Niklas Laxström
8 * @author Santhosh Thottingal
9 * @author Timo Tijhof
10 * @copyright © 2012, Antoine Musso
11 * @copyright © 2012, Niklas Laxström
12 * @copyright © 2012, Santhosh Thottingal
13 * @copyright © 2012, Timo Tijhof
14 *
15 */
16 class ResourcesTest extends MediaWikiTestCase {
17
18 /**
19 * @dataProvider provideResourceFiles
20 */
21 public function testFileExistence( $filename, $module, $resource ) {
22 $this->assertFileExists( $filename,
23 "File '$resource' referenced by '$module' must exist."
24 );
25 }
26
27 /**
28 * @dataProvider provideMediaStylesheets
29 */
30 public function testStyleMedia( $moduleName, $media, $filename, $css ) {
31 $cssText = CSSMin::minify( $css->cssText );
32
33 $this->assertTrue(
34 strpos( $cssText, '@media' ) === false,
35 'Stylesheets should not both specify "media" and contain @media'
36 );
37 }
38
39 public function testVersionHash() {
40 $data = self::getAllModules();
41 foreach ( $data['modules'] as $moduleName => $module ) {
42 $version = $module->getVersionHash( $data['context'] );
43 $this->assertEquals( 7, strlen( $version ), "$moduleName must use ResourceLoader::makeHash" );
44 }
45 }
46
47 /**
48 * Verify that nothing explicitly depends on the 'jquery' and 'mediawiki' modules.
49 * They are always loaded, depending on them is unsupported and leads to unexpected behaviour.
50 * TODO Modules can dynamically choose dependencies based on context. This method does not
51 * test such dependencies. The same goes for testMissingDependencies() and
52 * testUnsatisfiableDependencies().
53 */
54 public function testIllegalDependencies() {
55 $data = self::getAllModules();
56 $illegalDeps = [ 'jquery', 'mediawiki' ];
57
58 /** @var ResourceLoaderModule $module */
59 foreach ( $data['modules'] as $moduleName => $module ) {
60 foreach ( $illegalDeps as $illegalDep ) {
61 $this->assertNotContains(
62 $illegalDep,
63 $module->getDependencies( $data['context'] ),
64 "Module '$moduleName' must not depend on '$illegalDep'"
65 );
66 }
67 }
68 }
69
70 /**
71 * Verify that all modules specified as dependencies of other modules actually exist.
72 */
73 public function testMissingDependencies() {
74 $data = self::getAllModules();
75 $validDeps = array_keys( $data['modules'] );
76
77 /** @var ResourceLoaderModule $module */
78 foreach ( $data['modules'] as $moduleName => $module ) {
79 foreach ( $module->getDependencies( $data['context'] ) as $dep ) {
80 $this->assertContains(
81 $dep,
82 $validDeps,
83 "The module '$dep' required by '$moduleName' must exist"
84 );
85 }
86 }
87 }
88
89 /**
90 * Verify that all specified messages actually exist.
91 */
92 public function testMissingMessages() {
93 $data = self::getAllModules();
94 $lang = Language::factory( 'en' );
95
96 /** @var ResourceLoaderModule $module */
97 foreach ( $data['modules'] as $moduleName => $module ) {
98 foreach ( $module->getMessages() as $msgKey ) {
99 $this->assertTrue(
100 wfMessage( $msgKey )->useDatabase( false )->inLanguage( $lang )->exists(),
101 "Message '$msgKey' required by '$moduleName' must exist"
102 );
103 }
104 }
105 }
106
107 /**
108 * Verify that all dependencies of all modules are always satisfiable with the 'targets' defined
109 * for the involved modules.
110 *
111 * Example: A depends on B. A has targets: mobile, desktop. B has targets: desktop. Therefore the
112 * dependency is sometimes unsatisfiable: it's impossible to load module A on mobile.
113 */
114 public function testUnsatisfiableDependencies() {
115 $data = self::getAllModules();
116
117 /** @var ResourceLoaderModule $module */
118 foreach ( $data['modules'] as $moduleName => $module ) {
119 $moduleTargets = $module->getTargets();
120 foreach ( $module->getDependencies( $data['context'] ) as $dep ) {
121 if ( !isset( $data['modules'][$dep] ) ) {
122 // Missing dependencies reported by testMissingDependencies
123 continue;
124 }
125 $targets = $data['modules'][$dep]->getTargets();
126 foreach ( $moduleTargets as $moduleTarget ) {
127 $this->assertContains(
128 $moduleTarget,
129 $targets,
130 "The module '$moduleName' must not have target '$moduleTarget' "
131 . "because its dependency '$dep' does not have it"
132 );
133 }
134 }
135 }
136 }
137
138 /**
139 * CSSMin::getLocalFileReferences should ignore url(...) expressions
140 * that have been commented out.
141 */
142 public function testCommentedLocalFileReferences() {
143 $basepath = __DIR__ . '/../data/css/';
144 $css = file_get_contents( $basepath . 'comments.css' );
145 $files = CSSMin::getLocalFileReferences( $css, $basepath );
146 $expected = [ $basepath . 'not-commented.gif' ];
147 $this->assertArrayEquals(
148 $expected,
149 $files,
150 'Url(...) expression in comment should be omitted.'
151 );
152 }
153
154 /**
155 * Get all registered modules from ResouceLoader.
156 * @return array
157 */
158 protected static function getAllModules() {
159 global $wgEnableJavaScriptTest;
160
161 // Test existance of test suite files as well
162 // (can't use setUp or setMwGlobals because providers are static)
163 $org_wgEnableJavaScriptTest = $wgEnableJavaScriptTest;
164 $wgEnableJavaScriptTest = true;
165
166 // Initialize ResourceLoader
167 $rl = new ResourceLoader();
168
169 $modules = [];
170
171 foreach ( $rl->getModuleNames() as $moduleName ) {
172 $modules[$moduleName] = $rl->getModule( $moduleName );
173 }
174
175 // Restore settings
176 $wgEnableJavaScriptTest = $org_wgEnableJavaScriptTest;
177
178 return [
179 'modules' => $modules,
180 'resourceloader' => $rl,
181 'context' => new ResourceLoaderContext( $rl, new FauxRequest() )
182 ];
183 }
184
185 /**
186 * Get all stylesheet files from modules that are an instance of
187 * ResourceLoaderFileModule (or one of its subclasses).
188 */
189 public static function provideMediaStylesheets() {
190 $data = self::getAllModules();
191 $cases = [];
192
193 foreach ( $data['modules'] as $moduleName => $module ) {
194 if ( !$module instanceof ResourceLoaderFileModule ) {
195 continue;
196 }
197
198 $reflectedModule = new ReflectionObject( $module );
199
200 $getStyleFiles = $reflectedModule->getMethod( 'getStyleFiles' );
201 $getStyleFiles->setAccessible( true );
202
203 $readStyleFile = $reflectedModule->getMethod( 'readStyleFile' );
204 $readStyleFile->setAccessible( true );
205
206 $styleFiles = $getStyleFiles->invoke( $module, $data['context'] );
207
208 $flip = $module->getFlip( $data['context'] );
209
210 foreach ( $styleFiles as $media => $files ) {
211 if ( $media && $media !== 'all' ) {
212 foreach ( $files as $file ) {
213 $cases[] = [
214 $moduleName,
215 $media,
216 $file,
217 // XXX: Wrapped in an object to keep it out of PHPUnit output
218 (object)[
219 'cssText' => $readStyleFile->invoke(
220 $module,
221 $file,
222 $flip,
223 $data['context']
224 )
225 ],
226 ];
227 }
228 }
229 }
230 }
231
232 return $cases;
233 }
234
235 /**
236 * Get all resource files from modules that are an instance of
237 * ResourceLoaderFileModule (or one of its subclasses).
238 *
239 * Since the raw data is stored in protected properties, we have to
240 * overrride this through ReflectionObject methods.
241 */
242 public static function provideResourceFiles() {
243 $data = self::getAllModules();
244 $cases = [];
245
246 // See also ResourceLoaderFileModule::__construct
247 $filePathProps = [
248 // Lists of file paths
249 'lists' => [
250 'scripts',
251 'debugScripts',
252 'styles',
253 ],
254
255 // Collated lists of file paths
256 'nested-lists' => [
257 'languageScripts',
258 'skinScripts',
259 'skinStyles',
260 ],
261 ];
262
263 foreach ( $data['modules'] as $moduleName => $module ) {
264 if ( !$module instanceof ResourceLoaderFileModule ) {
265 continue;
266 }
267
268 $reflectedModule = new ReflectionObject( $module );
269
270 $files = [];
271
272 foreach ( $filePathProps['lists'] as $propName ) {
273 $property = $reflectedModule->getProperty( $propName );
274 $property->setAccessible( true );
275 $list = $property->getValue( $module );
276 foreach ( $list as $key => $value ) {
277 // 'scripts' are numeral arrays.
278 // 'styles' can be numeral or associative.
279 // In case of associative the key is the file path
280 // and the value is the 'media' attribute.
281 if ( is_int( $key ) ) {
282 $files[] = $value;
283 } else {
284 $files[] = $key;
285 }
286 }
287 }
288
289 foreach ( $filePathProps['nested-lists'] as $propName ) {
290 $property = $reflectedModule->getProperty( $propName );
291 $property->setAccessible( true );
292 $lists = $property->getValue( $module );
293 foreach ( $lists as $list ) {
294 foreach ( $list as $key => $value ) {
295 // We need the same filter as for 'lists',
296 // due to 'skinStyles'.
297 if ( is_int( $key ) ) {
298 $files[] = $value;
299 } else {
300 $files[] = $key;
301 }
302 }
303 }
304 }
305
306 // Get method for resolving the paths to full paths
307 $method = $reflectedModule->getMethod( 'getLocalPath' );
308 $method->setAccessible( true );
309
310 // Populate cases
311 foreach ( $files as $file ) {
312 $cases[] = [
313 $method->invoke( $module, $file ),
314 $moduleName,
315 ( $file instanceof ResourceLoaderFilePath ? $file->getPath() : $file ),
316 ];
317 }
318
319 // To populate missingLocalFileRefs. Not sure how sane this is inside this test...
320 $module->readStyleFiles(
321 $module->getStyleFiles( $data['context'] ),
322 $module->getFlip( $data['context'] ),
323 $data['context']
324 );
325
326 $property = $reflectedModule->getProperty( 'missingLocalFileRefs' );
327 $property->setAccessible( true );
328 $missingLocalFileRefs = $property->getValue( $module );
329
330 foreach ( $missingLocalFileRefs as $file ) {
331 $cases[] = [
332 $file,
333 $moduleName,
334 $file,
335 ];
336 }
337 }
338
339 return $cases;
340 }
341 }