From 07aef8f753be6b0860a855eeecb7f0f1a66ce9d9 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Mon, 18 Aug 2014 00:04:57 +0200
Subject: [PATCH] Remove EnhancedChangesList::arrow() and friends

Not used in core, the only usage outside removed in Ieb5bb6f9.

Also removed two now-unused files from skins/common/.

Bug: 69675
Change-Id: Ia0e9fc2af25af903db085f2a05c04dcd9aff213e
---
 RELEASE-NOTES-1.24                       |   1 +
 includes/changes/EnhancedChangesList.php |  44 -----------------------
 skins/common/images/Arr_l.png            | Bin 205 -> 0 bytes
 skins/common/images/Arr_r.png            | Bin 206 -> 0 bytes
 4 files changed, 1 insertion(+), 44 deletions(-)
 delete mode 100644 skins/common/images/Arr_l.png
 delete mode 100644 skins/common/images/Arr_r.png

diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24
index 30d59bad16..d5446ae9f6 100644
--- a/RELEASE-NOTES-1.24
+++ b/RELEASE-NOTES-1.24
@@ -333,6 +333,7 @@ changes to languages because of Bugzilla reports.
 * Action::checkCanExecute() no longer has a return value.
 * Removed cleanupForIRC(), loadFromCurRow(), newFromCurRow(), notifyRC2UDP()
   and sendToUDP() from RecentChange.php. (deprecated since 1.22)
+* Removed EnhancedChangesList::arrow(), sideArrow(), downArrow(), spacerArrow().
 
 ==== Renamed classes ====
 * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression
diff --git a/includes/changes/EnhancedChangesList.php b/includes/changes/EnhancedChangesList.php
index b471ea5ebe..82e36d95bf 100644
--- a/includes/changes/EnhancedChangesList.php
+++ b/includes/changes/EnhancedChangesList.php
@@ -474,50 +474,6 @@ class EnhancedChangesList extends ChangesList {
 		return $r;
 	}
 
-	/**
-	 * Generate HTML for an arrow or placeholder graphic
-	 * @param string $dir One of '', 'd', 'l', 'r'
-	 * @param string $alt
-	 * @param string $title
-	 * @return string HTML "<img>" tag
-	 */
-	protected function arrow( $dir, $alt = '', $title = '' ) {
-		global $wgStylePath;
-		$encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
-		$encAlt = htmlspecialchars( $alt );
-		$encTitle = htmlspecialchars( $title );
-
-		return "<img src=\"$encUrl\" width=\"12\" height=\"12\" alt=\"$encAlt\" title=\"$encTitle\" />";
-	}
-
-	/**
-	 * Generate HTML for a right- or left-facing arrow,
-	 * depending on language direction.
-	 * @return string HTML "<img>" tag
-	 */
-	protected function sideArrow() {
-		$dir = $this->getLanguage()->isRTL() ? 'l' : 'r';
-
-		return $this->arrow( $dir, '+', $this->msg( 'rc-enhanced-expand' )->text() );
-	}
-
-	/**
-	 * Generate HTML for a down-facing arrow
-	 * depending on language direction.
-	 * @return string HTML "<img>" tag
-	 */
-	protected function downArrow() {
-		return $this->arrow( 'd', '-', $this->msg( 'rc-enhanced-hide' )->text() );
-	}
-
-	/**
-	 * Generate HTML for a spacer image
-	 * @return string HTML "<img>" tag
-	 */
-	protected function spacerArrow() {
-		return $this->arrow( '', codepointToUtf8( 0xa0 ) ); // non-breaking space
-	}
-
 	/**
 	 * Enhanced RC ungrouped line.
 	 *
diff --git a/skins/common/images/Arr_l.png b/skins/common/images/Arr_l.png
deleted file mode 100644
index 2246254f4265f381a816fec0a436515d2a8d3245..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 205
zcmeAS@N?(olHy`uVBq!ia0vp^JRr=$3?vg*uel1OYyx~jTpcwoC<m=li`vz>^07wj
zL1~AUg}Yu}xcfyVY?D{Xk;v3a^_YEy)9>v#{civM{Xk8IhKB4ys?L5%-rnBU)3Q$i
zg&0eM{DK)Ap4~_Ta_l`_978JNa!<GmH5l+X2gU@geEP54)z~fa>H05Q&YX4=iT>)I
zr?sehPUr+?cmIeZrT01&n3v=;{A6g(@43j{^_fZ1e5!;m&?p8^S3j3^P6<r_gZD{^

diff --git a/skins/common/images/Arr_r.png b/skins/common/images/Arr_r.png
deleted file mode 100644
index 467a555a4ddfb7eb746377d16d454bbb971bbcd8..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 206
zcmeAS@N?(olHy`uVBq!ia0vp^JRr=$3?vg*uel1OYyx~jTpcwoC<m=li`unt*Gp-K
z7LC}0ohu*j-@hLyf8p+z!s++aWA?ENsqQ%a&d|`%tK^7E*rv$TN@u?$Z*T7ot1BQ2
z7)yfuf*Bm1-ADs+96VhdLn`7zPe$@J81OhdPAa+I`1}6W%vRN3`)odyK6}D{PLFA7
z=Z@3t-nTADUpVuYG1%$$fh&`a##CH$(SLT6rHzU4#vwB{BcNFfp00i_>zopr05?rd
AvH$=8

-- 
2.20.1