From: Brion Vibber Date: Wed, 1 Jun 2011 22:35:03 +0000 (+0000) Subject: Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(), which... X-Git-Tag: 1.31.0-rc.0~29790 X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/%7B%7B%20url_for%28%27vote%27%2C%20idvote=vote.voteid%29%20%7D%7D?a=commitdiff_plain;h=29aedac7db8b9463f769695957f839039ec00e9d;p=lhc%2Fweb%2Fwiklou.git Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(), which both have some failing test cases and are incomplete --- diff --git a/includes/Cookie.php b/includes/Cookie.php index 10d95a7883..95a4599fd9 100644 --- a/includes/Cookie.php +++ b/includes/Cookie.php @@ -62,6 +62,9 @@ class Cookie { * A better method might be to use a blacklist like * http://publicsuffix.org/ * + * @fixme fails to detect 3-letter top-level domains + * @fixme fails to detect 2-letter top-level domains for single-domain use (probably not a big problem in practice, but there are test cases) + * * @param $domain String: the domain to validate * @param $originDomain String: (optional) the domain the cookie originates from * @return Boolean diff --git a/includes/HttpFunctions.php b/includes/HttpFunctions.php index b36011e94c..75dbbdf37c 100644 --- a/includes/HttpFunctions.php +++ b/includes/HttpFunctions.php @@ -125,6 +125,9 @@ class Http { * protocols, because we only want protocols that both cURL * and php support. * + * @fixme this is wildly inaccurate and fails to actually check most stuff + * @fixme do we actually intend to have FTP support here? Does it work consistently? + * * @param $uri Mixed: URI to check for validity * @returns Boolean */