From 8743c3a4676d778c161b745dc07816c36e326720 Mon Sep 17 00:00:00 2001
From: Liangent <liangent@gmail.com>
Date: Wed, 1 Aug 2012 21:09:41 +0800
Subject: [PATCH] (bug 24521) Move hard coded "code error!" to messages

Change-Id: I43f064ce577da9918fea7430e5bda0853af236e3
---
 languages/LanguageConverter.php    | 5 +++--
 languages/messages/MessagesEn.php  | 1 +
 languages/messages/MessagesQqq.php | 1 +
 maintenance/language/messages.inc  | 1 +
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/languages/LanguageConverter.php b/languages/LanguageConverter.php
index 455c64e54c..77e8249c03 100644
--- a/languages/LanguageConverter.php
+++ b/languages/LanguageConverter.php
@@ -1114,7 +1114,6 @@ class LanguageConverter {
 class ConverterRule {
 	var $mText; // original text in -{text}-
 	var $mConverter; // LanguageConverter object
-	var $mManualCodeError = '<strong class="error">code error!</strong>';
 	var $mRuleDisplay = '';
 	var $mRuleTitle = false;
 	var $mRules = '';// string : the text of the rules
@@ -1490,7 +1489,9 @@ class ConverterRule {
 			}
 		}
 		if ( $this->mRuleDisplay === false ) {
-			$this->mRuleDisplay = $this->mManualCodeError;
+			$this->mRuleDisplay = '<span class="error">'
+				. wfMessage( 'converter-manual-rule-error' )->inContentLanguage()->escaped()
+				. '</span>';
 		}
 
 		$this->generateConvTable();
diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index 590f6ac43b..c378c2c79d 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1497,6 +1497,7 @@ These arguments have been omitted.",
 'expansion-depth-exceeded-warning'        => 'Page exceeded the expansion depth',
 'parser-unstrip-loop-warning'             => 'Unstrip loop detected',
 'parser-unstrip-recursion-limit'          => 'Unstrip recursion limit exceeded ($1)',
+'converter-manual-rule-error'             => 'Error detected in manual language conversion rule',
 
 # "Undo" feature
 'undo-success' => 'The edit can be undone.
diff --git a/languages/messages/MessagesQqq.php b/languages/messages/MessagesQqq.php
index f9f793961a..ab3d3743b2 100644
--- a/languages/messages/MessagesQqq.php
+++ b/languages/messages/MessagesQqq.php
@@ -1069,6 +1069,7 @@ This warning may be encountered due to input text like &lt;ref>&lt;ref>&lt;ref>.
 
 "Unstrip" refers to the internal function of the parser, called \'unstrip\', which recursively puts the output of parser functions in the place of the parser function call and which would enter an infinite loop in the situation above. See also:
 *{{msg-mw|Parser-unstrip-loop-warning}}',
+'converter-manual-rule-error' => 'This message is shown when a manual conversion rule for the language converter has errors. For example it\'s not using the correct syntax, or not supplying text in all variants.',
 
 # "Undo" feature
 'undo-success' => 'Text on special page to confirm edit revert. You arrive on this page by clicking on the "undo" link on a revision history special page.
diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc
index 000517fa90..9d1fca768b 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -700,6 +700,7 @@ $wgMessageStructure = array(
 		'expansion-depth-exceeded-warning',
 		'parser-unstrip-loop-warning',
 		'parser-unstrip-recursion-limit',
+		'converter-manual-rule-error',
 	),
 	'undo' => array(
 		'undo-success',
-- 
2.20.1