Aaron Schulz [Sun, 25 Dec 2011 23:17:30 +0000 (23:17 +0000)]
Fixed undefined var from r106280
Siebrand Mazeland [Sun, 25 Dec 2011 23:09:26 +0000 (23:09 +0000)]
Bye, bye $wgExtensionAliasesFiles (deprecated in 1.16).
Krinkle [Sun, 25 Dec 2011 20:34:03 +0000 (20:34 +0000)]
typo; follows-up r107289
Krinkle [Sun, 25 Dec 2011 20:32:38 +0000 (20:32 +0000)]
[Core JS] Clean up and optimization mediawiki.util
* partial rewrite of updateTooltipAccessKeys, much shorter and a bit faster
-- Remove self-calling logic, totally unnecessary here
-- removing the .each() loop, using .attr()'s callback function instead
* directly calling util.toggleToc instead of triggering a click event
* strict comparison
* unquoted keys
* substitute single-use variable
Raimond Spekking [Sun, 25 Dec 2011 20:25:45 +0000 (20:25 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sun, 25 Dec 2011 20:23:54 +0000 (20:23 +0000)]
Use 'newsectionheaderdefaultlevel' message when previewing a new section so that it renders the same as when saving the page
Alexandre Emsenhuber [Sun, 25 Dec 2011 20:03:33 +0000 (20:03 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Sun, 25 Dec 2011 16:36:13 +0000 (16:36 +0000)]
And while I'm a it:
* Use the commented-out code ("MW 1.6" is way old and "Revision.php 1.26" sounds like CVS)
* Don't revert to a revision whose text was deleted
Alexandre Emsenhuber [Sun, 25 Dec 2011 16:26:53 +0000 (16:26 +0000)]
* Use WikiPage instead of Article to call doEdit()
* Pass the revision ID to doEdit() when reverting a page
Niklas Laxström [Sun, 25 Dec 2011 12:34:52 +0000 (12:34 +0000)]
* (bug 33367) Gendered namespaces for Czech
Niklas Laxström [Sun, 25 Dec 2011 12:32:41 +0000 (12:32 +0000)]
Whitespace
Siebrand Mazeland [Sun, 25 Dec 2011 09:48:37 +0000 (09:48 +0000)]
Fix incorrect encoding in RELEASE-NOTES-1.19 from r107258.
Siebrand Mazeland [Sun, 25 Dec 2011 09:42:00 +0000 (09:42 +0000)]
Rename no to nb (step 4/4): Change 'no' to 'nb' in remaining files.
Siebrand Mazeland [Sun, 25 Dec 2011 09:30:47 +0000 (09:30 +0000)]
Follow-up r107259: Also update $wgDummyLanguageCodes.
Siebrand Mazeland [Sun, 25 Dec 2011 09:27:07 +0000 (09:27 +0000)]
Rename no to nb (step 2/4): Re-add MessagesNo.php. Falls back to 'nb'.
Siebrand Mazeland [Sun, 25 Dec 2011 09:24:39 +0000 (09:24 +0000)]
Rename no to nb (step 2/4): Rename MessagesNo.php to MessagesNb.php and update Names.php and RELEASE-NOTES-1.19.
Siebrand Mazeland [Sun, 25 Dec 2011 09:20:43 +0000 (09:20 +0000)]
Remove MessagesNb.php pending rename of no to nb.
Robin Pepermans [Sun, 25 Dec 2011 02:54:02 +0000 (02:54 +0000)]
@since for r99863
Sam Reed [Sat, 24 Dec 2011 23:12:09 +0000 (23:12 +0000)]
Change require to require_once in extensions/README
Sam Reed [Sat, 24 Dec 2011 23:11:25 +0000 (23:11 +0000)]
Improve/add to documentation
Add braces
Explicitly define member variable
Sam Reed [Sat, 24 Dec 2011 23:09:45 +0000 (23:09 +0000)]
Followup r107011 per Krinkle - "mediawiki.api needs to declare the mediawiki.util dependency."
Alexandre Emsenhuber [Sat, 24 Dec 2011 17:03:59 +0000 (17:03 +0000)]
* Use local context to get messages
* Use Language::userTimeAndDate() instead of Language::timeanddate() to use user's timezone preference
Alexandre Emsenhuber [Sat, 24 Dec 2011 15:32:35 +0000 (15:32 +0000)]
Per Nikerabbit, follow-up r102024: removed uneeded variable
Niklas Laxström [Sat, 24 Dec 2011 14:40:59 +0000 (14:40 +0000)]
Followup r103945 - @since and whitespace
Aaron Schulz [Sat, 24 Dec 2011 00:57:10 +0000 (00:57 +0000)]
Fix r107197: removed 'lockmanager-fail-acquirelocks' key from messages.inc
Aaron Schulz [Sat, 24 Dec 2011 00:43:06 +0000 (00:43 +0000)]
* Follow-up r107195: these params are resource paths now, rather than hashes of the resource paths.
* Removed lockmanager-fail-acquirelocks message; a series of lockmanager-fail-acquirelock messages are now used instead.
Siebrand Mazeland [Sat, 24 Dec 2011 00:23:39 +0000 (00:23 +0000)]
Use hash key instead of key for lock manager messages. It was confusing translators.
Aaron Schulz [Sat, 24 Dec 2011 00:19:01 +0000 (00:19 +0000)]
FU r106752: fixed call to bogus function in LocalFile::getSha1()
Aaron Schulz [Sat, 24 Dec 2011 00:16:06 +0000 (00:16 +0000)]
In LockManager classes:
* Only use hash keys later on in the data flow rather than right when doLock() is called. This allows for error messages in Status objects to use human readable paths rather than ugly hash keys.
* Moved $locksHeld declaration duplication up to the base class.
* Fixed __destruct() in FSLockManager to not use bogus doSingleUnlock() lock type parameter.
Siebrand Mazeland [Sat, 24 Dec 2011 00:13:11 +0000 (00:13 +0000)]
Follow-up r107187, r107188: rebuild MessagesXx.php.
Benny Situ [Fri, 23 Dec 2011 23:55:39 +0000 (23:55 +0000)]
follow up to -r107187 - remove unused message key "column" from language file
Benny Situ [Fri, 23 Dec 2011 22:47:10 +0000 (22:47 +0000)]
bug24430 - patch from Chinchin, remove number of column for edit field in preference
Raimond Spekking [Fri, 23 Dec 2011 21:10:51 +0000 (21:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Fri, 23 Dec 2011 20:51:37 +0000 (20:51 +0000)]
* Use local context to get messages
* Use Language::userTimeAndDate() instead of Language::timeanddate()
John Du Hart [Fri, 23 Dec 2011 20:35:57 +0000 (20:35 +0000)]
Moving the flatlist option to HTMLFormField to prevent code duplication per hashar on r100551
Aaron Schulz [Fri, 23 Dec 2011 18:59:39 +0000 (18:59 +0000)]
In FileBackendBase/FileBackend:
* Changed concatenate to store to a specified temp FS file rather than a final storage destination. This makes it better fit the use case (chunked upload), so we can avoid extra copying around. Subclasses no longer have to implement this function now as well.
* Added extensionFromPath() helper function.
* Moved createInternal() up a bit and fixed @see comments pointing to the wrong functions.
In FSFileBackend:
* Use parent implementation of doConcatenateInternal().
In FileRepo/File:
* Added FileRepo::ALLOW_STALE and made thumbnail transforms use it.
Benny Situ [Fri, 23 Dec 2011 18:55:04 +0000 (18:55 +0000)]
Bugzilla bug11612 - Make watchlist max days preference setting reflect the max days in Recent Changes
Krinkle [Fri, 23 Dec 2011 17:03:25 +0000 (17:03 +0000)]
[Core JS] scan all /phase3/, change certain constructors to literals
* new String, new Boolean, new Number
-- should not be used since they don't compare very well:
; 5 !== new Number( 5 ) // true
; !!new Boolean( false ) // true, objects are truethy
-- If type conversion is intended, they should be used as
functions instead of constructors.
* new Array, new Object
-- literals are shorter, no point in not using them.
Rotem Liss [Fri, 23 Dec 2011 14:47:41 +0000 (14:47 +0000)]
Localization update for magic words in he.
Aaron Schulz [Fri, 23 Dec 2011 09:43:28 +0000 (09:43 +0000)]
* Added 'latest' parameter to functions that get information about a file. This will get the latest version among all storage nodes. Non-distributed backends can ignore this.
* In doOperations(), ignore 'nonLocking' unless 'ignoreErrors' is set. Split out a doOperationsInternal() function so the sanity check could go in doOperations().
* Moved getFileList() down a bit.
* Documentation tweaks.
Jan Gerber [Fri, 23 Dec 2011 09:30:02 +0000 (09:30 +0000)]
Use getPath, all operations are on filerepo level no need to get a local path. Follow up r107064
Aaron Schulz [Fri, 23 Dec 2011 07:41:23 +0000 (07:41 +0000)]
Follow-up r98698: Reduce amount of ipv6 spam in FileCacheBase::incrMissesRecent() per CR
Ryan Lane [Fri, 23 Dec 2011 01:26:52 +0000 (01:26 +0000)]
Fix a session invalidation error when using LdapAuthentication.
Rob Lanphier [Fri, 23 Dec 2011 00:22:01 +0000 (00:22 +0000)]
Applying patch from bug 33335 (from Erwin Dokter). Followup to r105280
and r106884.
* td.diff-deletedline gets a softer yellow background
* td.diff-addedline gets a lighter blue background,
* td.diff-context gets slightly lighter grey background.
* Instead of only the changed text being displayed with white-space:pre-wrap,
the entire line in a cell is.
* The font-size is changed from 'smaller' to 88%
Aaron Schulz [Thu, 22 Dec 2011 23:18:57 +0000 (23:18 +0000)]
Documentation fixes
Brion Vibber [Thu, 22 Dec 2011 23:12:44 +0000 (23:12 +0000)]
Add comments explaining that the funky multiple Location headers stuff is a CURL artifact, and that the code will need updating if bug 29232 is done (high-level handling of http redirects)
Followup r94881, r106948.
Krinkle [Thu, 22 Dec 2011 22:30:52 +0000 (22:30 +0000)]
rephrase r106992 release notes
Alexandre Emsenhuber [Thu, 22 Dec 2011 20:37:55 +0000 (20:37 +0000)]
Use local context to get messages
Raimond Spekking [Thu, 22 Dec 2011 20:15:58 +0000 (20:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Mark A. Hershberger [Thu, 22 Dec 2011 18:12:36 +0000 (18:12 +0000)]
I hate eol w/s
Robin Pepermans [Thu, 22 Dec 2011 15:47:44 +0000 (15:47 +0000)]
(bug 12262) Follow-up r102026: update ul margin in shared.css
Antoine Musso [Thu, 22 Dec 2011 13:42:14 +0000 (13:42 +0000)]
Use ⌘ in for Mac keyboard shortcuts
Looks better to the eye when playing with your User:foo/style.css
http://en.wikipedia.org/wiki/Command_key
Antoine Musso [Thu, 22 Dec 2011 13:35:37 +0000 (13:35 +0000)]
apply CSS::Janus when user preview its CSS style
follow up r94421
Jan Gerber [Thu, 22 Dec 2011 13:18:49 +0000 (13:18 +0000)]
- add comment to document us_chunk_inx in sql file
- fix chunk upload to work with recent filerepo changes
Follow up r104687
Max Semenik [Thu, 22 Dec 2011 11:11:59 +0000 (11:11 +0000)]
Fixed a typo in r107054
Antoine Musso [Thu, 22 Dec 2011 11:06:23 +0000 (11:06 +0000)]
do not evaluate '<?php' line
This happen when you are sending to eval.php a php file. The first line
is the string '<?php' which is passed to eval(). Boom!
This patch skip that string.
Example usage:
$ cat somefile.php
<?php
echo "Working!\n";
$
$ cat somefile.php | php maintenance/eval.php
Working!
$
Antoine Musso [Thu, 22 Dec 2011 09:25:47 +0000 (09:25 +0000)]
remove bug 31921 from 1.19 RN
Fix was merged in REL1_18 by r107046
Max Semenik [Thu, 22 Dec 2011 09:18:39 +0000 (09:18 +0000)]
Moved SQLite test .sql files to the common test data directory
Raimond Spekking [Thu, 22 Dec 2011 08:33:37 +0000 (08:33 +0000)]
Make apibase of $wgForeignFileRepos (InstantCommons) protocol relative too
Robin Pepermans [Thu, 22 Dec 2011 01:27:59 +0000 (01:27 +0000)]
Add some letters per https://incubator.wikimedia.org/w/index.php?diff=666382&oldid=664736
Aaron Schulz [Thu, 22 Dec 2011 01:06:19 +0000 (01:06 +0000)]
* FU r106752: de-uglified Setup.php by moving most of the b/c code into FileBackendGroup. Deferred registration of file backends and lock managers to the respective singleton() functions for the group objects.
* Refactored FileRepo::initZones() to require the specific zones; nothing was using it differently.
* Removed deleted zone check in deleteBatch(), a similar error will instead trigger with the initZones() call as needed.
* Added $wgLocalFileRepo comment.
* Updated tests.
Brian Wolff [Thu, 22 Dec 2011 00:51:43 +0000 (00:51 +0000)]
Update documentation on params method of Message class to indicate it can either be varags, or it can also
take an array of all the parameters as the first argument.
Aaron Schulz [Thu, 22 Dec 2011 00:43:11 +0000 (00:43 +0000)]
FU r105512: urldecode() the file and thumb name in wfExtractThumbParams() for 404 handling as needed.
Ian Baker [Thu, 22 Dec 2011 00:11:38 +0000 (00:11 +0000)]
added missing UploadStash exceptions to AutoLoader
Krinkle [Wed, 21 Dec 2011 23:56:02 +0000 (23:56 +0000)]
[mediawiki.api] bug fixes
* error callback of some convenience functions was broken. Second argument to get() is ajaxOptions, there is no third argument.
Krinkle [Wed, 21 Dec 2011 23:52:37 +0000 (23:52 +0000)]
[mediawiki.api] clean up
* Adding return values to most of the ajax functions so that the jqXHR object (originally returned by jQuery.ajax) is available. Some functions documented they already did this, some don't. Now they all do and are also documented as such.
* Renaming a few 'callback' arguments to 'success' to avoid confusion with 'error'.
* Removed unused variables
** mw.Api's instance this.url was unused
** var cachedToken was unused in mediawiki.api.titleblacklist.js
* Making closure argument order the same and referencing mediaWiki as a global (mw is something thought not to be a global but mediaWiki certainly is, no need to access window from the global scope and then the mediaWiki property of it). Also renamed any used of $j to $. Adding 'undefined' to the closure arguments where missing.
* Re-written the mw.Api constructor's logic for options. Now keeping a defaultOptions privately "statically" cached outside the constructor and using that to build the options object.
* Made all non-block comments the same comment style (some were /* */ or /* \n */)
* Completed parameter documentation and wrote TODO as @todo and added an example use for mw.Api in the documentation.
* Some other random whitespacing, line breaking, merged var statement, and moved them out of blocks (since JS doesn't have block scope) into the main function body for clarity. And some other random JS Lint/JS Hint stuff.
* Added comment to api.titleblacklist module about the module not being in core but in the TitleBlacklist extension.
Danny B [Wed, 21 Dec 2011 23:19:24 +0000 (23:19 +0000)]
* (bug 23427) Introduced {{PAGEID}} variable to expose page.page_id [patch by Waldir]
Ryan Kaldari [Wed, 21 Dec 2011 22:54:22 +0000 (22:54 +0000)]
follow-up to r106912, making change to correct branch this time
Ian Baker [Wed, 21 Dec 2011 22:48:00 +0000 (22:48 +0000)]
This isn't a doc comment, so shouldn't start with /** (and it messes up my syntax highlighting)
Ian Baker [Wed, 21 Dec 2011 22:22:01 +0000 (22:22 +0000)]
changed instances of sample.com to example.com per RFC 2606
Krinkle [Wed, 21 Dec 2011 22:08:52 +0000 (22:08 +0000)]
[Core JS] mw.util.addCSS: Insert style tag into dom before setting cssText
* Fixes bug 33305
Krinkle [Wed, 21 Dec 2011 22:06:02 +0000 (22:06 +0000)]
[Core JS] Applying conventions to mw.util
- new recommended closure format
- fixing repeated var statements, or var statement inside blocks (there is no block scope in JavaScript) and moving them to the top of the function
- line breaking, indention, white space
- and more.. see also https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript
Aaron Schulz [Wed, 21 Dec 2011 21:29:16 +0000 (21:29 +0000)]
* FU r106752: unbreak urls to ForeignAPIRepo file thumbnails. FileRepo no longer uses bogus <public root URL>/thumb default for the thumnail URL when the public root URL wasn't even set. This was making ForeignAPIRepo not set it since it saw that it was already set.
* Cleaned up and added some missing sanity checks for scriptDirUrl member in FileRepo. Made some related documentation tweaks.
* Removed pointless getRepo() call in File.
Raimond Spekking [Wed, 21 Dec 2011 20:44:11 +0000 (20:44 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Wed, 21 Dec 2011 20:39:50 +0000 (20:39 +0000)]
* Added FileRepo::SKIP_LOCKING constant and made storeBatch() check it.
* Made File::maybeDoTransform() use the FileRepo::store() and a new File::getThumbRel() function. Looks cleaner and loosens FileBackend coupling.
* Also made storeTemp() use FileRepo::SKIP_LOCKING for performance.
* Killed some useless initZones() calls in FileRepo. Extensions may not even use these zones. Likewise, it could make tests fail even though they don't those zones. We already do the sanity with some prepare() calls in storeBatch().
* Removed FileRepo::SKIP_VALIDATION, not used by anything now.
* Moved getUrlRel() down a bit.
Brion Vibber [Wed, 21 Dec 2011 19:17:39 +0000 (19:17 +0000)]
Code style: move a couple htmlspecialchars() down to usage so it's clear where escaping happens
Roan Kattouw [Wed, 21 Dec 2011 18:58:27 +0000 (18:58 +0000)]
(bug 33246) News icon shown for news:// URLs but not for news: URLs. Patch by Erwin Dokter
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:53:00 +0000 (18:53 +0000)]
Declare constant default values directly in the class definition and removed the constructor since it's useless now
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:46:39 +0000 (18:46 +0000)]
Use LinkCache::singleton()->clear() instead of using a local variable so that I can see what LinkCache::singleton() will be used for directly in grep
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:44:25 +0000 (18:44 +0000)]
* Use local context to get messages
* Use Language::userTimeAndDate() and related instead of Language::timeanddate() where needed
* Factorised some calls to member functions
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:40:02 +0000 (18:40 +0000)]
Use accessor instead of the member variable directly and factorise the calls to it
Antoine Musso [Wed, 21 Dec 2011 15:31:30 +0000 (15:31 +0000)]
tests for r94881 which interprets relative Location: headers
Jeroen De Dauw [Wed, 21 Dec 2011 15:09:01 +0000 (15:09 +0000)]
follow up to r106883, typo fixes
Aaron Schulz [Wed, 21 Dec 2011 10:06:47 +0000 (10:06 +0000)]
Optimized doOperations() a bit to only get SH locks for the paths that aren't already going to get EX locks
Aaron Schulz [Wed, 21 Dec 2011 09:16:28 +0000 (09:16 +0000)]
* Renamed FileBackend functions internal to FileBackend/FileOp, making their usage clearer.
* Added convenience functions to FileBackendBase for basic file ops. Previously, doOperation() was the only convenience function...give it some friends :)
* More documentation comments.
Aaron Schulz [Wed, 21 Dec 2011 08:46:10 +0000 (08:46 +0000)]
Fixed typo in testGetFileList() and used the proper FileBackend function delete
Tim Starling [Wed, 21 Dec 2011 05:49:00 +0000 (05:49 +0000)]
Release notes for r105645.
Jeroen De Dauw [Wed, 21 Dec 2011 01:10:51 +0000 (01:10 +0000)]
actually use the flipping cssclass arg, so its possible to set a css class without creating your own input field type class
Ryan Kaldari [Wed, 21 Dec 2011 00:28:57 +0000 (00:28 +0000)]
follow-up to r105740, adding the actual graphic to use (in the right branch this time)
Ryan Kaldari [Tue, 20 Dec 2011 23:50:15 +0000 (23:50 +0000)]
follow-up to r106754 - using strict comparison, adding logic for editing existing pages, changing parameter name in WikiPage::replaceSection from $summary to $sectionTitle as it only used for section titling
Aaron Schulz [Tue, 20 Dec 2011 23:47:53 +0000 (23:47 +0000)]
FU r106752: use "media-" instead of "images-" in container names. Long live books, video, 3D meshes, and animated holograms from the future!
Neil Kandalgaonkar [Tue, 20 Dec 2011 23:02:42 +0000 (23:02 +0000)]
fix race condition in UploadFromChunks, followup to r104687
Brandon Harris [Tue, 20 Dec 2011 22:53:07 +0000 (22:53 +0000)]
Followup r105280
For bug 33139 "Swapping colors in new diff color scheme"
* Modified diff colorscheme to yellow[orange]/blue[blue]
- These colors attempt to address the following issues with diffs:
- Colorblindness (Protanopia/Deuteranopia)
- Cultural meaning of color (e.g., "green is good, therefore this diff is better")
* Bumped font size up overall (actually, just removed the smaller)
* Removed dotted line around difftext
Jeroen De Dauw [Tue, 20 Dec 2011 22:45:14 +0000 (22:45 +0000)]
partial revert of r106872 after discussion with Brion on #mediawiki irc
Brion Vibber [Tue, 20 Dec 2011 22:11:29 +0000 (22:11 +0000)]
Revert r106439, r106441 - bad formatting mushing separate lines together
Brion Vibber [Tue, 20 Dec 2011 22:05:40 +0000 (22:05 +0000)]
Revert r106870: doesn't seem like it would format things consistently as expected.
Aaron Schulz [Tue, 20 Dec 2011 21:58:29 +0000 (21:58 +0000)]
FU r106514: Sanity check for empty sha1 values in the DB
Brion Vibber [Tue, 20 Dec 2011 21:57:17 +0000 (21:57 +0000)]
Revert r106094 (broken unnecessary cleanup), r106454 (ugly unneceessary cleanup)
The ugliness of this sort of code is probably part of why there's still a Linker::tooltip() function.
Please don't just replace it with worse code; if truly cleaning it up this should be done by giving a saner interface to the nav generation code
Brion Vibber [Tue, 20 Dec 2011 21:52:18 +0000 (21:52 +0000)]
Revert r106456, r106485: system-wide setting seems to be intended to apply only to specific extensions' code but wouldn't? Also weird config parameter combining two unrelated things into one.
Sam Reed [Tue, 20 Dec 2011 21:37:51 +0000 (21:37 +0000)]
For r106521/r106865, wrap long example description strings
Follows up r106439