mrbluesky [Wed, 18 Jan 2012 22:46:26 +0000 (22:46 +0000)]
(bug 32899) Alphabetical sorting for methods and properties in doxygen
mrbluesky [Wed, 18 Jan 2012 22:40:51 +0000 (22:40 +0000)]
Additional doc/comments
Sam Reed [Wed, 18 Jan 2012 21:27:28 +0000 (21:27 +0000)]
Add __METHOD__ to begin/commit
Improve error message from r109433
Sam Reed [Wed, 18 Jan 2012 21:20:50 +0000 (21:20 +0000)]
Just experienced with commons. Dealt with UploadStashBadPathException
path doesn't exist
Backtrace:
#0 /home/wikipedia/common/php-1.18/maintenance/cleanupUploadStash.php(68): UploadStash->getFile('zyvzeiza5hg.xab...', true)
#1 /home/wikipedia/common/php-1.18/maintenance/doMaintenance.php(105): UploadStashCleanup->execute()
#2 /home/wikipedia/common/php-1.18/maintenance/cleanupUploadStash.php(75): require_once('/home/wikipedia...')
#3 /home/wikipedia/common/multiversion/MWScript.php(73): require_once('/home/wikipedia...')
#4 {main}
Raimond Spekking [Wed, 18 Jan 2012 21:07:15 +0000 (21:07 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Wed, 18 Jan 2012 20:01:46 +0000 (20:01 +0000)]
Make time of '-total' item correct if using 'user' time metric
Aaron Schulz [Wed, 18 Jan 2012 19:57:32 +0000 (19:57 +0000)]
In SwiftFileBackend:
* r108944: doCleanInternal() should delete empty containers only if the container dir was given.
* Made doSecureInternal() set container permissions. Also renamed swiftProxyUser -> swiftAnonUser.
* Made doGetFileStat() respect the 'latest' parameter (using r109235).
* Fixed connTTL default and renamed it to authTTL. Also added explicit close() call to getConnection().
* Reduced RTTs in doPrepareInternal() by checking getContainer() first (which is process cached).
* Killed an RTT in doStoreInternal(), doCreateInternal(), and doCopyInternal() by using create_object(). Also cleaned up logic with regards to the destination CF_Object object fields getting preloaded before write().
* Cleanups to getLocalCopy(); only create the tmp file if get_object() succeeds to short-circuits things.
* Made getContainer() limit the container cache size for sanity.
* Simplified doDeleteInternal() code a bit.
* Renamed $destRel => $dstRel for consistency.
Siebrand Mazeland [Wed, 18 Jan 2012 18:20:50 +0000 (18:20 +0000)]
Remove support for the deprecated and no longer used in trunk hook MagicWordMagicWords.
Siebrand Mazeland [Wed, 18 Jan 2012 17:53:04 +0000 (17:53 +0000)]
Update documentation.
Siebrand Mazeland [Wed, 18 Jan 2012 17:43:08 +0000 (17:43 +0000)]
Update documentation as LanguageGetMagic hook is deprecated.
Antoine Musso [Wed, 18 Jan 2012 15:58:25 +0000 (15:58 +0000)]
MWDebugTest: clear log before running tests
Some other test could have added their own logs, for example
deprecated notice. In that case, the first test will fail because
the log array already has some content :-b
Antoine Musso [Wed, 18 Jan 2012 15:50:00 +0000 (15:50 +0000)]
tests: mark tests requiring a database connection
Alexandre Emsenhuber [Wed, 18 Jan 2012 14:48:35 +0000 (14:48 +0000)]
Fix profiling, that function is not profiled
Alexandre Emsenhuber [Wed, 18 Jan 2012 12:10:16 +0000 (12:10 +0000)]
Pass some more __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit()
Antoine Musso [Wed, 18 Jan 2012 10:36:45 +0000 (10:36 +0000)]
dbg toolbar: prevents screen jumping
preventDefault() ask the browser to ignore URL fragment which
we handle manually (by closing/opening tabs).
Works with Hovzer plugin added by r107982
ping r105122
Siebrand Mazeland [Wed, 18 Jan 2012 08:05:27 +0000 (08:05 +0000)]
Follow-up r107881: revert. Adding forgotten part in r109260.
Gabriel Wicke [Wed, 18 Jan 2012 01:38:44 +0000 (01:38 +0000)]
Correct typo in comment, so that it reflects the spec and the actual value in
the regexp.
Siebrand Mazeland [Wed, 18 Jan 2012 00:26:11 +0000 (00:26 +0000)]
Revert r107881 per CR.
Aaron Schulz [Tue, 17 Jan 2012 23:07:15 +0000 (23:07 +0000)]
Reverted r109223 per CR
Aaron Schulz [Tue, 17 Jan 2012 22:56:43 +0000 (22:56 +0000)]
r108749: added missing backend-fail-contenttype message
Raimond Spekking [Tue, 17 Jan 2012 22:10:16 +0000 (22:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Tue, 17 Jan 2012 21:49:27 +0000 (21:49 +0000)]
[Actions] Move action logic out of MediaWiki::getAction/MediaWiki::performAction into Action::getActionName.
* Follows-up r109195
* Reverts/Redoes r108342, r108343, r108345
* Contributes to solution of bug 27930 - Ability to get current action (The Right Way)
Krinkle [Tue, 17 Jan 2012 19:56:08 +0000 (19:56 +0000)]
[Actions] Move the remaining actions out of MediaWiki::performAction into single action classes (finally).
- [Actions] -
* I am aware that eventually these classes should be more than just a few lines re-directing control to WikiPage, but I'm keeping these commits as uncontroversial as possible due to feature freeze. Refactor could be done later.
* Contributes to solution of bug 27930 - Ablity to get current action (The Right Way)
* Final goal: Get the current action without needing access to Wiki.php internals (i.e. with Action::factory in one hand and an instance of IContextSource in the other)
* Required for proper fix of r108342/108343 (currently marked FIXME)
Krinkle [Tue, 17 Jan 2012 17:39:30 +0000 (17:39 +0000)]
[jquery.footHovzer] Remove buggy scrollstate preserver
* Intended to preserver scroll-state (which is shifted when an element to the bottom gains height). However too unstable to be more handy that it is annoying when it is not.
* Follows-up r107982
Antoine Musso [Tue, 17 Jan 2012 16:42:53 +0000 (16:42 +0000)]
deprecated $query2 in Title.php
$query2 was used to pass a variant. Make that deprecated, the
recommanded way is to use an array as a first parameter. Ex:
$this->getLocalUrl( array( 'variant' => 'foo' ) );
Ping r105919
Sam Reed [Tue, 17 Jan 2012 13:29:42 +0000 (13:29 +0000)]
Fixed reading from file from r108774
Alexandre Emsenhuber [Tue, 17 Jan 2012 12:38:23 +0000 (12:38 +0000)]
* Reordered code to not create a RequestContext if the title is invalid
* Use Article::newFromTitle() instead of new Article()
* Set the WikiPage in the context from the created Article object
Alexandre Emsenhuber [Tue, 17 Jan 2012 12:19:51 +0000 (12:19 +0000)]
If you want to display miliseconds, make the time be really miliseconds and not seconds
Alexandre Emsenhuber [Tue, 17 Jan 2012 11:38:00 +0000 (11:38 +0000)]
Pass __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit()
Antoine Musso [Tue, 17 Jan 2012 10:10:21 +0000 (10:10 +0000)]
dbg toolbar: makes pane title consistent
Example output:
Console (1) | Queries (45) | Debug Log (21) | Request | PHP includes (131)
A null / undefined / 0 value will skip the parentheses output.
Antoine Musso [Tue, 17 Jan 2012 09:58:00 +0000 (09:58 +0000)]
dbg toolbar query list
* add headers (using <th> instead of <colgroup>
* hardcoded width that looks fine to me. 4em is enoug for query count
* split function name / execution time in their own column
Santhosh Thottingal [Tue, 17 Jan 2012 08:54:39 +0000 (08:54 +0000)]
Make the QunitTestResources in sync with qunit/index.html.
JqueryMsg tests were not preset in QunitTestResources.
Aaron Schulz [Tue, 17 Jan 2012 05:34:01 +0000 (05:34 +0000)]
* Fixed type check in StreamFile::prepareForStream() for 404s
* Code comment tweaks and fixes
Aaron Schulz [Tue, 17 Jan 2012 03:58:41 +0000 (03:58 +0000)]
Added CurlHttpRequest to AutoLoader.php
Jeroen De Dauw [Tue, 17 Jan 2012 00:33:44 +0000 (00:33 +0000)]
added missing semicolon
Amir E. Aharoni [Tue, 17 Jan 2012 00:23:07 +0000 (00:23 +0000)]
Force left-to-right directionality on the QUnit output and apply the appropriate directionality to its header, since it can be translated.
Amir E. Aharoni [Tue, 17 Jan 2012 00:17:55 +0000 (00:17 +0000)]
Follow up to r105855 - now with updated phpunit tests.
Aaron Schulz [Mon, 16 Jan 2012 22:54:22 +0000 (22:54 +0000)]
Follow-up r108185: removed now unused ALLOW_STALE param
Alexandre Emsenhuber [Mon, 16 Jan 2012 21:54:24 +0000 (21:54 +0000)]
* Use WikiPage instead of Article to call updateRevisionOn()
* Also lock 'user' table, needed in Revision::newFromId()
Raimond Spekking [Mon, 16 Jan 2012 21:47:30 +0000 (21:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 16 Jan 2012 21:29:05 +0000 (21:29 +0000)]
Only run some MWDebug code when really needed:
* Add the mediawiki.debug module from OutputPage::addDefaultModules() along with other modules
* Get the request information when building the JS output instead of in Setup.php
Antoine Musso [Mon, 16 Jan 2012 21:13:48 +0000 (21:13 +0000)]
firefox does not honor colgroup width with fixed layout
Sam Reed [Mon, 16 Jan 2012 15:49:32 +0000 (15:49 +0000)]
Update documentation for ImportHandleRevisionXMLTag
Siebrand Mazeland [Mon, 16 Jan 2012 14:27:46 +0000 (14:27 +0000)]
Tweak 'protect-text'.
Antoine Musso [Mon, 16 Jan 2012 13:56:18 +0000 (13:56 +0000)]
enable MWDebug tests
The first ones were failing because the test suite ran on gallium without
MWDebug being initialized. This is now the case since r109033.
The second part was failling because PHPUnit on gallium does not have
the assertCount() method. Use a assertEquals() / count() workaround instead.
Tests added by 108873
Reverts r108877
Antoine Musso [Mon, 16 Jan 2012 13:50:17 +0000 (13:50 +0000)]
test with MWDebug enabled (made possible by r109032)
Antoine Musso [Mon, 16 Jan 2012 13:44:46 +0000 (13:44 +0000)]
Move MWDebug enabling logic to Setup.php
MWDebug initialization method was made to look up for a global variable. This
patch move the logic to Setup.php so we can replicate it when doing tests.
Side effect, MWDebug is disabled by default. Users will explicitly have to
enable it by using init().
Ping r105123
Siebrand Mazeland [Mon, 16 Jan 2012 12:05:55 +0000 (12:05 +0000)]
Add plural support in 'longpageerror'.
Amir E. Aharoni [Mon, 16 Jan 2012 10:45:01 +0000 (10:45 +0000)]
Follow up to r109021, corrected the comment, and added a translation from Russian.
Antoine Musso [Mon, 16 Jan 2012 10:36:55 +0000 (10:36 +0000)]
typo in r103711: right -> rights
Antoine Musso [Mon, 16 Jan 2012 10:33:24 +0000 (10:33 +0000)]
Skip BrokenRedirectsPage query test under MySQL
The MySQL backend, when using temporary tables, does not support referencing
a table which was already open.
http://bugs.mysql.com/bug.php?id=10327
This patch skip BrokenRedirectsPage on MySQL as reported on r102411.
Santhosh Thottingal [Mon, 16 Jan 2012 10:05:48 +0000 (10:05 +0000)]
reintroduce the shortcut evaluation removed in r108403 and r108405
Amir E. Aharoni [Mon, 16 Jan 2012 09:46:56 +0000 (09:46 +0000)]
Improved the comment about the two-forms plural shortcut.
Antoine Musso [Mon, 16 Jan 2012 08:59:17 +0000 (08:59 +0000)]
reverts wgDeprecationWhitelist
Per wikitech-l
Reverts r106883 and r106946
Aaron Schulz [Sun, 15 Jan 2012 22:45:14 +0000 (22:45 +0000)]
In FileOp/FileBackend:
* Added SHA-1 to FileOp::attemptBatch $predicates (since concatenate was removed from FileOp). This lets us get rid of temp file backups, as the remaining failure case is just the backend medium going down (the ops would break in that case anyway). Doing so reduces RTTs and backup file I/O overhead. This also simplifies expiry object support by avoiding having to stash the expiry values of temp backup objects somewhere.
* Improved precheck() and attempt() status logic in FileOp::attemptBatch() a bit. Use separate $subStatus var to check if each op is OK.
* A few minor code cleanups and comment tweaks.
* Fixed MoveFileOp bug found in unit tests when the source/dest are the same and an overwriteDest/overwriteSame param is given (the file would just get deleted). Improved CopyFileOp in this case too.
Other:
* Added more unit tests.
Aaron Schulz [Sun, 15 Jan 2012 22:21:51 +0000 (22:21 +0000)]
* Killed an RTT in SwiftFileBackend::doStreamFile(). We already check existence in FileBackend::streamFile()
* A few minor code cleanups and comment tweaks.
Alexandre Emsenhuber [Sun, 15 Jan 2012 22:00:04 +0000 (22:00 +0000)]
Use the context's WikiPage object if the title of the new revision is the same as context's title; avoids a duplicated database query to load the WikiPage
Raimond Spekking [Sun, 15 Jan 2012 20:22:43 +0000 (20:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Jeroen De Dauw [Sun, 15 Jan 2012 16:13:16 +0000 (16:13 +0000)]
added some docs
Krinkle [Sun, 15 Jan 2012 13:56:55 +0000 (13:56 +0000)]
[mediawiki.action.history.diff.css] remove redundant css rule
* Background color reset for tables is no longer needed per r80495
* See r80495 commitmsg for rationale for removal of the `table { backgroundL: white }` rule
* Also touched in r105280
Alexandre Emsenhuber [Sun, 15 Jan 2012 12:30:14 +0000 (12:30 +0000)]
* Use WikiPage instead of Article to call doEdit()
* Pass the User object to WikiPage::doEdit()
Alexandre Emsenhuber [Sun, 15 Jan 2012 11:42:36 +0000 (11:42 +0000)]
* Fix Profiler::getUserTime() to return a float and not string with space separated values since, was breaking difference calculation since PHP doesn't know how to make the difference of two strings :P
* Same when adding fake items in the stack after a profiling error
* Removed useless ProfilerSimple::getTime()
Antoine Musso [Sun, 15 Jan 2012 11:05:51 +0000 (11:05 +0000)]
Release note for ug 17959
Bug 17959 - Inline rendering/thumbnailing for Gimp XCF images
Forgotten in r107351
John Du Hart [Sun, 15 Jan 2012 06:07:24 +0000 (06:07 +0000)]
Adding jquery.arrowSteps to core, from UploadWizard
Sam Reed [Sat, 14 Jan 2012 23:45:21 +0000 (23:45 +0000)]
* (bug 33733) API: Unknown error: mustbeloggedin
Add message to messagemap
Aaron Schulz [Sat, 14 Jan 2012 23:15:32 +0000 (23:15 +0000)]
r108944: fixed bogus field...php-cloudfiles documentation misspelled this, it's 'object_count' not 'count'
Aaron Schulz [Sat, 14 Jan 2012 23:11:21 +0000 (23:11 +0000)]
In SwiftFileBackend:
* Added getContainer(), createContainer(), and deleteContainer() helper functions, which cache container objects to avoid RTTs
* Made doCleanInternal() delete empty containers
* Bumped authentication TTL to 120 seconds
* Some comment tweaks
Amir E. Aharoni [Sat, 14 Jan 2012 22:32:18 +0000 (22:32 +0000)]
A bit of documentation.
Chad Horohoe [Sat, 14 Jan 2012 22:21:30 +0000 (22:21 +0000)]
Revert r108777 (making eval subclass maintenance). eval's supposed to be in the global context. See r54839
Niklas Laxström [Sat, 14 Jan 2012 22:00:27 +0000 (22:00 +0000)]
Typo
Amir E. Aharoni [Sat, 14 Jan 2012 20:26:54 +0000 (20:26 +0000)]
Follow up to r108927. Replaced die() with throw new MWException(), according to ^demon's suggestion.
Aaron Schulz [Sat, 14 Jan 2012 19:17:17 +0000 (19:17 +0000)]
r105512: Handle REDIRECT_URL discrepancies and always work with URI paths for thumb 404 handling
Sam Reed [Sat, 14 Jan 2012 18:32:04 +0000 (18:32 +0000)]
RELEASE-NOTES-1.19 for r108876
Raimond Spekking [Sat, 14 Jan 2012 17:55:26 +0000 (17:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Amir E. Aharoni [Sat, 14 Jan 2012 17:51:14 +0000 (17:51 +0000)]
Changing the failure message to something more meaningful.
Sam Reed [Sat, 14 Jan 2012 15:27:30 +0000 (15:27 +0000)]
Documentation
Wrapping up some long lines
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:53:32 +0000 (14:53 +0000)]
No need to do the safe_mode check on every request in $wgAdditionalMailParams is set; that variable will not be passed to mail() if safe_mode is enabled since r99411
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:27:46 +0000 (14:27 +0000)]
Per Aaron, fix for r108274: added canUseWikiPage() to context objects to know whether getWikiPage() can be safely called
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:18:56 +0000 (14:18 +0000)]
Fix for r107939: PHP Notice: Undefined variable: exportall in includes/specials/SpecialExport.php on line 173 when the "export all" checkbox is not checked
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:11:08 +0000 (14:11 +0000)]
* Use WikiPage instead of Article to call commitRollback()
* Pass the User object from WikiPage::commitRollback() to WikiPage::doEdit()
* Do the edits with 'Maintenance script' user as other maintenance scripts instead of 127.0.0.1
Alexandre Emsenhuber [Sat, 14 Jan 2012 13:15:19 +0000 (13:15 +0000)]
Fix comment, this doesn't use $wgTitle anymore
Aaron Schulz [Sat, 14 Jan 2012 03:16:18 +0000 (03:16 +0000)]
* Fixed bogus var in LSLockManager.
* Made DBLockManager constructor a bit more convenient to use with just 'localDBMaster' in the db buckets.
* Documentation tweaks.
Aaron Schulz [Sat, 14 Jan 2012 01:52:19 +0000 (01:52 +0000)]
* Renamed ContainerShardListIterator -> FileBackendShardListIterator
* Renamed FSFileIterator -> FSFileBackendFileList
* Renamed SwiftFileIterator -> SwiftFileBackendFileList and added it to autoloader
* A few minor doc fixes
Aaron Schulz [Sat, 14 Jan 2012 00:50:18 +0000 (00:50 +0000)]
Fixed annoying bug in FileRepo::deleteBatch() when a file is deleted that has multiple identical versions. The operation would fail due to the file already existing.
Krinkle [Sat, 14 Jan 2012 00:40:48 +0000 (00:40 +0000)]
[Core JS] Fix code from r107327 which was broken by r108222
-- Of course one most not assume the DOM is finished enough for #p-logo to be parsed, simply bind to document ready
Sam Reed [Sat, 14 Jan 2012 00:25:26 +0000 (00:25 +0000)]
Revert out r108882
Sam Reed [Sat, 14 Jan 2012 00:09:58 +0000 (00:09 +0000)]
Recommitting r108367 to break unit tests as phpunit on ubuntu seems FUBAR'd again
Will revert after
Aaron Schulz [Fri, 13 Jan 2012 23:39:48 +0000 (23:39 +0000)]
Removed call to ParserTest::setUp() which was unnecessary. Also, the called function leaks globals anyway atm.
Aaron Schulz [Fri, 13 Jan 2012 23:30:46 +0000 (23:30 +0000)]
In FileBackend:
* Made secure() call doPrepare() for caller dummy proofing (especially those that don't check the status).
In FSFileBackend:
* Removed redundant wfMkdirParents() calls in FSFileBackend, we already have prepare() for this purpose. This also keeps it's behavior more consistent with the other backends.
* Made use of 'backend-fail-store' message in doStoreInternal().
Other:
* Updated unit tests and renamed $src => $source in some functions for consistency.
* Added some documentation comments and @since tags.
Antoine Musso [Fri, 13 Jan 2012 23:26:26 +0000 (23:26 +0000)]
Disable MWDebug tests for now
PHPUnit is too old on gallium so assertCount() is not recognized
The other two tests are broken for an unknown reason.
Sam Reed [Fri, 13 Jan 2012 23:14:28 +0000 (23:14 +0000)]
Rather than using an error code of unknownerror, use the error code returned by EditPage if it's a string, and it has length, else just return the usual "unknownerror"
Antoine Musso [Fri, 13 Jan 2012 23:10:21 +0000 (23:10 +0000)]
MWDebug: avoid double count()
Follow r107954
Antoine Musso [Fri, 13 Jan 2012 23:07:52 +0000 (23:07 +0000)]
some tests for MWDebug
Really incomplete. We need better testing.
Added two new public methods so we can get or clear the internal logs.
Benny Situ [Fri, 13 Jan 2012 22:58:32 +0000 (22:58 +0000)]
followup to -r107187 - adding bug24430 patch to 1.19 release note
Benny Situ [Fri, 13 Jan 2012 22:48:21 +0000 (22:48 +0000)]
Add bug33703 fix to 1.19 release note
Benny Situ [Fri, 13 Jan 2012 22:27:16 +0000 (22:27 +0000)]
patch from fomafix - bug33703 - remove black border-bottom-color for abbr
mrbluesky [Fri, 13 Jan 2012 22:19:01 +0000 (22:19 +0000)]
Fixing comments
Using shell style comments here stops Doxygen from processing the rest of the comments.
See http://svn.wikimedia.org/doc/classHTMLForm.html
Antoine Musso [Fri, 13 Jan 2012 22:09:11 +0000 (22:09 +0000)]
XCF: force rendering
Browsers do not support GIMP native format (yet?!). So we really need
to force rendering.
Noticed by Mark while testing the feature on labs.
Follow r107351
Rob Moen [Fri, 13 Jan 2012 21:57:52 +0000 (21:57 +0000)]
reverted r108850 as patch should be introduced after code freeze
Niklas Laxström [Fri, 13 Jan 2012 21:50:13 +0000 (21:50 +0000)]
@since, ping r101030