Santhosh Thottingal [Sun, 13 Nov 2011 12:41:33 +0000 (12:41 +0000)]
Oops, missed to notice the missed <?php. Reverting.
Aaron Schulz [Sun, 13 Nov 2011 12:35:28 +0000 (12:35 +0000)]
Removed transaction in saveOptions(). No reason was given for it and it could break any callers that have transactions.
Santhosh Thottingal [Sun, 13 Nov 2011 12:22:10 +0000 (12:22 +0000)]
Correct the name of Sanskrit Language.
Bug 32393
Aaron Schulz [Sun, 13 Nov 2011 11:28:56 +0000 (11:28 +0000)]
Added rollback-related comment to nextSequenceValue()
Alexandre Emsenhuber [Sun, 13 Nov 2011 09:12:03 +0000 (09:12 +0000)]
Refactored EditPage::getPreloadedText():
* Use WikiPage instead of Article (avoids conflicting with oldid url parameter)
* Use getRedirectTarget() instead of creating a new Title with the content of the page
* Changed userCanRead() calls to userCan( 'read' )
* Use "if ( something ) return;" instead of nesting if checks
Niklas Laxström [Sun, 13 Nov 2011 08:58:38 +0000 (08:58 +0000)]
Address comments in r97628
Alexandre Emsenhuber [Sun, 13 Nov 2011 07:25:56 +0000 (07:25 +0000)]
Removed usage of $wgUser in block and unblock processing:
* Made HTMLFormField pass the HTMLForm object to the validation and filter callbacks (so that they can get a context)
* Added new parameter to SpecialBlock::checkUnblockSelf() to pass the user doing the request
* SpecialBlock::processForm() and SpecialUnblock::processUnblock() now require a context as second parameter; added SpecialBlock::processUIForm() and SpecialUnblock::processUIUnblock() as adaptators from HTMLForm as second parameter to context
Diederik van Liere [Sun, 13 Nov 2011 01:50:24 +0000 (01:50 +0000)]
This patch fixes rev. 102575.
Aaron Schulz [Sat, 12 Nov 2011 22:36:47 +0000 (22:36 +0000)]
Document $wgGroupPermissions better, including per-NS stuff
Raimond Spekking [Sat, 12 Nov 2011 21:52:22 +0000 (21:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Chad Horohoe [Sat, 12 Nov 2011 21:32:39 +0000 (21:32 +0000)]
Comment tweak on MediaWikiParserTest and make ResourceLoaderTest extend MediaWikiTestCase
Alexandre Emsenhuber [Sat, 12 Nov 2011 13:47:17 +0000 (13:47 +0000)]
Moved methods around to group them by functionnality
Alexandre Emsenhuber [Sat, 12 Nov 2011 12:13:08 +0000 (12:13 +0000)]
Per Nikerabbit, fix undefined variable notice from r102851
Alexandre Emsenhuber [Sat, 12 Nov 2011 09:57:47 +0000 (09:57 +0000)]
* Renamed member variables to begin with a lower case
* Moved constant definitions from the constructor to the class definition
* Removed default values from the class definition for members that are always set in the constructor
Roan Kattouw [Sat, 12 Nov 2011 09:55:28 +0000 (09:55 +0000)]
Allow extensions to add post-update maintenance scripts
Alexandre Emsenhuber [Sat, 12 Nov 2011 07:36:41 +0000 (07:36 +0000)]
Use WikiPage instead of Article
Alexandre Emsenhuber [Sat, 12 Nov 2011 07:30:25 +0000 (07:30 +0000)]
Use the local user to get time offset and format, also removed wfTimestamp() call since this is already done in the function
Aaron Schulz [Fri, 11 Nov 2011 22:14:21 +0000 (22:14 +0000)]
FU r102073:
* (bug 32367) Fixed SpecialMovePage to not call wfLocalFile() on a non file title and expect an actual File back. Previously "worked" due to an old file title checking loophole (File objects with non File: titles).
* Use File::normalizeTitle() in some more functions that were still doing their own incomplete normalization.
* Updated FileRepo::newFile() docs to reflect that it can return null; wfLocalFile() docs already mentioned this.
Raimond Spekking [Fri, 11 Nov 2011 20:38:26 +0000 (20:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Santhosh Thottingal [Fri, 11 Nov 2011 17:23:12 +0000 (17:23 +0000)]
Make commafy support negative numbers too,
Add test cases.
Ref Bug 32359 and Followup r97793
Sam Reed [Fri, 11 Nov 2011 17:06:03 +0000 (17:06 +0000)]
Same for the getPostDatabaseUpdateMaintenance
We only need to run them once
Sam Reed [Fri, 11 Nov 2011 16:58:09 +0000 (16:58 +0000)]
Followup r102799, unconditionally running them anyway also isn't much use
Sam Reed [Fri, 11 Nov 2011 16:47:48 +0000 (16:47 +0000)]
Naff all point varying on $this->updateRowExists when we never bloody insert to that database (more of these to come as I cleanup the updater)
Roan Kattouw [Fri, 11 Nov 2011 16:37:38 +0000 (16:37 +0000)]
Followup r102785, fix wrong index order in tables.sql. The patches are fine
Alexandre Emsenhuber [Fri, 11 Nov 2011 16:09:34 +0000 (16:09 +0000)]
Don't pass the count parameter in rawParams() otherwise {{PLURAL:}} won't work (spotted while looking at r102794 but not related to that rev)
Brian Wolff [Fri, 11 Nov 2011 15:59:40 +0000 (15:59 +0000)]
(bug 32358) Do not display "No higher resolution available" if the file doesn't have dimensions (like an audio file)
Alexandre Emsenhuber [Fri, 11 Nov 2011 15:58:17 +0000 (15:58 +0000)]
Reordered some functions for more consistency: setOldSubtitle() near other view-related functions and deprecated functions to the bottom
Brian Wolff [Fri, 11 Nov 2011 15:33:37 +0000 (15:33 +0000)]
Follow-up r102751 - I think this test was intermitently failing because it was re-using thumbs generated for previous tests. Add a random number to stop that.
Jure Kajzer [Fri, 11 Nov 2011 14:28:44 +0000 (14:28 +0000)]
* applyed the patch from bug 26393 (please comment on the bug page)
Siebrand Mazeland [Fri, 11 Nov 2011 13:20:56 +0000 (13:20 +0000)]
Localisation updates from translatewiki.net.
Siebrand Mazeland [Fri, 11 Nov 2011 12:25:58 +0000 (12:25 +0000)]
Remove trailing newline in 'config-db-host-help'.
Siebrand Mazeland [Fri, 11 Nov 2011 12:24:29 +0000 (12:24 +0000)]
Localisation updates. Add Canadian English, by popular demand.
Siebrand Mazeland [Fri, 11 Nov 2011 11:05:12 +0000 (11:05 +0000)]
Localisation updates from translatewiki.net.
Protocol relative URL updates in mainpagedocfooter translations (updated with bot) following up r102767.
Siebrand Mazeland [Fri, 11 Nov 2011 10:43:32 +0000 (10:43 +0000)]
Localisation updates from translatewiki.net.
Mostly protocol relative URL updates in translations (updated with bot) following up r102767, r102749.
Siebrand Mazeland [Fri, 11 Nov 2011 10:39:30 +0000 (10:39 +0000)]
Follow-up 102749: more protocol relative URLs.
Brian Wolff [Fri, 11 Nov 2011 04:09:05 +0000 (04:09 +0000)]
(follow-up r99910) Make $wgEnableAutoRotation work...
Also unit-tests. There's a bit of duplication in the unit tests, and I wasn't sure if there was a better way with less duplication.
Daniel Friesen [Fri, 11 Nov 2011 03:40:13 +0000 (03:40 +0000)]
Update xcache url since the old url redirects to the lighttpd redmine homepage instead of anything related to xcache.
Daniel Friesen [Fri, 11 Nov 2011 03:35:18 +0000 (03:35 +0000)]
Update Installer i18n to use some protocol relative urls.
Daniel Friesen [Fri, 11 Nov 2011 03:30:17 +0000 (03:30 +0000)]
Followup r102744 update parser tests.
Daniel Friesen [Fri, 11 Nov 2011 03:20:45 +0000 (03:20 +0000)]
Switch some urls inside en to protocol relative.
Krinkle [Fri, 11 Nov 2011 00:17:38 +0000 (00:17 +0000)]
[Resources.php] Must. Have. Order.
Sam Reed [Fri, 11 Nov 2011 00:13:27 +0000 (00:13 +0000)]
RELEASE-NOTES-1.19 for r102722
Sam Reed [Fri, 11 Nov 2011 00:05:04 +0000 (00:05 +0000)]
* (bug 30062) Add $wgDBprefix option to cli installer
Patch by Grunny
gicode [Thu, 10 Nov 2011 23:52:56 +0000 (23:52 +0000)]
Fix file name and class case.
Follow-up r102719
gicode [Thu, 10 Nov 2011 23:45:35 +0000 (23:45 +0000)]
Add test to catch the problem fixed in r102595.
Confirmed the test works by removing "Test" from one of the test file names.
Antoine Musso [Thu, 10 Nov 2011 22:54:29 +0000 (22:54 +0000)]
on tablesort, verify <caption> is the first child in the table
r102303 tried to compare the whole table when bug 32047 only require
we have <caption> as a first child. Easier definition leads to easier
code!
Aaron Schulz [Thu, 10 Nov 2011 21:03:23 +0000 (21:03 +0000)]
Added some revision table comments
Raimond Spekking [Thu, 10 Nov 2011 20:56:42 +0000 (20:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Thu, 10 Nov 2011 20:50:21 +0000 (20:50 +0000)]
Documentation
Jure Kajzer [Thu, 10 Nov 2011 20:50:01 +0000 (20:50 +0000)]
* sry about that :S ... 10x Aaron
Sam Reed [Thu, 10 Nov 2011 20:49:11 +0000 (20:49 +0000)]
Fix syntax error I introduced from r102683
Sam Reed [Thu, 10 Nov 2011 20:44:37 +0000 (20:44 +0000)]
Pass in some more , __METHOD__
Sam Reed [Thu, 10 Nov 2011 20:39:23 +0000 (20:39 +0000)]
Add $fname to tableExists
Pass $fname/__METHOD__ in in upstream callers
Jure Kajzer [Thu, 10 Nov 2011 19:49:32 +0000 (19:49 +0000)]
* fix as per comment on CR r102625#c25856
Siebrand Mazeland [Thu, 10 Nov 2011 19:01:41 +0000 (19:01 +0000)]
Revert r102650, r102640. Caused breakage on translatewiki.net:
No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php.
Backtrace:
#0 /www/w/includes/LocalisationCache.php(288): LocalisationCache->initLanguage('en')
#1 /www/w/includes/LocalisationCache.php(223): LocalisationCache->loadItem('en', 'specialPageAlia...')
#2 /www/w/languages/Language.php(2630): LocalisationCache->getItem('en', 'specialPageAlia...')
#3 /www/w/includes/SpecialPageFactory.php(211): Language->getSpecialPageAliases()
#4 /www/w/includes/SpecialPageFactory.php(247): SpecialPageFactory::getAliasList()
#5 /www/w/includes/Title.php(4186): SpecialPageFactory::resolveAlias('LanguageStats/n...')
#6 /www/w/includes/Wiki.php(154): Title->isSpecial('Badtitle')
#7 /www/w/includes/Wiki.php(605): MediaWiki->performRequest()
#8 /www/w/includes/Wiki.php(524): MediaWiki->main()
#9 /www/w/index.php(58): MediaWiki->run()
#10 {main}
gicode [Thu, 10 Nov 2011 18:02:38 +0000 (18:02 +0000)]
Follow-up r102587. Add details to comments and add a couple more tests.
Chad Horohoe [Thu, 10 Nov 2011 15:20:01 +0000 (15:20 +0000)]
Minor tweaks to r102595: remove echo that clutters output, etc
Alexandre Emsenhuber [Thu, 10 Nov 2011 14:31:19 +0000 (14:31 +0000)]
Use WikiPage instead of Article to call getRedirectTarget()
Jure Kajzer [Thu, 10 Nov 2011 13:29:32 +0000 (13:29 +0000)]
some more oracle-phpunit-fu (should not affect non-oracle)
* CloneDatabase - already droping tables in internal function, removed duplicate action
* DatabaseOracle - stopped ignoring "temporary" parameter
* added two parameters to phpunit (use-normal-tables & reuse-db), default actions stay the same
* with reuse-db oracle phpunit test run on oracle down to 1m 20s ;)
Antoine Musso [Thu, 10 Nov 2011 13:14:52 +0000 (13:14 +0000)]
correct variable name
This is caused by r102640, I have moved some code to a new function
and forgot to rename the internal variable name to match the function
parameter.
Alexandre Emsenhuber [Thu, 10 Nov 2011 13:06:52 +0000 (13:06 +0000)]
Made DifferenceEngine use a context instead of global variables and updaters calls to constructor in core
Alexandre Emsenhuber [Thu, 10 Nov 2011 12:49:10 +0000 (12:49 +0000)]
Made setupGlobals() return the created context and use it instead of either global variables or recreating more instance of those classes
Alexandre Emsenhuber [Thu, 10 Nov 2011 12:09:33 +0000 (12:09 +0000)]
Removed FeedItem::getLastMod() and FeedItem::getDBPrefixedTitle() since they are not used and would throw an error since FeedItem::$Title is a string and not an object
Antoine Musso [Thu, 10 Nov 2011 11:56:52 +0000 (11:56 +0000)]
move store writing out of recache()
Writing to cache is now handled in a new method. That makes recache() a bit
shorter and easier to read. Since there is no point in writing data to
/dev/null , return early in such a case (ie if store is LCStore_Null).
Antoine Musso [Thu, 10 Nov 2011 11:18:50 +0000 (11:18 +0000)]
load up includes/Setup.php before Maintenance::finalSetup()
This let us get access to global functions and the autoloader when trying
to do some final setup for our maintenance scripts.
Siebrand Mazeland [Thu, 10 Nov 2011 09:42:16 +0000 (09:42 +0000)]
Follow-up r102628, r102612: More protocol relative URLs.
Also contains localisation updates from //translatewiki.net :)
Jure Kajzer [Thu, 10 Nov 2011 09:36:18 +0000 (09:36 +0000)]
* reverted changes to Block and ApiBlockTest made in r102625 ... PEBKAC
Siebrand Mazeland [Thu, 10 Nov 2011 09:06:33 +0000 (09:06 +0000)]
Follow-up r102612: Use protocol relative URLs for translatewiki.net also
Jure Kajzer [Thu, 10 Nov 2011 07:41:12 +0000 (07:41 +0000)]
* Added getInfinity to DatabaseOracle
* Block - replaced 'infinity' strings with DB->getInfinity calls
* UploadStash - added sequence value generation for ID
Daniel Friesen [Thu, 10 Nov 2011 06:55:21 +0000 (06:55 +0000)]
Add a new User::getDisplayName() to return the name that should be displayed in the interface.
Add a UserDisplayName hook to allow extensions to give custom display names for users.
Add a $wgRealNameInInterface to use the real name of a user as the display name.
To start of the first use of the display name functionality tweak SkinTemplate to declare the userdisplayname and use it inside of personal_urls.
Daniel Friesen [Thu, 10 Nov 2011 03:27:55 +0000 (03:27 +0000)]
Refactor core from Title::getLinkUrl to Title::getLinkURL to match Title's getLocalURL and getFullURL.
This shouldn't cause any back or forward compat issues since php treats method names as case-insensitive. So this change shouldn't break any old extensions, and extensions are free to start using getLinkURL and won't have any issue breaking with old versions of MediaWiki.
Krinkle [Thu, 10 Nov 2011 02:08:47 +0000 (02:08 +0000)]
[mediawiki.Uri] Add overrideKeys option
* The behavior of turning foo=bar&foo=quux&lorem=ipsum into "{ lorem: 'ipsum', foo: ['bar', 'quux'] }", has annoyed me several times. As it is in contrary with the way PHP works (PHP only makes numeral arrays if the key ends in '[]'). Adding in an option to make mw.Uri behave like that.
* We may wanna make that the default at some point, leaving default behavior unchanged for now.
* Converted 'strictMode' into 'options', kept backwards compatibility
* Fixed documentation comment for example (q1=0 -> "{ q1: '0'")
* Updated unit tests to account for this option.
Benny Situ [Thu, 10 Nov 2011 01:13:35 +0000 (01:13 +0000)]
This SVN commit fixes bug32220 and makes links to mediawiki.org in language message files protocol relative
Platonides [Wed, 9 Nov 2011 23:35:30 +0000 (23:35 +0000)]
Follow-up r102521
Remove $wgUseExternalEditor globals.
gicode [Wed, 9 Nov 2011 23:11:52 +0000 (23:11 +0000)]
Move tests that have likely never been executed. Now they will be executed.
It might be a good idea to have a commit hook or similar to catch these.
You can find candidates for renaming with this command:
$ find tests/phpunit/includes/ -name '*.php' | grep -Ev 'Test.php$' | xargs grep -l MediaWikiTestCase
Aaron Schulz [Wed, 9 Nov 2011 22:59:09 +0000 (22:59 +0000)]
Reverted r101244 changes - these are not equivalent and may have been causing the assertion failures people (timo, myself) were getting.
Rob Moen [Wed, 9 Nov 2011 22:53:45 +0000 (22:53 +0000)]
essage=fix trumped line of code from svn update
gicode [Wed, 9 Nov 2011 22:44:12 +0000 (22:44 +0000)]
Add wfRemoveDotSegments and unit tests. This is a sane step towards fixing
bug 32168. This implements RFC3986 Section 5.2.4.
http://tools.ietf.org/html/rfc3986#section-5.2.4
This is important because you need to remove dot segments in order to safely
compare URLs when limiting URLs to a particular path.
Aaron Schulz [Wed, 9 Nov 2011 22:35:31 +0000 (22:35 +0000)]
Fixed misleading getItem() comments...things like arrays or FileDependency objects and what not can be returned
Rob Moen [Wed, 9 Nov 2011 22:08:38 +0000 (22:08 +0000)]
essage=This bug fixes bug30483
Diederik van Liere [Wed, 9 Nov 2011 21:15:48 +0000 (21:15 +0000)]
Commit to fix bug 30513.
Sam Reed [Wed, 9 Nov 2011 20:52:24 +0000 (20:52 +0000)]
Bug 31995 - Addition of PPFrame::getTitle
Applied patch by Van de Bugger
Added documentation to go with
Added code to Preprocess_HipHop too
Sam Reed [Wed, 9 Nov 2011 20:40:22 +0000 (20:40 +0000)]
Update RELEASE-NOTES-1.18 from branch
Raimond Spekking [Wed, 9 Nov 2011 20:18:41 +0000 (20:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Wed, 9 Nov 2011 17:34:52 +0000 (17:34 +0000)]
Move RELEASE-NOTES from r102416, after r102542
Roan Kattouw [Wed, 9 Nov 2011 17:20:05 +0000 (17:20 +0000)]
(bug 32256) API list=search stops at first invalid result. Thanks to Lupo for finding the cause of the bug: in the code path for invalid titles, the iterator wasn't moved to the next result, so the loop kept processing the same result until it hit the limit.
Antoine Musso [Wed, 9 Nov 2011 17:14:53 +0000 (17:14 +0000)]
move bug 29912 RN form 1.19 to 1.18
This follow up a manual merge of r101002 in REL1_18 made by r102535
Bug fix is:
(bug 29912) Unit tests break if parsertest tables are still present
Chad Horohoe [Wed, 9 Nov 2011 17:01:09 +0000 (17:01 +0000)]
Drop "selenium" user right. As far as I can tell, this isn't actually used anywhere (core or exts) and is leftover from the special page for selenium that was removed.
Antoine Musso [Wed, 9 Nov 2011 16:15:35 +0000 (16:15 +0000)]
split getHooksFromDoc() function
if() { LOT OF CODE } else { LOT OF CODE } structures are hard to read
move the LOT OF CODE piece in its own function makes code easier to
understand.
Jure Kajzer [Wed, 9 Nov 2011 15:50:24 +0000 (15:50 +0000)]
* phpunit fixes & optimizations for oracle backend
Alexandre Emsenhuber [Wed, 9 Nov 2011 15:31:55 +0000 (15:31 +0000)]
Some updates to EditPage and ExternalEdit:
* Made ExternalEdit use a context
* Updated DifferenceEngine to use ExternalEdit to send the diff stuff to reduce code duplication
* Introduced ExternalEdit::useExternalEngine() to check whether to use the external edit or diff (except for the action, section and oldid which are still checked in Wiki.php) to remove code duplication; external diff can now also be controlled with externaledit or internaledit URL parameters
* Use $wgContLang to get the name of the "Special" namespace instead of user's language
* Modified the line breaks in the comment on the top of the control file so that the URL is on its own line
* Updated extension to call EditPage::edit() instead of EditPage::submit(), the latter will just call the former
* Updated extension to let core handle itself the ExternalEdit mode instead of doing this themself
Alexandre Emsenhuber [Wed, 9 Nov 2011 11:39:52 +0000 (11:39 +0000)]
Use WikiPage instead of Article
Alexandre Emsenhuber [Wed, 9 Nov 2011 10:59:17 +0000 (10:59 +0000)]
Throw a FatalError exception instead of calling OutputPage::showFatalError() (on usage of $wgOut less)
Antoine Musso [Wed, 9 Nov 2011 10:24:54 +0000 (10:24 +0000)]
Allow \x1b (ascii ESC) in wfDebug() output
It is a local hack I had to let me pass colored debug message using a local
wrapper:
function wfDebugGreen($msg) {
$color = "\x1b[1;32m"; # Green
$reset = "\x1b[1;0m";
wfDebug( $color . $msg . $reset );
}
Ideally \x1b should only be kept if it is followed by /(\d+(;\d)?)?+m/
which should match the 'graphic rendering' ANSI escape code.
Antoine Musso [Wed, 9 Nov 2011 09:01:34 +0000 (09:01 +0000)]
Comments out console.log calls
Catched by Schnark on CR of r102303
Mark A. Hershberger [Wed, 9 Nov 2011 03:25:15 +0000 (03:25 +0000)]
fix bug #29102: Upgrade fails "Unknown character set: 'mysql4'"
by replacing "mysql4" with "binary"
Trivial enough to be backported, I think.
Platonides [Tue, 8 Nov 2011 23:23:23 +0000 (23:23 +0000)]
Delete LanguageSr_el.deps.php. LanguageSr_ec.php doesn't
contain any base class used in LanguageSr_el. Not even in r13157.
Platonides [Tue, 8 Nov 2011 23:01:30 +0000 (23:01 +0000)]
Add name for code tly: Talysh ( en.wikipedia.org/wiki/Talysh_language ).
There are translations in that language for the toolserver and
some extensions (AdminLinks, Babel, CategoryTree, Contest, GlobalUsage,
LanguageSelector, Todo, Translate and WikiData).
Platonides [Tue, 8 Nov 2011 22:27:25 +0000 (22:27 +0000)]
Mark as FIXME. This three calls leak a png filename in sys_get_temp_dir() each,
tempnam() like, not the two-words filenames of RandomImageGenerator::getRandomFilenames()
They aren't produced by ApiTestCaseUpload::fakeUploadFile() either.
Platonides [Tue, 8 Nov 2011 21:55:05 +0000 (21:55 +0000)]
Test for bug 32057.
Latent bug in quite unused preprocessing path (expansion of heading nodes),
which was exposed by r101291 and fixed in r102440.
This test is used to exercise that code path.