Gergő Tisza [Sun, 29 May 2016 21:14:28 +0000 (21:14 +0000)]
Fix required field calculation in AuthenticationRequest
Instead of only flagging fields which are required by a request
needed by all primairy providers, it should be enough if all
requests needed by some primary provider require that field.
Also make CreationReasonAuthenticationRequest non-required so that
the list of required form fields is more in sync with that of
pre-AuthManager code.
Bug: T85853
Change-Id: I9d33bd22295758cc532a260b1848616b41d94f12
Gergő Tisza [Wed, 25 May 2016 21:45:09 +0000 (21:45 +0000)]
Enable AuthManager by default
Second attempt, after fixing T135884.
(First attempt was I6695aa3da42fb2b088eaa8d1883ccbb67f2c0c38.)
Depends on:
https://gerrit.wikimedia.org/r/#/q/topic:authmanager-selenium,n,z
Bug: T135498
Change-Id: I756a82267cb9c44ec35146fbb4599b183747c741
jenkins-bot [Fri, 27 May 2016 12:43:09 +0000 (12:43 +0000)]
Merge "Special:UserLogin: Consolidate create account buttons"
Arlo Breault [Fri, 27 May 2016 02:48:01 +0000 (19:48 -0700)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
b0d48342e0c540c17b2c073833d4a7ab147e2852
Change-Id: I9eb00fdc854eac7ddfc37520bd6b3cf8913db523
jenkins-bot [Thu, 26 May 2016 23:46:29 +0000 (23:46 +0000)]
Merge "Use HTMLForm style sheets on mobile"
jenkins-bot [Thu, 26 May 2016 23:43:43 +0000 (23:43 +0000)]
Merge "Make the call match the function definition."
jenkins-bot [Thu, 26 May 2016 23:12:12 +0000 (23:12 +0000)]
Merge "Add LinksUpdate::getRevision()"
jenkins-bot [Thu, 26 May 2016 23:04:53 +0000 (23:04 +0000)]
Merge "Parser: Make makeKnownLinkHolder() protected, and remove $query handling"
Roan Kattouw [Mon, 23 May 2016 19:21:45 +0000 (12:21 -0700)]
Add LinksUpdate::getRevision()
Similar to getTriggeringUser(). Also propagate it
to subjobs similarly.
Bug: T135959
Change-Id: I3d894acaf3d85b790e5034c7d9f76bf94672f445
Kunal Mehta [Thu, 26 May 2016 22:00:49 +0000 (15:00 -0700)]
Parser: Make makeKnownLinkHolder() protected, and remove $query handling
Extensions shouldn't be calling this, just the Parser, so make it
protected. And since the only caller passes an empty array for $query,
we can just remove it entirely.
Change-Id: I3adbcaabbb40870eb3df1495c3c2743ff21f0c64
Kunal Mehta [Mon, 23 May 2016 05:55:38 +0000 (22:55 -0700)]
LinkBatch: Use TitleValue instead of Title
Replace the remaining instances of Title with TitleValue, and use
services from MediaWikiServices instead of calling deprecated singleton
functions.
Change-Id: I5d13939a76380fff6b787cea8d4a5f90c1a31a5d
Kunal Mehta [Fri, 13 May 2016 06:28:06 +0000 (23:28 -0700)]
Have Linker::getLinkColour() accept LinkTarget objects
Change-Id: I7d7318099a822f9ddd88c538274511e6d8a8f1bc
Kunal Mehta [Fri, 20 May 2016 02:01:48 +0000 (19:01 -0700)]
LinkCache: Don't try looking up NS_SPECIAL
Change-Id: I1afe8c780c3b12ae806ac19c4efb37c7033951ca
Kunal Mehta [Thu, 19 May 2016 22:09:19 +0000 (15:09 -0700)]
Add tests for Linker::getLinkColour()
Change-Id: Ic1553e21def47f5c4923ba747146b36b0b3ffdfc
Kunal Mehta [Fri, 13 May 2016 07:24:29 +0000 (00:24 -0700)]
ChangesList: Use LinkRenderer instead of Linker::link()
Change-Id: Iae32a9e365aad268d2671df6a0b916e4d9c0a801
jenkins-bot [Thu, 26 May 2016 21:31:40 +0000 (21:31 +0000)]
Merge "Parser: Replace Linker::link() with LinkRenderer"
jenkins-bot [Thu, 26 May 2016 21:26:30 +0000 (21:26 +0000)]
Merge "Send edit stash metrics for cache attempts"
jenkins-bot [Thu, 26 May 2016 21:22:00 +0000 (21:22 +0000)]
Merge "LinkRenderer: Re-implement noclasses as makePreloadedLink function"
Kunal Mehta [Fri, 13 May 2016 00:37:17 +0000 (17:37 -0700)]
Parser: Replace Linker::link() with LinkRenderer
Replaces usage of Linker::link() in Parser and LinkHolderArray with the
new LinkRenderer.
Change-Id: Icb796ef08d70926728732ab5468940c09ba5eaf8
Aaron Schulz [Thu, 26 May 2016 19:46:32 +0000 (12:46 -0700)]
Send edit stash metrics for cache attempts
Change-Id: I22d5626cca55c2cc35e1b33fced5902e8d364d40
jenkins-bot [Thu, 26 May 2016 21:01:39 +0000 (21:01 +0000)]
Merge "TitleParser: In formatTitle(), don't throw exceptions on bad namespaces"
Ori Livneh [Wed, 18 May 2016 09:19:20 +0000 (02:19 -0700)]
Whenever possible, reuse User objects in unit tests
The unit tests spend nearly half of their run time resetting the user table for
each test. But the majority of tests do not depend on the user table having the
exact value that the setup code resets it to, and do not need to modify the
user objects they require to run.
Fix that by providing an API for tests to get User objects, and to indicate
whether the User object will be subject to destructive modification or not.
This allows User objects to be reused across multiple unit tests.
Change-Id: I17ef1f519759c5e7796c259282afe730ef722e96
Kunal Mehta [Thu, 26 May 2016 20:29:02 +0000 (13:29 -0700)]
TitleParser: In formatTitle(), don't throw exceptions on bad namespaces
This ocassionally happens for whatever reason, but it doesn't really
make sense to throw an exception when creating a broken-looking link
would also work. We already do this for TitleParser::getPrefixedDBkey(),
and this also matches the behavior of Title::getNsText().
Bug: T136352
Bug: T136356
Change-Id: Ic7eb17f8917f7fbb28b11d94b742dac1fe5582a1
jenkins-bot [Thu, 26 May 2016 20:11:45 +0000 (20:11 +0000)]
Merge "Revert "build: Bump grunt-karma and related tools to 1.0.x""
jenkins-bot [Thu, 26 May 2016 20:11:01 +0000 (20:11 +0000)]
Merge "Bail out in ApiStashEdit for bots for sanity"
Translation updater bot [Thu, 26 May 2016 19:59:57 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I04fc4e9de4d4d0f4c8a13d559d6eafa91f1d70ac
Aaron Schulz [Thu, 26 May 2016 19:04:22 +0000 (12:04 -0700)]
Bail out in ApiStashEdit for bots for sanity
checkCache() is disabled in this case anyway.
Change-Id: I1c18585eecc1a7c4c0e24546799c7ee448b3ea57
Hashar [Thu, 26 May 2016 19:55:36 +0000 (19:55 +0000)]
Revert "build: Bump grunt-karma and related tools to 1.0.x"
Karma is suspected to have an issue disconnecting Chromium.
That causes the qunit job to idle even after all tests have
been completed.
This reverts commit
72b0d9da08d6ea8c1842d76aaefe8e57046a2026.
Bug: T136188
Change-Id: Id818f5a0d1983d0bffa545f7731a780bf2b9bf25
jenkins-bot [Thu, 26 May 2016 19:13:47 +0000 (19:13 +0000)]
Merge "Document thumbinner's block formatting context"
jenkins-bot [Thu, 26 May 2016 19:05:48 +0000 (19:05 +0000)]
Merge "mediawiki.special: Remove unused mediawiki.special.js"
Derk-Jan Hartman [Wed, 25 May 2016 21:27:00 +0000 (23:27 +0200)]
Document thumbinner's block formatting context
Document the side effect of setting overflow:hidden on thumbinner.
It's primary utility here is to clear the background of the block from
any floating content, avoiding potential overlap.
The property sets a new block formatting context.
Change-Id: I91b759cdd386cb648b1b704b0e7df708f6c4fa92
Aaron Schulz [Thu, 26 May 2016 18:36:40 +0000 (11:36 -0700)]
Exclude bots from edit stash stats
Change-Id: Id309879eaaf039de7ac5f531930fa8e758a959c7
jenkins-bot [Thu, 26 May 2016 18:21:19 +0000 (18:21 +0000)]
Merge "registration: Add --config-prefix to convertExtensionToRegistration.php"
jenkins-bot [Thu, 26 May 2016 18:05:16 +0000 (18:05 +0000)]
Merge "Revert "Thumbnails: allow overflow inside thumbnails""
jenkins-bot [Thu, 26 May 2016 17:59:12 +0000 (17:59 +0000)]
Merge "mediawiki.special.apisandbox: Use module.exports instead of mw.special"
jenkins-bot [Thu, 26 May 2016 17:58:25 +0000 (17:58 +0000)]
Merge "mediawiki.special.recentchanges: Use module.exports instead of mw.special"
Brad Jorsch [Wed, 25 May 2016 16:42:41 +0000 (12:42 -0400)]
registration: Add --config-prefix to convertExtensionToRegistration.php
For converting extensions that use custom prefixes.
Change-Id: I4fcf7ff2af04e9a0367de368503f2c70d8fed959
jenkins-bot [Thu, 26 May 2016 17:52:32 +0000 (17:52 +0000)]
Merge "Follow-up
276c30e: Use the correct hex for the green we want"
Timo Tijhof [Thu, 26 May 2016 17:42:21 +0000 (18:42 +0100)]
mediawiki.special: Remove unused mediawiki.special.js
'mediawiki.special' violates T92459 due to having both script and styles and
being loaded as a styles-only module. This avoids the warning from I8b6c6a10d.
> Unexpected general module 'mediawiki.special' in styles queue.
mw.special was first introduced in r90943 (
d4abcb526806). I regretted recommending it.
Change-Id: I7bb000c9946d194fd1ae7f9a18fbc031ba225f25
Timo Tijhof [Thu, 26 May 2016 17:40:41 +0000 (18:40 +0100)]
mediawiki.special.apisandbox: Use module.exports instead of mw.special
mw.special.ApiSandbox is not used anywhere, and it's an easy candidate for
converting to the new module export pattern.
This removes the last use of the 'mediawiki.special.js' file, which violates
T92459 due to having styles.
Change-Id: I9b6972d763f34d50479099d4d726d1c77a91c223
Timo Tijhof [Thu, 26 May 2016 17:35:28 +0000 (18:35 +0100)]
mediawiki.special.recentchanges: Use module.exports instead of mw.special
This isn't generally used as a public method. The only reason it's exposed is
for an integration test to access it.
This commit and others prepare for removal of the 'mediawiki.special.js' file.
This script does nothing other than create "mw.special = {};". While that init
pattern is common in extensions and not wrong, 'mediawiki.special' violates
T92459 due to having styles. Given there's only script uses of it, it's easiest
to remove it in favour of the new module export pattern.
Change-Id: I2e78828828601e1160550efe02c07172ac32e985
jenkins-bot [Thu, 26 May 2016 17:33:13 +0000 (17:33 +0000)]
Merge "collation: Remove suppressWarnings() for getSortKey()"
jenkins-bot [Thu, 26 May 2016 16:45:07 +0000 (16:45 +0000)]
Merge "Avoid DBPerformance warnings on PURGE/TRACE requests"
Ori Livneh [Mon, 23 May 2016 22:43:16 +0000 (15:43 -0700)]
collation: Remove suppressWarnings() for getSortKey()
Small optimization to IcuCollation::fetchFirstLetterData().
This used to suppress / restore warnings once per every letter of
every alphabet. The workaround for string casting and error
suppression is no longer needed as of PHP 5.3, in which the
bug was fixed.
Change-Id: Idd41a509858c0887df4f632b480b387bd74027b2
James D. Forrester [Thu, 26 May 2016 16:38:23 +0000 (09:38 -0700)]
Follow-up
276c30e: Use the correct hex for the green we want
Bug: T136175
Change-Id: I4ce6010d55c361c56584a36ac252a68f0d2ee363
Florian [Sat, 21 May 2016 23:36:21 +0000 (01:36 +0200)]
Special:UserLogin: Consolidate create account buttons
When logged in and not logged in. Both now shares the same styles
and DOM structure. The differences:
* When logged in, you don't get a "Don't have an account?" message
* When logged in, the button's label is "Create another account"
instead of "Join {wikiname}"
Bug: T135925
Change-Id: I90c7a1288af927a03da3ccf9499f625935742125
Gergő Tisza [Thu, 26 May 2016 14:24:22 +0000 (14:24 +0000)]
Use HTMLForm style sheets on mobile
Bug: T135779
Change-Id: I7152da816b979a2d41b57cd4c117ec8087c3ff7a
Gergő Tisza [Thu, 26 May 2016 14:16:52 +0000 (14:16 +0000)]
Change button text for *Credentials special pages
Bug: T135779
Change-Id: If6c2edab6a574bc961e47c7ea04ec0ef18e36491
Kunal Mehta [Wed, 25 May 2016 23:37:21 +0000 (16:37 -0700)]
LinkRenderer: Re-implement noclasses as makePreloadedLink function
'noclasses' makes more sense as a per-link option rather than an
instance member of the LinkRenderer instance, since it depends entirely
on whether the calling code has preloaded the link classes.
Introduce LinkRenderer::makePreloadedLink() which makes this clear and
requires passing in the classes as a separate parameter. As a side-
effect, due to the way LinkRenderer::mergeAttribs() is implemented, the
'class' attribute will always appear before the 'title' attribute in the
final output.
Change-Id: I0545aa9d7139794bc22f9d3d6d6eccde003b2982
Timo Tijhof [Tue, 10 May 2016 19:47:04 +0000 (20:47 +0100)]
resourceloader: Merge 'user.groups' into 'user' module
This is with T92459 in mind to simplify the process of splitting
the 'user' module for the styles-only queue.
Consequences:
* Cached HTML isn't relevant in practice since there is no caching for logged-in
users and this module is only for logged-in users. Even then, cached HTML will
work and may happen as browsers re-use HTML responses when revisiting a
privately cached page (after 304 Not Modified).
Note that OutputPage (via isKnownEmpty) only actually tries to load 'user.groups'
if the wiki has 'MediaWiki:Group-*.{js,css}' pages for the current user's groups.
- Old style queue request will continue to ask for user.groups which is now a
FileModule with no styles (simply concats the empty string to the bundle)
- Old load() request will resolve with an empty function.
* The are no known dependants of 'user.groups'. If there are, they will work
by proxy of it now being an empty module that just ensures 'user' is loaded.
* The security origin of 'user.groups' was USER_SITEWIDE. The origin of 'user'
is lower (USER_INDIVIDUAL). Pages that are restricted to USER_SITEWIDE
previously received user.groups, but won't anymore. This should be fine as
OutputPage::reduceAllowedModules() is mainly used to either allow everything
or restrict all the way down to CORE. The only exception is disallowUserJs()
if $wgAllowSiteCSSOnRestrictedPages is enabled (T73621) but that edge case was
made for Common.css, not Group-*.css.
Change-Id: I74cd2368ebd2989c5e1c22bea491a80beb0319dc
Aaron Schulz [Fri, 20 May 2016 03:31:19 +0000 (20:31 -0700)]
Avoid DBPerformance warnings on PURGE/TRACE requests
The former sometimes show up in the logs as they were causing
CentralAuth to use the master but the expectations treated
the request as a GET request. This makes things more
consistent.
Bug: T92357
Change-Id: I55bf3139c68f5926fe67a51cf0eb1b2ffe55d17b
jenkins-bot [Wed, 25 May 2016 23:31:53 +0000 (23:31 +0000)]
Merge "Use correct module name for stats in executeActionWithErrorHandling()"
jenkins-bot [Wed, 25 May 2016 22:12:27 +0000 (22:12 +0000)]
Merge "Restore Userlogin error/warning URL parameter"
Derk-Jan Hartman [Wed, 25 May 2016 21:23:48 +0000 (23:23 +0200)]
Revert "Thumbnails: allow overflow inside thumbnails"
This reverts commit
2964c2799f0c19ac4c765f025a2998a0f3baeff0.
Bug: T133439
Change-Id: Id16420e8f5fd73e31cba2d5415ae9c1730a5a32c
jenkins-bot [Wed, 25 May 2016 21:17:18 +0000 (21:17 +0000)]
Merge "Param &$html for the "LinkBegin" hook needs to be null if $text is null"
Gergő Tisza [Wed, 25 May 2016 20:04:41 +0000 (20:04 +0000)]
Restore Userlogin error/warning URL parameter
I accidentally removed this when rewriting for AuthManager.
Also change an ID into a CSS class for now since HTMLInfoField
does not support IDs.
Bug: T135775
Change-Id: I5663a02c9809dd573087a4a528702c949b938970
jenkins-bot [Wed, 25 May 2016 20:22:23 +0000 (20:22 +0000)]
Merge "Do not use $wgUser in Linker/LinkRenderer when sessions are disabled"
Translation updater bot [Wed, 25 May 2016 19:59:28 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7108f988a2c97e99bb3f889d0ecea55fceb0d95f
Gergő Tisza [Wed, 25 May 2016 19:54:47 +0000 (19:54 +0000)]
Do not use $wgUser in Linker/LinkRenderer when sessions are disabled
When MW_NO_SESSION is set, getting the user options for $wgUser will
result in an error. Check for that in the service definition, and
reuse that check in Linker.
Also removed an unused use clause.
Bug: T136124
Change-Id: Id6448d12e8f4a8a94852980e5eb6ccb202066822
Alexia E. Smith [Wed, 25 May 2016 19:52:46 +0000 (14:52 -0500)]
Make the call match the function definition.
Change-Id: I381fbc9b6ddbf27f4f7a79dc19eec0547e0fddbb
Aaron Schulz [Wed, 25 May 2016 19:31:19 +0000 (12:31 -0700)]
Use correct module name for stats in executeActionWithErrorHandling()
Change-Id: I7d300525c32877d6fcc940962c93b932dc4c9181
Marius Hoch [Wed, 25 May 2016 19:25:12 +0000 (21:25 +0200)]
Param &$html for the "LinkBegin" hook needs to be null if $text is null
To keep b/c with the old implementation.
Change-Id: I5fff92f47babe890fe0d3726dba6f60cc75ee708
jenkins-bot [Wed, 25 May 2016 18:36:11 +0000 (18:36 +0000)]
Merge "filerepo: Add missing quote back to LocalFileLockError message"
Aaron Schulz [Tue, 24 May 2016 09:55:16 +0000 (02:55 -0700)]
filerepo: Add missing quote back to LocalFileLockError message
Follows-up
e724d14495.
Change-Id: I48e304a307d3c0427f797a382dc23347bb7e914f
Volker E [Wed, 25 May 2016 16:02:38 +0000 (09:02 -0700)]
Fix regression: text color in `.mw-search-result-data`
Follow-up to I2ba04cc3ad9898c17fee3c65bb3bead834c3a1fd where `green` in
`.mw-search-result-data` was transcripted falsely into
`#0f0` instead of `#008000`.
Bug: T136175
Change-Id: I5d55718510650634a718d688a0e0698355097c6c
James D. Forrester [Mon, 23 May 2016 23:33:57 +0000 (16:33 -0700)]
Update es5-shim to v4.5.8
Project site
* https://github.com/es-shims/es5-shim
File source
* https://github.com/es-shims/es5-shim/tree/v4.5.8
Changelog
* https://github.com/es-shims/es5-shim/blob/v4.5.8/CHANGES
Change-Id: I4a6a703d7db00d7eaaeb1365c1c19f3ae055c440
jenkins-bot [Wed, 25 May 2016 13:13:33 +0000 (13:13 +0000)]
Merge "Remove explicit tabindex from diff links"
Brion Vibber [Tue, 24 May 2016 15:32:12 +0000 (08:32 -0700)]
Add LBFactory::closeAll() method
Needed to allow long-running background tasks to close out database
connections in a way that allows them to reopen later when needed
again.
Bug: T97641
Change-Id: I4974b691392d4225b15e7b771a28a2cefeb9d8e4
jenkins-bot [Wed, 25 May 2016 03:15:00 +0000 (03:15 +0000)]
Merge "Tidy: Add mw-empty-elt class"
Bartosz Dziewoński [Wed, 25 May 2016 01:10:02 +0000 (01:10 +0000)]
Merge "Update OOjs UI to v0.17.3"
Tim Starling [Wed, 25 May 2016 00:47:06 +0000 (10:47 +1000)]
Tidy: Add mw-empty-elt class
In hindsight, it was pretty silly to put the element name in the class.
This is to support an upcoming Html5Depurate change.
Change-Id: I38ddcdb7daf8f0e2bde9e019457fd4192d86e02b
James D. Forrester [Tue, 24 May 2016 22:53:46 +0000 (15:53 -0700)]
Update OOjs UI to v0.17.3
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.17.3
Change-Id: I3fe38754c18a83554593479ea1b01f8a60144435
jenkins-bot [Tue, 24 May 2016 23:59:24 +0000 (23:59 +0000)]
Merge "Support non-replicating DB clusters for static datasets"
Derk-Jan Hartman [Tue, 24 May 2016 18:16:07 +0000 (20:16 +0200)]
Remove explicit tabindex from diff links
These were added to Special:RecentChanges in 2004, but it doesn't
match what we do in any of the other lists. For accessibility
purposes, in flow indexing is preferred these days, or alternatively
a JS controlled roving tabindex, but this was neither.
Bug: T116127
Change-Id: Id455fafe4bdea40fb5988bdec14eed672844c8e3
jenkins-bot [Tue, 24 May 2016 21:10:08 +0000 (21:10 +0000)]
Merge "Simplify code for updating tooltips with accesskey tips"
Translation updater bot [Tue, 24 May 2016 20:21:58 +0000 (22:21 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3941ec39a42414aa051ab58922267e143c5b30f1
Matthew Flaschen [Thu, 19 May 2016 21:10:35 +0000 (17:10 -0400)]
RevDel: Fix ChangeTags for archived items
Bug: T128980
Change-Id: Ibc9ec57da16e1b71c9efa0d2c062f8d7965f59bc
jenkins-bot [Tue, 24 May 2016 18:31:55 +0000 (18:31 +0000)]
Merge "Revert "Convert Special:NewFiles to use OOUI.""
Bartosz Dziewoński [Tue, 24 May 2016 18:05:25 +0000 (18:05 +0000)]
Revert "Convert Special:NewFiles to use OOUI."
Removing the 'hidden' fields from the HTMLForm definition
means that they are no longer preserved when the form is
resubmitted. I think that's a problematic regression.
This reverts commit
179e2f892d7811fa5613e1d6e0d5626e52c93b31.
Change-Id: Ib84dca5119b7a5270b349c5d1164541a5f082d96
jenkins-bot [Tue, 24 May 2016 16:41:45 +0000 (16:41 +0000)]
Merge "Convert Special:NewFiles to use OOUI."
jenkins-bot [Tue, 24 May 2016 16:41:40 +0000 (16:41 +0000)]
Merge "Convert Special:WithoutInterwiki to OOUI"
jenkins-bot [Tue, 24 May 2016 15:27:07 +0000 (15:27 +0000)]
Merge "Document what User::newSystemUser()'s "stealing" does"
jenkins-bot [Tue, 24 May 2016 15:27:02 +0000 (15:27 +0000)]
Merge "Improve some documentation of AuthManager's additions"
Brad Jorsch [Tue, 24 May 2016 15:05:47 +0000 (11:05 -0400)]
Document what User::newSystemUser()'s "stealing" does
Also improves a few other comments in the method.
Change-Id: I87e293c0ef487ef15bee8fbe1085d530c99a7b07
jenkins-bot [Tue, 24 May 2016 11:13:44 +0000 (11:13 +0000)]
Merge "Disable CAS check when saving TestUser data."
daniel [Thu, 19 May 2016 12:51:04 +0000 (14:51 +0200)]
Disable CAS check when saving TestUser data.
During testing, we are not worried about data loss, so we can safely
bypass the CAS check when setting up a test fixture.
This change was added to address sporadic test failures like the following:
18:03:38 1) ApiEchoMarkReadTest::testMarkReadWithList
18:03:38 MWException: CAS update failed on user_touched for user ID '2' (read from slave); the version of the user to be saved is older than the current version.
18:03:38
18:03:38 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/user/User.php:3931
18:03:38 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/includes/TestUser.php:83
18:03:38 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/includes/api/ApiTestCase.php:30
18:03:38 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Echo/tests/phpunit/api/ApiEchoMarkReadTest.php:11
18:03:38 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:370
Bug: T131178
Change-Id: I99b43e0db85bc2c1cd335c82971df4e95520d34b
Aaron Schulz [Tue, 24 May 2016 07:06:36 +0000 (00:06 -0700)]
Add the LockManager error to LocalFileLockError exceptions
Change-Id: Ibfa7312993806554f7939b4f5692e30714f71304
jenkins-bot [Tue, 24 May 2016 03:29:32 +0000 (03:29 +0000)]
Merge "Add LinkRenderer (rewrite of Linker::link())"
jenkins-bot [Tue, 24 May 2016 03:29:28 +0000 (03:29 +0000)]
Merge "Avoid invidual LinkCache lookups in Linker::makeBrokenImageLinkObj()"
jenkins-bot [Tue, 24 May 2016 03:19:35 +0000 (03:19 +0000)]
Merge "Cleanup Special:PrefixIndex::showPrefixChunk()"
jenkins-bot [Tue, 24 May 2016 03:07:15 +0000 (03:07 +0000)]
Merge "TraditionalImageGallery: Preload Titles being linked into LinkCache"
jenkins-bot [Tue, 24 May 2016 03:07:01 +0000 (03:07 +0000)]
Merge "Remove 'noclasses' from Linker::linkKnown() defaults"
Bartosz Dziewoński [Thu, 19 May 2016 17:22:06 +0000 (19:22 +0200)]
Simplify code for updating tooltips with accesskey tips
After
79e095fd, we can assume that if this code runs, then the fast
querySelectorAll() is available, and therefore jQuery will use it
rather than its polyfill.
This completes the fix for T60255 started in
ed85c136.
Change-Id: I6b905ffb8ccf791d0edebfc15f2a4f1d1a57fbe1
jenkins-bot [Mon, 23 May 2016 22:26:18 +0000 (22:26 +0000)]
Merge "Lowered incrTableUpdate() batch size to $wgUpdateRowsPerQuery"
jenkins-bot [Mon, 23 May 2016 21:27:51 +0000 (21:27 +0000)]
Merge "Remove unused import in MediaWikiServices"
jenkins-bot [Mon, 23 May 2016 21:06:26 +0000 (21:06 +0000)]
Merge "Batch updateNotificationTimestamp() UPDATE queries (without wl_id)"
jenkins-bot [Mon, 23 May 2016 21:02:50 +0000 (21:02 +0000)]
Merge "RollbackAction: Implement AJAX interface and require POST"
Translation updater bot [Mon, 23 May 2016 20:00:48 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I00c9bd3bf3a03e38b1cc2573212bfae257d3dc4c
umherirrender [Mon, 23 May 2016 18:49:21 +0000 (20:49 +0200)]
Batch updateNotificationTimestamp() UPDATE queries (without wl_id)
The new primary key is not usable in production (T130067), so batch the
query using the old where condition.
Some code ideas from I3dbe1de4cf39499728a2077a71157d4bcc203e44
Bug: T134613
Change-Id: Ic12926a5166f7578a1136c7944d883c2fe1f3b3a
Timo Tijhof [Tue, 29 Sep 2015 02:53:20 +0000 (19:53 -0700)]
RollbackAction: Implement AJAX interface and require POST
Similar to WatchAction (converted in commit
77cdf1919).
* Make FormAction::getFormFields not abstract.
In most cases this will just be an empty array.
* Convert RollbackAction from FormlessAction to FormAction and implement the
required error handling scenarios (mostly moved out of from the old method, or
duplicated from the WikiPage method where necessary).
* In most cases the in-between form is never used since a JavaScript handler
takes over the link and uses the API over AJAX instead. In the no-js fallback
(as well as for any existing tokenless rollback links) copy the GET parameters
into the form for re-submission as POST (plus token, added by HTMLForm).
* Remove the distinction between WebUI and API tokens. This stronger token salt made it
unnecessarily complex and was only there because it used GET until now. This streamlining of
tokens matches what we already do for 'watch', 'edit', 'patrol' and other actions.
* Fix form submission bugs when 'from' query parameter is missing.
- Ensure the required 'from' query parameter is present before showing a form.
No need for the user to submit a form we know will fail.
- Plain GET request to action=rollback (with no parameters) is now a 400 Bad Request
instead of a form that would fail when submitted.
- Submitting the form without 'form' field now correctly says why it failed.
Previously it emitted a session error, which was a lie.
Bug: T88044
Change-Id: Ia457802fec2e90573c8e7d552bc1f3cee258f10b