Niklas Laxström [Wed, 27 Feb 2013 08:56:06 +0000 (08:56 +0000)]
Docs, typofix, additional testcase for I7be51e
Change-Id: I0ab17cb749c23b666e0bb1ee61fe7d424e717fde
umherirrender [Tue, 26 Feb 2013 20:16:46 +0000 (21:16 +0100)]
Added missing @deprecated doc to File and Title
Change-Id: I32bd054e97905a5a763e47daecf4be615981a3ff
jenkins-bot [Wed, 27 Feb 2013 04:02:35 +0000 (04:02 +0000)]
Merge "Make maintenance/update.php parse again under PHP 4.1.0"
Kaldari [Wed, 27 Feb 2013 02:14:52 +0000 (02:14 +0000)]
Merge "Expose additional user attributes as JS vars"
Ori Livneh [Tue, 22 Jan 2013 22:44:22 +0000 (14:44 -0800)]
Expose additional user attributes as JS vars
This change adds user ID, registration time, and edit count to the
default set of JavaScript configuration variables.
These values are all included in $mCacheVars and so require no additional
database lookups.
Change-Id: Id0adb795567d4ba932104938f2793cdb4084883c
Brad Jorsch [Tue, 26 Feb 2013 23:19:52 +0000 (15:19 -0800)]
(bug 44923) Fix API upload with only one chunk
The API supports chunked uploads to upload a file in multiple pieces.
But it doesn't check if the the entire file is uploaded in the first
chunk, so it winds up waiting for a subsequent chunk that can never
come.
It's actually fairly easy to fix, we just need to move the check for
"did we get the entire file?" outside of the "if we're getting a chunk
after the first" check.
Change-Id: I915c1678dfa3107f1739fed8613ab9452139b946
jenkins-bot [Wed, 27 Feb 2013 00:04:21 +0000 (00:04 +0000)]
Merge "Fix UploadStash::removeFile() error"
jenkins-bot [Tue, 26 Feb 2013 23:58:32 +0000 (23:58 +0000)]
Merge "[Upload] Moved async upload stuff to the job queue."
Brad Jorsch [Tue, 26 Feb 2013 23:15:17 +0000 (15:15 -0800)]
Fix UploadStash::removeFile() error
If nothing has called getFile() for a key before that key is passed to
removeFileNoAuth(), UploadStash will throw a fatal error when it tries to
remove the file from the filesystem because the UploadStashFile was
never created.
Change-Id: Idf0d2c53ce759b59836f34ff5aaad393b8c371c6
MatmaRex [Tue, 26 Feb 2013 21:13:51 +0000 (22:13 +0100)]
Revert "(bug 29788) Swedish Collation (uppercase-sv). Swaps Ä and Æ"
This workaround is unnecessary now that I838484b9 was merged.
This reverts commit
13dc8ff88f48e0bb18750f5e98d50cdb8057c0d3.
Change-Id: I2cd22ad87eb7a56c5742b20c6089a4b8607e5614
jenkins-bot [Tue, 26 Feb 2013 21:34:35 +0000 (21:34 +0000)]
Merge "(bug 44921) API should properly handle OPTIONS"
Translation updater bot [Tue, 26 Feb 2013 21:00:46 +0000 (21:00 +0000)]
Merge "Localisation updates from translatewiki.net."
Brad Jorsch [Tue, 26 Feb 2013 20:41:00 +0000 (12:41 -0800)]
(bug 44921) API should properly handle OPTIONS
When given an OPTIONS request, ApiMain should return just after the CORS
check. It should not actually execute the action or return any response
body.
Change-Id: I1c16cb89e777aaac69ae86b532d16f4c10a1f1d2
Platonides [Tue, 26 Feb 2013 20:52:23 +0000 (21:52 +0100)]
Make maintenance/update.php parse again under PHP 4.1.0
The instanceof produces a parse error on old PHP versions,
which doesn't show the old-version error message.
Note that our is minimum PHP version is 5.3.2, so it won't
produce E_STRICTs (is_a() was undeprecated in 5.3.0)
Change-Id: I5904301759bd154dd87ed90a5176369e37346482
jenkins-bot [Tue, 26 Feb 2013 20:50:58 +0000 (20:50 +0000)]
Merge "(bug 43270) Add wgPostEdit to show if user just saved this page"
Aaron Schulz [Thu, 21 Feb 2013 22:03:26 +0000 (14:03 -0800)]
Avoid pool fragmentation in RedisConnectionPool.
* Avoid fragmenting the client pools due to "poolSize" differences.
Instead that config parameter does not affect the pool something uses,
but the pool used will grow to fit the pool size of anything using it.
Change-Id: Ibc9db7cfc277824b1acde5e6fbf1db0ed296cb41
Aaron Schulz [Thu, 21 Feb 2013 21:33:12 +0000 (13:33 -0800)]
[BagOStuff] Converted RedisBagOStuff to RedisConnectionPool.
Change-Id: I9c269b77e51d335702146d15ebbfd38167c4ed1d
Translation updater bot [Tue, 26 Feb 2013 20:22:07 +0000 (20:22 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ifc278590545d0516a7470abbb4ef0cc0f297c0a4
MatmaRex [Mon, 18 Feb 2013 21:09:16 +0000 (22:09 +0100)]
(bug 43799) create language-specific collations for category sorting
This allows one to *finally* get articles to be correctly sorted on
category pages for 67 languages based in latin, greek and cyrillic
alphabets.
Fixes bug 29788, bug 41040, and bug 42412 (implementing collations for
Swedish, Polish, Ukrainian).
Full list of language codes this adds support for: af, ast, az, be,
bg, br, bs, ca, co, cs, cy, da, de, dsb, el, en, eo, es, et, eu, fi,
fo, fr, fur, fy, ga, gd, gl, hr, hsb, hu, is, it, kk, kl, ku, ky, la,
lb, lt, lv, mk, mo, mt, nl, no, oc, pl, pt, rm, ro, ru, rup, sco, sk,
sl, smn, sq, sr, sv, tk, tl, tr, tt, uk, uz, vi.
* Include data about first-letter characters for 67 language
tailorings. This data was generated from based on
http://developer.mimer.com/charts/tailorings.htm by a Ruby script
(https://www.mediawiki.org/wiki/User:Matma_Rex/generateCollationTailoringData.rb),
then adjusted by hand (removed duplicate definitions for Spanish and
German, changed code fil -> tl (Filipino -> Tagalog).
* Mark languages verified by native speakers (currently only pl
(Polish) I verified by myself and fi (Finnish) checked by Niklas).
* Allow for collations named like 'uca-<langcode>', mapping them to
IcuCollation with appropriate parameter. The code doesn't check if
we actually have data for given language, as it's checked after the
IcuCollation class instance is constructed.
* Add the tailoring data to the default first-letter file (for root
collation) before it's cached for given locale.
Change-Id: I838484b9aaf23945fe7880fef2e3da5f5c06877f
jenkins-bot [Tue, 26 Feb 2013 18:56:35 +0000 (18:56 +0000)]
Merge "Script calling cleanups"
jenkins-bot [Tue, 26 Feb 2013 18:35:24 +0000 (18:35 +0000)]
Merge "(bug 45417) Remove resetArticleID() call from RecentChanges::getTitle()"
jenkins-bot [Tue, 26 Feb 2013 17:30:00 +0000 (17:30 +0000)]
Merge "Put the check for empty comment outside of the section anchor section of EditPage::internalAttemptSave()"
jenkins-bot [Tue, 26 Feb 2013 17:01:31 +0000 (17:01 +0000)]
Merge "(bug 44219) Avoid fatal errors when a revision doesn't exist in action=info"
Santhosh Thottingal [Thu, 14 Feb 2013 11:55:41 +0000 (17:25 +0530)]
Remove temporary plural overrides for fa, hu, ja, vi
These overrides were done for Bug 40251, but fixed later in
I345c305134a62d43c9dfedc5243981d0e77e326d
Change-Id: I8c1cc0055722ddd31d04fbd9b6cb1215adde23c6
Santhosh Thottingal [Thu, 14 Feb 2013 10:26:13 +0000 (15:56 +0530)]
Remove MediaWiki overrides for plural rules for Scots Gaelic (gd)
Also cleanup the tests.
Change-Id: Ic29026a7a8128b890882b8869569309ab05e4226
Alexandre Emsenhuber [Tue, 26 Feb 2013 15:33:13 +0000 (16:33 +0100)]
(bug 45417) Remove resetArticleID() call from RecentChanges::getTitle()
This is doing more harm than good; see I489c406f (
4769f44) for a similar issue.
The problem is that if resetArticleID() get called with a strictly positive value
when the page does not exist, getArticleID() will return that value indicating that
the page exists, but the LinkCache will return null for complementary fields, causing
the exception mentionned in the bug.
By removing the resetArticleID() call, the ID will get loaded from the LinkCache, and
thus the whole Title object is in a consistent state.
Since a LinkBatch is already executed for those titles from Special:Recentchanges and
Special:Watchlist, this will not increase the number of database queries for those
special pages (and even lowers it from what I saw on my development wiki).
Change-Id: I8742cce46908ce8eb3fee55c1b6e458732b1ebd7
jenkins-bot [Tue, 26 Feb 2013 15:27:31 +0000 (15:27 +0000)]
Merge "(Bug 44987) Allow n=form in plural syntax"
Niklas Laxström [Tue, 26 Feb 2013 10:41:02 +0000 (10:41 +0000)]
Refresh docs for wfMessage
Change-Id: I53d2d32e7d6972171f3c2430412a44eea0b5b0a8
jeroendedauw [Wed, 6 Feb 2013 10:53:10 +0000 (11:53 +0100)]
Extend ... magic to also work when "others" is linked somewhere
Change-Id: I8c6657c95061b066ed48f115e771889a507bd268
jenkins-bot [Tue, 26 Feb 2013 10:22:32 +0000 (10:22 +0000)]
Merge "Commafy support for convertNumber"
Aaron Schulz [Mon, 25 Feb 2013 18:26:25 +0000 (10:26 -0800)]
Mention the batch-download time in copyFileBackend.php.
Change-Id: Idc46f9ed276d116b5b7eda0fbf354659243b646f
jenkins-bot [Tue, 26 Feb 2013 08:40:00 +0000 (08:40 +0000)]
Merge "(bug 35753) Allow {{FORMATNUM}} to only do digit transform"
Pavel Selitskas [Wed, 28 Nov 2012 10:24:45 +0000 (13:24 +0300)]
(bug 35753) Allow {{FORMATNUM}} to only do digit transform
{{formatnum:
1234567.89|NOSEP}} will perform only digit transformations.
Change-Id: Ic882d5ba087665030144e85248680acece8aa901
Platonides [Wed, 20 Feb 2013 23:52:24 +0000 (00:52 +0100)]
Remove dead code.
$initialTime was never used. It was probably a clever trick
for an old time where ProfilerSimple used globals.
Change-Id: I34fd952127914d50ce4d12b6f9275926496aff9d
jenkins-bot [Tue, 26 Feb 2013 01:50:44 +0000 (01:50 +0000)]
Merge "Concatenate two literals"
jenkins-bot [Tue, 26 Feb 2013 00:40:00 +0000 (00:40 +0000)]
Merge "Add PagesWithProp special page and API module"
Mark Holmquist [Mon, 25 Feb 2013 23:37:43 +0000 (15:37 -0800)]
(bug 45396) Use IETF example domains, not Britney
I don't know why Britney-Spears was in core parser tests as the example domain
name, but....well, suffice it to say she's not any more. We're using
example.org now, like sane people.
Change-Id: I47b53b94b4d7e8ad4a992de5e112685df48156c2
Brad Jorsch [Mon, 31 Dec 2012 21:30:24 +0000 (16:30 -0500)]
Add PagesWithProp special page and API module
It would be useful to be able to list pages using a particular page
property, particularly in light of the new Disambiguator extension.
This adds a special page Special:PagesWithProp and an API query module
list=pageswithprop to do just this. It also adds an API query module
list=pagepropnames to list the prop names currently in use on the wiki.
Change-Id: Ib0d4e17f22b8d0cb9894eac6095962315480e809
Reedy [Mon, 25 Feb 2013 23:57:31 +0000 (23:57 +0000)]
Add a wfWaitForSlaves() call at the end of sql.php
Useful if you're doing queries over many wikis (wmf usage) that might
induce some repllag
Change-Id: I9818f1763d3330d0b96d9bb9c192a957293b6a5b
GWicke [Mon, 25 Feb 2013 23:30:42 +0000 (23:30 +0000)]
Merge "Additional tests to catch future Parsoid regressions."
jenkins-bot [Mon, 25 Feb 2013 22:54:48 +0000 (22:54 +0000)]
Merge "Add pp_propname_page index to page_props"
Platonides [Mon, 25 Feb 2013 20:09:38 +0000 (21:09 +0100)]
Script calling cleanups
· Use env(1) in shebangs instead of hardcoding paths.
· $IP is already set in the constructor of Maintenance classes.
· Add sapi guard to some phpunit files.
Change-Id: I6c6fd6c61e2861b5992f2ccd67a4e3f62e2c445e
Ori Livneh [Mon, 25 Feb 2013 08:15:40 +0000 (00:15 -0800)]
Flip order of conditionals and add explanatory note
The conditional is nominally more performant and considerably more readable
with its constituents flipped. Also adds an explanatory note. Prompted by
confusion over change Ie89507f8e98c365df9d93a7633223103b9025790.
Change-Id: I2d3db63bdbcebe0fd59c063c9f371362c9d07f91
Matthew Flaschen [Sat, 23 Feb 2013 10:35:22 +0000 (05:35 -0500)]
(bug 43270) Add wgPostEdit to show if user just saved this page
* Sets short-lived cookie in EditPage
* Adds JS module, 'mediawiki.action.view.postEdit', to all views to
convert cookie to wgPostEdit. This avoids caching the variable in the
HTML.
* Based in part on PostEdit extension
Change-Id: Ie89507f8e98c365df9d93a7633223103b9025790
Translation updater bot [Mon, 25 Feb 2013 20:53:03 +0000 (20:53 +0000)]
Localisation updates from translatewiki.net.
Change-Id: If14859a3c91bd48ed6597473a516f65f7da812aa
Mark Holmquist [Fri, 22 Feb 2013 00:15:15 +0000 (16:15 -0800)]
(bug 43661) Add link trail and link prefix to API
This is more than just fetching messages -- we also check whether the messages
are enabled via the preferences and configuration. If not, the variables won't
be there.
Change-Id: If617f43004dbd42f7eaa6f75010cdc5a0a662f60
jenkins-bot [Mon, 25 Feb 2013 18:22:13 +0000 (18:22 +0000)]
Merge "(bug 41716) Add variant config to siprop=general"
Mark Holmquist [Wed, 20 Feb 2013 19:15:35 +0000 (11:15 -0800)]
(bug 41716) Add variant config to siprop=general
Parsoid again needs some extra information, this time so we can support
language variant conversion on our side of things. Added to properties to the
general siteinfo property.
Change-Id: I1ec7da2ec5b08228e74fec4fb366dae26cab8936
jenkins-bot [Mon, 25 Feb 2013 17:54:48 +0000 (17:54 +0000)]
Merge "Make ApiEditPage use Article::newFromWikiPage() and add user to context"
jenkins-bot [Mon, 25 Feb 2013 08:55:30 +0000 (08:55 +0000)]
Merge "Misc follow-ups to I2fc3966e (
a161c5e)"
Translation updater bot [Sun, 24 Feb 2013 20:17:53 +0000 (20:17 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ia33a43b0df52af2259663153f4e8fe50a3a024b5
jenkins-bot [Sun, 24 Feb 2013 14:46:44 +0000 (14:46 +0000)]
Merge "Remove gaps from $wgFileExtensions array"
Lee Worden [Sun, 24 Feb 2013 07:15:11 +0000 (23:15 -0800)]
Remove gaps from $wgFileExtensions array
If $wgFileExtensions contains values that are in $wgFileBlacklist,
when Setup.php uses array_diff to remove them it leaves $wgFileExtensions
as an array with nonconsecutive integer indices.
When this array is encoded by the Xml class, for use in client-side
JavaScript, the nonconsecutive indices cause it to encode it as an
Object rather than Array. This breaks the extension processing in
UploadWizard's JS code. To fix this, use array_values to remove the
gaps in indices.
Bug: 44776
Change-Id: I4ef7f1de90a0384800722839f3fa3a581c63bac9
Alexandre Emsenhuber [Sun, 24 Feb 2013 10:34:50 +0000 (11:34 +0100)]
Make ApiEditPage use Article::newFromWikiPage() and add user to context
- Changed the creation of the Article object in ApiEditPage::execute() to
use Article::newFromWikiPage(), this allows to re-use the already-existing
WikiPage object in that method instead of having to create a new one.
Article::newFromTitle() was used before, but for some reason this got
reverted back to "new Article" with the merge of the Wikidata branch.
- Removed the call to WikiPage::clear() added in I1d28164d (
2c27926); no
longer needed since the WikiPage object is now already up to date after
the edit.
- Added WikiPage and User objects to the context passed to the created
Article object; follow-up to I74394282 (
078334f).
Change-Id: I53088a42ef7592aaba7449ef3f84f77f2e07b2f5
jenkins-bot [Sun, 24 Feb 2013 10:29:36 +0000 (10:29 +0000)]
Merge "XML format: fix "Unrecognized parameter" warning"
Kevin Israel [Sun, 24 Feb 2013 02:16:03 +0000 (21:16 -0500)]
Web installer: fix "Upgrade existing installation"
Fixes a regression caused by Ic166066a: when updating an
existing database, the web installer uses the DatabaseUpdater
class, which requires Maintenance.php.
Bug: 45257
Change-Id: Ie2dc80ab1e0cd9a9552b51dce6681f748aa38ab7
Kevin Israel [Sat, 23 Feb 2013 21:19:29 +0000 (16:19 -0500)]
XML format: fix "Unrecognized parameter" warning
ApiMain::reportUnusedParams() is called before the XML formatter is
executed, so using "includexmlnamespace" or another such parameter
causes the incorrect generation of a warning. This patch corrects
the issue by explicitly excluding valid formatter parameters from
the list of unused parameters.
This does not need a release note because MediaWiki 1.20 did not
generate this kind of warning.
Change-Id: I269a6e07aa245099c811947d7832e1aa6fcfb9ec
Translation updater bot [Sat, 23 Feb 2013 20:10:36 +0000 (20:10 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ifd281891424d5f523b9b5ba342ad2b6e6c8e596d
umherirrender [Mon, 18 Feb 2013 18:55:08 +0000 (19:55 +0100)]
Pass user to File::recordUpload to avoid $wgUser
Moves the giving of a user one level up, because File::recordUpload2
already needs this (and fallback to $wgUser).
Can also use the user for the watching of the file, which was using
$wgUser before.
Change-Id: I697ae0df65b07ea59ab11b62804853cdc03cb172
Matthew Flaschen [Sat, 23 Feb 2013 10:42:05 +0000 (05:42 -0500)]
Change comment:
From ResourceLoaderStartupScript to ResourceLoaderStartUpModule
Change-Id: Ie5640752bed3d71d7e519385c139fe8490bd7052
Matthew Flaschen [Sat, 23 Feb 2013 06:25:19 +0000 (01:25 -0500)]
Fix documentation error for $expire in WebResponse::setcookie.
Change-Id: I657ba9b722706d3c71a6fffa3f4b94d35d8de7c5
jenkins-bot [Sat, 23 Feb 2013 02:35:09 +0000 (02:35 +0000)]
Merge "Initial JSDuck implementation"
Timo Tijhof [Sun, 13 Jan 2013 00:47:00 +0000 (01:47 +0100)]
Initial JSDuck implementation
* Adding configuration files for jsduck.
* Fixing our previously undocumented code documentation to comply
with jsduck specifications
.. for the following modules:
- mediawiki
- mediawiki.Title
- mediawiki.util
- mediawiki.notification
- mediawiki.api (and plugins thereof)
- jquery.localize
I've choose these to show as many different examples for
different types of modules and methods that we encounter
in our code base.
Hopefully with this as a start it will be easy for other people
to extend the documentation for most (if not, all) other modules
we have in MediaWiki core.
Change-Id: Ieb8c5d2d2cb4672f1d6abc3f865c6fb1470d8feb
jenkins-bot [Fri, 22 Feb 2013 21:46:32 +0000 (21:46 +0000)]
Merge "phpcs: Naming of GlobalFunctions tests classes."
Translation updater bot [Fri, 22 Feb 2013 19:52:31 +0000 (19:52 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I936368bae0a6ab95ec4cc62d4a993efe24fcd084
jenkins-bot [Fri, 22 Feb 2013 19:39:28 +0000 (19:39 +0000)]
Merge "(bug 44988) unbreak $.suggestions up/down arrow navigation [regression]"
Subramanya Sastry [Fri, 22 Feb 2013 16:12:52 +0000 (10:12 -0600)]
Additional tests to catch future Parsoid regressions.
Change-Id: I1fd9bb201983769d19c1b8fd5a5422f89258722c
jenkins-bot [Fri, 22 Feb 2013 15:42:02 +0000 (15:42 +0000)]
Merge "[FileRepo] Changed LocalFile locking to avoid breaking transactions."
Demon [Fri, 22 Feb 2013 15:41:43 +0000 (15:41 +0000)]
Merge "Allow adding arbitrary properties to OutputPage"
jenkins-bot [Fri, 22 Feb 2013 15:36:12 +0000 (15:36 +0000)]
Merge "properly stop output buffering"
Antoine Musso [Thu, 14 Feb 2013 21:13:35 +0000 (22:13 +0100)]
(bug 20281) test the parsing of inline URLs.
It turns out we did not have a parser test to check we properly parse
inline URL such as:
http://en.wikipedia.org/wiki/Main_Page
That should create a basic anchor pointing to the URL and containing the
full URL.
Change-Id: I1d1240b21e7b1b7c79d0ba224c8de2767bf9a2c1
X-EasterEgg: yes
jenkins-bot [Fri, 22 Feb 2013 00:55:32 +0000 (00:55 +0000)]
Merge "Give a 200 response for valid user pages"
Ryan Lane [Thu, 21 Feb 2013 22:45:57 +0000 (14:45 -0800)]
Give a 200 response for valid user pages
Rather than sending a 404 on empty user pages, send a 200 response.
It's ideal to use the user's page as an OpenID identity url, but
OpenID expects 200 responses on identity urls. If we send 404s on
empty user pages it's necessary for all users to have content on
their pages to use Wikimedia as a provider. This change eliminates
that requirement.
Fixes: bug 45241
Change-Id: I527aa9d9c19c5cef7bebde78ef22f426bcbb3cd6
jenkins-bot [Fri, 22 Feb 2013 00:21:54 +0000 (00:21 +0000)]
Merge "Add tests for wfParseUrl()"
Alexandre Emsenhuber [Thu, 21 Feb 2013 10:03:53 +0000 (11:03 +0100)]
Add tests for wfParseUrl()
Follows-up Ife07d6e2 (
a7c103a).
Change-Id: Ie32cf604959829904fb8661347edbbd94091d84b
Timo Tijhof [Thu, 21 Feb 2013 23:58:19 +0000 (00:58 +0100)]
phpcs: Naming of GlobalFunctions tests classes.
Code convensions:
Class names should be UpperCamelCase.
And for PHPUnit:
Class name should end in 'Test'.
Class name should match file name.
Also made headers and spacing a bit more consistent.
Change-Id: Id7b6cec7e552240de44386b4759b57c2d37a39d1
jenkins-bot [Thu, 21 Feb 2013 21:51:06 +0000 (21:51 +0000)]
Merge "Made sql.php except a "cluster" option and cleaned up the arguments."
Aaron Schulz [Thu, 21 Feb 2013 20:48:35 +0000 (12:48 -0800)]
Made sql.php except a "cluster" option and cleaned up the arguments.
* This lets people choose to run the script on some external cluster
instead of only the primary cluster for a given wiki ID.
Change-Id: I6e8c10bc772d4a26c38f2ed8ae5787c8d130bd4c
Aaron Schulz [Thu, 21 Feb 2013 19:45:51 +0000 (11:45 -0800)]
Various job queue documentation tweaks.
Change-Id: I2fcd2470f4e9e29d44cccc9e4d82d0380fe48434
Aaron Schulz [Thu, 21 Feb 2013 20:21:33 +0000 (12:21 -0800)]
Changed blob table to use InnoDB.
Change-Id: Ied2f1bf7577e6afe1d09222ada6be54cedeec574
Translation updater bot [Thu, 21 Feb 2013 20:05:04 +0000 (20:05 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ic7add4176c7a91730c80ef24ebf64d54bdfcf771
Aaron Schulz [Wed, 20 Feb 2013 18:49:10 +0000 (10:49 -0800)]
Cleanups for runJobs.php.
* Handle exceptions in run() better.
* Made the profiling more accurate.
* Simplified the code to handle non-boolean results of run().
wfWarn() was removed, and bugs reports were already filed.
Change-Id: Ic702319420efbdf12c17d51494255a64a6212d99
jenkins-bot [Thu, 21 Feb 2013 18:57:16 +0000 (18:57 +0000)]
Merge "PHPUnit/Framework.php was removed in 2010"
Alexandre Emsenhuber [Thu, 21 Feb 2013 13:44:53 +0000 (14:44 +0100)]
Put the check for empty comment outside of the section anchor section of EditPage::internalAttemptSave()
Also reorganise checks for better clarity
Change-Id: Ib75b2c0b0c240459d58618eed283b547aaefd7f6
Aaron Schulz [Wed, 20 Feb 2013 22:00:15 +0000 (14:00 -0800)]
Small tweaks to $wgLockManagers documentation.
Change-Id: Ib9678e303a1360ccb1e9005ac919ed75e4e45705
Santhosh [Thu, 21 Feb 2013 06:18:23 +0000 (06:18 +0000)]
Merge "Extend Russian grammar support"
Santhosh Thottingal [Fri, 18 Jan 2013 15:34:54 +0000 (21:04 +0530)]
Commafy support for convertNumber
As per http://www.unicode.org/reports/tr35
Change-Id: I765298959ad10ea8561abfea487328c8ddeb39f0
Aaron Schulz [Wed, 20 Feb 2013 01:05:28 +0000 (17:05 -0800)]
[JobQueue] Made the maximum number of job attempts configurable.
Change-Id: I3aaab748913af68f4a676855c5c4f825706f7be7
Aaron Schulz [Fri, 8 Feb 2013 18:52:54 +0000 (10:52 -0800)]
[JobQueue] Cleanups for JobQueueRedis.
* Cleaned up 'server' option to not fragment the pool.
Also made it actually match the documentation.
* Made it use doGetPeriodicTasks() for job recycling.
* Made it so that other job queue classes can be tested.
* Renamed "redisConf" => "redisConfig".
* Tweaked comments about the "random" order option.
Change-Id: I7823d90010e6bc9d581435c3be92830c5ba68480
Aaron Schulz [Mon, 4 Feb 2013 00:28:52 +0000 (16:28 -0800)]
[JobQueue] Use target wiki configuration for some key functions.
* getQueueTypes() now gets the config of the target wiki.
Previously, for WMF, if an extension using jobs was not
on aawiki, those job queues would not be seen by nextJobDB.
* Also fixed nextJobDB.php so that it no longer only considers
jobs types known to aawiki for picking a DB for default jobs.
* Note that $wgJobTypesExcludedFromDefaultQueue should be global.
* This adds a SiteConfiguration::getConfig() function, which calls
a new getConfiguration.php script.
Change-Id: I7e6904ead17efa407291f423a2b18e3c866d55fd
Tim Starling [Thu, 21 Feb 2013 05:32:45 +0000 (05:32 +0000)]
Merge "[JobQueue] Added aggregate empty/non-empty queue caching."
jenkins-bot [Thu, 21 Feb 2013 05:24:47 +0000 (05:24 +0000)]
Merge "Tests: Add missing expect numbers in QUnit tests."
Aaron Schulz [Tue, 5 Feb 2013 20:00:24 +0000 (12:00 -0800)]
[JobQueue] Added aggregate empty/non-empty queue caching.
* The default class is JobQueueAggregatorMemc.
This essentially has the logic that nextJobDB.php used.
* Also created a JobQueueAggregatorRedis class.
This is much more efficient and more responsive.
* This can speed up calls to getQueuesWithJobs().
* Removed unused getDefaultQueuesWithJobs() function.
Change-Id: Ifb3c6c881decd643da1b662956ded69db4b39431
jenkins-bot [Thu, 21 Feb 2013 00:59:30 +0000 (00:59 +0000)]
Merge "Fix how QUnit.newMwEnvironment merges live and custom settings"
Daniel Werner [Mon, 18 Feb 2013 17:51:09 +0000 (18:51 +0100)]
Fix how QUnit.newMwEnvironment merges live and custom settings
We shouldn't merge a live state's setting value with a custom
value anymore as it has been done since I7d20f0b2f4. Doing this
can produce very unpredictable outcome of tests depending on the
server's state and will prevent from being able to properly
define a test's conditions.
Change-Id: I7ad058a45708244918211658b5d4e07f69abba31
jenkins-bot [Wed, 20 Feb 2013 23:56:56 +0000 (23:56 +0000)]
Merge "Move around/add PHP_SAPI check, making find-entries happier."
Platonides [Wed, 20 Feb 2013 23:50:27 +0000 (00:50 +0100)]
Move around/add PHP_SAPI check, making find-entries happier.
Change-Id: Ic166066a543c4a5c0958351fdfe5f984e8d443d7
jenkins-bot [Wed, 20 Feb 2013 23:35:04 +0000 (23:35 +0000)]
Merge "Fixed documentation typo."
Platonides [Wed, 20 Feb 2013 23:14:17 +0000 (00:14 +0100)]
Concatenate two literals
Convert «'/' . 'MediaWikiInstallationCommonFunction.php'» into
«'/MediaWikiInstallationCommonFunction.php'»
Makes find-entries.php life easier.
Change-Id: I2952a14daa651099ff1d0b15a166880b710cad34
Platonides [Wed, 20 Feb 2013 22:35:19 +0000 (23:35 +0100)]
PHPUnit/Framework.php was removed in 2010
Removed in 9e3aec (phpunit 3.5.1):
https://github.com/sebastianbergmann/phpunit/commit/
9e3aec43cf6a0a81fab7cd98003d35b427f861b6
Deprecated since
fb48a69 (phpunit 3.4.8):
https://github.com/sebastianbergmann/phpunit/commit/
fb48a69ea606a4740ba1f0e4ddcfe60fcd2a8301
Its usage was replaced with the autoloader.
Change-Id: Ib76ed6e9ec83e9e33c76ef423bb0caa0c37067e8