Victor Vasiliev [Mon, 14 Jan 2008 13:57:40 +0000 (13:57 +0000)]
Revert accidentally commited image moving stuff
Victor Vasiliev [Mon, 14 Jan 2008 13:50:55 +0000 (13:50 +0000)]
* Introduce getUserPermissionsErrorsExpensive hook
Domas Mituzas [Mon, 14 Jan 2008 12:50:20 +0000 (12:50 +0000)]
Cleanup for Special:Randompage and Special: Randomredirect after r29725 - bugzilla.wikimedia.org/show_bug.cgi?id=12624
Thanks to: alex.emsenhuber
Rotem Liss [Mon, 14 Jan 2008 12:47:15 +0000 (12:47 +0000)]
Update for he.
Raimond Spekking [Mon, 14 Jan 2008 12:02:33 +0000 (12:02 +0000)]
* Updates German
Siebrand Mazeland [Mon, 14 Jan 2008 12:01:14 +0000 (12:01 +0000)]
Localisation updates for core messages from Betawiki (2008-01-14 12:52 CET)
Raimond Spekking [Mon, 14 Jan 2008 11:13:51 +0000 (11:13 +0000)]
* Updates German
Patch by Tim 'avatar' Bartel
Domas Mituzas [Mon, 14 Jan 2008 10:23:48 +0000 (10:23 +0000)]
* Shortcutted Title::userCanRead() for public wikis
* Moved redirects code in OutputPage before skins and ajax stuff, to handle likely scenario better
* Stripped off lots of fat (like... 30-50% of execution time) from Special:Randompage - mwahaha... ha... hahaha...
Huji [Mon, 14 Jan 2008 09:26:36 +0000 (09:26 +0000)]
(bug 12608) (in continuation of r29719) Unifying the spelling of getDBkey() in the code.
Huji [Mon, 14 Jan 2008 09:13:04 +0000 (09:13 +0000)]
(bug 12608) Unifying the spelling of getDBkey() in the code.
Tim Starling [Mon, 14 Jan 2008 06:59:20 +0000 (06:59 +0000)]
* Fixed loop detection in LST
* Renamed some LST parser tests
* Fixed <gallery> caption behaviour .It should not generate <pre> when there are spaces at the start. Used recursiveTagParse() instead of parse(), to avoid generation of a limit report, among other things.
* Refactored template loop check
* Updated a couple of parser tests
Shinjiman [Mon, 14 Jan 2008 05:43:20 +0000 (05:43 +0000)]
* Update Cantonese translations
Tim Starling [Mon, 14 Jan 2008 03:43:14 +0000 (03:43 +0000)]
* Fix heading immediately after comment-on-own-line
* Fix ===== on own line
Siebrand Mazeland [Sun, 13 Jan 2008 22:46:51 +0000 (22:46 +0000)]
Localisation updates for core messages from Betawiki (2008-01-13 23:37 CET)
Aryeh Gregor [Sun, 13 Jan 2008 22:26:08 +0000 (22:26 +0000)]
Tweak tweaks.
Aryeh Gregor [Sun, 13 Jan 2008 22:23:36 +0000 (22:23 +0000)]
Random small fixes: formatting/whitespace, comments, fix inexplicably misleading profiling name in getUserPermissionsErrorsInternal.
Aryeh Gregor [Sun, 13 Jan 2008 21:36:08 +0000 (21:36 +0000)]
The 'rollback' permission now only affects whether rollback is made available through the interface. Users without the rollback permission can still use it by generating the proper token through a script. This does nothing but allow automated rollback scripts to generate less load on both the client and the server, without allowing them to do anything extra. This was inspired by an anti-vandal bot operator on enwiki who showed me his server load dropping in half when his bot switched from manual reverts to rollback.
Bertrand Grondin [Sun, 13 Jan 2008 21:15:14 +0000 (21:15 +0000)]
Localisation updates for extensions from Betawiki (2008-01-13 21:14 UTC)
Victor Vasiliev [Sun, 13 Jan 2008 17:58:14 +0000 (17:58 +0000)]
* (bug 12611) Bot flag ignored in recent changes
Domas Mituzas [Sun, 13 Jan 2008 13:34:45 +0000 (13:34 +0000)]
don't open transactions for SHOW and SET statements - reduces some redundancy of transaction startup
Tim Starling [Sun, 13 Jan 2008 12:47:38 +0000 (12:47 +0000)]
Expansion cache for template arguments. Fixes the most common <ref> numbering bugs. I think the rest can be fixed in the Cite extension itself. I will give that a go later.
Domas Mituzas [Sun, 13 Jan 2008 12:29:43 +0000 (12:29 +0000)]
avoid calling things on $wgTitle that might be not yet initialized
Siebrand Mazeland [Sun, 13 Jan 2008 11:40:17 +0000 (11:40 +0000)]
Localisation updates for core messages from Betawiki (2008-01-13 12:23 CET)
Bertrand Grondin [Sun, 13 Jan 2008 10:07:18 +0000 (10:07 +0000)]
Update french localization file
* Add Special aliases names
* Add Special magic words
* Add Skin names
Tim Starling [Sun, 13 Jan 2008 09:23:58 +0000 (09:23 +0000)]
Third time lucky? More complex method to obtain precise bug-for-bug compatibility with the old parser.
Tim Starling [Sun, 13 Jan 2008 08:51:09 +0000 (08:51 +0000)]
Improved tplarg whitespace fix, following on from buggy r29685.
Tim Starling [Sun, 13 Jan 2008 06:40:14 +0000 (06:40 +0000)]
Fix handling for whitespace in template arguments.
Tim Starling [Sun, 13 Jan 2008 03:47:07 +0000 (03:47 +0000)]
Revert r29671, it was based on a misunderstanding of the purpose of the LoggedOut cookie. The LoggedOut cookie is there to suppress the client-side cache, not the server-side cache. It prevents privately cached logged-in pages from being displayed after the user logs out. Feel free to special-case it in squid if you're worried about the server-side cache hit ratio, but note that IMS requests would need special handling.
* Credential data in the session is destroyed, so the session is harmless. But it is still useful for abuse tracking (logout/login sequences) and similar analysis.
* Not much point in removing the username persistence feature if you can't improve the squid cache hit ratio, which was obviously your goal.
Aryeh Gregor [Sun, 13 Jan 2008 01:03:28 +0000 (01:03 +0000)]
Clarify comment on $wgRateLimits.
Domas Mituzas [Sat, 12 Jan 2008 23:52:46 +0000 (23:52 +0000)]
should have some coffee - one more typo :)
Domas Mituzas [Sat, 12 Jan 2008 23:12:51 +0000 (23:12 +0000)]
damn, how did this typo slip in :)
Domas Mituzas [Sat, 12 Jan 2008 23:10:08 +0000 (23:10 +0000)]
Well, logging out is an action, where people don't want to have any of their their credentials still sit in browser.
Actually, keeping a session is still bad. And trying to ensure that they don't see cached content... Well, thats wrong idea.
See, if someone is logged out, he is anonymous and deserves to see cached content as everyone else.
So, let's destroy all cookies.
Domas Mituzas [Sat, 12 Jan 2008 22:51:16 +0000 (22:51 +0000)]
Few sanity things for database activity:
* Provide function to COMMIT master connection in case there were any changes
* Use it at cleanup, instead of sending too many COMMITs to all slaves
* Don't acquire master connection, if no updates are to be done
* Don't care about closing database connections, let PHP do that (would close HTTP socket few nanoseconds earlier)
Domas Mituzas [Sat, 12 Jan 2008 17:51:21 +0000 (17:51 +0000)]
* importing livehack for profiling errors output
* fixing some of CPU profile elimination errors :)
Domas Mituzas [Sat, 12 Jan 2008 17:39:02 +0000 (17:39 +0000)]
remove Cpu from here too
Domas Mituzas [Sat, 12 Jan 2008 17:32:21 +0000 (17:32 +0000)]
aaaAAAAAAAAAaaaaaAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaaAAAAAAAAAaaaaaAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaaAAAAAAAAAaaaaaAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaaAAAAAAAAAaaaaaAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaaaaa:
* ditch CPU profiling from ProfilerSimple, because:
** getrusage() is updated just on end of quant, which is 10ms on our new servers and 1ms on old ones:
*** All CPU profiling before looked reasonable just just just because lots of 0's and 10's sometimes add up to reasonable guestimate.
Siebrand Mazeland [Sat, 12 Jan 2008 17:29:42 +0000 (17:29 +0000)]
Localisation updates. Updating special pages.
Siebrand Mazeland [Sat, 12 Jan 2008 16:41:20 +0000 (16:41 +0000)]
Localisation updates for core messages from Betawiki (2008-01-12 17:18 CET)
Tim Starling [Sat, 12 Jan 2008 13:44:08 +0000 (13:44 +0000)]
Revert r29647, as per my comment on bug 12536.
Victor Vasiliev [Sat, 12 Jan 2008 12:31:20 +0000 (12:31 +0000)]
* (bug 12536) User should be able to get MediaWiki version from any page
Bertrand Grondin [Sat, 12 Jan 2008 10:53:52 +0000 (10:53 +0000)]
Localisation updates for extensions from Betawiki (2008-01-12 11:53 UTC)
Daniel Cannon [Sat, 12 Jan 2008 07:08:17 +0000 (07:08 +0000)]
API: Various docu and clean-up.
Brion Vibber [Sat, 12 Jan 2008 00:13:53 +0000 (00:13 +0000)]
* Use only default options when generating RSS and Atom syndication links.
This should help prevent infinite link loops that some software may follow,
and will generally keep feed behavior cleaner.
Combined duplicate link expansion from OutputPage and SkinTemplate into OutputPage::getSyndicationLinks()
Siebrand Mazeland [Fri, 11 Jan 2008 22:48:20 +0000 (22:48 +0000)]
Localisation updates for core messages from Betawiki
* adding pag/Pangasinan
Siebrand Mazeland [Fri, 11 Jan 2008 22:04:05 +0000 (22:04 +0000)]
Localisation updates for core messages from Betawiki
* adding pap/Papiamento
Brion Vibber [Fri, 11 Jan 2008 21:10:51 +0000 (21:10 +0000)]
* (bug 12588) Fix selection in namespace selector on Special:Newpages
Godawful hack... we'll be frequently passed selected namespaces as strings since PHP is such a shithole.
But we also don't want blanks and nulls and "all"s matching 0, so let's convert *just* string ints to clean ints.
Aryeh Gregor [Fri, 11 Jan 2008 21:02:39 +0000 (21:02 +0000)]
I doubt we'll get $this->hookError set to '0', but let's head that off at the pass.
Brion Vibber [Fri, 11 Jan 2008 20:52:54 +0000 (20:52 +0000)]
* (bug 12584) Don't reset cl_timestamp when auto-updating sort key on move
Also cleaned up comment and ugly manual query
Aryeh Gregor [Fri, 11 Jan 2008 20:51:53 +0000 (20:51 +0000)]
Some random code cleanup/prettification.
Siebrand Mazeland [Fri, 11 Jan 2008 14:32:45 +0000 (14:32 +0000)]
Localisation updates for core messages from Betawiki (2008-01-11 15:07 CET)
Shinjiman [Fri, 11 Jan 2008 14:16:42 +0000 (14:16 +0000)]
* (bug 12145) Update Kazakh translations
Patch by AlefZet
Shinjiman [Fri, 11 Jan 2008 12:15:12 +0000 (12:15 +0000)]
* Update Chinese translations
* Update Cantonese translations
* Update Old Chinese / Late Time Chinese translations
Aaron Schulz [Fri, 11 Jan 2008 05:06:10 +0000 (05:06 +0000)]
Explicitly use 0 like the other checks here
Brion Vibber [Fri, 11 Jan 2008 04:55:48 +0000 (04:55 +0000)]
Redo r29565, but as far as I see working now. :)
getRestrictions() always returns an array -- just use a standard boolean condition, not is_array().
Marked Title::getTitleProtection() private.
Brion Vibber [Fri, 11 Jan 2008 04:41:11 +0000 (04:41 +0000)]
Tweak for r29561: don't grab a database object until we need it
Tim Starling [Fri, 11 Jan 2008 03:25:41 +0000 (03:25 +0000)]
* Fixed template loop check, broken by changes in parse order
* Added template recursion depth limit. It needs a small limit, because of exorbitant stack space usage, xdebug compatibility problems, and the potential for O(N^2) memory usage in the template loop check.
* Made these two error messages more obvious in the parser output, with <span class="error"> instead of a comment. This is similar to the #expr error messages, which seem to have been well received by our template programmer community.
Aaron Schulz [Thu, 10 Jan 2008 23:28:08 +0000 (23:28 +0000)]
Revert back for now, this is not quite correct
Aaron Schulz [Thu, 10 Jan 2008 23:13:45 +0000 (23:13 +0000)]
Don't call getTitleProtection(). That is really just an internal function for a DB query. It shouldn't even by public as it is. Just check 'create' restrictions. This is where they are saved too.
Niklas Laxström [Thu, 10 Jan 2008 22:15:33 +0000 (22:15 +0000)]
* No need to query database for special namespaces
Aryeh Gregor [Thu, 10 Jan 2008 19:27:49 +0000 (19:27 +0000)]
Right, *this* was the vulnerability that existed. Users couldn't mark the other edits bot, but they could mark their own rollback revision as bot.
Siebrand Mazeland [Thu, 10 Jan 2008 18:16:14 +0000 (18:16 +0000)]
Localisation updates for core messages from Betawiki (2008-01-10 18:51 CET)
Thomas Bleher [Thu, 10 Jan 2008 16:51:45 +0000 (16:51 +0000)]
Fix some places where globals where used without being declared as
being global. Also remove one unused variable.
Roan Kattouw [Thu, 10 Jan 2008 13:37:01 +0000 (13:37 +0000)]
Removing unused global $wgRequest; that I missed in the previous commit.
Roan Kattouw [Thu, 10 Jan 2008 13:33:23 +0000 (13:33 +0000)]
Fixing the mess that was r29539:
* $wgRequest shouldn't be used in functions like Article::doEdit() that are also called by API modules
* Moving code that decides whether the edit is bot out of DB logic and into UI logic: API and UI each decide indepentently from one another
* Removing $bot==='default' behavior from RecentChange::notifyEdit() and notifyNew(): nobody uses it, and it shouldn't be used anyway; whether the edit is bot should've been decided long ago
Daniel Cannon [Thu, 10 Jan 2008 09:54:35 +0000 (09:54 +0000)]
* (bug 12574) Allow bots to specify whether an edit should be marked as a bot
edit, via the parameter 'bot'. (Default: '1')
Patch by Cobi <Winbots at gmail dot com>.
Roan Kattouw [Thu, 10 Jan 2008 07:52:09 +0000 (07:52 +0000)]
Revert r29525: this vulnerability never existed; Article::doRollback() does the check already. Besides, the permission is called markboteditS
Aryeh Gregor [Thu, 10 Jan 2008 02:28:58 +0000 (02:28 +0000)]
Do not log user rights change that didn't change anything
Aryeh Gregor [Thu, 10 Jan 2008 02:21:16 +0000 (02:21 +0000)]
Fix vulnerability (hopefully): anyone with rollback privileges can mark the rollback as bot, despite r27657.
Siebrand Mazeland [Thu, 10 Jan 2008 00:19:23 +0000 (00:19 +0000)]
Localisation updates. Update namespaces per ast.wikipedia.org/w/index.php?title=Uiquipedia:Votaciones&oldid=216561
Siebrand Mazeland [Wed, 9 Jan 2008 23:57:15 +0000 (23:57 +0000)]
Localisation updates for core messages from Betawiki (2008-01-10 0:38 CET)
* fallback for 'lij' to 'it'
Domas Mituzas [Wed, 9 Jan 2008 23:23:53 +0000 (23:23 +0000)]
this profiling section is nearly identical to our already verbose Database::open and dbconnect ones
Aryeh Gregor [Wed, 9 Jan 2008 21:40:40 +0000 (21:40 +0000)]
Clean up some braces, indentation; add profiling to LoadBalancer::reallyOpenConnection.
Domas Mituzas [Wed, 9 Jan 2008 20:47:46 +0000 (20:47 +0000)]
set OutputPage::mContainsOldMagic only for specific listed magic words
For now the suggested times are ignored and base 3600 is used for all dynamic ones
This makes templates more friendly parser-cache wise.
Huji [Wed, 9 Jan 2008 15:26:43 +0000 (15:26 +0000)]
Added translations for the remaining EXIF messages.
Siebrand Mazeland [Wed, 9 Jan 2008 14:11:14 +0000 (14:11 +0000)]
* ran rebuildLanguage.php
* removed 3 non-existing entries in $specialPageAliases
Huji [Wed, 9 Jan 2008 14:11:08 +0000 (14:11 +0000)]
RebuildLanguage on r29493 broke this one. Fixing by hand...
Huji [Wed, 9 Jan 2008 13:54:47 +0000 (13:54 +0000)]
* Added Persian translations
* Updated language related maintenance scripts to support the newly created message group (r29482)
* Performed RebuildLanguage for En and Fa
Siebrand Mazeland [Wed, 9 Jan 2008 07:57:25 +0000 (07:57 +0000)]
Localisation updates for core messages from Betawiki (2008-01-09 8:32 CET)
Tim Starling [Wed, 9 Jan 2008 07:13:54 +0000 (07:13 +0000)]
Added {{#tag:}}: generic adaptor from parser function syntax to XML-style extension tag. Allows any extension tag (including nowiki and pre) to be called with input given by a template expansion. Inspired by [[Extension:TagParser]].
Shinjiman [Wed, 9 Jan 2008 04:34:39 +0000 (04:34 +0000)]
* (bug 12469) Update Indonesian translations
Patch by Borgx
Brion Vibber [Wed, 9 Jan 2008 02:18:58 +0000 (02:18 +0000)]
* (bug 12505) Fixed section=0 with action=raw
PHP's fuzzy type comparisons strike again! A check for $this->mSection != '', probably intended to protect against an unset value, matched for integer values of 0 as well. (The fun part is that 0=='' and 0=='0' but '0'!='' :) Since the parameter is validated through getIntOrNull(), only the null check is necessary here.
Brion Vibber [Wed, 9 Jan 2008 01:08:59 +0000 (01:08 +0000)]
* (bug 12553) Fixed invalid XHTML in edit conflict screen
Tim Starling [Wed, 9 Jan 2008 00:21:16 +0000 (00:21 +0000)]
Revert revert of setSingleton(), unrelated to broken, accidentally committed code in FSRepo.php.
Brion Vibber [Tue, 8 Jan 2008 23:58:16 +0000 (23:58 +0000)]
tweak paths more
Brion Vibber [Tue, 8 Jan 2008 23:53:20 +0000 (23:53 +0000)]
fix include path regressions with text prefetch
Roan Kattouw [Tue, 8 Jan 2008 22:05:39 +0000 (22:05 +0000)]
Improving r29456:
* The XML formatting bug is obscure and not trivial to fix, working around it is easier
* Added missing braces
Brion Vibber [Tue, 8 Jan 2008 22:01:23 +0000 (22:01 +0000)]
Revert r29361 -- breaks upload, calls nonexistent functions
Roan Kattouw [Tue, 8 Jan 2008 21:42:00 +0000 (21:42 +0000)]
API: Temporary fix for broken XML rendering; XML formatter apparently doesn't like array(null). Will attempt to fix the real issue later
Victor Vasiliev [Tue, 8 Jan 2008 18:34:06 +0000 (18:34 +0000)]
* Add exception hooks to output pretty messages
* Also, there's an example of such extension
Victor Vasiliev [Tue, 8 Jan 2008 18:22:46 +0000 (18:22 +0000)]
Add some variables to globals.txt
Victor Vasiliev [Tue, 8 Jan 2008 18:21:05 +0000 (18:21 +0000)]
Introduce BagOStuff::keys() method for debugging/etc. purposes
Victor Vasiliev [Tue, 8 Jan 2008 18:10:58 +0000 (18:10 +0000)]
API: add action=logout
Siebrand Mazeland [Tue, 8 Jan 2008 17:25:38 +0000 (17:25 +0000)]
Localisation updates for core messages from Betawiki (2008-01-08 17:05 CET)
Roan Kattouw [Tue, 8 Jan 2008 16:42:18 +0000 (16:42 +0000)]
Returning protections more consistently
Roan Kattouw [Tue, 8 Jan 2008 16:36:47 +0000 (16:36 +0000)]
Changing name of error code to something making slightly more sense
Roan Kattouw [Tue, 8 Jan 2008 16:31:50 +0000 (16:31 +0000)]
* (bug 12543) API should support new protected titles system
* Changing ApiProtect to return ISO 8601 timestamps
* This doesn't really need a RELEASE-NOTES entry, as the protected titles system is already mentioned in RELEASE-NOTES
Rotem Liss [Tue, 8 Jan 2008 15:43:20 +0000 (15:43 +0000)]
Consistent newlines and svn:eol-style=native for MessagesNa.php.
Roan Kattouw [Tue, 8 Jan 2008 15:35:11 +0000 (15:35 +0000)]
Partial fix of bug 12533
Tim Starling [Tue, 8 Jan 2008 05:12:20 +0000 (05:12 +0000)]
* Fixed handling of whitespace before HTML comments, slightly broken since r29292.
* Fixed ot['pre'] bug
Siebrand Mazeland [Mon, 7 Jan 2008 22:34:00 +0000 (22:34 +0000)]
Localisation updates for core messages from Betawiki (2008-01-07 22:49 CET)