Timo Tijhof [Wed, 8 Mar 2017 04:48:21 +0000 (20:48 -0800)]
Skin: Only load jquery.makeCollapsible if needed
Currently, module 'jquery.makeCollapsible' is loaded on all pages
regarless of whether the page contains any collapsible elements.
It is required via 'mediawiki.page.ready'. Change this to lazy-loading
when needed only.
However, this lazy-load is discovered very late (after page ready,
after modules ready). To avoid regressing UX with an annoying reflow
of content and a very late hiding of collapsed elements, still
enqueue it in the main module loader by default on pages that
contain collapsible content server-side.
Bug: T159911
Change-Id: I4703ecd52d2d60207ba39108a4b3ef4aa1570965
Timo Tijhof [Wed, 8 Mar 2017 04:31:10 +0000 (20:31 -0800)]
Skin: Preload jquery.tablesorter based on rough heuristics
Whenever a page contains table.sortable, mediawiki/page/ready.js
will lazy-load the module. However this can create a significant
delay and hides the entire prodecure from our module loader.
Instead, do a rough check (similarl to mw-ui-button) and preload
the module based on that.
Bug: T159911
Change-Id: I87600f968241c723e6bead3ef96c34f1021e1164
jenkins-bot [Wed, 8 Mar 2017 01:37:08 +0000 (01:37 +0000)]
Merge "RCFilters UI: Prevent the popup from disappearing when input is out of view"
jenkins-bot [Wed, 8 Mar 2017 01:32:35 +0000 (01:32 +0000)]
Merge "RC filters: update the state of the app on popstate."
jenkins-bot [Wed, 8 Mar 2017 01:29:22 +0000 (01:29 +0000)]
Merge "RCFilters UI: Add 'highlight' icon to highlight button"
jenkins-bot [Wed, 8 Mar 2017 01:28:55 +0000 (01:28 +0000)]
Merge "RCFilters UI: Display popups above CapsuleItemWidgets"
Moriel Schottlender [Mon, 6 Mar 2017 23:01:51 +0000 (15:01 -0800)]
RCFilters UI: Add 'highlight' icon to highlight button
Bug: T149467
Change-Id: Iba11de7ba47e41046631dbf16f464f8bd3820811
Depends-On: I0b5adaaec52f9cc01c3dfb6262adaf2da368476e
jenkins-bot [Wed, 8 Mar 2017 01:00:57 +0000 (01:00 +0000)]
Merge "Update OOjs UI to v0.19.5"
jenkins-bot [Wed, 8 Mar 2017 00:38:16 +0000 (00:38 +0000)]
Merge "RC Filters UI: 'restore defaults' clears highlight"
Volker E [Tue, 7 Mar 2017 23:26:56 +0000 (15:26 -0800)]
Update OOjs UI to v0.19.5
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.19.5
Change-Id: Ic15534df2f4006b94d1161a91e2d689f96892073
Timo Tijhof [Tue, 7 Mar 2017 02:14:14 +0000 (18:14 -0800)]
Clean up remaining get_class() uses
* get_class() -> __CLASS__ (same as self::class)
* get_called_class() -> static::class
* get_class($this) -> static::class
Change-Id: I1888a1897ecf4548a2e5a67a942e5c080dd7e3d3
jenkins-bot [Tue, 7 Mar 2017 21:43:41 +0000 (21:43 +0000)]
Merge "Clean up get_class() in /includes/filerepo and /includes/resourceloader"
jenkins-bot [Tue, 7 Mar 2017 21:39:02 +0000 (21:39 +0000)]
Merge "HTMLMultiSelect parameter to specify which options are disabled"
Timo Tijhof [Tue, 7 Mar 2017 02:14:14 +0000 (18:14 -0800)]
Clean up get_class() in /includes/filerepo and /includes/resourceloader
* get_class() -> __CLASS__ (same as self::class)
* get_called_class() -> static::class
* get_class($this) -> static::class
Change-Id: Ic4f9b150ddc35e25f51297de7fc12410d421be4d
jenkins-bot [Tue, 7 Mar 2017 21:30:14 +0000 (21:30 +0000)]
Merge "Update oyejorge/less.php to 1.7.0.13"
Huji Lee [Thu, 22 Dec 2016 00:37:10 +0000 (19:37 -0500)]
HTMLMultiSelect parameter to specify which options are disabled
Depends on I32fa20e4adb23960d9db6bf6023f79bf128fb600
Bug: T153751
Change-Id: I3bcf6720c960e0be962e0f3f37a22ec8778db1d1
Paladox [Thu, 23 Feb 2017 18:17:45 +0000 (18:17 +0000)]
Update oyejorge/less.php to 1.7.0.13
See changes at
https://github.com/oyejorge/less.php/blob/master/CHANGES.md
https://github.com/oyejorge/less.php/compare/v1.7.0.10...v1.7.0.13
Depends-On: Iaafb9800a223f2a1e163bb2e55b4017fcc98e682
Change-Id: I6a925c2e82812df0acf4c8b8da2541b62fea8809
Timo Tijhof [Tue, 7 Mar 2017 02:14:14 +0000 (18:14 -0800)]
Clean up get_class($this) -> static::class in /includes/cache and /includes/libs
* get_class() -> __CLASS__ (same as self::class)
* get_called_class() -> static::class
* get_class($this) -> static::class
Change-Id: I22c62851bcc88405f4bdd77258d6e28ec1a14924
Translation updater bot [Tue, 7 Mar 2017 21:03:55 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I97bab36cdd05b162843e47e8b65d2ad2c224eb0f
Stephane Bisson [Tue, 7 Mar 2017 20:37:04 +0000 (15:37 -0500)]
RC Filters UI: 'restore defaults' clears highlight
The 'restore defaults' button clear any
highlight config and brings the UI back
to the same default state every time.
Bug: T159848
Change-Id: I78397c914aa5510e259a28c226f6e953b4dded4d
Stephane Bisson [Wed, 1 Mar 2017 12:04:05 +0000 (07:04 -0500)]
RC filters: update the state of the app on popstate.
Also re-fetch changes list.
Bug: T153949
Change-Id: Id3d4ea2a4de6074ae1c15cadb74e7a324a39e7ff
jenkins-bot [Tue, 7 Mar 2017 18:05:57 +0000 (18:05 +0000)]
Merge "Change mw-body ancestor selector to mw-body-content"
jenkins-bot [Tue, 7 Mar 2017 07:39:43 +0000 (07:39 +0000)]
Merge "registration: Allow documenting config settings with i18n messages"
jenkins-bot [Tue, 7 Mar 2017 07:37:14 +0000 (07:37 +0000)]
Merge "registration: Allow specifying the value of a config setting can be public"
jenkins-bot [Tue, 7 Mar 2017 07:34:18 +0000 (07:34 +0000)]
Merge "PageArchive: Fix typo in class file"
Florian Schmidt [Fri, 13 Jan 2017 05:14:42 +0000 (06:14 +0100)]
registration: Allow documenting config settings with i18n messages
In addition to the general (English) description key in a config
option in extension.json, developers now can provide a description message
key. This localized message will be used in user interfaces, such as
viewing configuration options on-wiki (see later changes).
Bug: T155157
Change-Id: I5c780b3347bd54a05694cfa6de93879656b4e921
Florian Schmidt [Fri, 13 Jan 2017 05:11:55 +0000 (06:11 +0100)]
registration: Allow specifying the value of a config setting can be public
This value is currently unused but will be used in later changes
for allowing to view configuration options on-wiki. It will require each
extension maintainer to whitelist the keys that can be published by marking
them as public.
Bug: T155156
Change-Id: I020c148157818ef8bfee0e79cb5a6f43181c5a8c
jenkins-bot [Tue, 7 Mar 2017 07:08:17 +0000 (07:08 +0000)]
Merge "Fix @covers for FileBackend"
jenkins-bot [Tue, 7 Mar 2017 02:28:35 +0000 (02:28 +0000)]
Merge "resourceloader: Remove useless INFO log for message blob cache-miss"
jenkins-bot [Tue, 7 Mar 2017 02:19:49 +0000 (02:19 +0000)]
Merge "RCFilters UI: Add tooltip to highlight menu"
Moriel Schottlender [Tue, 7 Mar 2017 01:09:18 +0000 (17:09 -0800)]
RCFilters UI: Add tooltip to highlight menu
Bug: T159587
Change-Id: Iae5e050fd721d8c51d0b6c150d039c7f2ed6647d
jenkins-bot [Tue, 7 Mar 2017 00:38:54 +0000 (00:38 +0000)]
Merge "RCFilters UI: Override 'list-style' for <li> results"
Moriel Schottlender [Tue, 7 Mar 2017 00:22:45 +0000 (16:22 -0800)]
RCFilters UI: Override 'list-style' for <li> results
Just in case a wiki defines list-style-image for recent changes
(like in beta labs) we remove it from the general system, so it
does not interfere with highlights.
Bug: T159586
Change-Id: Ic20961efa047d16191b9dd889e390eb29d28ab7d
jenkins-bot [Tue, 7 Mar 2017 00:09:46 +0000 (00:09 +0000)]
Merge "RCFilters UI: Fix double-loading of mw.rcfilters.less"
jenkins-bot [Tue, 7 Mar 2017 00:06:50 +0000 (00:06 +0000)]
Merge "RCFilters UI: Unify the loader animation"
jenkins-bot [Mon, 6 Mar 2017 23:58:29 +0000 (23:58 +0000)]
Merge "RCFilters UI: Change hover background for filter items"
jenkins-bot [Mon, 6 Mar 2017 23:57:36 +0000 (23:57 +0000)]
Merge "RCFilters UI: Fix capsule highlight circle to use pixels"
Roan Kattouw [Mon, 6 Mar 2017 23:49:47 +0000 (15:49 -0800)]
RCFilters UI: Fix double-loading of mw.rcfilters.less
Change-Id: I424d4f84bb17a54980b311da7db9fdbb5ce56530
Moriel Schottlender [Mon, 6 Mar 2017 23:40:12 +0000 (15:40 -0800)]
RCFilters UI: Fix scrolling (once again) so it works in Firefox
In firefox our scrollable container is html, we need to account
for that along with body element.
Change-Id: Ida603d419c85a2bf27ce8a5d46da7da3c1dc00ea
Moriel Schottlender [Mon, 6 Mar 2017 23:28:21 +0000 (15:28 -0800)]
RCFilters UI: Unify the loader animation
Bug: T159766
Change-Id: Ifda7510efa4e16422b5988c37c2e54aa08b52b71
jenkins-bot [Mon, 6 Mar 2017 23:25:32 +0000 (23:25 +0000)]
Merge "Ensure the editing textarea is not higher than browser's viewport"
Moriel Schottlender [Mon, 6 Mar 2017 23:07:54 +0000 (15:07 -0800)]
RCFilters UI: Fix capsule highlight circle to use pixels
That circle is small enough so that using 'em' values results in
it being mangled/stretched. Using exact pixels fixes that issue.
Change-Id: I5607c2c1f09c022e215b08993115ef631597e85c
C. Scott Ananian [Mon, 27 Feb 2017 21:27:15 +0000 (16:27 -0500)]
Strip U+0000 in wikitext
U+0000 is not allowed in HTML5, there's no reason to allow it in wikitext.
It simplifies our code if we can just strip them at the start. Strip in
PST as well so they don't sneak into our database either.
Tweaked the EXT_LINK URLs to account for the fact that invalid characters
get transformed into U+FFFD when using Preprocessor_DOM. See
73649741ed1e
(r65967) for context on that change.
Bug: T159174
Change-Id: I3f67e92b61aacc87a40c3662085c84d1dac08bfb
jenkins-bot [Mon, 6 Mar 2017 22:13:31 +0000 (22:13 +0000)]
Merge "Add mw-body-content to indicators"
jenkins-bot [Mon, 6 Mar 2017 22:06:29 +0000 (22:06 +0000)]
Merge "DatabaseUpdater add missing $maintenance property"
jenkins-bot [Mon, 6 Mar 2017 21:56:57 +0000 (21:56 +0000)]
Merge "resourceloader: Enforce strict string keys in mw.Map"
jenkins-bot [Mon, 6 Mar 2017 21:56:43 +0000 (21:56 +0000)]
Merge "resourceloader: Undeprecate mw.Map#values"
jenkins-bot [Mon, 6 Mar 2017 21:49:31 +0000 (21:49 +0000)]
Merge "mediawiki.inspect: Fix intermittent test failure"
Florian Schmidt [Mon, 6 Mar 2017 20:25:23 +0000 (21:25 +0100)]
PageArchive: Fix typo in class file
Follow up: I02b7e4785f369c7b6574c4bce093b6de58d1c651
Change-Id: Iec60fb023ef3c57e61ee29c829f750ca1b34467e
jenkins-bot [Mon, 6 Mar 2017 21:27:54 +0000 (21:27 +0000)]
Merge "Add dynomite comments to WANObjectCache"
Timo Tijhof [Sat, 4 Mar 2017 00:46:24 +0000 (16:46 -0800)]
resourceloader: Enforce strict string keys in mw.Map
* No longer perform any key-to-string casting in get(), set(),
or exists().
- Setting a non-string key is ignored.
- Looking for a non-string key that looks like a string key
that exists will not find it.
Clean up:
* Remove needless `selection=slice.call(selection)` in mw.Map#get
Follows-up
77d71f743 (r75486). Not sure why this was here.
* Inline logic for the multi-key retrieval instead of recursing.
This also removes undocumented behaviour where a nested array
could be passed to mw.config.get(), e.g. mw.config.get([['debug']]),
which would produces a nested object.
Change-Id: I84506930919e59ce16d96d6d623db5aae5f273e1
Timo Tijhof [Sat, 4 Mar 2017 00:36:46 +0000 (16:36 -0800)]
resourceloader: Undeprecate mw.Map#values
Follows-up
dc0f9b3a3a, which renamed #values to #internalValues to ease
migration to ES5 Map where such object could no longer exist in
real-time as a plain object.
However ES5 Map for mw.Map is no longer on the roadmap per T146432.
The main reason for adopting ES5 was performance, which turns out
to be invalid and was merely a bug in V8 that has since been fixed.
Change this back and undeprecate it. If anything, for developer
convience and type-ahead, which is fairly wildely used.
Change-Id: Ic19641656e53068a0aa15c27f172d39eb13620dd
Timo Tijhof [Mon, 6 Mar 2017 21:11:48 +0000 (13:11 -0800)]
mediawiki.inspect: Fix intermittent test failure
Follows-up
15c0382121.
Bug: T159751
Change-Id: Ib60521c03e72b1fac694b643c570242d8ee8fab1
addshore [Mon, 6 Mar 2017 21:06:43 +0000 (22:06 +0100)]
DatabaseUpdater add missing $maintenance property
Change-Id: I57b1fbbe2f85a74d56c49edef012a185d32ceb1a
Translation updater bot [Mon, 6 Mar 2017 20:56:45 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I71792e5fc230528c7b7b24aac3a69f390ef6de16
jenkins-bot [Mon, 6 Mar 2017 20:53:05 +0000 (20:53 +0000)]
Merge "Add missing dependency from 'mediawiki.user' to 'mediawiki.storage'"
jenkins-bot [Mon, 6 Mar 2017 20:47:58 +0000 (20:47 +0000)]
Merge "RCFilters UI, Followup I97a45208: Replace the entire fieldset"
jenkins-bot [Mon, 6 Mar 2017 20:44:01 +0000 (20:44 +0000)]
Merge "mw.special.block: Add missing dependency"
Timo Tijhof [Mon, 6 Mar 2017 20:42:40 +0000 (12:42 -0800)]
resourceloader: Remove useless INFO log for message blob cache-miss
Change-Id: I306fe87a1de5335e4ce7042667a005bbd7d772c1
jenkins-bot [Mon, 6 Mar 2017 20:37:40 +0000 (20:37 +0000)]
Merge "RCFilters UI: Fix scrolling behavior on search/popup"
Bartosz Dziewoński [Mon, 6 Mar 2017 20:31:32 +0000 (21:31 +0100)]
mw.special.block: Add missing dependency
Bug: T159741
Change-Id: Iff4686b9d5411675582426b3264b88e49baf1f74
Moriel Schottlender [Mon, 6 Mar 2017 20:26:43 +0000 (12:26 -0800)]
RCFilters UI: Fix scrolling behavior on search/popup
Bug: T158018
Change-Id: I7278f34018721e7631ed3f9307e093bd55ff7d24
jenkins-bot [Mon, 6 Mar 2017 20:21:01 +0000 (20:21 +0000)]
Merge "Fix Title::loadRestrictions() for create-protected titles"
jenkins-bot [Mon, 6 Mar 2017 19:41:37 +0000 (19:41 +0000)]
Merge "RCFilters UI: Add highlight icon"
Fomafix [Mon, 6 Mar 2017 19:02:19 +0000 (20:02 +0100)]
Add missing dependency from 'mediawiki.user' to 'mediawiki.storage'
Follows-up
213cdfbec8cf063a6e5a6f168ec97dbd32653d4f.
Change-Id: I2fb1ae48eade34e5df640313b7976541655f2a79
Moriel Schottlender [Thu, 2 Mar 2017 23:13:33 +0000 (15:13 -0800)]
RCFilters UI: Add highlight icon
Bug: T149467
Change-Id: I8a38fd2a07b1d3516b21911ddcf4014a9015d48e
Moriel Schottlender [Mon, 6 Mar 2017 18:21:44 +0000 (10:21 -0800)]
RCFilters UI: Change hover background for filter items
Bug: T149452
Change-Id: I4b891c2b25b03b185f1e6034fc9a224d632caa89
Brad Jorsch [Mon, 6 Mar 2017 17:32:48 +0000 (12:32 -0500)]
Fix mediawiki.action.edit.collapsibleFooter dependencies
Ie9a4612de changed it to use mw.storage, but didn't update the
dependencies. So if nothing else happened to load mediawiki.storage
already, it blows up.
Change-Id: Id276a29d914dacd1d176469db542b41ce6498ea1
Zppix [Fri, 3 Mar 2017 14:38:48 +0000 (14:38 +0000)]
Update CREDIT file
Change-Id: Id2edc2c8ffc56d1a6e8a05ed5c774130b788ac09
jenkins-bot [Sun, 5 Mar 2017 22:25:13 +0000 (22:25 +0000)]
Merge "Move PageArchive class to it's own file"
Florian Schmidt [Sun, 5 Mar 2017 16:13:43 +0000 (17:13 +0100)]
Move PageArchive class to it's own file
Change-Id: I02b7e4785f369c7b6574c4bce093b6de58d1c651
Translation updater bot [Sun, 5 Mar 2017 20:57:10 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie3c474bf55dbed48626aa59e09bf330ea21ece6f
jenkins-bot [Sun, 5 Mar 2017 20:05:54 +0000 (20:05 +0000)]
Merge "EditPage: Remove checks for false contentModel"
Brian Wolff [Fri, 3 Feb 2017 07:50:51 +0000 (07:50 +0000)]
Add another entry to Content-security-policy logging blacklist
Add https://ad.lkqd.net/vpaid/vpaid.js which spams the log quite
a bit. The CSP blacklist includes urls which we know are caused
by adware, and thus aren't interesting (to us).
Change-Id: I11e5a3bbd9090b7d3053ca4c855b220b14511bb5
jenkins-bot [Sun, 5 Mar 2017 16:31:15 +0000 (16:31 +0000)]
Merge "Code cleanups for PageArchive"
jenkins-bot [Sun, 5 Mar 2017 16:28:22 +0000 (16:28 +0000)]
Merge "Remove redundant input from search form"
Florian Schmidt [Sun, 5 Mar 2017 16:11:35 +0000 (17:11 +0100)]
Code cleanups for PageArchive
* define function visibility explicitly
* Fix falsly defined return types
* Fix indention
Change-Id: Ic9fbb27adab24441510e59a3c74c6652d3cedd5d
jenkins-bot [Sun, 5 Mar 2017 13:30:05 +0000 (13:30 +0000)]
Merge "Use getMainObjectStash from MediawikiServices in static UploadBase methods"
Ed Sanders [Fri, 3 Mar 2017 21:07:27 +0000 (21:07 +0000)]
Change mw-body ancestor selector to mw-body-content
mw-body-content can be applied to other elements on the page,
such as content snippets in global overlays. The mw-body class
applies layout styles and so can't be used in this way.
Bug: T155863
Bug: T159578
Depends-On: I036d4def3f61d4a604c804c5368d74ec74883d2e
Depends-On: Id3b89933ed49b6f1395ca407ebf167ad4c55c81f
Change-Id: If2ea04d32677e2c33a6a10213f80f472bb72f440
Ed Sanders [Sun, 5 Mar 2017 11:56:27 +0000 (11:56 +0000)]
Add mw-body-content to indicators
Bug: T155863
Change-Id: I111d0fd1ead266b6dbf7ad81e6e73133b96a7127
jenkins-bot [Sun, 5 Mar 2017 09:56:27 +0000 (09:56 +0000)]
Merge "Chinese Conversion Table Update 2017-2"
Chiefwei [Sun, 5 Mar 2017 08:03:43 +0000 (16:03 +0800)]
Chinese Conversion Table Update 2017-2
Update the Chinese conversion table routinely to fix bugs reported from
https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82
.
It is only data changes and only works for Chinese WikiProjects.
Change-Id: I4c71183a5c7b8cadb04ea2b8026c0ac09b512584
Translation updater bot [Sat, 4 Mar 2017 21:16:41 +0000 (22:16 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ifb5cae0cee83bb7f2021a7c557eca11bdcda22e8
Aaron Schulz [Sat, 4 Mar 2017 19:27:57 +0000 (11:27 -0800)]
Add dynomite comments to WANObjectCache
Change-Id: I7ac9961e6acdecf90b766643138bb64b5ea9ec4a
addshore [Thu, 26 Jan 2017 18:30:28 +0000 (19:30 +0100)]
EditPage: Remove checks for false contentModel
contentModel should always have a value here.
Change-Id: I38ab7211d63ec8b729965e8eefef4ed330f7b1f9
addshore [Tue, 21 Feb 2017 16:53:52 +0000 (16:53 +0000)]
Use getMainObjectStash from MediawikiServices in static UploadBase methods
Change-Id: Ic547efe231c1457b2028301b9db055d3d4e6abfe
Timo Tijhof [Sat, 4 Mar 2017 03:27:43 +0000 (19:27 -0800)]
mediawiki.action.edit: Reduce collapsibleFooter storage size
Follows-up
bf5c263466. No need for back-compat since this is
a new mw.storage key.
Change-Id: Ia25bc5a6c7b26e528692f70ba7c842d80260885c
Roan Kattouw [Sat, 4 Mar 2017 03:16:42 +0000 (19:16 -0800)]
RCFilters UI: Display popups above CapsuleItemWidgets
Depends on I6f2d03ac83aa in oojs-ui
Change-Id: Ia0ff92ef34431827c80a4bc86b391f9d3a3a8958
Moriel Schottlender [Sat, 4 Mar 2017 01:33:13 +0000 (17:33 -0800)]
RCFilters UI: Adjust styles for filter list elements
* Add bottom border between filters
* Adjust the placement of the header label (use table layout)
Bug: T149452
Change-Id: Ie3892b34e5ca5e00380862fa65959d148f2196f4
Eddie Greiner-Petter [Sat, 4 Mar 2017 00:27:51 +0000 (01:27 +0100)]
Remove redundant input from search form
A hidden input 'profile' gets added within the search form widget no
matter what profile is loaded at the moment. This is done in
shortDialogHtml along with a few other hidden fields. The same hidden
field is added a second time in optionsHtml if the profile 'advanced' is
run. Remove this redundance.
Bug: T158869
Change-Id: I3be598702dbe9fa2cfe0fdd6c23fe6d88477626d
jenkins-bot [Sat, 4 Mar 2017 00:01:08 +0000 (00:01 +0000)]
Merge "Use tabs for autoloader extension.json generation"
Moriel Schottlender [Fri, 3 Mar 2017 23:27:41 +0000 (15:27 -0800)]
RCFilters UI: Prevent the popup from disappearing when input is out of view
Depends on OOjs-UI patch (and subsequent release)
Bug: T158118
Change-Id: I5248dcde7fef47a78b60630e944a9392bec99f64
Depends-On: I92b794d5556302099df72af36620299536bf6fe4
jenkins-bot [Fri, 3 Mar 2017 23:19:33 +0000 (23:19 +0000)]
Merge "mediawiki.action.edit: Move collapsibleFooter cookies to localStorage"
Moriel Schottlender [Fri, 3 Mar 2017 20:46:22 +0000 (12:46 -0800)]
RCFilters UI, Followup I97a45208: Replace the entire fieldset
Instead of replacing pieces of the fieldset, replace the entire
thing whenever results are requested (whether there are results
or not)
Bug: T159582
Change-Id: I962ad8f44eb9431e86239bbe3cb3a852227dec17
jenkins-bot [Fri, 3 Mar 2017 22:58:27 +0000 (22:58 +0000)]
Merge "RCFilters UI: Add hover effect on filter list items"
jenkins-bot [Fri, 3 Mar 2017 22:39:57 +0000 (22:39 +0000)]
Merge "mediawiki.inspect: Simplify getModuleSize() by using module descriptor"
Moriel Schottlender [Fri, 3 Mar 2017 22:38:45 +0000 (14:38 -0800)]
RCFilters UI: Add hover effect on filter list items
Bug: T149452
Change-Id: I3b02d9ff6ea6171492fa9b67b17872b5220d5fd4
Bartosz Dziewoński [Fri, 3 Mar 2017 20:43:58 +0000 (21:43 +0100)]
mw.special.apisandbox: Correct fixTokenAndResend() when a token is already known
In this snippet:
success = function ( k ) {
delete tokenWait[ k ];
...
};
...
tokenWait[ k ] = page.tokenWidget.fetchToken()
.done( success.bind( page.tokenWidget, k ) )
.fail( failure.bind( page.tokenWidget, k ) );
If fetchToken() returns a promise that is already resolved (because we
have the token cached), the `delete tokenWait[ k ];` will happen before
the `tokenWait[ k ] = ...`, and later code checking that `tokenWait` is
empty will not work correctly.
Fix this by doing the assigment before connecting the done/fail handlers,
in a separate statement.
Change-Id: Ieeb23cad0fd7e0cd4d3d259ff9f324f2001de0c6
Bartosz Dziewoński [Fri, 3 Mar 2017 20:56:46 +0000 (21:56 +0100)]
mw.special.apisandbox: Pass $overlay to PopupButtonWidgets to fix overlaps
Bug: T155992
Change-Id: I32b26b72a3aaa6f118cd774396b6f350195cd2a7
Timo Tijhof [Fri, 3 Mar 2017 22:01:59 +0000 (14:01 -0800)]
mediawiki.inspect: Simplify getModuleSize() by using module descriptor
Follows-up
ce2652c9ec. Also add unit tests.
Change-Id: I26caaf982f0d317028b5b00374dded6995564ece