jenkins-bot [Mon, 11 Feb 2019 15:07:41 +0000 (15:07 +0000)]
Merge "Exception is never thrown in the getConnection() method"
Derick Alangi [Mon, 11 Feb 2019 12:01:11 +0000 (13:01 +0100)]
Remove unused @throws anotation from PHPDoc comment
Change-Id: If60ad5c12edbf4ea96c5c337f0c05cf0a8d5e43d
jenkins-bot [Mon, 11 Feb 2019 03:54:58 +0000 (03:54 +0000)]
Merge "Add jakub-onderka/php-console-highlighter 0.3.2 explicitly"
Reedy [Mon, 11 Feb 2019 03:27:55 +0000 (03:27 +0000)]
Add jakub-onderka/php-console-highlighter 0.3.2 explicitly
We pin it in various libraries, might aswell in core for completenes
Change-Id: I659c880c9e16e4eab7050874f75c9eb5c9fa958c
Reedy [Mon, 11 Feb 2019 02:02:04 +0000 (02:02 +0000)]
Update cssjanus from 1.2.0 to 1.2.1
Change-Id: I99f11a24ff0a8b02b1c0103ad8cb8faeb165c84e
Depends-On: Iee4c24b6b5dd92493160caafa4764b6d6e427147
jenkins-bot [Mon, 11 Feb 2019 00:58:25 +0000 (00:58 +0000)]
Merge "Updated pear/net_smtp from 1.8.0 to 1.8.1"
jenkins-bot [Mon, 11 Feb 2019 00:53:07 +0000 (00:53 +0000)]
Merge "ParserTestPrinter: use Shell class"
jenkins-bot [Mon, 11 Feb 2019 00:51:56 +0000 (00:51 +0000)]
Merge "JpegPixelFormatTest: use Shell class"
jenkins-bot [Mon, 11 Feb 2019 00:43:31 +0000 (00:43 +0000)]
Merge "Linker: Remove some else statements, and unnecessary temporary variables"
jenkins-bot [Mon, 11 Feb 2019 00:37:59 +0000 (00:37 +0000)]
Merge "Make attachLatest.php wait for DB replica lag"
Reedy [Sun, 10 Feb 2019 23:00:06 +0000 (23:00 +0000)]
Updated pear/net_smtp from 1.8.0 to 1.8.1
Depends-On: I6543ac3e6482da197ce2d644823861d1db4624d8
Change-Id: I91b3c2864536a53fcc829a1e10a3bc0d4638db2b
Reedy [Sat, 9 Feb 2019 07:25:57 +0000 (07:25 +0000)]
Linker: Remove some else statements, and unnecessary temporary variables
Change-Id: I9b9383459edf06280135d9709da889fc5a688c98
Reedy [Sun, 10 Feb 2019 22:37:29 +0000 (22:37 +0000)]
Update dev dependancies
* Updated psy/psysh from 0.9.6 to 0.9.9 (dev-only).
* Updated nikic/php-parser from 3.1.3 to 3.1.5 (dev-only).
Change-Id: I05e45327e93d3bc733db73c0efe573b3223cc902
Depends-On: I896ac6c5afa8221ceca726eb7895e05d87d7e6f3
Translation updater bot [Sun, 10 Feb 2019 20:56:24 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I26dda2663489848ffc75fc54b766fb827eeff4de
Reedy [Sat, 9 Feb 2019 23:27:14 +0000 (23:27 +0000)]
Make attachLatest.php wait for DB replica lag
Change-Id: I4f402ba772d0b0dda8360eaacf11e318f659efc0
Timo Tijhof [Wed, 23 Jan 2019 23:51:49 +0000 (15:51 -0800)]
build: Use headless Chrome and Firefox for QUnit testing
Also:
* Remove "watch" task from Gruntfile.
This wasn't exposed via npm-run and afaik rarely if ever used.
It seems mostly obsoleted by modern editors which perform
linting and style guidance as-you-type and on-save.
* Remove "chromium" target from karma config, the default
target supports both Chromium and Chrome.
* Remove unused "default" alias in Gruntfile. Was only
accessible if developers installed grunt-cli globally, which
we don't require and shouldn't encourage. The new minify task
is now exposed as "npm run build".
* Remove "test" alias in Gruntfile. Was only used by "npm run test",
which now uses "grunt lint" directly, which makes it more clear
that these are only linters, and not unit tests.
This references T211784 because ensuring no headed browsers are used
(which would need Xvfb to start), is a prerequisite for the new Node 10
images. We may still need to provide a slower Xvfb-wrapped variant for
some repos, but would be nice of mw-core wasn't one of them.
Bug: T211784
Change-Id: I270a16d2b4f799ac7c9f84e9e2ee23806bdbc57e
Max Semenik [Sun, 10 Feb 2019 06:25:57 +0000 (22:25 -0800)]
ParserTestPrinter: use Shell class
Change-Id: I9e2eb3b01a9907d72e3edaa6660a4057d513942e
Max Semenik [Sun, 10 Feb 2019 06:20:25 +0000 (22:20 -0800)]
JpegPixelFormatTest: use Shell class
Change-Id: I53099827dc2b2b26b7f3cbc9f0e12030868fdafd
jenkins-bot [Sun, 10 Feb 2019 06:19:28 +0000 (06:19 +0000)]
Merge "build: Update karma to 3.1.4"
jenkins-bot [Sun, 10 Feb 2019 06:03:08 +0000 (06:03 +0000)]
Merge "Hard deprecate Language::setCode"
Timo Tijhof [Sun, 10 Feb 2019 04:00:38 +0000 (04:00 +0000)]
build: Update karma to 3.1.4
This fixes the bug where HeadlessChrome was always shown as
version 0.0.0 in the console output, which makes it rather
difficult to debug which Chrome version is installed.
Upstream https://github.com/karma-runner/karma/issues/2762,
which updates the ua-parser library to a version that fixes
that bug.
Change-Id: I0b7fe7f8a90649592c4d31fb3055cdc9e8d34814
Roan Kattouw [Sat, 9 Feb 2019 22:59:10 +0000 (14:59 -0800)]
RCFilters: Export config vars in the RL modules where possible
Right now there are only a few settings that don't depend on the request
context, but we can at least export those. The tag data in
particular can get pretty big.
Downgrade the type hint for ChangeTags::tagDescription() and
tagLongDescriptionMessage() from IContextSource to MessageLocalizer, so
we can pass a ResourceLoaderContext to these functions. (Since
IContextSource extends MessageLocalizer, this won't break any callers.)
truncateTagDescription() can't be downgraded to MessageLocalizer because
it needs a Language object, so hack up a fake RequestContext when
calling it. It would be nice if this weren't necessary; perhaps we can
move getLanguage() from IContextSource up into MessageLocalizer?
Bug: T201574
Change-Id: I9b66e35de826a07aa9551ba285e64e4852293229
jenkins-bot [Sun, 10 Feb 2019 02:11:01 +0000 (02:11 +0000)]
Merge "resourceloader: Reduce 'implement' overhead for modules without scripts"
jenkins-bot [Sun, 10 Feb 2019 01:26:02 +0000 (01:26 +0000)]
Merge "Move migrateActors.php to includes"
jenkins-bot [Sun, 10 Feb 2019 01:19:26 +0000 (01:19 +0000)]
Merge "RCFilters: Convert RL modules to packageFiles"
Roan Kattouw [Fri, 14 Sep 2018 19:29:51 +0000 (12:29 -0700)]
RCFilters: Convert RL modules to packageFiles
* Use per-file require() to get classes' dependencies
* Export all DM classes to the global mw.rcfilters.dm object because the
unit tests need that
* Don't make any of the UI classes globally available except
MainWrapperWidget (and we can probably drop that one too)
* Rename mw.rcfilters.{dm,ui}.XYZ.js to XYZ.js
Change-Id: I8e541abf15c6987827a29eecc6a6f19f27378abb
Krinkle [Sun, 10 Feb 2019 00:17:45 +0000 (00:17 +0000)]
Merge "wdio-mediawiki: Rename internal "Front page" ref to "Main page""
jenkins-bot [Sat, 9 Feb 2019 23:40:34 +0000 (23:40 +0000)]
Merge "resources: Update jquery-client from v2.0.1 to v2.0.2"
jenkins-bot [Sat, 9 Feb 2019 23:40:29 +0000 (23:40 +0000)]
Merge "mediawiki.user: Remove deprecated stickyRandomId()"
James D. Forrester [Sat, 9 Feb 2019 22:42:09 +0000 (14:42 -0800)]
resources: Update jquery-client from v2.0.1 to v2.0.2
Bug: T101483
Change-Id: Ib1537cd92d733998818fe28b04ee81bec48a75d3
jenkins-bot [Sat, 9 Feb 2019 23:14:59 +0000 (23:14 +0000)]
Merge "wdio-mediawiki: Move non-public methods to local scope"
Timo Tijhof [Fri, 25 Jan 2019 19:08:01 +0000 (11:08 -0800)]
wdio-mediawiki: Rename internal "Front page" ref to "Main page"
Also remove redundant 'new Promise' indirection, in favour
of native chaining through "then()".
This avoids a situation where wdio could hang indefinitely (until
timeout) when MWBot.request fails because we did not attach any
"catch()" handler to the promise. By always keeping a chain, the
failures are (by default) forwarded and thus propagated and thus
caught eventually.
Change-Id: If2f09479600029db2fa967c57082031744a06d8f
jenkins-bot [Sat, 9 Feb 2019 23:05:59 +0000 (23:05 +0000)]
Merge "Follow-up I5bcae848: Remove from 1.33 RL, backported to 1.32"
Timo Tijhof [Fri, 25 Jan 2019 19:05:57 +0000 (11:05 -0800)]
wdio-mediawiki: Move non-public methods to local scope
Change-Id: I56258290d7c731b913f4df21c0bf4adc7fe4c69f
jenkins-bot [Sat, 9 Feb 2019 22:54:57 +0000 (22:54 +0000)]
Merge "mediawiki.language: Deprecate mw.language.specialCharacters"
jenkins-bot [Sat, 9 Feb 2019 22:50:25 +0000 (22:50 +0000)]
Merge "mediawiki.libs.jpegmeta: Remove deprecated mw.libs property"
James D. Forrester [Thu, 7 Feb 2019 22:34:09 +0000 (14:34 -0800)]
Follow-up I5bcae848: Remove from 1.33 RL, backported to 1.32
Change-Id: I84fa5e2fae785f80833a3128c18790d6ad3d1042
Bartosz Dziewoński [Tue, 29 Jan 2019 03:33:14 +0000 (04:33 +0100)]
resourceloader: Reduce 'implement' overhead for modules without scripts
Change-Id: I55728c526711545be3923d3e1e2f276cbfa52224
Roan Kattouw [Sat, 9 Feb 2019 00:53:48 +0000 (16:53 -0800)]
mediawiki.language: Deprecate mw.language.specialCharacters
Use require( 'mediawiki.language.specialCharacters' ) instead.
Remove mw.language.setSpecialCharacters(), because it was only used by
the specialCharacters module. There already was no getter.
Depends-On: I9cf525a1e1aadc12d72284d08b98882b0ab95f5e
Depends-On: I74e706a6603bd8fa899193de91e49f246608c4c1
Change-Id: I02e0e84b79309caa314954925cc9c0c2874b9bde
jenkins-bot [Sat, 9 Feb 2019 22:37:17 +0000 (22:37 +0000)]
Merge "Drop SessionManager::autoCreateUser(), deprecated in 1.27 and unused"
Timo Tijhof [Sat, 9 Feb 2019 01:21:46 +0000 (01:21 +0000)]
mediawiki.user: Remove deprecated stickyRandomId()
Introduced and renamed/deprecated in the same cycle (MW 1.32), was
meant to be removed before release but forgotten.
Change-Id: I4bb219a1e38e15651115b70277e1968886dca690
Timo Tijhof [Sat, 9 Feb 2019 01:16:05 +0000 (01:16 +0000)]
mediawiki.libs.jpegmeta: Remove deprecated mw.libs property
Deprecated since 1.31.
Also fix existing uses to not use the private mw.loader access
pattern, which is unsupported and not needed here.
Depends-On: If0a125320af15b92216d98f54348f8b375cc1988
Change-Id: I403379ebf710077b77a02854c22071014d1a6bc4
jenkins-bot [Sat, 9 Feb 2019 22:32:47 +0000 (22:32 +0000)]
Merge "Drop b/c reading of wgSessionsInObjectCache and wgSessionHandler, deprecated in 1.27"
jenkins-bot [Sat, 9 Feb 2019 22:16:53 +0000 (22:16 +0000)]
Merge "resourceloader: Misc optimisations in startup module"
James D. Forrester [Sat, 9 Feb 2019 01:41:28 +0000 (17:41 -0800)]
Drop SessionManager::autoCreateUser(), deprecated in 1.27 and unused
Depends-On: I261ea755c1d273ccc7fcc7c3b041623ccf4e331b
Change-Id: Ice2d755bee694b97e5ddbfc72caddf2b87ba0fc9
James D. Forrester [Sat, 9 Feb 2019 20:59:00 +0000 (12:59 -0800)]
Drop b/c reading of wgSessionsInObjectCache and wgSessionHandler, deprecated in 1.27
Depends-On: I0d861a24b6cfd5c881112f15c682d97cef715cf0
Change-Id: I6b69d9ad3863512879f287f960828c1fdf7b214c
James D. Forrester [Sat, 9 Feb 2019 01:43:08 +0000 (17:43 -0800)]
Drop User::getGroup{Name|Member}(), deprecated in 1.29 and unused
Except in the Configure extension.
Change-Id: Id6e2511cc2c5f86afcf0af2faa69d4a712efbe26
James D. Forrester [Sat, 9 Feb 2019 20:18:35 +0000 (12:18 -0800)]
Drop EmailNotification::updateWatchlistTimestamp(), deprecated in 1.27 and unused
Change-Id: Idad6f5aa579e41e941d1074465dd2f0e0f4577dc
Matěj Suchánek [Sat, 9 Feb 2019 10:30:34 +0000 (11:30 +0100)]
Move migrateActors.php to includes
This way it can be subclassed in extensions, like AbuseFilter
(Ic755526d5f989c4a66b1d37527cda235f61cb437).
Bug: T188180
Change-Id: Idf320232011c72e39267b1f3c39848aea35d37fe
James D. Forrester [Sat, 9 Feb 2019 01:40:22 +0000 (17:40 -0800)]
Drop SearchEngine::getNearMatchResultSet(), deprecated in 1.27 and unused
Change-Id: I87987af702b9b92c4d1b3578e69f1b2e68529b52
James D. Forrester [Sat, 9 Feb 2019 01:37:23 +0000 (17:37 -0800)]
Drop MWExceptionHandler::getLogId(), deprecated in 1.27 and unused
Change-Id: Id03aaf4f2ea5c910e13274826e44033e12adcd2e
James D. Forrester [Sat, 9 Feb 2019 01:36:01 +0000 (17:36 -0800)]
Drop JsonContent->getJsonData(), deprecated in 1.25 and unused
Change-Id: I2cac3a1d2cda799c302ca2364fb91916c3240c11
James D. Forrester [Sat, 9 Feb 2019 01:34:49 +0000 (17:34 -0800)]
Drop LinkCache->addLink(), deprecated in 1.27 and unused
Change-Id: Id6395cc9a122375349b7a13c051049bca3f5ab08
jenkins-bot [Sat, 9 Feb 2019 07:44:02 +0000 (07:44 +0000)]
Merge "Drop EventRelayerGroup::singleton(), deprecated in 1.27 and unused"
jenkins-bot [Sat, 9 Feb 2019 07:38:21 +0000 (07:38 +0000)]
Merge "Drop Linker::formatTemplates, deprecated in 1.28 and unused"
jenkins-bot [Sat, 9 Feb 2019 07:33:23 +0000 (07:33 +0000)]
Merge "Drop Linker::formatSize, deprecated in 1.28 and unused"
James D. Forrester [Sat, 9 Feb 2019 01:32:42 +0000 (17:32 -0800)]
Drop EventRelayerGroup::singleton(), deprecated in 1.27 and unused
Change-Id: I9e63fc255a575086a6c0934e51e593b5ee0a31d8
jenkins-bot [Sat, 9 Feb 2019 02:21:22 +0000 (02:21 +0000)]
Merge "Persist sessions pre-send instead of post-send"
jenkins-bot [Sat, 9 Feb 2019 02:21:17 +0000 (02:21 +0000)]
Merge "resourceloader: Require logName parameter in mw.log.deprecate()"
Timo Tijhof [Fri, 8 Feb 2019 23:54:44 +0000 (23:54 +0000)]
resourceloader: Misc optimisations in startup module
* Remove redundant trackQueue var.
* Simplify logError() code, and remove some local vars.
* Simplify Map#set() code.
* Simplify performance.now check. There are no known browsers,
supported and unsupported, in which this property is existant
as anything other than a function.
* Optimised baseModules iteration in sortDependencies().
Slightly shorter and slightly faster as for-loop.
* Omit trailing dot from error message in one case.
(None of the other error messages had trailing dots.)
* Add missing space to error message for mainScript.
* Simplify splitModuleKey() code.
* Remove redundant quotes in mw.loader.store.set() for encodedScript.
Differences in response body size on stock MediaWiki.
> uncomp 42152 - 41984 = 168 bytes saved.
> gzip-1 15437 - 15364 = 73 bytes saved.
> gzip-9 13506 - 13419 = 87 bytes saved.
Change-Id: I54c9ab30522c36ece054b915809fe20bff6867b3
Timo Tijhof [Sat, 9 Feb 2019 01:36:13 +0000 (01:36 +0000)]
resourceloader: Require logName parameter in mw.log.deprecate()
When omitted it, it previously defaulted to the key string, which
would automatically lead to the creation of confusing and
non-descript Graphite metrics. (Via the WikimediaEvents extension
via the 'mw.deprecate' tracking topic.)
If Graphite tracking is intended, require the logName parameter
to be set. For example, in wikibits, a deprecated 'write' method
is set on the 'document' object. Its Graphite property under
mw/js/deprecate/ will be document_write because logName is set.
Without logName, it would previously create 'mw/js/deprecate/write'
as metric, which easily clashes and is not very understandable
in Grafana.
An exception is kept for properties of the window object as their
fully-qualified property name would always be identical due to
them being available as global variables.
Change-Id: I9d99fe0395ec5309eac0895f2419f7cd16caeb94
James D. Forrester [Sat, 9 Feb 2019 01:31:42 +0000 (17:31 -0800)]
Drop Linker::formatTemplates, deprecated in 1.28 and unused
Change-Id: I02e677021cdc1fc7ac6da4839a23b15afcfb2296
James D. Forrester [Sat, 9 Feb 2019 01:31:29 +0000 (17:31 -0800)]
Drop Linker::formatSize, deprecated in 1.28 and unused
Change-Id: Id119e9f3ff0d27b59654876bad9212cc0f3c5a2d
James D. Forrester [Sat, 9 Feb 2019 01:26:04 +0000 (17:26 -0800)]
Drop SiteSQLStore, deprecated in 1.27, unused
Change-Id: I6743417c3aafbba59ac02350e0190fbf688a5a40
jenkins-bot [Sat, 9 Feb 2019 01:14:39 +0000 (01:14 +0000)]
Merge "Remove old Title CSS/JS methods, deprecated in 1.31, unused"
jenkins-bot [Sat, 9 Feb 2019 01:05:02 +0000 (01:05 +0000)]
Merge "Remove Title->canTalk, deprecated in 1.30, unused"
jenkins-bot [Sat, 9 Feb 2019 00:44:57 +0000 (00:44 +0000)]
Merge "Remove Title::escapeFragmentForURL, deprecated in 1.30, unused"
Roan Kattouw [Mon, 5 Nov 2018 22:20:05 +0000 (14:20 -0800)]
Use packageFiles feature to replace special-purpose RL modules
For config vars, add a virtual package file called 'config.js', and use
require( './config.js' ) in the module. For most data modules, add a
virtual package file called 'data.js', use require( './data.js' ) in the
module. Where needed, add wrapper files that put the data in the
relevant global object and in module.exports.
LanguageDataModule is the only special-purpose module not being removed
in this commit, because it uses languageScripts, and those are not
compatible with packageFiles (yet).
Also merge mediawiki.ForeignStructuredUpload.config into
mediawiki.ForeignStructuredUpload, since that was the only thing that
used it.
Change-Id: I203d4e3ecdeeeb16729eba2dcf40d11a41d2e582
James D. Forrester [Fri, 8 Feb 2019 01:03:39 +0000 (17:03 -0800)]
Remove old Title CSS/JS methods, deprecated in 1.31, unused
Change-Id: I500b5efbdc2ee3b4ca09662ed0df89e9d7514bbd
jenkins-bot [Fri, 8 Feb 2019 19:52:12 +0000 (19:52 +0000)]
Merge "Remove Title->getSquidURLs, deprecated in 1.27, unused"
jenkins-bot [Fri, 8 Feb 2019 19:51:12 +0000 (19:51 +0000)]
Merge "Fix mw-ui-quiet+progressive/destructive selectors"
Marko Obrovac [Fri, 1 Feb 2019 23:48:08 +0000 (15:48 -0800)]
MWHttpRequest: Include the request ID in outgoing HTTP requests
In order to be able to trace requests across the production environment,
we attach the X-Request-Id to outgoing requests.
Bug: T201409
Change-Id: Iadd6cbd51a78a1876a1a318783b51635717d054f
Fomafix [Fri, 8 Feb 2019 18:35:40 +0000 (19:35 +0100)]
NoLocalSettings: Remove style for the html element
There is no need to style the html element. A style of the body element
is enough.
Change-Id: I4ab90824de393de3569ff55cf0138a7aede5770c
Ed Sanders [Fri, 8 Feb 2019 14:13:03 +0000 (14:13 +0000)]
Fix mw-ui-quiet+progressive/destructive selectors
Bonus: Fix color of disabled button text
Bug: T215610
Change-Id: I6e38355b46d87920605604beb0141cf097efab08
jenkins-bot [Fri, 8 Feb 2019 03:55:22 +0000 (03:55 +0000)]
Merge "Collapse some else statements and nested if statements"
jenkins-bot [Fri, 8 Feb 2019 03:46:09 +0000 (03:46 +0000)]
Merge "Expose external link additions and deletions"
Reedy [Thu, 7 Feb 2019 03:28:29 +0000 (03:28 +0000)]
Collapse some else statements and nested if statements
Change-Id: Idd4d751e149e2ee11b8749ba847323f189b6ae51
jenkins-bot [Fri, 8 Feb 2019 02:50:54 +0000 (02:50 +0000)]
Merge "Move upload stash related exceptions to own files"
James D. Forrester [Fri, 8 Feb 2019 01:02:52 +0000 (17:02 -0800)]
Remove Title->canTalk, deprecated in 1.30, unused
Change-Id: I0c397f8d33a2841343c7907b233530bf3c88e212
Bill Pirkle [Wed, 6 Feb 2019 16:29:52 +0000 (10:29 -0600)]
Change HttpRequestFactory default to guzzle
Activate the changes from T212175 by changing the default
MWHttpRequest-derived type to guzzle. This is being done
as a separate change so that it is conveniently revertable
if issues arise.
Bug: T214703
Change-Id: I0868d2e7f3eed6d7c6b15334eb3187f3edcd7bec
James D. Forrester [Fri, 8 Feb 2019 01:02:15 +0000 (17:02 -0800)]
Remove Title::escapeFragmentForURL, deprecated in 1.30, unused
Change-Id: I649f3f1346c366e722fe4fd8690773bedce7ec54
James D. Forrester [Fri, 8 Feb 2019 01:01:40 +0000 (17:01 -0800)]
Remove Title->getSquidURLs, deprecated in 1.27, unused
Change-Id: I9e9b8ba33ba5d5cb219d00879ecb45b6b005b7e3
Roan Kattouw [Thu, 7 Feb 2019 22:28:10 +0000 (14:28 -0800)]
resourceloader: Fix localStorage for multi-file modules
I had forgotten to update mw.loader.store.set() for the new multi-file
module format.
Follows-up
fbbd65d2df43f522f4deae719.
Change-Id: I27edeb43b218c93761ea7c394e18fac7a5cc914d
Baha [Thu, 7 Feb 2019 16:10:09 +0000 (11:10 -0500)]
Expose external link additions and deletions
Needed for links event stream.
Bug: T214706
Change-Id: Ie93c8d90c2f69d7a08b8a6e9a0a5bb8266d4dd51
jenkins-bot [Thu, 7 Feb 2019 22:03:09 +0000 (22:03 +0000)]
Merge "API: Don't return a deprecation warning for default values"
jenkins-bot [Thu, 7 Feb 2019 21:50:47 +0000 (21:50 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 24.0.0"
Translation updater bot [Thu, 7 Feb 2019 21:04:39 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I36b74b2277e53dceeb60a3662eb14da9fa4f0589
Brad Jorsch [Thu, 7 Feb 2019 20:32:36 +0000 (15:32 -0500)]
API: Don't return a deprecation warning for default values
If a deprecated parameter has a default value, or a deprecated value is
part of the default value for a parameter, don't give the client a
deprecation warning about it.
Bug: T215548
Change-Id: I980763e3d44fb1b7459c64b175fcaddf5fd44a13
jenkins-bot [Thu, 7 Feb 2019 19:52:45 +0000 (19:52 +0000)]
Merge "build: Add 'svgmin' Grunt task and crush SVGs"
jenkins-bot [Thu, 7 Feb 2019 19:29:54 +0000 (19:29 +0000)]
Merge "Ensure action object matches passed in right in Title::checkUserBlock()"
David Barratt [Tue, 8 Jan 2019 21:14:48 +0000 (16:14 -0500)]
Ensure action object matches passed in right in Title::checkUserBlock()
There is a possibility that the retrieved action (by name) will not match the
passed in right, we should ensure that the retrieved action matches.
Also adds 'purge' to the whitelist of actions that are not prevented by a
block.
Bug: T213220
Change-Id: I5671dcd6f004b1663c8a5c5aec200abbf742ec1d
Kunal Mehta [Thu, 7 Feb 2019 09:21:19 +0000 (01:21 -0800)]
build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: I66b1775b7c1d36076d9ca78cbeb42787a743f2aa
James D. Forrester [Thu, 7 Feb 2019 18:13:29 +0000 (10:13 -0800)]
resources: Allow jquery.ui.widgets on mobile
Change-Id: If0d7b687e5996e5dcdce0651c85a4dc4461b482b
jenkins-bot [Thu, 7 Feb 2019 16:57:13 +0000 (16:57 +0000)]
Merge "Stop overwriting $cache in User::getCacheKey()"
Volker E [Thu, 7 Feb 2019 05:53:50 +0000 (21:53 -0800)]
build: Add 'svgmin' Grunt task and crush SVGs
Adding 'grunt-svgmin' package and corresponding 'svgmin' task and
also crush SVGs. Several of them are featuring bad UX and are not optimal
in many different angles (a.o. clarity, universality, recognizablity etc.).
Specifically the 'mediawiki.skinning' ones.
But while they are here, let's make them suck less.
Change-Id: I8191ceac14565ae31d941982fab1586fa9b6bbdd
Brad Jorsch [Fri, 4 Jan 2019 18:55:11 +0000 (13:55 -0500)]
Mostly drop old comment schemas
This removes most of the pre-CommentStore text columns, and the
$wgCommentTableSchemaMigrationStage setting that used to determine
whether the columns were used.
rev_comment remains in the code, as on Wikimedia wikis the revision
table is too large to alter at this time. A future change will combine
that with the removal of rev_user_text, rev_content_model, and
rev_content_format (and the addition of rev_comment_id and rev_actor).
CommentStore's constructor continues to take a $stage parameter, and
continues to have the logic for handling it, for the benefit of
extensions that might need their own migration process.
Bug: T166733
Change-Id: I1479c73774e01ead1490adf6128f820c09bce9d4
Brad Jorsch [Mon, 9 Jul 2018 19:22:45 +0000 (15:22 -0400)]
Improve performance of ActiveUsersPager query
The query can be very slow, as it has to scan all the recentchanges rows
for all the users in querycachetwo (for activeusers). We can speed that
up at the cost of not filtering out users who were active when
querycachetwo was last updated but aren't anymore.
Also in testing this I found that the query is extremely slow when the
actor table migration stage is in one of the transitional states. This
too can be sped up with some custom logic.
Bug: T199044
Change-Id: Ia9d2ff00cfcdcc6191d854eb4365ecbf67f60b1c
Reedy [Thu, 7 Feb 2019 03:30:57 +0000 (03:30 +0000)]
Stop overwriting $cache in User::getCacheKey()
Replace a few deprecated function calls
Bug: T215483
Change-Id: I000b58d8bf67d9c1ea0123a7547b986e8ca69f25
jenkins-bot [Thu, 7 Feb 2019 01:42:14 +0000 (01:42 +0000)]
Merge "Make invalidateModuleCache() take a database domain ID"
jenkins-bot [Thu, 7 Feb 2019 01:42:09 +0000 (01:42 +0000)]
Merge "Rename WikiMap DB domain ID methods to reduce confusion with web domains"