jenkins-bot [Tue, 31 May 2016 22:56:44 +0000 (22:56 +0000)]
Merge "mw.Title: Correct order of file URL regexes in newFromImg"
jenkins-bot [Tue, 31 May 2016 22:56:04 +0000 (22:56 +0000)]
Merge "HTMLMultiSelectField: Use CheckboxMultiselectInputWidget"
jenkins-bot [Tue, 31 May 2016 22:48:24 +0000 (22:48 +0000)]
Merge "objectcache: Support key versioning in WANObjectCache"
Bartosz Dziewoński [Mon, 30 May 2016 11:16:51 +0000 (13:16 +0200)]
HTMLMultiSelectField: Use CheckboxMultiselectInputWidget
Depends on I6f9fad0a462b43ac45c117cd3a3e11c36781cf11 in OOjs UI.
Bug: T123935
Change-Id: I62322739b985cc2143b5094d23b3aa5dd1004c25
Bartosz Dziewoński [Tue, 31 May 2016 22:40:15 +0000 (00:40 +0200)]
mw.Title: Correct order of file URL regexes in newFromImg
The "Thumbnails in non-hashed upload directories" regex can match
non-thumbnailed files in hashed directories if the file name contains
the word "thumbnail" or the first two bytes of the MD5 hash of the
file name. We should check "Full size images" first.
Bug: T134860
Change-Id: I74af47969bf9ba204c24e299f788f5349302e437
James D. Forrester [Tue, 31 May 2016 21:55:25 +0000 (14:55 -0700)]
Update OOjs UI to v0.17.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.17.4
Change-Id: I35019c565ec1d72fde0b69f217cab8d73ce441a4
jenkins-bot [Tue, 31 May 2016 20:40:57 +0000 (20:40 +0000)]
Merge "Reset all tokens on login"
Translation updater bot [Tue, 31 May 2016 20:10:00 +0000 (22:10 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3f77a9f17cd70c9ba120d024b0acb7a4de31a37e
jenkins-bot [Tue, 31 May 2016 19:22:44 +0000 (19:22 +0000)]
Merge "populateRevisionLength: Read from slaves when possible"
Chad Horohoe [Tue, 31 May 2016 19:20:05 +0000 (12:20 -0700)]
Reset all tokens on login
Bug: T122056
Change-Id: I03739e942b6c182ed9cbcd0d9615dcd799e8baed
Derk-Jan Hartman [Wed, 11 May 2016 11:53:59 +0000 (13:53 +0200)]
resourceloader: Strip leading BOM when concatenating files
We read files and concatenate their contents. Files may start with a BOM character.
BOM characters are only allowed at the beginning of a file, not half way.
Stripping it should be safe, since we already assume that everything is UTF-8.
Change-Id: I14ad698a684e78976e873e9ae2c367475550a063
jenkins-bot [Tue, 31 May 2016 17:39:48 +0000 (17:39 +0000)]
Merge "Do not redirect to HTTPS when it's not supported"
jenkins-bot [Tue, 31 May 2016 17:01:07 +0000 (17:01 +0000)]
Merge "Return error message in users API cancreate field"
jenkins-bot [Tue, 31 May 2016 16:41:53 +0000 (16:41 +0000)]
Merge "AuthManager fixups around the login→RESTART→create flow"
Gergő Tisza [Thu, 26 May 2016 18:04:02 +0000 (18:04 +0000)]
Do not redirect to HTTPS when it's not supported
Most URL generation happens via wfExpandUrl, which honors $wgServer
(or whatever setting it is told to use): if it has an explicit
protcol, that is always used; if it is a protocol-relative URL,
the protocol is selected based on the parameters given to wfExpandUrl.
One exception is MediaWiki::main() which always uses HTTPS if the
relevant cookie or user option is set, even if the wiki does not
support it. That can lead to annoying problems on Vagrant where it
is not unusual to turn HTTPS support on and off: when that happens,
the user can get locked out of the account.
Change-Id: I06982a26cd808f2aaa26753cd3353ed82473d9e0
jenkins-bot [Tue, 31 May 2016 16:17:32 +0000 (16:17 +0000)]
Merge "Fix encryption code in Session"
Gergő Tisza [Mon, 30 May 2016 22:05:14 +0000 (22:05 +0000)]
Fix encryption code in Session
* verify that the algorithm that's about to be used is available
* fix exception namespace
Bug: T136587
Change-Id: I9f8636bef0e10b4f2b8bfe232a26a8c33376ca04
Brad Jorsch [Thu, 26 May 2016 17:09:14 +0000 (13:09 -0400)]
AuthManager fixups around the login→RESTART→create flow
* ApiQueryAuthManagerInfo will differentiate between preserved linking
data and a preserved createRequest.
* ApiQueryAuthManagerInfo will indicate the preserved username, if any,
because the client will have to pass that back to action=createaccount.
* ApiClientLogin won't tell about the confusing
CreateFromLoginAuthenticationRequest returned on RESTART responses.
* Explain how 'preservestate' works in ApiAMCreateAccount's auto-doc.
* ConfirmLinkSecondaryAuthenticationProvider will filter out requests
that can no longer be used (i.e. if it was for linking the account
that got used for creation).
* All the complicated code in AuthManager::beginAccountCreation() was
trying to deal with allowing the client to pass only the
CreateFromLoginAuthenticationRequest. That was dumb, removed it.
* Added methods to CreateFromLoginAuthenticationRequest to indicate its
status with respect to different kinds of preserved state.
* Increase accuracy of the AuthenticationResponse::$createRequest doc.
Change-Id: I726d79de18e739d6e60c1eea51453433c21ba207
Translation updater bot [Mon, 30 May 2016 19:56:25 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iafc12789c203b6b3d1ce0f81136f139a023ed972
Nemo bis [Thu, 27 Nov 2014 12:52:56 +0000 (13:52 +0100)]
pngcrush -brute -reduce on mediawiki.skinning
About 25 % size reduction. Looks good in my image viewer.
Change-Id: I9e4815a75899a68e30b8c264f3d772c8ceb6301b
Gergő Tisza [Mon, 30 May 2016 18:16:07 +0000 (20:16 +0200)]
Return error message in users API cancreate field
That API field exposes AuthManager::canCreateAccount, where the error
message is important.
Change-Id: Idef441b311b94ff0cb6c4deaed1ac93959ee7ee8
Timo Tijhof [Mon, 30 May 2016 16:15:09 +0000 (17:15 +0100)]
Fix rvtoken=rollback in ApiQueryRevisions
Follows-up
9af38c0. Token must match ApiRollback, RollbackAction,
Linker, and WikiPage. (This should not be in different 5 places!)
This broke the "PILT" gadget.
Bug: T136375
Change-Id: Ia6b6879a952925ec52fa627ba57991bc87fd947a
Bartosz Dziewoński [Mon, 30 May 2016 13:09:23 +0000 (15:09 +0200)]
mediawiki.debug: Use monospaced font for debug toolbar, really
It's "monospace", not "monospaced".
Follow-up to
19679b4f which introduced the mistake and
58920c46 which
incorrectly fixed it.
Change-Id: I898486baafebec13f42649ad2da832eb8a8ff1dd
Paladox [Mon, 30 May 2016 12:14:51 +0000 (13:14 +0100)]
Add single quotes around monospaced in less
Follow-Up: I3e3a7c110d4ceae8c1b65b35bf17b34fed7f68f8
Failed in
11:45:13 Running "stylelint:src" (stylelint) task
11:45:15 >>
/home/jenkins/workspace/mediawiki-core-npm-node-4.3/src/resources/src/mediawiki/mediawiki.debug.less
failed:
11:45:15 >> Line 98, column 15: Expected single quotes around font-family
name "monospaced" (font-family-name-quotes) (error)
11:45:15
Which this patch fixes.
Caused I278f6ef063d37c1b6325da76edc9f34b01c27087 to fail which this also
fixes.
Change-Id: I10f64ec5517176a43c292599e4bdb1ad7098929d
jenkins-bot [Mon, 30 May 2016 12:37:34 +0000 (12:37 +0000)]
Merge "API: Fixes for AuthManager"
jenkins-bot [Mon, 30 May 2016 12:31:51 +0000 (12:31 +0000)]
Merge "Typo fix for AuthPluginPrimaryAuthenticationProvider::providerAllowsAuthenticationDataChange"
Brad Jorsch [Tue, 24 May 2016 18:05:52 +0000 (14:05 -0400)]
API: Fixes for AuthManager
* Set API response metadata on the AuthenticationRequest metadata so it
is output as an assoc generally.
* Remove the 'image' field in AuthenticationRequest::getFieldInfo()'s
response, since we ended up not using it anywhere.
* Make it so meta=authmanagerinfo can be used on private wikis without
logging in, so action=clientlogin can be used to log in.
** This generalizes the exception for meta=tokens that was added in
I83dafb030.
* ApiAuthManagerInfo needs the "messageformat" parameter.
* ApiAuthManagerInfo shouldn't be publically cached, since the responses
vary depending on session state.
Change-Id: Iea5ddb4ef9febed18f16a7ae8314968026f39148
jenkins-bot [Mon, 30 May 2016 12:22:30 +0000 (12:22 +0000)]
Merge "Fix required field calculation in AuthenticationRequest"
Gergő Tisza [Sun, 29 May 2016 21:14:28 +0000 (21:14 +0000)]
Fix required field calculation in AuthenticationRequest
Instead of only flagging fields which are required by a request
needed by all primairy providers, it should be enough if all
requests needed by some primary provider require that field.
Also make CreationReasonAuthenticationRequest non-required so that
the list of required form fields is more in sync with that of
pre-AuthManager code.
Bug: T85853
Change-Id: I9d33bd22295758cc532a260b1848616b41d94f12
Ori Livneh [Mon, 30 May 2016 09:47:48 +0000 (09:47 +0000)]
Merge "Make number of PBKDF2 iterations used for deriving session secret configurable"
jenkins-bot [Mon, 30 May 2016 09:11:51 +0000 (09:11 +0000)]
Merge "Use monospaced font for the debug toolbar"
jenkins-bot [Mon, 30 May 2016 09:11:30 +0000 (09:11 +0000)]
Merge "EditPage: Do not resolve redirect on cancel button"
saper [Sun, 12 Apr 2015 23:40:35 +0000 (01:40 +0200)]
Use monospaced font for the debug toolbar
Debug output seems to be much more readable
with the monospaced font.
Change-Id: I3e3a7c110d4ceae8c1b65b35bf17b34fed7f68f8
jenkins-bot [Mon, 30 May 2016 08:59:46 +0000 (08:59 +0000)]
Merge "SpecialUpload: Separate style only module"
jenkins-bot [Mon, 30 May 2016 08:12:41 +0000 (08:12 +0000)]
Merge "Add support for icu-ta collation"
Ori Livneh [Mon, 30 May 2016 04:21:00 +0000 (21:21 -0700)]
wikimedia/cdb: 1.4.0 => 1.4.1
Updated for I5a7a9f259: stop using wikimedia/assert
Change-Id: I8c867eeb3e6612b85db1373e5a25565861174f07
Derk-Jan Hartman [Sat, 28 May 2016 20:55:39 +0000 (22:55 +0200)]
SpecialUpload: Separate style only module
Move the style into a style only module, because it is used
independant of the javascript module. Add the new style module as a
dependency for the javascript module.
Bug: T136364
Change-Id: If34483fdc50dc130a4bcf3d163b34b954f2269bb
Translation updater bot [Sun, 29 May 2016 19:53:53 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id11f3672bf50a6ce9521295db140c6c0f2e9d0f9
Gergő Tisza [Sun, 29 May 2016 14:00:23 +0000 (14:00 +0000)]
Typo fix for AuthPluginPrimaryAuthenticationProvider::providerAllowsAuthenticationDataChange
Change-Id: I7c05ea91009cdf765b06438e055de891e0edd1f4
jenkins-bot [Sun, 29 May 2016 10:42:19 +0000 (10:42 +0000)]
Merge "WatchedItemStore: Use callable type hint instead of Assert library"
Fomafix [Sat, 28 May 2016 20:21:07 +0000 (20:21 +0000)]
EditPage: Do not resolve redirect on cancel button
Change-Id: I9343c7e97cee7fa6550b186e6a6ffbf3438060a4
jenkins-bot [Sat, 28 May 2016 20:14:56 +0000 (20:14 +0000)]
Merge "LoginSignupSpecialPage: Load return and returnto params as early as possible"
jenkins-bot [Sat, 28 May 2016 20:14:52 +0000 (20:14 +0000)]
Merge "RollbackAction: Don't return true, causes '1' to be output"
Translation updater bot [Sat, 28 May 2016 19:54:09 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8038db5de26e5efb0b801902e8ce51536af5e47b
jenkins-bot [Sat, 28 May 2016 17:43:42 +0000 (17:43 +0000)]
Merge "mw.ForeignStructuredUpload.BookletLayout: Make licensing links clickable again"
jenkins-bot [Sat, 28 May 2016 17:35:57 +0000 (17:35 +0000)]
Merge "Clean up updatedmarker styling mess"
Florian [Fri, 27 May 2016 14:02:40 +0000 (16:02 +0200)]
SpecialSearch: Use OOUI\ActionFieldLayout for search input and button
This prevents the button from flipping to a new line if the window or
the available width at all is smaller as the width of the input and the
button together. Now, the input will be as small as needed for the button
to be on the same line.
Bug: T134475
Change-Id: Icc68a8e83fc7037b96a5efec2766ffdf453c5413
Florian [Sat, 21 May 2016 23:20:08 +0000 (01:20 +0200)]
LoginSignupSpecialPage: Load return and returnto params as early as possible
They're are needed for a redirect to the target page after
a successful login, which is made before the SpecialPage::execute()
function is called. Loading basic request varaibles in the execute()
function is therefore too late to take effect for the redirect after
a successul authentication with a primary provider, which needs to
redirect the user to another site.
Bug: T135924
Change-Id: I6ded7f9bb255cbb332a5810e7ed3cb3ecfdb2c04
jenkins-bot [Sat, 28 May 2016 15:54:42 +0000 (15:54 +0000)]
Merge "OOUI HTMLForm: Allow specifying whether buttons are framed"
jenkins-bot [Sat, 28 May 2016 15:39:38 +0000 (15:39 +0000)]
Merge "SpecialSearch: Remove obsolete styles"
jenkins-bot [Sat, 28 May 2016 15:39:33 +0000 (15:39 +0000)]
Merge "Separate Special:Search styling info into separate module"
Bartosz Dziewoński [Sat, 28 May 2016 15:17:25 +0000 (17:17 +0200)]
Clean up updatedmarker styling mess
This is the follow-up to
d629541076c29ce4a7ec50d69a5e5969b409f16d
that
b09bfb7bf6b811f9657a606d611a7f889a5e013e meant to be but failed.
It updates the right file this time, and removes the old override for
old skins.
Bug: T134515
Change-Id: I074688562e4da8c7c32d9f2bae67cd601e9b5f65
Ori Livneh [Sat, 28 May 2016 13:25:48 +0000 (06:25 -0700)]
Make number of PBKDF2 iterations used for deriving session secret configurable
The intent is both to allow the number of iterations to be dialed up (either as
computational power increases, or on the basis of security needs) and dialed
down for the unit tests, where hash_pbkdf2() calls account for 15-40% of wall
time. The number of iterations is stored in the session, so changing the number
of iterations does not cause existing sessions to become invalid or corrupt.
Sessions that do not have wsSessionPbkdf2Iterations set (i.e., sessions which
precede this change) are transparently upgraded.
Change-Id: I084a97487ef4147eea0f0ce0cdf4b39ca569ef52
Paladox [Sat, 28 May 2016 12:04:37 +0000 (13:04 +0100)]
Update mediawiki/mediawiki-codesniffer to 0.7.2
Change-Id: I9371faef4b8a0b9c80ec41d8ba08f4ff4936791e
Kunal Mehta [Sat, 28 May 2016 02:30:42 +0000 (19:30 -0700)]
Improve @covers tags for LinkerTest
These hooks are now called from LinkRenderer, so make sure it is
covering the right code.
Change-Id: Ifaa28d471f585dce9d968cc1173c7fdceb408239
Kunal Mehta [Sat, 28 May 2016 02:30:14 +0000 (19:30 -0700)]
WatchedItemStore: Use callable type hint instead of Assert library
And remove an unused use statement.
Change-Id: Idb74a564088744d73f71f5ef17e8f84f6e484c69
Derk-Jan Hartman [Fri, 27 May 2016 22:10:57 +0000 (00:10 +0200)]
SpecialSearch: Remove obsolete styles
Remove old Advanced PowerSearch table styles, which seem to not have
been in use for quite some time now.
Change-Id: I4c3013b035e146a8f8ad9622662491934c0c5389
Matthew Flaschen [Sat, 28 May 2016 00:04:01 +0000 (17:04 -0700)]
OOUI HTMLForm: Allow specifying whether buttons are framed
Bug: T136361
Change-Id: Ic31f857c749d62a32cafae68dc3f1cbd86e1e382
Kunal Mehta [Fri, 27 May 2016 23:12:46 +0000 (16:12 -0700)]
RollbackAction: Don't return true, causes '1' to be output
Bug: T136375
Change-Id: Id994b7ee7044ce18cf245a219ba290970511ea0f
Derk-Jan Hartman [Fri, 27 May 2016 21:44:25 +0000 (23:44 +0200)]
Separate Special:Search styling info into separate module
Almost all styling of this page has little to do with the JS module.
Separating it into a styles module.
Also made the selector for the JS elements far simpler, as there was
no reason for being overly specific here.
Bug: T136363
Change-Id: I96a35f930be26b26f139120f3e5b23c33a5d019e
Translation updater bot [Fri, 27 May 2016 19:58:00 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I47fe8c2cc2ff6457d934627dbe71842a34e4c48d
jenkins-bot [Fri, 27 May 2016 19:53:12 +0000 (19:53 +0000)]
Merge "Fix @covers tags for LinkRenderer tests"
jenkins-bot [Fri, 27 May 2016 19:52:32 +0000 (19:52 +0000)]
Merge "Avoid system styling issue of <textarea>s in Firefox+Linux"
jenkins-bot [Fri, 27 May 2016 19:43:07 +0000 (19:43 +0000)]
Merge "Revert "RollbackAction: Implement AJAX interface and require POST""
Kunal Mehta [Fri, 27 May 2016 18:53:04 +0000 (11:53 -0700)]
Fix @covers tags for LinkRenderer tests
phpunit's coverage report needs class names that include the namespace,
otherwise it'll just fail.
Bug: T136420
Change-Id: Ie748237176ea1363b35d73084e63e6fafe808286
Ed Sanders [Fri, 27 May 2016 15:16:48 +0000 (16:16 +0100)]
Avoid system styling issue of <textarea>s in Firefox+Linux
Bug: T136415
Change-Id: I5ebfeb65f4eb5607b161b4f95822e7dbfeea6d8b
jenkins-bot [Fri, 27 May 2016 16:19:59 +0000 (16:19 +0000)]
Merge "Fix ConfirmLinkSecondaryAuthenticationProvider error message name"
Krinkle [Fri, 27 May 2016 15:13:13 +0000 (15:13 +0000)]
Revert "RollbackAction: Implement AJAX interface and require POST"
This partially reverts commit
9af38c046c.
* The new JS modules continue to exist. While not used by default,
the mediawiki.api.rollback may be used elsewhere by now.
The mediawiki.page.rollback module may still be used on cached
pages and should continue to work.
* The new API behaviour remains.
* To avoid breaking mid-air rollbacks again, the token remains
the same (plain "rollback" salt). We're not re-introducing the
web-specific salt again.
Bug: T136375
Change-Id: Iba17ce55ff9506e838bfc6e70ca280e5a20b77b6
Gergő Tisza [Fri, 27 May 2016 15:00:26 +0000 (15:00 +0000)]
Fix ConfirmLinkSecondaryAuthenticationProvider error message name
Change-Id: I49f149004b3ad5c3eefbcbfcd0cfed64d9cbf522
Gergő Tisza [Wed, 25 May 2016 21:45:09 +0000 (21:45 +0000)]
Enable AuthManager by default
Second attempt, after fixing T135884.
(First attempt was I6695aa3da42fb2b088eaa8d1883ccbb67f2c0c38.)
Depends on:
https://gerrit.wikimedia.org/r/#/q/topic:authmanager-selenium,n,z
Bug: T135498
Change-Id: I756a82267cb9c44ec35146fbb4599b183747c741
jenkins-bot [Fri, 27 May 2016 12:43:09 +0000 (12:43 +0000)]
Merge "Special:UserLogin: Consolidate create account buttons"
Arlo Breault [Fri, 27 May 2016 02:48:01 +0000 (19:48 -0700)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
b0d48342e0c540c17b2c073833d4a7ab147e2852
Change-Id: I9eb00fdc854eac7ddfc37520bd6b3cf8913db523
jenkins-bot [Thu, 26 May 2016 23:46:29 +0000 (23:46 +0000)]
Merge "Use HTMLForm style sheets on mobile"
jenkins-bot [Thu, 26 May 2016 23:43:43 +0000 (23:43 +0000)]
Merge "Make the call match the function definition."
jenkins-bot [Thu, 26 May 2016 23:12:12 +0000 (23:12 +0000)]
Merge "Add LinksUpdate::getRevision()"
jenkins-bot [Thu, 26 May 2016 23:04:53 +0000 (23:04 +0000)]
Merge "Parser: Make makeKnownLinkHolder() protected, and remove $query handling"
Roan Kattouw [Mon, 23 May 2016 19:21:45 +0000 (12:21 -0700)]
Add LinksUpdate::getRevision()
Similar to getTriggeringUser(). Also propagate it
to subjobs similarly.
Bug: T135959
Change-Id: I3d894acaf3d85b790e5034c7d9f76bf94672f445
Kunal Mehta [Thu, 26 May 2016 22:00:49 +0000 (15:00 -0700)]
Parser: Make makeKnownLinkHolder() protected, and remove $query handling
Extensions shouldn't be calling this, just the Parser, so make it
protected. And since the only caller passes an empty array for $query,
we can just remove it entirely.
Change-Id: I3adbcaabbb40870eb3df1495c3c2743ff21f0c64
Kunal Mehta [Mon, 23 May 2016 05:55:38 +0000 (22:55 -0700)]
LinkBatch: Use TitleValue instead of Title
Replace the remaining instances of Title with TitleValue, and use
services from MediaWikiServices instead of calling deprecated singleton
functions.
Change-Id: I5d13939a76380fff6b787cea8d4a5f90c1a31a5d
Kunal Mehta [Fri, 13 May 2016 06:28:06 +0000 (23:28 -0700)]
Have Linker::getLinkColour() accept LinkTarget objects
Change-Id: I7d7318099a822f9ddd88c538274511e6d8a8f1bc
Kunal Mehta [Fri, 20 May 2016 02:01:48 +0000 (19:01 -0700)]
LinkCache: Don't try looking up NS_SPECIAL
Change-Id: I1afe8c780c3b12ae806ac19c4efb37c7033951ca
Kunal Mehta [Thu, 19 May 2016 22:09:19 +0000 (15:09 -0700)]
Add tests for Linker::getLinkColour()
Change-Id: Ic1553e21def47f5c4923ba747146b36b0b3ffdfc
Kunal Mehta [Fri, 13 May 2016 07:24:29 +0000 (00:24 -0700)]
ChangesList: Use LinkRenderer instead of Linker::link()
Change-Id: Iae32a9e365aad268d2671df6a0b916e4d9c0a801
jenkins-bot [Thu, 26 May 2016 21:31:40 +0000 (21:31 +0000)]
Merge "Parser: Replace Linker::link() with LinkRenderer"
jenkins-bot [Thu, 26 May 2016 21:26:30 +0000 (21:26 +0000)]
Merge "Send edit stash metrics for cache attempts"
jenkins-bot [Thu, 26 May 2016 21:22:00 +0000 (21:22 +0000)]
Merge "LinkRenderer: Re-implement noclasses as makePreloadedLink function"
Kunal Mehta [Fri, 13 May 2016 00:37:17 +0000 (17:37 -0700)]
Parser: Replace Linker::link() with LinkRenderer
Replaces usage of Linker::link() in Parser and LinkHolderArray with the
new LinkRenderer.
Change-Id: Icb796ef08d70926728732ab5468940c09ba5eaf8
Aaron Schulz [Thu, 26 May 2016 19:46:32 +0000 (12:46 -0700)]
Send edit stash metrics for cache attempts
Change-Id: I22d5626cca55c2cc35e1b33fced5902e8d364d40
jenkins-bot [Thu, 26 May 2016 21:01:39 +0000 (21:01 +0000)]
Merge "TitleParser: In formatTitle(), don't throw exceptions on bad namespaces"
Ori Livneh [Wed, 18 May 2016 09:19:20 +0000 (02:19 -0700)]
Whenever possible, reuse User objects in unit tests
The unit tests spend nearly half of their run time resetting the user table for
each test. But the majority of tests do not depend on the user table having the
exact value that the setup code resets it to, and do not need to modify the
user objects they require to run.
Fix that by providing an API for tests to get User objects, and to indicate
whether the User object will be subject to destructive modification or not.
This allows User objects to be reused across multiple unit tests.
Change-Id: I17ef1f519759c5e7796c259282afe730ef722e96
Kunal Mehta [Thu, 26 May 2016 20:29:02 +0000 (13:29 -0700)]
TitleParser: In formatTitle(), don't throw exceptions on bad namespaces
This ocassionally happens for whatever reason, but it doesn't really
make sense to throw an exception when creating a broken-looking link
would also work. We already do this for TitleParser::getPrefixedDBkey(),
and this also matches the behavior of Title::getNsText().
Bug: T136352
Bug: T136356
Change-Id: Ic7eb17f8917f7fbb28b11d94b742dac1fe5582a1
jenkins-bot [Thu, 26 May 2016 20:11:45 +0000 (20:11 +0000)]
Merge "Revert "build: Bump grunt-karma and related tools to 1.0.x""
jenkins-bot [Thu, 26 May 2016 20:11:01 +0000 (20:11 +0000)]
Merge "Bail out in ApiStashEdit for bots for sanity"
Translation updater bot [Thu, 26 May 2016 19:59:57 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I04fc4e9de4d4d0f4c8a13d559d6eafa91f1d70ac
Aaron Schulz [Thu, 26 May 2016 19:04:22 +0000 (12:04 -0700)]
Bail out in ApiStashEdit for bots for sanity
checkCache() is disabled in this case anyway.
Change-Id: I1c18585eecc1a7c4c0e24546799c7ee448b3ea57
Hashar [Thu, 26 May 2016 19:55:36 +0000 (19:55 +0000)]
Revert "build: Bump grunt-karma and related tools to 1.0.x"
Karma is suspected to have an issue disconnecting Chromium.
That causes the qunit job to idle even after all tests have
been completed.
This reverts commit
72b0d9da08d6ea8c1842d76aaefe8e57046a2026.
Bug: T136188
Change-Id: Id818f5a0d1983d0bffa545f7731a780bf2b9bf25
jenkins-bot [Thu, 26 May 2016 19:13:47 +0000 (19:13 +0000)]
Merge "Document thumbinner's block formatting context"
jenkins-bot [Thu, 26 May 2016 19:05:48 +0000 (19:05 +0000)]
Merge "mediawiki.special: Remove unused mediawiki.special.js"
Derk-Jan Hartman [Wed, 25 May 2016 21:27:00 +0000 (23:27 +0200)]
Document thumbinner's block formatting context
Document the side effect of setting overflow:hidden on thumbinner.
It's primary utility here is to clear the background of the block from
any floating content, avoiding potential overlap.
The property sets a new block formatting context.
Change-Id: I91b759cdd386cb648b1b704b0e7df708f6c4fa92
Aaron Schulz [Thu, 26 May 2016 18:36:40 +0000 (11:36 -0700)]
Exclude bots from edit stash stats
Change-Id: Id309879eaaf039de7ac5f531930fa8e758a959c7