Set $wgShowExceptionDetails and/or $wgShowHostnames instead.
* The $wgShowDBErrorBacktrace global is deprecated and nonfunctional.
Set $wgShowExceptionDetails instead.
+* Public access to the DifferenceEngine properties mOldid, mNewid, mOldPage,
+ mNewPage, mOldContent, mNewContent, mRevisionsLoaded, mTextLoaded and
+ mCacheHit is deprecated. Use getOldid() / getNewid() for the first two,
+ do your own lookup for page/content. mNewRev / mOldRev remains public.
=== Other changes in 1.32 ===
* (T198811) The following tables have had their UNIQUE indexes turned into
* @ingroup DifferenceEngine
*/
class DifferenceEngine extends ContextSource {
+
+ use DeprecationHelper;
+
/**
* Constant to indicate diff cache compatibility.
* Bump this when changing the diff formatting in a way that
const DIFF_VERSION = '1.12';
/** @var int Revision ID or 0 for current */
- public $mOldid;
+ protected $mOldid;
/** @var int|string Revision ID or null for current or an alias such as 'next' */
- public $mNewid;
+ protected $mNewid;
private $mOldTags;
private $mNewTags;
/** @var Content|null */
- public $mOldContent;
+ protected $mOldContent;
/** @var Content|null */
- public $mNewContent;
+ protected $mNewContent;
/** @var Language */
protected $mDiffLang;
/** @var Title */
- public $mOldPage;
+ protected $mOldPage;
/** @var Title */
- public $mNewPage;
+ protected $mNewPage;
/** @var Revision|null */
public $mOldRev;
private $mRevisionsIdsLoaded = false;
/** @var bool Have the revisions been loaded */
- public $mRevisionsLoaded = false;
+ protected $mRevisionsLoaded = false;
/** @var int How many text blobs have been loaded, 0, 1 or 2? */
- public $mTextLoaded = 0;
+ protected $mTextLoaded = 0;
/**
* Was the content overridden via setContent()?
protected $isContentOverridden = false;
/** @var bool Was the diff fetched from cache? */
- public $mCacheHit = false;
+ protected $mCacheHit = false;
/**
* Set this to true to add debug info to the HTML output.
public function __construct( $context = null, $old = 0, $new = 0, $rcid = 0,
$refreshCache = false, $unhide = false
) {
+ $this->deprecatePublicProperty( 'mOldid', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mNewid', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mOldPage', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mNewPage', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mOldContent', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mNewContent', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mRevisionsLoaded', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mTextLoaded', '1.32', __CLASS__ );
+ $this->deprecatePublicProperty( 'mCacheHit', '1.32', __CLASS__ );
+
if ( $context instanceof IContextSource ) {
$this->setContext( $context );
}