From e5b061d6b66ff8d2820abade8c85090ed848491b Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 20 Sep 2016 11:06:59 -0700 Subject: [PATCH] Add debugging logging to LoadBalancer connection closes This matches the logging used for opening new connections and can be useful for seeing connection leakage. Change-Id: I8d24d059062f3b698e64751b46542eb1fa78bb36 --- includes/libs/rdbms/loadbalancer/LoadBalancer.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index c07d38fdbf..791e5ad5ff 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -937,6 +937,8 @@ class LoadBalancer implements ILoadBalancer { public function closeAll() { $this->forEachOpenConnection( function ( IDatabase $conn ) { + $host = $conn->getServer(); + $this->connLogger->debug( "Closing connection to database '$host'." ); $conn->close(); } ); @@ -957,6 +959,8 @@ class LoadBalancer implements ILoadBalancer { foreach ( $connsByServer[$serverIndex] as $i => $trackedConn ) { if ( $conn === $trackedConn ) { + $host = $this->getServerName( $i ); + $this->connLogger->debug( "Closing connection to database $i at '$host'." ); unset( $this->mConns[$type][$serverIndex][$i] ); --$this->connsOpened; break 2; -- 2.20.1