From 603180de45378780a9433f828d1f114ffc09d5dd Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 18 Oct 2013 22:34:31 +0200 Subject: [PATCH] BaseTemplate: Exclude two more attributes in makeLink() 'context' and 'primary' are used internally by some SkinTemplate functions and Vector. They should not be passed on to HTML. Bug: 55659 Bug: 55660 Change-Id: I1f7a656aacc93f9bf289c481f258824ae28ccf4e --- includes/SkinTemplate.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php index 44cafe9ebf..e5b8872c8a 100644 --- a/includes/SkinTemplate.php +++ b/includes/SkinTemplate.php @@ -1717,6 +1717,10 @@ abstract class BaseTemplate extends QuickTemplate { * on the link) is present it will be used to generate a tooltip and * accesskey for the link. * + * The keys "context" and "primary" are ignored; these keys are used + * internally by skins and are not supposed to be included in the HTML + * output. + * * If you don't want an accesskey, set $item['tooltiponly'] = true; * * @param array $options can be used to affect the output of a link. @@ -1757,7 +1761,7 @@ abstract class BaseTemplate extends QuickTemplate { if ( isset( $item['href'] ) || isset( $options['link-fallback'] ) ) { $attrs = $item; - foreach ( array( 'single-id', 'text', 'msg', 'tooltiponly' ) as $k ) { + foreach ( array( 'single-id', 'text', 'msg', 'tooltiponly', 'context', 'primary' ) as $k ) { unset( $attrs[$k] ); } -- 2.20.1