From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sun, 4 Oct 2015 20:22:01 +0000 (-0700)
Subject: Remove return value from FormSpecialPage::checkExecutePermissions
X-Git-Tag: 1.31.0-rc.0~9541^2
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dcompta/operations/modifier.php?a=commitdiff_plain;h=19160cbca00a246d2eda50f55a8c8e561a14554b;p=lhc%2Fweb%2Fwiklou.git

Remove return value from FormSpecialPage::checkExecutePermissions

It is unused and few callers comply with it

Change-Id: I3ac02ca996b57bf2222006712cc988a064dc38e5
---

diff --git a/includes/specialpage/FormSpecialPage.php b/includes/specialpage/FormSpecialPage.php
index 42c59806b4..d22875b9bd 100644
--- a/includes/specialpage/FormSpecialPage.php
+++ b/includes/specialpage/FormSpecialPage.php
@@ -169,7 +169,6 @@ abstract class FormSpecialPage extends SpecialPage {
 	 * Failures here must throw subclasses of ErrorPageError.
 	 * @param User $user
 	 * @throws UserBlockedError
-	 * @return bool True
 	 */
 	protected function checkExecutePermissions( User $user ) {
 		$this->checkPermissions();
@@ -182,8 +181,6 @@ abstract class FormSpecialPage extends SpecialPage {
 		if ( $this->requiresWrite() ) {
 			$this->checkReadOnly();
 		}
-
-		return true;
 	}
 
 	/**
diff --git a/includes/specials/SpecialPasswordReset.php b/includes/specials/SpecialPasswordReset.php
index 9e72807f0b..f1eb8c2325 100644
--- a/includes/specials/SpecialPasswordReset.php
+++ b/includes/specials/SpecialPasswordReset.php
@@ -58,7 +58,7 @@ class SpecialPasswordReset extends FormSpecialPage {
 			throw new ErrorPageError( 'internalerror', 'resetpass_forbidden' );
 		}
 
-		return parent::checkExecutePermissions( $user );
+		parent::checkExecutePermissions( $user );
 	}
 
 	protected function getFormFields() {