From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 31 Oct 2012 03:14:59 +0000 (-0700)
Subject: [JobQueue] Make sure broken/duplicate job removal counts in stats.
X-Git-Tag: 1.31.0-rc.0~21784
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dcompta/operations/modifier.php?a=commitdiff_plain;h=0b8546ae58a163a5923110ecb9b154cb514a6bc7;p=lhc%2Fweb%2Fwiklou.git

[JobQueue] Make sure broken/duplicate job removal counts in stats.

Change-Id: I09b3faa770172ce7aae457ef0af3dd5bafe7319d
---

diff --git a/includes/job/JobQueueDB.php b/includes/job/JobQueueDB.php
index d7d2b1974d..b850610e05 100644
--- a/includes/job/JobQueueDB.php
+++ b/includes/job/JobQueueDB.php
@@ -144,6 +144,7 @@ class JobQueueDB extends JobQueue {
 				$title = Title::makeTitleSafe( $row->job_namespace, $row->job_title );
 				if ( !$title ) {
 					$dbw->delete( 'job', array( 'job_id' => $row->job_id ), __METHOD__ );
+					wfIncrStats( 'job-pop' );
 					wfDebugLog( 'JobQueueDB', "Row has invalid title '{$row->job_title}'." );
 					continue; // try again
 				}
@@ -156,6 +157,7 @@ class JobQueueDB extends JobQueue {
 							"job_id != {$dbw->addQuotes( $row->job_id )}" ),
 						__METHOD__
 					);
+					wfIncrStats( 'job-pop', $dbw->affectedRows() );
 				}
 				break; // done
 			} while( true );