dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 756d125) | patch
WebRequest::getIP() cleanups.
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 30 May 2013 17:30:55 +0000 (10:30 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 30 May 2013 18:24:43 +0000 (18:24 +0000)
commit8bd6922ab0b1f9a317dc1912d97257112bc90ece
tree4933bf31707cd5c6795406b52adcb9f8fade4eb9tree | snapshot
parent756d125b1e6ed9d8a14ccec98c3001d4ce3ec648commit | diff
WebRequest::getIP() cleanups.

* Always treat the first XFF IP from cache proxies as sane
  even if it is a private IP (useful for things like labs wmf).
* Make sure IP::canonicalize() gets called if the IP is selected
  from the XFF chain (this matches getRawIP()).
* Altered and expanded unit tests.

bug: 48919
Change-Id: I350aca72c7a96ba3ec727324800612fc84e0e7a4
includes/WebRequest.php diff | blob | history
tests/phpunit/includes/WebRequestTest.php diff | blob | history
Wiklou, le Wiki du Wiklou