From d3b19b3a7bd187114589a6c32fc138bf57f87d8d Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Fri, 27 Dec 2013 01:45:19 +0100 Subject: [PATCH] Declare visibility for class properties in DatabaseMssql Change-Id: Icf0209a1f1f601a50dbc1e8cf59ca0b8afabd40f --- includes/db/DatabaseMssql.php | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php index 5a5eab14e9..96b4c1559a 100644 --- a/includes/db/DatabaseMssql.php +++ b/includes/db/DatabaseMssql.php @@ -28,11 +28,20 @@ * @ingroup Database */ class DatabaseMssql extends DatabaseBase { - var $mInsertId = null; - var $mLastResult = null; - var $mAffectedRows = null; + /** @var resource */ + protected $mLastResult = null; - var $mPort; + /** @var int The number of rows affected as an integer */ + protected $mAffectedRows = null; + + /** + * @var int Post number for database + * @todo Unused and can be removed? + */ + protected $mPort; + + /** @var int */ + private $mInsertId = null; function cascadingDeletes() { return true; @@ -271,7 +280,7 @@ class DatabaseMssql extends DatabaseBase { /** * This must be called after nextSequenceVal - * @return null + * @return int|null */ function insertId() { return $this->mInsertId; -- 2.20.1