From d385d18d20677a98c467d89ce6db921176e1d9b6 Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Mon, 6 Mar 2017 17:09:18 -0800 Subject: [PATCH] RCFilters UI: Add tooltip to highlight menu Bug: T159587 Change-Id: Iae5e050fd721d8c51d0b6c150d039c7f2ed6647d --- languages/i18n/en.json | 1 + languages/i18n/qqq.json | 1 + resources/Resources.php | 1 + .../mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemWidget.js | 3 ++- 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/languages/i18n/en.json b/languages/i18n/en.json index 098adb62f4..b7078dd82e 100644 --- a/languages/i18n/en.json +++ b/languages/i18n/en.json @@ -1381,6 +1381,7 @@ "rcfilters-filterlist-feedbacklink": "Provide feedback on the new (beta) filters", "rcfilters-highlightbutton-title": "Highlight results", "rcfilters-highlightmenu-title": "Select a color", + "rcfilters-highlightmenu-help": "Select a color to highlight this property", "rcfilters-filterlist-noresults": "No filters found", "rcfilters-filtergroup-registration": "User registration", "rcfilters-filter-registered-label": "Registered", diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json index 026157e4c8..a3e2a8cee1 100644 --- a/languages/i18n/qqq.json +++ b/languages/i18n/qqq.json @@ -1568,6 +1568,7 @@ "rcfilters-filterlist-feedbacklink": "Caption for the link to the feedback page about the filters beta feature.", "rcfilters-highlightbutton-title": "Title for the highlight button used to toggle the highlight feature on and off.", "rcfilters-highlightmenu-title": "Title for the highlight menu used to select the highlight color for an individual filter.", + "rcfilters-highlightmenu-help": "Tooltip for the highlight menu for individual filters.", "rcfilters-filterlist-noresults": "Message showing no results found for searching a filter.", "rcfilters-filtergroup-registration": "Title for the filter group for editor registration type.", "rcfilters-filter-registered-label": "Label for the filter for showing edits made by logged-in users.\n{{Identical|Registered}}", diff --git a/resources/Resources.php b/resources/Resources.php index 67a3de5ae4..13c7cd11d3 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -1846,6 +1846,7 @@ return [ 'rcfilters-filter-logactions-description', 'rcfilters-highlightbutton-title', 'rcfilters-highlightmenu-title', + 'rcfilters-highlightmenu-help', 'recentchanges-noresult', ], 'dependencies' => [ diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemWidget.js index 81b856d961..4ea284b232 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemWidget.js @@ -45,7 +45,8 @@ this.controller, this.model, { - $overlay: config.$overlay || this.$element + $overlay: config.$overlay || this.$element, + title: mw.msg( 'rcfilters-highlightmenu-help' ) } ); this.highlightButton.toggle( this.model.isHighlightEnabled() ); -- 2.20.1