From cff78fbda1e167043323c9baf0184fcf3e3cf937 Mon Sep 17 00:00:00 2001 From: Andrew Garrett Date: Sat, 31 Jan 2009 11:43:42 +0000 Subject: [PATCH] Fix r46628 -- I'd misunderstood the nature of the hack. People wanted to append the string to be truncated to an empty string, not the reverse. --- includes/parser/CoreParserFunctions.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/parser/CoreParserFunctions.php b/includes/parser/CoreParserFunctions.php index 1045fad2a0..fba3d5faf0 100644 --- a/includes/parser/CoreParserFunctions.php +++ b/includes/parser/CoreParserFunctions.php @@ -381,7 +381,11 @@ class CoreParserFunctions { static function pad( $string, $length, $padding = '0', $direction = STR_PAD_RIGHT ) { $lengthOfPadding = mb_strlen( $padding ); if ( $lengthOfPadding == 0 ) return $string; - if ( $length < mb_strlen( $string ) ) return $string; + + // Thwart attempts to use this function to truncate strings. + // We don't want people implementing ParserFunctions in template, + // for performance and usability reasons. + if ($lengthOfPadding > $length && $string == '') return $string; # The remaining length to add counts down to 0 as padding is added $length = min( $length, 500 ) - mb_strlen( $string ); -- 2.20.1