From b4fdf95c9190906165a1bc8b0c15f692df16d9f5 Mon Sep 17 00:00:00 2001
From: Happy-melon <happy-melon@users.mediawiki.org>
Date: Thu, 23 Dec 2010 15:03:24 +0000
Subject: [PATCH] Follow-up r78865 CR; restore arrow helper functions, fixing
 fatal on TWN.

---
 includes/ChangesList.php | 34 +++++++++++++++++++++++++++++++---
 1 file changed, 31 insertions(+), 3 deletions(-)

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 4597529fdb..bad178107d 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -811,9 +811,9 @@ class EnhancedChangesList extends ChangesList {
 
 		$tl = "<span class='collapsible-expander'>"
 			. "<span class='mw-rc-openarrow'>"
-			. "<a href='#' title='$expandTitle'>{$this->arrow( 'd', '-', wfMsg( 'rc-enhanced-hide' ) )}</a>"
+			. "<a href='#' title='$expandTitle'>{$this->sideArrow()}</a>"
 			. "</span><span class='mw-rc-closearrow'>"
-			. "<a href='#' title='$closeTitle'>{$this->arrow( 'd', '-', wfMsg( 'rc-enhanced-hide' ) )}</a>"
+			. "<a href='#' title='$closeTitle'>{$this->downArrow()}</a>"
 			. "</span></span>";
 		$r .= "<td>$tl</td>";
 
@@ -1013,6 +1013,34 @@ class EnhancedChangesList extends ChangesList {
 		return "<img src=\"$encUrl\" width=\"12\" height=\"12\" alt=\"$encAlt\" title=\"$encTitle\" />";
 	}
 
+	/**
+	 * Generate HTML for a right- or left-facing arrow,
+	 * depending on language direction.
+	 * @return String: HTML <img> tag
+	 */
+	protected function sideArrow() {
+		global $wgContLang;
+		$dir = $wgContLang->isRTL() ? 'l' : 'r';
+		return $this->arrow( $dir, '+', wfMsg( 'rc-enhanced-expand' ) );
+	}
+
+	/**
+	 * Generate HTML for a down-facing arrow
+	 * depending on language direction.
+	 * @return String: HTML <img> tag
+	 */
+	protected function downArrow() {
+		return $this->arrow( 'd', '-', wfMsg( 'rc-enhanced-hide' ) );
+	}
+
+	/**
+	 * Generate HTML for a spacer image
+	 * @return String: HTML <img> tag
+	 */
+	protected function spacerArrow() {
+		return $this->arrow( '', codepointToUtf8( 0xa0 ) ); // non-breaking space
+	}
+
 	/**
 	 * Enhanced RC ungrouped line.
 	 * @return String: a HTML formated line (generated using $r)
@@ -1038,7 +1066,7 @@ class EnhancedChangesList extends ChangesList {
 		$r = Html::openElement( 'table', array( 'class' => $classes ) ) .
 			Html::openElement( 'tr' );
 
-		$r .= '<td class="mw-enhanced-rc">' . $this->arrow( '', codepointToUtf8( 0xa0 ) );
+		$r .= '<td class="mw-enhanced-rc">' . $this->spacerArrow();
 		# Flag and Timestamp
 		if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
 			$r .= '&#160;&#160;&#160;&#160;'; // 4 flags -> 4 spaces
-- 
2.20.1