From 9e3e9e28d4f9d77e50e92f6feb834c50caa7dd41 Mon Sep 17 00:00:00 2001
From: Timo Tijhof <krinklemail@gmail.com>
Date: Mon, 22 Sep 2014 17:35:33 -0700
Subject: [PATCH] PrefixSearch: Add unit tests for StringPrefixSearch

Change-Id: If0fa66b212f70ea39d2e7feec117930fcd1b9642
---
 includes/PrefixSearch.php                   |   3 +-
 tests/phpunit/includes/PrefixSearchTest.php | 134 ++++++++++++++++++++
 2 files changed, 135 insertions(+), 2 deletions(-)
 create mode 100644 tests/phpunit/includes/PrefixSearchTest.php

diff --git a/includes/PrefixSearch.php b/includes/PrefixSearch.php
index 718750f58c..9511579ef0 100644
--- a/includes/PrefixSearch.php
+++ b/includes/PrefixSearch.php
@@ -63,8 +63,7 @@ abstract class PrefixSearch {
 			if ( $ns[0] == NS_MAIN ) {
 				$ns = $namespaces; // no explicit prefix, use default namespaces
 			}
-			return $this->searchBackend(
-				$ns, $title->getText(), $limit );
+			return $this->searchBackend( $ns, $title->getText(), $limit );
 		}
 
 		// Is this a namespace prefix?
diff --git a/tests/phpunit/includes/PrefixSearchTest.php b/tests/phpunit/includes/PrefixSearchTest.php
new file mode 100644
index 0000000000..63dcc3f79b
--- /dev/null
+++ b/tests/phpunit/includes/PrefixSearchTest.php
@@ -0,0 +1,134 @@
+<?php
+/**
+ * @group Search
+ * @group Database
+ */
+class PrefixSearchTest extends MediaWikiTestCase {
+
+	protected function setUp() {
+		parent::setUp();
+
+		// Avoid special pages from extensions interferring with the tests
+		$this->setMwGlobals( 'wgSpecialPages', array() );
+	}
+
+	protected function searchProvision( Array $results = null ) {
+		if ( $results === null ) {
+			$this->setMwGlobals( 'wgHooks', array() );
+		} else {
+			$this->setMwGlobals( 'wgHooks', array(
+				'PrefixSearchBackend' => array(
+					function ( $namespaces, $search, $limit, &$srchres ) use ( $results ) {
+						$srchres = $results;
+						return false;
+					}
+				),
+			) );
+		}
+	}
+
+	public function addDBData() {
+		$this->insertPage( 'Sandbox' );
+
+		$this->insertPage( 'Example' );
+		$this->insertPage( 'Example Bar' );
+		$this->insertPage( 'Example Foo' );
+		$this->insertPage( 'Example Foo/Bar' );
+		$this->insertPage( 'Example/Baz' );
+
+		$this->insertPage( 'Talk:Sandbox' );
+		$this->insertPage( 'Talk:Example' );
+
+		$this->insertPage( 'User:Example' );
+	}
+
+	public static function provideSearch() {
+		return array(
+			array( array(
+				'Empty string',
+				'query' => '',
+				'results' => array(),
+			) ),
+			array( array(
+				'Main namespace with title prefix',
+				'query' => 'Ex',
+				'results' => array(
+					'Example',
+					'Example/Baz',
+					'Example Bar',
+				),
+			) ),
+			array( array(
+				'Talk namespace prefix',
+				'query' => 'Talk:',
+				'results' => array(
+					'Talk:Example',
+					'Talk:Sandbox',
+				),
+			) ),
+			array( array(
+				'User namespace prefix',
+				'query' => 'User:',
+				'results' => array(
+					'User:Example',
+				),
+			) ),
+			array( array(
+				'Special namespace prefix',
+				'query' => 'Special:',
+				'results' => array(
+					'Special:ActiveUsers',
+					'Special:AllMessages',
+					'Special:AllMyFiles',
+				),
+			) ),
+			array( array(
+				'Special namespace with prefix',
+				'query' => 'Special:Un',
+				'results' => array(
+					'Special:Unblock',
+					'Special:UncategorizedCategories',
+					'Special:UncategorizedFiles',
+				),
+			) ),
+			array( array(
+				'Special page name',
+				'query' => 'Special:EditWatchlist',
+				'results' => array(
+					'Special:EditWatchlist',
+				),
+			) ),
+			array( array(
+				'Special page subpages',
+				'query' => 'Special:EditWatchlist/',
+				'results' => array(
+					'Special:EditWatchlist/clear',
+					'Special:EditWatchlist/raw',
+				),
+			) ),
+			array( array(
+				'Special page subpages with prefix',
+				'query' => 'Special:EditWatchlist/cl',
+				'results' => array(
+					'Special:EditWatchlist/clear',
+				),
+			) ),
+		);
+	}
+
+	/**
+	 * @dataProvider provideSearch
+	 * @covers PrefixSearch::search
+	 * @covers PrefixSearch::searchBackend
+	 */
+	public function testSearch( Array $case ) {
+		$this->searchProvision( null );
+		$searcher = new StringPrefixSearch;
+		$results = $searcher->search( $case['query'], 3 );
+		$this->assertEquals(
+			$case['results'],
+			$results,
+			$case[0]
+		);
+	}
+}
-- 
2.20.1