From 6ca0ea07a2261c8e1e423e5f05df55a0d76126b7 Mon Sep 17 00:00:00 2001 From: Brian Wolff Date: Thu, 20 Jan 2011 01:49:49 +0000 Subject: [PATCH] (bug 26716, well partially anyways. kind of second half of r80608) Add a comment to external editor ini control file explaining what it is. This will give people who accidently select the preference a fighting chance to debug what is going on. Of course, since it has a mime type of application/x-external-edit (or something like that), and the download would have a .php extension, the chance they will open it in a text editor is pretty slim... See bug 2760 for proposal to just kill the preference altogether. --- RELEASE-NOTES | 3 ++- includes/ExternalEdit.php | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 5cba9de762..59f15478e6 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -99,7 +99,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN adding overflow:hidden to h1,h2,h3,h4,h5,h6 (also fixes editsection bunching). * (bug 26708) Remove background-color:white from tables in Monobook and Vector. * (bug 26781) {{PAGENAME}} and related parser functions escape their output better. -* (bug 26716) Provide link to instructions for external editor related preferences. +* (bug 26716) Provide link to instructions for external editor related preferences + and add a comment to the ini control file explaining what is going on. === API changes in 1.18 === * (bug 26339) Throw warning when truncating an overlarge API result diff --git a/includes/ExternalEdit.php b/includes/ExternalEdit.php index cfdd55969f..7109c1ac93 100644 --- a/includes/ExternalEdit.php +++ b/includes/ExternalEdit.php @@ -53,6 +53,11 @@ class ExternalEdit { } $special=$wgLang->getNsText(NS_SPECIAL); $control = <<