From 60a92d256a388801645c36860eaa18ea42eed1f4 Mon Sep 17 00:00:00 2001
From: Kunal Mehta <legoktm@gmail.com>
Date: Wed, 28 Jan 2015 20:49:57 -0800
Subject: [PATCH] replacers: Make Replacer abstract, and add abstract
 Replacer::replace()

Change-Id: Ib00dc8585e8ba599491e51e0b99a8667c3b4cd63
---
 includes/libs/replacers/DoubleReplacer.php    | 2 +-
 includes/libs/replacers/HashtableReplacer.php | 2 +-
 includes/libs/replacers/RegexlikeReplacer.php | 2 +-
 includes/libs/replacers/Replacer.php          | 8 +++++++-
 4 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/includes/libs/replacers/DoubleReplacer.php b/includes/libs/replacers/DoubleReplacer.php
index 20a4089a6c..fed023b1ba 100644
--- a/includes/libs/replacers/DoubleReplacer.php
+++ b/includes/libs/replacers/DoubleReplacer.php
@@ -37,7 +37,7 @@ class DoubleReplacer extends Replacer {
 	 * @param array $matches
 	 * @return mixed
 	 */
-	public function replace( $matches ) {
+	public function replace( array $matches ) {
 		return str_replace( $this->from, $this->to, $matches[$this->index] );
 	}
 }
diff --git a/includes/libs/replacers/HashtableReplacer.php b/includes/libs/replacers/HashtableReplacer.php
index e1572f2b57..b3c219d40a 100644
--- a/includes/libs/replacers/HashtableReplacer.php
+++ b/includes/libs/replacers/HashtableReplacer.php
@@ -37,7 +37,7 @@ class HashtableReplacer extends Replacer {
 	 * @param array $matches
 	 * @return mixed
 	 */
-	public function replace( $matches ) {
+	public function replace( array $matches ) {
 		return $this->table[$matches[$this->index]];
 	}
 }
diff --git a/includes/libs/replacers/RegexlikeReplacer.php b/includes/libs/replacers/RegexlikeReplacer.php
index 630a754762..2b1fa74023 100644
--- a/includes/libs/replacers/RegexlikeReplacer.php
+++ b/includes/libs/replacers/RegexlikeReplacer.php
@@ -35,7 +35,7 @@ class RegexlikeReplacer extends Replacer {
 	 * @param array $matches
 	 * @return string
 	 */
-	public function replace( $matches ) {
+	public function replace( array $matches ) {
 		$pairs = array();
 		foreach ( $matches as $i => $match ) {
 			$pairs["\$$i"] = $match;
diff --git a/includes/libs/replacers/Replacer.php b/includes/libs/replacers/Replacer.php
index 924fb30775..f4850bf6ad 100644
--- a/includes/libs/replacers/Replacer.php
+++ b/includes/libs/replacers/Replacer.php
@@ -22,11 +22,17 @@
  * Base class for "replacers", objects used in preg_replace_callback() and
  * StringUtils::delimiterReplaceCallback()
  */
-class Replacer {
+abstract class Replacer {
 	/**
 	 * @return array
 	 */
 	public function cb() {
 		return array( &$this, 'replace' );
 	}
+
+	/**
+	 * @param array $matches
+	 * @return string
+	 */
+	abstract public function replace( array $matches );
 }
-- 
2.20.1