lhc/web/wiklou.git
15 years agoSet replace flag for headers
Aaron Schulz [Wed, 27 Aug 2008 20:44:43 +0000 (20:44 +0000)]
Set replace flag for headers

15 years agoMake Special:Allpages/User:Foo actually work. Patch by Mormegil
Roan Kattouw [Wed, 27 Aug 2008 20:28:12 +0000 (20:28 +0000)]
Make Special:Allpages/User:Foo actually work. Patch by Mormegil

15 years agoAdd an own message for the fieldset legend instead of duplicating the special page...
Raimond Spekking [Wed, 27 Aug 2008 19:49:09 +0000 (19:49 +0000)]
Add an own message for the fieldset legend instead of duplicating the special page name

15 years agoLocalisation updates: Using a better Persian translation for "hide"
Huji [Wed, 27 Aug 2008 19:33:53 +0000 (19:33 +0000)]
Localisation updates: Using a better Persian translation for "hide"

15 years agoFixup the function declarations that we're overridden from UploadFromBase.
Bryan Tong Minh [Wed, 27 Aug 2008 19:10:57 +0000 (19:10 +0000)]
Fixup the function declarations that we're overridden from UploadFromBase.

15 years agoLets render BMP pictures to PNG.
Antoine Musso [Wed, 27 Aug 2008 18:25:24 +0000 (18:25 +0000)]
Lets render BMP pictures to PNG.

15 years agoMove the timestamp into the message of the current revision link to make the link...
Raimond Spekking [Wed, 27 Aug 2008 18:23:03 +0000 (18:23 +0000)]
Move the timestamp into the message of the current revision link to make the link consistent with the link to the previous version on the left side

15 years ago* Remove a debug statement
Bryan Tong Minh [Wed, 27 Aug 2008 18:09:18 +0000 (18:09 +0000)]
* Remove a debug statement
* Return a status on unsaveTempFile

15 years agoSplitting backend upload code from SpecialUpload.
Bryan Tong Minh [Wed, 27 Aug 2008 17:38:33 +0000 (17:38 +0000)]
Splitting backend upload code from SpecialUpload.
* All common upload code resides in UploadFromBase. Then depending on the upload source, one of its derived classes is initiated by Special:Upload.
* SpecialUpload::ajaxGetExistsWarning now only returns warnings that are related to existence.
* Allow LocalFile::upload to attribute the upload to another user than $wgUser

This introduces breaking changes for upload extensions.

15 years agoAPI:
Roan Kattouw [Wed, 27 Aug 2008 16:48:30 +0000 (16:48 +0000)]
API:
* Add titlePartToKey() and keyPartToTitle() which use the substr() hack to preserve trailing spaces
* Migrate function calls where needed. ??continue parameters still use titleToKey() because they're generated using keyToTitle() and therefore can't contain trailing spaces

15 years agoFix fatal error caused by missing comma
Roan Kattouw [Wed, 27 Aug 2008 16:40:29 +0000 (16:40 +0000)]
Fix fatal error caused by missing comma

15 years agoReverting my reversions of the fieldset on Special:Watchlist. I liked it, and apparen...
Chad Horohoe [Wed, 27 Aug 2008 15:22:50 +0000 (15:22 +0000)]
Reverting my reversions of the fieldset on Special:Watchlist. I liked it, and apparently some other people did too (although some don't). Plus, it's been pointed out that semantically, a fieldset belongs around fields. Who knew? Could use some CSS tweaks maybe.

15 years agoCan't add to a variable if it doesn't exist...
Chad Horohoe [Wed, 27 Aug 2008 15:07:30 +0000 (15:07 +0000)]
Can't add to a variable if it doesn't exist...

15 years agoFix a minor regression pointed out by aaron.
Daniel Friesen [Wed, 27 Aug 2008 14:47:41 +0000 (14:47 +0000)]
Fix a minor regression pointed out by aaron.
The spacer for between the preview area and the edit toolbar was being outputted even when not previewing.

15 years agoRemove messages and rebuild all messages files per r40076.
Siebrand Mazeland [Wed, 27 Aug 2008 14:33:05 +0000 (14:33 +0000)]
Remove messages and rebuild all messages files per r40076.

15 years agoRemove fieldset from Watchlist that apparently only I liked :)
Chad Horohoe [Wed, 27 Aug 2008 14:32:15 +0000 (14:32 +0000)]
Remove fieldset from Watchlist that apparently only I liked :)

15 years agoCheck on $wgEnableEmail && $wgEnableUserEmail
Bryan Tong Minh [Wed, 27 Aug 2008 13:40:11 +0000 (13:40 +0000)]
Check on $wgEnableEmail && $wgEnableUserEmail

15 years ago* Fixup validation methods in UserEmailForm a bit so that they don't return arrays...
Bryan Tong Minh [Wed, 27 Aug 2008 13:36:39 +0000 (13:36 +0000)]
* Fixup validation methods in UserEmailForm a bit so that they don't return arrays when it's not necessary.
* Add email errors to the API's message map

15 years agoRemove unused messages, function deleted with r39717.
Raimond Spekking [Wed, 27 Aug 2008 12:19:37 +0000 (12:19 +0000)]
Remove unused messages, function deleted with r39717.

15 years agoPatch by Shlomi Fish to fix this test
Tim Starling [Wed, 27 Aug 2008 09:25:31 +0000 (09:25 +0000)]
Patch by Shlomi Fish to fix this test

15 years agoAdd $wgPhpCli var so shell outs know what exec name to use
Aaron Schulz [Wed, 27 Aug 2008 06:45:49 +0000 (06:45 +0000)]
Add $wgPhpCli var so shell outs know what exec name to use

15 years agoMinor error... sorry bout that, forgot to remove the > when I redid the fix locally.
Daniel Friesen [Wed, 27 Aug 2008 06:06:39 +0000 (06:06 +0000)]
Minor error... sorry bout that, forgot to remove the > when I redid the fix locally.

15 years agoRecommit the EditPage changes:
Daniel Friesen [Wed, 27 Aug 2008 05:56:34 +0000 (05:56 +0000)]
Recommit the EditPage changes:
Thanks for the heads up brion. $attribs was being overridden in EditPage::showTextbox rather than having individual things set which caused the tabindexes inputted to be ignored. Your test case is fixed.
I did a page diff, there are no more ui regressions. The only difference is the preview-toolbar <p><br /></p> has been moved from the inside of the preview to outside of it. There's no real difference in that.

15 years agoRevert r40027 "Recommit my changes to EditPage without the regressions:"
Brion Vibber [Wed, 27 Aug 2008 00:19:13 +0000 (00:19 +0000)]
Revert r40027 "Recommit my changes to EditPage without the regressions:"
This caused at least a regression in tab order which causes all my edits to fail:
1) Click "edit"
2) Hit "tab" to tab into edit field
3) Type something
4) Hit "tab" to tab into the comment field
5) Hit "enter" to save
Hey wait a minute, where's my edit?
When I go back and do it over, I find that I get tabbed from the edit box to the *cancel link*, so hitting enter goes back to the view page, destroying my edit.
Not good. :(

Haven't checked for other regressions; please be *very* careful with this edit page work, as seemingly small breakages can really damage the user experience and make things really badly broken.
Maybe we need a fuller UI test suite...

15 years agoadd more info
Aaron Schulz [Tue, 26 Aug 2008 22:40:45 +0000 (22:40 +0000)]
add more info

15 years agolog strange anomaly
Aaron Schulz [Tue, 26 Aug 2008 22:35:23 +0000 (22:35 +0000)]
log strange anomaly

15 years agoReset password throttles on login
Andrew Garrett [Tue, 26 Aug 2008 22:24:44 +0000 (22:24 +0000)]
Reset password throttles on login

15 years agoAPI: Remove the throttle from ApiLogin because
Roan Kattouw [Tue, 26 Aug 2008 22:18:24 +0000 (22:18 +0000)]
API: Remove the throttle from ApiLogin because
* it's been obsoleted by a similar throttle in core
* it uses time(), which causes problems when you have multiple servers with a significant clock skew between them

15 years agoAPI: Improvements to action=emailuser:
Roan Kattouw [Tue, 26 Aug 2008 21:34:47 +0000 (21:34 +0000)]
API: Improvements to action=emailuser:
* Add two messages from ApiEmailUser to ApiBase::$messageMap
* Add email tokens to prop=info

15 years agoAPI: Fixed bug that caused all action=edit requests to return with the nochange flag...
Roan Kattouw [Tue, 26 Aug 2008 20:49:52 +0000 (20:49 +0000)]
API: Fixed bug that caused all action=edit requests to return with the nochange flag set on wikis where DB_MASTER != DB_SLAVE

15 years agoAPI: Throwing a more specific error message when the client tries to create empty...
Roan Kattouw [Tue, 26 Aug 2008 20:40:44 +0000 (20:40 +0000)]
API: Throwing a more specific error message when the client tries to create empty new sections, which isn't allowed. Unknown error: ``228'' isn't very user-friendly.

15 years ago-T
Brion Vibber [Tue, 26 Aug 2008 20:26:26 +0000 (20:26 +0000)]
-T

15 years agoFix for r40041. PHP strict notice. Thanks to Ialex
Raimond Spekking [Tue, 26 Aug 2008 20:23:53 +0000 (20:23 +0000)]
Fix for r40041. PHP strict notice. Thanks to Ialex

15 years agoLocalization update.
Rotem Liss [Tue, 26 Aug 2008 20:23:23 +0000 (20:23 +0000)]
Localization update.

15 years ago* (bug 15264) Underscores in Special:Search/Foo_bar parameters were taken
Brion Vibber [Tue, 26 Aug 2008 20:17:58 +0000 (20:17 +0000)]
* (bug 15264) Underscores in Special:Search/Foo_bar parameters were taken
  literally; now converting them to spaces per expectation.

15 years ago* In Article::replaceSection(), actually return null when $section is bogus. Used...
Roan Kattouw [Tue, 26 Aug 2008 20:07:53 +0000 (20:07 +0000)]
* In Article::replaceSection(), actually return null when $section is bogus. Used this in my half-complete and now kind of abandoned attempt at rewriting EditPage.php
* In UserMailer::send(), allow the caller to override the Content-type header so people can send multipart messages if they really want to. Using this in an extension I'm developing

15 years ago* Add tooltips to rollback and undo links
Raimond Spekking [Tue, 26 Aug 2008 20:06:57 +0000 (20:06 +0000)]
* Add tooltips to rollback and undo links
At least on de.wiki the users with the review right have the rollback right too. They are confused about the difference rollback/undo. Hope that helps a bit

15 years agoQuick hack to fix the broken hack noted in bug 15301
Brion Vibber [Tue, 26 Aug 2008 18:51:27 +0000 (18:51 +0000)]
Quick hack to fix the broken hack noted in bug 15301

Use of:
$action_desc[0] = strtolower($action_desc[0]);
is horrible wrong for a few reasons:

1) The first-byte match fails for all non-ASCII characters -- use lcfirst()!
2) System strtolower() or lcfirst() may not work for UTF-8 or lang-specific issues properly; use $wgLang->lcfirst()
3) You shouldn't be forcing things to lowercase here anyway, you can't know it's correct gramattically.

This whole message output should be redone cleanly; either all the rights info messages should be designed to work in an inline list sentence, or they should be formatted as stand-alone text strings using a <ul> or something.

15 years agoRecommit my changes to EditPage without the regressions:
Daniel Friesen [Tue, 26 Aug 2008 15:45:32 +0000 (15:45 +0000)]
Recommit my changes to EditPage without the regressions:
* Content was double encoded by the call to htmlspecialchars and the use of Xml::textarea
* showFormBeforeText was returning instead of outputting (This caused saves to fail since there was no edittime)
* As a little extra no-one noticed, accidentally $encodedtext was left in showTextbox2 rather than $this->textbox2.

15 years agoFix path. Patch by rindolf on IRC.
Alexandre Emsenhuber [Tue, 26 Aug 2008 15:31:52 +0000 (15:31 +0000)]
Fix path. Patch by rindolf on IRC.

15 years agoMove @ingroup around so each of the classes are picked up by Doxygen.
Chad Horohoe [Tue, 26 Aug 2008 15:23:53 +0000 (15:23 +0000)]
Move @ingroup around so each of the classes are picked up by Doxygen.

15 years agoRevert 40016, 40021, 40022. Breaks ability to save and has html entities problems.
Chad Horohoe [Tue, 26 Aug 2008 15:10:52 +0000 (15:10 +0000)]
Revert 40016, 40021, 40022. Breaks ability to save and has html entities problems.

15 years agoRedo r39954, without regression this time. Sorry :(
Alexandre Emsenhuber [Tue, 26 Aug 2008 15:10:12 +0000 (15:10 +0000)]
Redo r39954, without regression this time. Sorry :(

15 years ago* Remove duplicated function in EditPage.
Robert Leverington [Tue, 26 Aug 2008 14:58:50 +0000 (14:58 +0000)]
* Remove duplicated function in EditPage.

15 years agoWhoops, this was probably supposed to be an elseif.
Daniel Friesen [Tue, 26 Aug 2008 14:38:25 +0000 (14:38 +0000)]
Whoops, this was probably supposed to be an elseif.

15 years ago* Revert back to my parser pseudo-branch again. Note: if you feel like reverting...
Tim Starling [Tue, 26 Aug 2008 14:37:15 +0000 (14:37 +0000)]
* Revert back to my parser pseudo-branch again. Note: if you feel like reverting this, reverting Parser.php alone to r40010 will work just fine.
* Merged replaceFreeExternalLinks() with doMagicLinks(). Makes a lot of sense, very similar operations, doesn't break any parser tests. Stops free links from interacting with other parser stages, the same way ISBN links don't.
* The pass order change fixes Brion's complaint in r39980. Early link expansion, triggered by having more than 1000 links in the page, was outputting URLs which were destroyed by RFEL. Added parser test.
* Fixed an unrelated bug in LinkHolderArray::replace(): if a link to a redirect appears in two separate RLH calls, the second and subsequent calls do not add the mw-redirect class. Caused by an unmigrated LinkCache fetch.
* Added a parser test for a pass interaction bug that the pass order change fixes.
* The fuzzer told me to tell you that free external links in non-caption image parameters, which are and have always been invisible, are now not registered either.
* Miscellaneous supporting updates to the test infrastructure.

15 years agoLocalisation updates Cantonese, Chinese and Old/Late Time Chinese
Shinjiman [Tue, 26 Aug 2008 14:22:39 +0000 (14:22 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese

15 years agoMake the elements of the watchlist fieldset identical to the elements of the recent...
Raimond Spekking [Tue, 26 Aug 2008 14:21:10 +0000 (14:21 +0000)]
Make the elements of the watchlist fieldset identical to the elements of the recent changes fieldset.

15 years agoCommit initial portion of EditPage refactoring.
Daniel Friesen [Tue, 26 Aug 2008 14:07:31 +0000 (14:07 +0000)]
Commit initial portion of EditPage refactoring.
This isn't complete, but nothing is broken.
The goal here is to make it possible for extensions to subclass the editpage and override certain areas of it while allowing the rest to keep it's presence without needing to copy code from core which may change.
* Use $this->action instead of hardcoded 'submit's so this may be overridden for subclasses that use a different action=...
* Move all the header setting into a new setHeaders() function. This way subclasses can tweak the title, this was previously impossible because of how scattered setPageTitle calls were.
* Move the previewarea stuff that was being duplicated in 2 places into it's own function.
* Move some inputs into a beforetext function
* Move wpTextbox1 into a special function. And create a textbox function to unify textarea creation. wpTextbox1 and wpTextbox2 now have a unified style due to this. (Though the metadata textarea could use this applied to it as well)
* Move edittools into a function.
* In getPreviewText;
** Don't use $wgOut
** Move template and other parseroutput related code outside of the function and simply set a $this->parserOutput variable while we're in here. (We should probably also move the $wgOut->addParserOutputNoText call somewhere else, and move most of the preview parsing into one of the initialization functions.

15 years agoLocalisation updates for core messages from Betawiki (2008-08-26 14:37 CEST)
Siebrand Mazeland [Tue, 26 Aug 2008 12:46:51 +0000 (12:46 +0000)]
Localisation updates for core messages from Betawiki (2008-08-26 14:37 CEST)

15 years agoAdded __destruct(), for stable pseudo-branch
Tim Starling [Tue, 26 Aug 2008 06:48:24 +0000 (06:48 +0000)]
Added __destruct(), for stable pseudo-branch

15 years agomark getOldIDFromRequest as public
Aaron Schulz [Tue, 26 Aug 2008 00:32:55 +0000 (00:32 +0000)]
mark getOldIDFromRequest as public

15 years agoRevert r39949 "* Revert revert r39662 of my parser changes."
Brion Vibber [Mon, 25 Aug 2008 22:19:50 +0000 (22:19 +0000)]
Revert r39949 "* Revert revert r39662 of my parser changes."
Causes weird regressions on http://meta.wikimedia.org/wiki/Talk:Spam_blacklist
Couldn't isolate to a parser test in a few minutes; some kind of template interaction perhaps.

Sample bad HTML like:
The associated page is used by the Mediawiki <a href="&lt;a href=" class="external free" title="http://www.mediawiki.org/wiki/Extension:SpamBlacklist" rel="nofollow">http://www.mediawiki.org/wiki/Extension:SpamBlacklist</a>" class="extiw" title="mw:Extension:SpamBlacklist"&gt;Spam Blacklist extension, and lists strings of text that may not be used in URLs in any page in Wikimedia Foundation projects (as well as many external wikis). Any meta <a href="/wiki/Administrator" title="Administrator">administrator</a> can edit the spam blacklist. There is also a more aggressive way to block spamming through direct use of <a href="/wiki/Anti-spam_features#.24wgSpamRegex" title="Anti-spam features">$wgSpamRegex</a>. Only <a href="/wiki/Developers" title="Developers" class="mw-redirect">developers</a> can make changes to $wgSpamRegex, and its use is to be avoided whenever possible.

15 years agoRevert r39954, 39958 "Tweaks for SiteConfiguration:"
Brion Vibber [Mon, 25 Aug 2008 22:06:03 +0000 (22:06 +0000)]
Revert r39954, 39958 "Tweaks for SiteConfiguration:"
This seems to have broken upload dirs on live site (eg http://upload.wikimedia.org/wiki/commons/6/66/Diemetrie.png in place of http://upload.wikimedia.org/wikipedia/commons/6/66/Diemetrie.png)
Please make no further changes without some regression testing...

15 years agothis looks backwards
Aaron Schulz [Mon, 25 Aug 2008 20:57:19 +0000 (20:57 +0000)]
this looks backwards

15 years agomark these 'public'
Aaron Schulz [Mon, 25 Aug 2008 20:52:13 +0000 (20:52 +0000)]
mark these 'public'

15 years ago* Add all HTMLDiff-related classes to the autoloader.
Chad Horohoe [Mon, 25 Aug 2008 20:19:00 +0000 (20:19 +0000)]
* Add all HTMLDiff-related classes to the autoloader.
* Move all stuff @ingroup DifferenceEngine to /diff
* Split off Node and friends to Nodes.php to make HTMLDiff.php shorter.

15 years agoAdd @ingroup definitions.
Chad Horohoe [Mon, 25 Aug 2008 20:01:04 +0000 (20:01 +0000)]
Add @ingroup definitions.

15 years agoAdd separate debug output from the normal wfDebug() output, similar to the parser...
Chad Horohoe [Mon, 25 Aug 2008 19:03:18 +0000 (19:03 +0000)]
Add separate debug output from the normal wfDebug() output, similar to the parser debug report. Only displayed if A) $wgEnableHtmlDiff is on and B) $wgDebugComments is on.

15 years agoRemoved Exception used for debugging. Disabled edit buttons for HTML diff.
Guy Van den Broeck [Mon, 25 Aug 2008 18:45:29 +0000 (18:45 +0000)]
Removed Exception used for debugging. Disabled edit buttons for HTML diff.

15 years ago*stab*
Alexandre Emsenhuber [Mon, 25 Aug 2008 18:10:27 +0000 (18:10 +0000)]
*stab*

15 years ago(bug 15303) Title conversion for templates wasn't working in some cases
Alexandre Emsenhuber [Mon, 25 Aug 2008 18:06:54 +0000 (18:06 +0000)]
(bug 15303) Title conversion for templates wasn't working in some cases

15 years agoSet svn:eol-style native on includes/api/ApiWatch.php.
Aryeh Gregor [Mon, 25 Aug 2008 17:57:20 +0000 (17:57 +0000)]
Set svn:eol-style native on includes/api/ApiWatch.php.

Reported on IRC by rindolf.

15 years agorm useless comment :)
Alexandre Emsenhuber [Mon, 25 Aug 2008 17:12:20 +0000 (17:12 +0000)]
rm useless comment :)

15 years agoTweaks for SiteConfiguration:
Alexandre Emsenhuber [Mon, 25 Aug 2008 16:46:34 +0000 (16:46 +0000)]
Tweaks for SiteConfiguration:
* Introduced SiteConfiguration::$siteParamsCallback, a callback function that returns an array of params to define custom parameters to replace and wiki tags so that they can be used at run time (e.g. for CentralAuth or SiteMatrix), can also override SiteConfiguration::siteFromDB(). See the documentation of that variable for further information. Backward compatibility is maintened for paramters passed to SiteConfiguration::get() and similar functions but the vaules returned by the callback function will override them.
* Added SiteConfiguration::arrayMerge() for merging arrays, written by Werdna. Warning: as array_merge(), it may change numeric keys, so don't use it for settings having namespaces index in keys.
* Removed SiteFromDB hook, deprecated by the callback function
* document a bit

15 years ago* Revert revert r39662 of my parser changes.
Tim Starling [Mon, 25 Aug 2008 16:08:19 +0000 (16:08 +0000)]
* Revert revert r39662 of my parser changes.
* Fixed image link whitespace handling (Brion's complaint, r39662)
* Added fuzz test capability to parserTests.php
* Added __destruct() functions to Parser and Language, and called them explicitly from parserTests.inc, to avoid unconstrained memory usage during fuzz testing.
* Added unified diff to output of Parser_DiffTest
* Fixed whitespace change in Parser::doTableStuff() (found by fuzzing)
* Added feature to RELEASE-NOTES which I'd committed last time but forgotten to note: <gallery> will accept image names with no "Image:" prefix (rediscovered by fuzzing)
* Limit memory usage in Title::getInterwikiLink()
* Fixed chronic fail of all interwiki link parser tests (hid Siebrand's complaint, r39464)
* Fixed chronic fail of one of the LanguageConverter parser tests. Was actually an ignored bug.

15 years agoTweak for r39944: correct fix :)
Alexandre Emsenhuber [Mon, 25 Aug 2008 14:49:15 +0000 (14:49 +0000)]
Tweak for r39944: correct fix :)

15 years agoLocalization update.
Rotem Liss [Mon, 25 Aug 2008 14:26:49 +0000 (14:26 +0000)]
Localization update.

15 years agoAdd {{PLURAL}} support to 'anonymous'. 2 uses in Credits already passed the $1 param...
Chad Horohoe [Mon, 25 Aug 2008 14:13:32 +0000 (14:13 +0000)]
Add {{PLURAL}} support to 'anonymous'. 2 uses in Credits already passed the $1 param, it just wasn't in the message.

15 years agoUse wfEmptyMsg() here instead of !$tagDescription. Should make <non-existent-message...
Chad Horohoe [Mon, 25 Aug 2008 13:39:33 +0000 (13:39 +0000)]
Use wfEmptyMsg() here instead of !$tagDescription. Should make <non-existent-message> errors when a particular HTML tag doesn't exist (notably, diff-s) to go away now. Should now output the raw tag ('<s>', again in the noticed case). Oddly, I like that more than the messages ;-)

15 years agoAdd siteadmin to core rights list.
Victor Vasiliev [Mon, 25 Aug 2008 10:32:11 +0000 (10:32 +0000)]
Add siteadmin to core rights list.

15 years agorevert rev#36938
Domas Mituzas [Mon, 25 Aug 2008 09:44:20 +0000 (09:44 +0000)]
revert rev#36938

15 years agoApiQueryBase::titleToKey and ApiQueryBase::keyToTitle;
Daniel Friesen [Mon, 25 Aug 2008 06:57:15 +0000 (06:57 +0000)]
ApiQueryBase::titleToKey and ApiQueryBase::keyToTitle;
Don't bother constructing a title object when the $title/$key is ''. (Why were we doing this check after creating the title object, there's no point in even creating a big object if we're just going to check the old string we already had to see if it's empty)
And as a bonus, use trim() so that user input such as ' ' does not dish out an error (There really isn't much difference between "&title=" and "&title= " if one shouldn't output an error, why should the other?).

15 years agoRevert 39936 and 39935;
Daniel Friesen [Mon, 25 Aug 2008 06:50:31 +0000 (06:50 +0000)]
Revert 39936 and 39935;
This 'fix' is merely a bad workaround and creates more issues rather than simply fixing.
A) Part of the Title class is being /duplicated/ meaning more bugs are going to show up when someone improves stuff inside Title and doesn't know stuff is duplicated here.
B) This change breaks cases as $wgCaptialLinks is now a per-namespace array, not a boolean.
C) This is the wrong way to 'fix' the issue, titleToKey and keyToTitle are meant to handle full titles, not prefixes, the issue is not that they break prefixes, it's that they are being misused and thus outputting something other than expected. The best way to fix this issue, would probably be to pad the title with something like '.' and then strip that single character off the db key.
D) Because whitespace is no longer being trimmed actual titles aren't being normalized properly in the other modules causing 'foobar ' to attempt to use the db key 'foobar_' which cannot exist.

15 years agoFollow-up for r39935: re-fix bug 14651 by making the first letter uppercase if needed...
Roan Kattouw [Mon, 25 Aug 2008 05:51:46 +0000 (05:51 +0000)]
Follow-up for r39935: re-fix bug 14651 by making the first letter uppercase if needed in keyToTitle(). Code stolen from Yuri in r17039, who removed the functionality without explanation in r17096. So much for today's history lesson.

15 years agoAPI: Go back to using the good old str_replace() hacks rather than Title methods...
Roan Kattouw [Mon, 25 Aug 2008 05:41:53 +0000 (05:41 +0000)]
API: Go back to using the good old str_replace() hacks rather than Title methods in ApiQueryBase::titleToKey() and keyToTitle(). Error handling was awkward and the Title methods over-normalize the input, causing bug 15275 (apprefix ignores spaces at the end)

15 years agoRevert r39675, which made functions that don't depend on $this static, for performanc...
Tim Starling [Mon, 25 Aug 2008 04:27:40 +0000 (04:27 +0000)]
Revert r39675, which made functions that don't depend on $this static, for performance. See wikitech-l for a full explanation.

15 years agoMinor log-related changes for documentation and to support a potential extension
Tim Starling [Mon, 25 Aug 2008 03:08:56 +0000 (03:08 +0000)]
Minor log-related changes for documentation and to support a potential extension

15 years agoremove extra parenthesis
Aaron Schulz [Sun, 24 Aug 2008 22:50:12 +0000 (22:50 +0000)]
remove extra parenthesis

15 years agoDocument the new param.
Chad Horohoe [Sun, 24 Aug 2008 21:39:10 +0000 (21:39 +0000)]
Document the new param.

15 years ago+RELEASE-NOTES for previous commit.
Chad Horohoe [Sun, 24 Aug 2008 20:04:29 +0000 (20:04 +0000)]
+RELEASE-NOTES for previous commit.

15 years agoLet action=purge actually do something for the ForeignAPIFile/Repo code. Still need...
Chad Horohoe [Sun, 24 Aug 2008 20:02:50 +0000 (20:02 +0000)]
Let action=purge actually do something for the ForeignAPIFile/Repo code. Still need to make it work on the metadata cache too, but I can live with this for now :)

15 years agotypo
Meno25 [Sun, 24 Aug 2008 19:58:32 +0000 (19:58 +0000)]
typo

15 years agoLocalisation updates for core messages from Betawiki (2008-08-24 21:20 CEST)
Siebrand Mazeland [Sun, 24 Aug 2008 19:26:01 +0000 (19:26 +0000)]
Localisation updates for core messages from Betawiki (2008-08-24 21:20 CEST)

15 years agoCleaning enotif-* messages : replacing obsolete (PAGEEDITOR|PAGETITLE)_(QC|RAWURL...
Nicolas Dumazet [Sun, 24 Aug 2008 15:11:54 +0000 (15:11 +0000)]
Cleaning enotif-* messages : replacing obsolete (PAGEEDITOR|PAGETITLE)_(QC|RAWURL) by PAGEEDITOR/PAGETITLE

15 years agoLocalisation updates for extension messages from Betawiki (2008-08-24 13:51 CEST)
Siebrand Mazeland [Sun, 24 Aug 2008 12:00:07 +0000 (12:00 +0000)]
Localisation updates for extension messages from Betawiki (2008-08-24 13:51 CEST)

15 years agoRemoved the AOL hack. Use the TrustedXFF extension instead.
Tim Starling [Sun, 24 Aug 2008 06:45:07 +0000 (06:45 +0000)]
Removed the AOL hack. Use the TrustedXFF extension instead.

15 years agoClarified visibility + docs
Chad Horohoe [Sun, 24 Aug 2008 03:06:03 +0000 (03:06 +0000)]
Clarified visibility + docs

15 years agoUpdate ar and arz
Meno25 [Sun, 24 Aug 2008 01:04:08 +0000 (01:04 +0000)]
Update ar and arz

15 years agomark visibility
Aaron Schulz [Sat, 23 Aug 2008 23:22:24 +0000 (23:22 +0000)]
mark visibility

15 years agoforgot debugging code
Alexandre Emsenhuber [Sat, 23 Aug 2008 20:35:23 +0000 (20:35 +0000)]
forgot debugging code

15 years agoMake SpecialAllpages and SpecialPrefixindex directly extend IncludableSpecialPage:
Alexandre Emsenhuber [Sat, 23 Aug 2008 20:32:46 +0000 (20:32 +0000)]
Make SpecialAllpages and SpecialPrefixindex directly extend IncludableSpecialPage:
* it is possible to have the title object by calling $this->getTitle() and not by having to redefine the special page name in that classes
* passing the $including param is no longer required, use $this->including() instead

15 years agoremove comment
Aaron Schulz [Sat, 23 Aug 2008 20:16:41 +0000 (20:16 +0000)]
remove comment

15 years agomd5() the URL in cache keys so they're not excessively long. Thanks to Nikerabbit...
Chad Horohoe [Sat, 23 Aug 2008 19:13:04 +0000 (19:13 +0000)]
md5() the URL in cache keys so they're not excessively long. Thanks to Nikerabbit for pointing this out.

15 years agoLocalisation updates Cantonese, Chinese and Old/Late Time Chinese
Shinjiman [Sat, 23 Aug 2008 01:45:21 +0000 (01:45 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese

15 years agoshould be <=, not <
Aaron Schulz [Sat, 23 Aug 2008 01:26:06 +0000 (01:26 +0000)]
should be <=, not <

15 years ago*sigh*...needs to return a string to not die in ImagePage
Aaron Schulz [Sat, 23 Aug 2008 01:19:44 +0000 (01:19 +0000)]
*sigh*...needs to return a string to not die in ImagePage

15 years agoFix arguments to call:
Aaron Schulz [Sat, 23 Aug 2008 01:12:00 +0000 (01:12 +0000)]
Fix arguments to call:
Catchable fatal error: Argument 2 passed to Parser::parse() must be an instance of Title, instance of ParserOptions given, called in C:\Server\xampp\htdocs\MW\includes\filerepo\LocalFile.php on line 1118 and defined in C:\Server\xampp\htdocs\MW\includes\parser\Parser.php on line 290

15 years agoAdd cache update hook for flaggedrevs
Aaron Schulz [Fri, 22 Aug 2008 22:36:02 +0000 (22:36 +0000)]
Add cache update hook for flaggedrevs

15 years agoA few more messages that shouldn't be here
Meno25 [Fri, 22 Aug 2008 22:02:20 +0000 (22:02 +0000)]
A few more messages that shouldn't be here