From: Antoine Musso <hashar@users.mediawiki.org>
Date: Sat, 3 Feb 2007 21:58:37 +0000 (+0000)
Subject: Fix #6684: Improper javascript array iteration causes problems
X-Git-Tag: 1.31.0-rc.0~54141
X-Git-Url: https://git.cyclocoop.org/%28%28?a=commitdiff_plain;h=62d676f114d9aef45588d51d64d8f6adb6ccf123;p=lhc%2Fweb%2Fwiklou.git

Fix #6684: Improper javascript array iteration causes problems
Patch by Dan Li <dto@dev.java.net>
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 97d3ff5e71..390ff47d3d 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -169,6 +169,7 @@ lighter making things easier to read.
 * Fix for paths in 1.4->1.5 special-case updater script
 * (bug 8789) AJAX search: IE users can now use the return key
 * (bug 6844) Use <ins> and <del> tags to emphase the differences
+* (bug 6684) Fix improper javascript array iteration
 
 
 == Languages updated ==
diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index cf5369457e..b7762b987f 100644
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -374,10 +374,10 @@ function mwSetupToolbar() {
 		return false;
 	}
 
-	for (var i in mwEditButtons) {
+	for (var i = 0; i < mwEditButtons.length; i++) {
 		mwInsertEditButton(toolbar, mwEditButtons[i]);
 	}
-	for (i in mwCustomEditButtons) {
+	for (var i = 0; i < mwCustomEditButtons.length; i++) {
 		mwInsertEditButton(toolbar, mwCustomEditButtons[i]);
 	}
 	return true;